[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr updated this revision to Diff 273464. gribozavr added a comment. Added calls to default implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files:

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to add a test for the symbols added target notification. See my previous comment on stripping a.out to a.out.stripped and then using "a.out.stripped" as the main

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko marked an inline comment as done. atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c efriedma wrote: > Missed powitf? Fixed, thank you. Repository: rG LLVM Github

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 273457. avl added a comment. removed early check for TRE candidates from canTRE(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files:

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko updated this revision to Diff 273452. atrosinenko added a comment. Move missed `powitf2.c` source as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 Files:

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82332/new/ https://reviews.llvm.org/D82332

[PATCH] D82586: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

yamauchi created this revision. yamauchi added reviewers: arsenm, yaxunl. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Similarly to D82046 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82586 Files:

[clang] c61ef1f - [Sema][CodeComplete][ObjC] Don't split the first selector fragment

Author: David Goldman Date: 2020-06-25T13:58:27-04:00 New Revision: c61ef1f25c7fe774e68d20beb956a3b12a353b95 URL: https://github.com/llvm/llvm-project/commit/c61ef1f25c7fe774e68d20beb956a3b12a353b95 DIFF: https://github.com/llvm/llvm-project/commit/c61ef1f25c7fe774e68d20beb956a3b12a353b95.diff

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, vsavchenko, martong, balazske, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[clang] 3661595 - [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

Author: Xun Li Date: 2020-06-25T10:49:50-07:00 New Revision: 366159566df3a980d3e34f3ec9609e77cdb4df8b URL: https://github.com/llvm/llvm-project/commit/366159566df3a980d3e34f3ec9609e77cdb4df8b DIFF: https://github.com/llvm/llvm-project/commit/366159566df3a980d3e34f3ec9609e77cdb4df8b.diff LOG:

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; I don't think assert should be used for something that

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

nickdesaulniers updated this revision to Diff 273449. nickdesaulniers added a comment. - drop `Invalid` param from getLocalSLocEntry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82498/new/ https://reviews.llvm.org/D82498 Files:

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a child revision: D78127: [SVE] Mark VectorType::getNumElements() deprecated. Repository: rG LLVM Github Monorepo

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ https://reviews.llvm.org/D73186

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } laytonio wrote: > avl wrote: > >

[PATCH] D82506: [HIP] Add missing options for lto

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82506/new/ https://reviews.llvm.org/D82506 ___ cfe-commits mailing list

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

lewissbaker accepted this revision. lewissbaker added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaCoroutine.cpp:621 +// returns a handle. In that case, even __builtin_coro_resume is not +// declared as

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) {

[PATCH] D82360: Add StringLiteral to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG466e8b7ea6e1: Add StringLiteral to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82360?vs=273346=273438#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

This revision was automatically updated to reflect the committed changes. Closed by commit rG37c1bf21d1da: [analyzer] Enable constructor support in evalCall event. (authored by vrnithinkumar, committed by Artem Dergachev adergac...@apple.com). Changed prior to commit:

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b404b6d0031: Add `FloatingLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82318?vs=273347=273437#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG221d7bbe49cc: Add `CharLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82312?vs=273343=273436#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82506: [HIP] Add missing options for lto

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:76 +MAttrString.append(Args.MakeArgString(OneFeature)); +if (OneFeature != Features.back()) + MAttrString.append(","); tra wrote:

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

This revision was automatically updated to reflect the committed changes. Closed by commit rG408efffbe4a5: [Clang][SourceManager] optimize getFileIDLocal() (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82497/new/

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:66 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel41S(%struct.S.coerce %s.coerce) +// OPT: %0 = extractvalue %struct.S.coerce %s.coerce, 0 +// OPT: %1 = extractvalue

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl added a child revision: D82506: [HIP] Add missing options for lto. extract unifyTargetFeatures to be used by lld. https://reviews.llvm.org/D82579 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7849-7851 +if ( != &*Components.begin()) { + ElementType = ElementType->getPointeeOrArrayElementType(); +} No need for braces here

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 273421. Conanap marked 9 inline comments as done. Conanap added a comment. Fixed return signature for the open coded functions in altivec.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/

[PATCH] D82506: [HIP] Add missing options for lto

yaxunl updated this revision to Diff 273424. yaxunl marked an inline comment as done. yaxunl added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Fix issue about -mattr. Also use generic LTO option translation and use -plugin-opt. CHANGES SINCE LAST ACTION

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

efriedma added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c Missed powitf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/

[clang] 7b404b6 - Add `FloatingLiteral` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 7b404b6d003181e990f53d27866ee98d5151c4f3 URL: https://github.com/llvm/llvm-project/commit/7b404b6d003181e990f53d27866ee98d5151c4f3 DIFF: https://github.com/llvm/llvm-project/commit/7b404b6d003181e990f53d27866ee98d5151c4f3.diff

[clang] 466e8b7 - Add StringLiteral to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 466e8b7ea6e162d48cac42ccda210bdeb11080e3 URL: https://github.com/llvm/llvm-project/commit/466e8b7ea6e162d48cac42ccda210bdeb11080e3 DIFF: https://github.com/llvm/llvm-project/commit/466e8b7ea6e162d48cac42ccda210bdeb11080e3.diff

[clang] 221d7bb - Add `CharLiteral` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c URL: https://github.com/llvm/llvm-project/commit/221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c DIFF: https://github.com/llvm/llvm-project/commit/221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c.diff

[clang] 408efff - [Clang][SourceManager] optimize getFileIDLocal()

Author: Nick Desaulniers Date: 2020-06-25T09:59:41-07:00 New Revision: 408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 URL: https://github.com/llvm/llvm-project/commit/408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 DIFF:

[clang] f79a66b - Ensure that default value for -triple is correctly normalizedvalues

Author: Daniel Grumberg Date: 2020-06-25T17:49:59+01:00 New Revision: f79a66ba69628db471d559f0f182f476bf49ac90 URL: https://github.com/llvm/llvm-project/commit/f79a66ba69628db471d559f0f182f476bf49ac90 DIFF:

[clang] 37c1bf2 - [analyzer] Enable constructor support in evalCall event.

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-06-25T09:47:13-07:00 New Revision: 37c1bf21d1da85c164638efc32e8c7cfbf713ac5 URL: https://github.com/llvm/llvm-project/commit/37c1bf21d1da85c164638efc32e8c7cfbf713ac5 DIFF:

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

This revision was automatically updated to reflect the committed changes. fpetrogalli marked an inline comment as done. Closed by commit rG7200fa38a912: [sve][acle] Add some C intrinsics for brain float types. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao added a comment. ping for code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, fpetrogalli, kmclaughlin. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added a project: clang. `svwhilerw_bf16` and `svwhilewr_bf16`

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli updated this revision to Diff 273411. fpetrogalli added a comment. Removed the run lines that didn't work, as described in https://reviews.llvm.org/D82429#inline-759371 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82429/new/

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple

[PATCH] D82575: [OpenMP] Additional OpenMP test without version string after upgrading to 5.0

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, gregrodgers. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. saiislam added a commit: rG2bfce22a924a: [OpenMP] Upgrade default version of OpenMP to 5.0. saiislam removed

[PATCH] D70603: Change while to do-while

pi1024e added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, Conanap, saghir, nemanjai, lei. amyk added projects: LLVM, clang, PowerPC. Herald added a subscriber: shchenz. This patch aims to add the following function prototypes: vector signed int vec_mod (vector signed int a,

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1479 + let Predicates = [IsLE, HasBF16] in { +def : Pat<(nxv16i8 (bitconvert (nxv8bf16 ZPR:$src))), (nxv16i8 ZPR:$src)>; + These patterns are missing tests in

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

andreybokhanko added a comment. Fix committed in https://reviews.llvm.org/rG16501782c8d849bc1812d527dc8466574700663d. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81825/new/ https://reviews.llvm.org/D81825

[clang] 7200fa3 - [sve][acle] Add some C intrinsics for brain float types.

Author: Francesco Petrogalli Date: 2020-06-25T16:31:01Z New Revision: 7200fa38a912d0d9ec407ccdd7c4d924979da160 URL: https://github.com/llvm/llvm-project/commit/7200fa38a912d0d9ec407ccdd7c4d924979da160 DIFF:

[clang] 772f482 - Change while to do-while

Author: Seija Kijin Date: 2020-06-25T09:30:30-07:00 New Revision: 772f4826465de80d8c7f11b2fb35b92f9fe58f45 URL: https://github.com/llvm/llvm-project/commit/772f4826465de80d8c7f11b2fb35b92f9fe58f45 DIFF: https://github.com/llvm/llvm-project/commit/772f4826465de80d8c7f11b2fb35b92f9fe58f45.diff

[libunwind] c55051e - [libunwind] Allow specifying custom Lit config files

Author: Louis Dionne Date: 2020-06-25T12:15:15-04:00 New Revision: c55051eea5d3cd57abfd9727f519b670517704d9 URL: https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9 DIFF: https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9.diff

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f8564808b: Add `BoolLiteralExpression` to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82310/new/

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @NoQ gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

This revision was automatically updated to reflect the committed changes. Closed by commit rG16501782c8d8: [Clang] Add support for -Wno-inline-namespace-reopened-noninline (authored by Elvina, committed by andreybokhanko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

This revision was automatically updated to reflect the committed changes. Closed by commit rG15edd7aaa714: [FPEnv] PowerPC-specific builtin constrained FP enablement (authored by ajwock, committed by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

fpetrogalli updated this revision to Diff 273399. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. @david-arm, at the end I decided to add the `ASM-NOT` test, it was easy and came for free. Also, I have moved the IR tests in the file with all other bitcasts, using a

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 273393. Conanap added a comment. Addressed Amy's comments regarding documentation of the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } avl wrote: > laytonio wrote: > > Is there any reason to find and validate

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp. Herald added a project: clang. balazske added reviewers: gamesh411, martong. Herald added a subscriber: rnkovacs. Parent map of ASTContext is built once. If this happens and later the TU

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

c-rhodes accepted this revision. c-rhodes added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Will land this one too. In the meantime feel free to apply for commit access, as explained in https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (IIRC, you

[PATCH] D70603: Change while to do-while

pi1024e added a comment. How do I do that, if I may ask? Sorry for the rude tone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

kadircet marked 5 inline comments as done. kadircet added a comment. LGTM with couple of nits. Regarding clang-format, I was mostly confused by `template class Located {` being on a single line, but apparently that's the style :D Comment at:

[clang] 1650178 - [Clang] Add support for -Wno-inline-namespace-reopened-noninline

Author: Elvina Yakubova Date: 2020-06-25T18:48:50+03:00 New Revision: 16501782c8d849bc1812d527dc8466574700663d URL: https://github.com/llvm/llvm-project/commit/16501782c8d849bc1812d527dc8466574700663d DIFF:

[clang] 15edd7a - [FPEnv] PowerPC-specific builtin constrained FP enablement

Author: Andrew Wock Date: 2020-06-25T11:42:58-04:00 New Revision: 15edd7aaa7142e5db2a6cf9b81e4514967431824 URL: https://github.com/llvm/llvm-project/commit/15edd7aaa7142e5db2a6cf9b81e4514967431824 DIFF: https://github.com/llvm/llvm-project/commit/15edd7aaa7142e5db2a6cf9b81e4514967431824.diff

[clang] 7f7f856 - Add `BoolLiteralExpression` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T15:37:53Z New Revision: 7f7f8564808b51aa62744edf75c07c0df102056a URL: https://github.com/llvm/llvm-project/commit/7f7f8564808b51aa62744edf75c07c0df102056a DIFF: https://github.com/llvm/llvm-project/commit/7f7f8564808b51aa62744edf75c07c0df102056a.diff

[PATCH] D70603: Change while to do-while

MaskRay added a comment. In D70603#2114361 , @pi1024e wrote: > @MaskRay it's been months yet this hasn't landed yet. Why? It is usually assumed that the patch author pushes this commit. In this case, it seems that you don't have commit access. You'll

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } laytonio wrote: > Is there any reason to

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen abandoned this revision. aelitashen added a comment. Mistakenly created two diffs on same commit, See D82477 for the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 ___ cfe-commits

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; HsiangKai wrote: > evandro wrote: > > HsiangKai

[PATCH] D82563: [Sema][NFC] Remove Redundant Condition

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: sammccall, rsmith. baloghadamsoftware added a project: clang. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs. Condition `TypeQuals` is checked both in an outer and in an inner `if` statement

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane created this revision. erichkeane added reviewers: craig.topper, echristo. The x86-64 "avx" feature changes how >128 bit vector types are passed, instead of being passed in separate 128 bit registers, they can be passed in 256 bit registers. "avx512f" does the same thing, except it

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

gamesh411 created this revision. gamesh411 added reviewers: martong, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a

[PATCH] D70603: Change while to do-while

pi1024e added a comment. @MaskRay it's been months yet this hasn't landed yet. Why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

gamesh411 updated this revision to Diff 273372. gamesh411 added a comment. update test value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82561/new/ https://reviews.llvm.org/D82561 Files:

Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

On Thu, Jun 25, 2020 at 5:53 AM Yitzhak Mandelbaum wrote: > > Thanks for alerting me. Why is it important to strip out this information? > Also, might this be something we can change on the arcanist side (to not add > to the commit message) rather than strip out on the git end? Mostly to keep

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

c-rhodes updated this revision to Diff 273365. c-rhodes added a comment. Changes: - Guard patterns on `+bf16`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 Files: clang/include/clang/Basic/arm_sve.td

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c:5 + +#include + david-arm wrote: > Hi @fpetrogalli, in the same way that you asked @kmclaughlin

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE

[PATCH] D70603: Change while to do-while

pi1024e added a comment. Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:9 +/// +/// This file describes the RISC-V instructions from the standard 'V', +/// Vector instruction set extension. asb wrote: >

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>;

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273347. eduucaldas marked an inline comment as done. eduucaldas added a comment. Fix indenting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files:

[PATCH] D82360: Add StringLiteral to SyntaxTree

eduucaldas updated this revision to Diff 273346. eduucaldas added a comment. Add unicode tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82360/new/ https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82548: [CodeComplete] add code completion for `delete` and `default` specifier.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82535: [CodeComplete] Add code completion for using alias.. add code completion for `delete` and `default` specifier.

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273343. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Add tests for unicode characters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/ https://reviews.llvm.org/D82312

[PATCH] D82226: Add Metadata to Transformer tooling

ymandel added a comment. Looks good! Only real question is one of design -- should we consider the (deeper) change of templating the various types rather than using dynamic typing? For that matter, the decision doesn't even have to be the same for both AtomicChange and the Transformer types.

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro created this revision. djtodoro added reviewers: vsk, aprantl, dblaikie, probinson. djtodoro added projects: debug-info, LLVM. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. djtodoro added a parent revision: D82546: [Debugify][OriginalMode] Export the

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin updated this revision to Diff 273331. kmclaughlin added a comment. - Added HasSVE to Predicates in AArch64SVEInstrInfo.td - Removed unnecessary indentation changes in AArch64SVEInstrInfo.td - Removed hasBF16 variable from performST1Combine/performSTNT1Combine CHANGES SINCE LAST

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this again, @fpetrogalli! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

ymandel added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:335 + template struct is_same_method_impl { +static bool isSameMethod(...) { return false; } + }; Why use var-args rather than spelling out the type arguments like

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added a comment. The last patchset contains the comment about rounding, so I think I will consider this accepted. As a final addendum to the discussion on rounding and overflow... The last Appendix to the E-C TR does actually say: 2. In the first edition requires that overflow

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:537 + // true for equality and false for disequality. + bool IsEquality = true; + vsavchenko wrote: > NoQ wrote: > > Do i understand correctly that this isn't used

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b9ce07a761f: [openmp] Use Directive_enumSize instead of OMPD_unknown position (authored by clementval). Changed prior to commit: https://reviews.llvm.org/D82518?vs=273216=273327#toc Repository: rG

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

clementval marked 2 inline comments as done. clementval added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:583 OpenMPDirectiveKind DKind) { - assert(DKind <= OMPD_unknown); + assert(unsigned(DKind) <= llvm::omp::Directive_enumSize); switch (DKind) {

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273321. lh123 marked 3 inline comments as done. lh123 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files:

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

asb added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:9 +/// +/// This file describes the RISC-V instructions from the standard 'V', +/// Vector instruction set extension. Please add similar language as in RISCVInstrInfoB.td to indicate

[clang] 5b9ce07 - [openmp] Use Directive_enumSize instead of OMPD_unknown position

Author: Valentin Clement Date: 2020-06-25T09:18:54-04:00 New Revision: 5b9ce07a761f7d62ad793f9827750243de597215 URL: https://github.com/llvm/llvm-project/commit/5b9ce07a761f7d62ad793f9827750243de597215 DIFF:

Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

Thanks for alerting me. Why is it important to strip out this information? Also, might this be something we can change on the arcanist side (to not add to the commit message) rather than strip out on the git end? On Wed, Jun 24, 2020 at 3:28 PM Fangrui Song via Phabricator <

<    1   2   3   >