[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. This is a huge change, I've got pretty tired at the end of the review. I haven't checked the test-cases too deeply. I've found only minor typos, clarity enhancement opportunities etc. nothing serious. It was awesome to see how this code can be improved, even becoming c

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added a comment. In D86065#2235434 , @david-arm wrote: > Hi @fpetrogalli, if you don't mind I think I'll stick with Paul's idea for > ogt because this matches the IR neatly, i.e. "fcmp ogt". Also, for me > personally it's much simpler and mor

[PATCH] D85934: Enable OpenMP offloading to VE and enable tests for offloading to VE

manorom updated this revision to Diff 287660. manorom edited the summary of this revision. manorom added a comment. - Move VE specific vars into test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85934/new/ https://reviews.llvm.org/D85934

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 287658. simoll added a comment. - made bool-vector layout target dependent (one byte per bool element on Hexagon, one bit everywhere else). - Added hvx-specific debug info test. - Updated docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald added a comment. @serge-sans-paille - the diff is PEP8 compliant now. Care to commit, as I don't have the right permissions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

This revision was automatically updated to reflect the committed changes. Closed by commit rG121a49d839d7: [LiveDebugValues] Add switches for using instr-ref variable locations (authored by jmorse). Changed prior to commit: https://reviews.llvm.org/D83048?vs=286814&id=287655#toc Repository:

[clang] 121a49d - [LiveDebugValues] Add switches for using instr-ref variable locations

Author: Jeremy Morse Date: 2020-08-25T14:58:48+01:00 New Revision: 121a49d839d79f5a72be3e22a9d156c9e4b219dc URL: https://github.com/llvm/llvm-project/commit/121a49d839d79f5a72be3e22a9d156c9e4b219dc DIFF: https://github.com/llvm/llvm-project/commit/121a49d839d79f5a72be3e22a9d156c9e4b219dc.diff

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko added a comment. Uploaded, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84932/new/ https://reviews.llvm.org/D84932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f49d13fd44: [compiler-rt][builtins] Add more test cases for __div[sdt]f3 LibCalls (authored by atrosinenko). Changed prior to commit: https://reviews.llvm.org/D84932?vs=286523&id=287650#toc Repositor

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

martong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:490-491 + +- Added :ref:`on-demand parsing ` capability to cross translation + unit analysis. + whisperity wrote: > What's the proper way of naming this feature, @martong @dkrupp @xazax.hun?

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:494-496 + OS << "Smart pointer"; + checkAndPrettyPrintRegion(OS, ThisRegion); + OS << " is non-null"; ---

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

whisperity added inline comments. Comment at: clang/docs/ReleaseNotes.rst:439 - ... Static Analyzer ... here. Comment at: clang/docs/ReleaseNotes.rst:498 .. _release-notes-ubsan: @Szelethus Speaking of labels in the de

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API

martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-POSIX-lookup.c:14 +// declarations in a way that the summary is not added to the map. We expect no +// crashes (i.e. no optionals should be 'dereferenced') and no output. + Pro

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 287641. vrnithinkumar added a comment. - Making the note tags prunable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D86027 Files: clang/lib/StaticAnalyzer/Checkers/

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

whisperity added a comment. Some grammatical fixes and suggestions, inline. I might have absolutely butchered 80-col in the suggestions (thanks Phab for not showing any indication of line length...), so make sure you manually reformat the document before going forward! Comme

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

martong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:471 + +- Improve the pre- and post condition modeling of several hundred more standard + C functions. Umm, this is still an alpha command line option, plus we improved only the pre-condition

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

ABataev added a comment. Reformat the code Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:498 /// far. + class OffloadEntriesInfoManagerTy { Remove unnecessary formatting changes. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:2479-2

[PATCH] D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

martong added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:213 compile said TU are given in YAML format referred to as `invocation list`, and must be passed as an analyer-config argument. The index, which maps function USR names to sourc

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added a comment. @vsavchenko I just realized your work for this release is the following list: git log llvmorg-11-init..llvmorg-11.0.0-rc2 --oneline -- clang/utils/analyzer/ Is it a correct guess that while your primary audience are the analyzer developers, but it wouldn't hurt to m

[PATCH] D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

Szelethus added a reviewer: hans. Szelethus added a comment. We will need to push this to the 11.0.0. release branch as well, sorry for the trouble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86532/new/ https://reviews.llvm.org/D86532

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 287640. martong added a comment. - Rebase to parent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctions

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus created this revision. Szelethus added reviewers: hans, NoQ, vsavchenko, dcoughlin, xazax.hun, baloghadamsoftware, martong, balazske, steakhal, Charusso, jkorous, dkrupp, gamesh411. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, phosek, donat.nag

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added inline comments. Comment at: clang/test/Driver/cl-options.c:686 +// vctoolsdir is handled by the driver; just check that we don't error. Pass -c because fakedir isn't a real toolchain path +// RUN: %clang_cl -c -vctoolsdir fakedir -- %s 2>&1 + zahen w

[clang-tools-extra] 4d90ff5 - [clangd] When inserting "using", add "::" in front if that's the style.

Author: Adam Czachorowski Date: 2020-08-25T14:07:49+02:00 New Revision: 4d90ff59ac453a67ac692ffdf8242e4cfbd2b34f URL: https://github.com/llvm/llvm-project/commit/4d90ff59ac453a67ac692ffdf8242e4cfbd2b34f DIFF: https://github.com/llvm/llvm-project/commit/4d90ff59ac453a67ac692ffdf8242e4cfbd2b34f.d

[PATCH] D86473: [clangd] When inserting "using", add "::" in front if that's the style.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d90ff59ac45: [clangd] When inserting "using", add "::" in front if that's the style. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D864

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API

martong created this revision. martong added reviewers: balazske, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a

[PATCH] D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

Szelethus created this revision. Szelethus added reviewers: xazax.hun, haowei, NoQ, martong, balazske, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, phosek, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, b

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus planned changes to this revision. Szelethus marked an inline comment as done. Szelethus added a comment. Thanks! I'll get these fixed. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:901 + + void next(Token &Result) { +if (CurrTokenIt == TokenRange

[libunwind] 1c39ffe - [libunwind] Fix warning when building without frameheader cache

Author: Mikael Holmen Date: 2020-08-25T12:58:39+02:00 New Revision: 1c39ffecd84a5eba54f5fabb433b0192d1dbd3b4 URL: https://github.com/llvm/llvm-project/commit/1c39ffecd84a5eba54f5fabb433b0192d1dbd3b4 DIFF: https://github.com/llvm/llvm-project/commit/1c39ffecd84a5eba54f5fabb433b0192d1dbd3b4.diff

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84932/new/ https://reviews.llvm.org/D84932 __

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

vrnithinkumar updated this revision to Diff 287612. vrnithinkumar marked 9 inline comments as done. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:351 +bool SmartPtrModeling::handleEqOp(const CallEvent &Call, + CheckerContext &C) const { vsavchenko wrote: > xazax.hun wro

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. Documentation under `clang/docs/analyzer/checkers.rst` seems to be missing. Could we get that fixed before 11.0.0 releases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 updated this revision to Diff 287609. gargvaibhav64 edited the summary of this revision. gargvaibhav64 added a comment. Resolve a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 Files: clang/include/clang/Serialization/ASTR

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. This preprocessor expansion stuff is definitely not my expertise, nvm here is my review. However, I observed some strange things happening in the test-cases, that's why I //requ

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 created this revision. gargvaibhav64 added reviewers: rsmith, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. gargvaibhav64 requested review of this revision. While parsing LateParsedTemplates, Clang assumes that the Global DeclID matches with th

[PATCH] D86427: Fix some spelling errors

YangZhihui added a comment. how can I add the Author property in the patch Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 ___ cfe-commits mailing list cf

[PATCH] D86427: Fix some spelling errors

YangZhihui added a comment. Thanks, Full Name: Yang Zhihui Email: yangzh.f...@cn.fujitsu.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 ___ cfe-commits mail

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. In D86427#2235574 , @YangZhihui wrote: > Thanks, but I don't have commit access I can commit it for you. Can you give me your github email? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + vsavchenko wrote: > NoQ wrote: > > vsavchenko wrote: > > >

[PATCH] D86427: Fix some spelling errors

YangZhihui added a comment. Thanks, but I don't have commit access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:882 + const QualType SizePtrTy = getPointerTy(SizeTy); + const QualType SizePtrRestrictTy = getRestrictTy(SizePtrTy); balazske wrote: > martong wrote:

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus added a comment. In D86135#2233611 , @martong wrote: >> The fundamental problem is, we simply can't ask Preprocessor what a macro >> expands into without hacking really hard. > > Can you summarize what is the exact problem (or give a link to a d

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:106 + + EmitBTIMarking = MarkBTIProperty.getValue(); } No need to the `.getValue()` part. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArc

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:119 + + return makePersistent(std::move(Result)); +} NoQ wrote: > Given that we're certain from the start that the container will be > persistent, can we save

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm added a comment. Hi @fpetrogalli, if you don't mind I think I'll stick with Paul's idea for ogt because this matches the IR neatly, i.e. "fcmp ogt". Also, for me personally it's much simpler and more intuitive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86065/new/ https:/

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2235289 , @NoQ wrote: > If the numbers are confirmed to be as good as what i've sneak-peeked so far, > that should be pretty amazing. Also whoa, test coverage!~ I'll add the charts with performance in the next couple

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:882 + const QualType SizePtrTy = getPointerTy(SizeTy); + const QualType SizePtrRestrictTy = getRestrictTy(SizePtrTy); martong wrote: > balazske wrote:

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:315-318 +SVal Val = I->second; +for (auto si = Val.symbol_begin(), se = Val.symbol_end(); si != se; ++si) { + SR.markLive(*si); +} Yes, this looks corre

<    1   2