[clang-tools-extra] efd8c9e - [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

Author: Haojian Wu Date: 2020-10-09T08:51:18+02:00 New Revision: efd8c9ed726df5376ca8ac3ddc75ab91a40dd873 URL: https://github.com/llvm/llvm-project/commit/efd8c9ed726df5376ca8ac3ddc75ab91a40dd873 DIFF: https://github.com/llvm/llvm-project/commit/efd8c9ed726df5376ca8ac3ddc75ab91a40dd873.diff LO

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd8c9ed726d: [clangd] Add more incomplete_type diagnostics that could be fixed by include… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D78699: [X86] Passing union type through register.

LiuChen3 added a comment. In D78699#2320678 , @bruno wrote: > LGTM Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[clang] 26cfb6e - [X86] Passing union type through register

Author: Liu, Chen3 Date: 2020-10-09T11:24:29+08:00 New Revision: 26cfb6e562f12f8c0d8952120d9df81151dc9c19 URL: https://github.com/llvm/llvm-project/commit/26cfb6e562f12f8c0d8952120d9df81151dc9c19 DIFF: https://github.com/llvm/llvm-project/commit/26cfb6e562f12f8c0d8952120d9df81151dc9c19.diff LO

[PATCH] D78699: [X86] Passing union type through register.

This revision was automatically updated to reflect the committed changes. Closed by commit rG26cfb6e562f1: [X86] Passing union type through register (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fbb499e - [AST] Fix crashes caused by redeclarations in hidden prototypes

Author: Ben Barham Date: 2020-10-08T19:48:36-07:00 New Revision: fbb499ef255b77c5a3300543de88956b13e706b7 URL: https://github.com/llvm/llvm-project/commit/fbb499ef255b77c5a3300543de88956b13e706b7 DIFF: https://github.com/llvm/llvm-project/commit/fbb499ef255b77c5a3300543de88956b13e706b7.diff LO

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb499ef255b: [AST] Fix crashes caused by redeclarations in hidden prototypes (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 abandoned this revision. LiuChen3 added a comment. In D60748#2310148 , @RKSimon wrote: > @wxiao3 @LiuChen3 Are you still looking at this or should it be abandoned? I will abandon this patch for it is difficult to confirm the behavior of gcc. CH

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

bnbarham updated this revision to Diff 297098. bnbarham added a comment. Removed platform-specific path separator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redecls-sub.h

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: wenlei, dang, hiraditya. Herald added projects: clang, LLVM. tejohnson requested review of this revision. Similar to -fprofile-generate=, add -fmemory-profile= which takes a directory path. This is pass

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. The new code/functionality wrt. no exit blocks should be a separate commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-com

[clang] 66face6 - Re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: Alexandre Ganea Date: 2020-10-08T20:49:17-04:00 New Revision: 66face6aa0f5f68de56067b0dff3295e47fdf66c URL: https://github.com/llvm/llvm-project/commit/66face6aa0f5f68de56067b0dff3295e47fdf66c DIFF: https://github.com/llvm/llvm-project/commit/66face6aa0f5f68de56067b0dff3295e47fdf66c.dif

[clang] d1751d1 - PR47175: Ensure type-dependent function-style casts have dependent

Author: Richard Smith Date: 2020-10-08T17:00:22-07:00 New Revision: d1751d14a6b2787974a4d203be2b554de9fa613c URL: https://github.com/llvm/llvm-project/commit/d1751d14a6b2787974a4d203be2b554de9fa613c DIFF: https://github.com/llvm/llvm-project/commit/d1751d14a6b2787974a4d203be2b554de9fa613c.diff

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hi Paula, This error is fine. The buildbot has tested the worker version. 0.8.x apparently does not have that method. The error gets handled gracefully on the server side. At least it seems so so far. That should not prevent your bot from connecting. Thanks Galina On Thu, Oct 8, 2020 at 2:11 P

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297079. compnerd marked an inline comment as done. compnerd added a comment. address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 Files: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-win

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:92 +Length = GetFinalPathNameByHandleW(DirectoryHandle, Buffer.data(), + Buffer.capacit

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd created this revision. compnerd added reviewers: vsk, rnk. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. compnerd requested review of this revision. In order for the hot/cold splitting pass to graduate out of experimental status,

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 297072. njames93 added a comment. Remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/l

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 297070. atmnpatel added a comment. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 297069. atmnpatel added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://rev

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

NoQ added a comment. This actually looks correct to me but i suggest a bit more investigation. Architecturally, it doesn't make sense to me that `CastRetrievedVal()` does anything beyond `svalBuilder.dispatchCast(V, castTy)`. After all, there's only one way to cast a value from one type to anot

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

avemilia added a comment. As a workaround, you can use a standalone utility called `unbuffer` from Tcl/Tk's expect bundle. Just put it in front of the clang-tidy invocation. In case you use run-clang-tidy, you can put `invocation.insert(0, 'unbuffer')` right above `proc = subprocess.Popen(invoc

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:82 +DirectoryWatcherCallback Receiver) +: Callback(Receiver) { + // Pre-compute the real location as we will be handing

[clang] afff74e - [HWAsan][NewPM] Handle hwasan like other sanitizers

Author: Arthur Eubanks Date: 2020-10-08T14:43:21-07:00 New Revision: afff74e5c26fd8b57968ae111a2a4fc8fc8deda8 URL: https://github.com/llvm/llvm-project/commit/afff74e5c26fd8b57968ae111a2a4fc8fc8deda8 DIFF: https://github.com/llvm/llvm-project/commit/afff74e5c26fd8b57968ae111a2a4fc8fc8deda8.diff

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rGafff74e5c26f: [HWAsan][NewPM] Handle hwasan like other sanitizers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://r

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to un

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hey Andrzej, What are you seeing in your buildbot logs? Is it this error? `twisted.spread.flavors.NoSuchMethod: No such method: remote_getWorkerInfo` If so, you might want to try updating your buildbot worker. I updated llvmlibc's to 2.8.4 and that seemed to solve the connection problem: https:/

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

steveire added a comment. In D88275#2319290 , @ymandel wrote: > TL;DR Stephen's fix works; I'll drop this patch. > This is a longer discussion and not necessarily worth having on this review > thread. Are you attending the dev meeting today? If so, wan

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added a comment. I'll probably leave the llvm/CodeView parts of this for @rnk - but for the clang parts, they should have corresponding clang test coverage & I'd be curious to see the test for that to understand what the IR was before/after this change. (& to understand if/how either o

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + Not sure if AIXPragmaPack is the best name here. It's more like IBM xl pragma pack handling on AIX. Would it

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. Can we use a regex to make this also work in AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 ___ cfe-commits mailing

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind created this revision. lxfind added reviewers: lewissbaker, wenlei, bruno, junparser, rjmccall. Herald added subscribers: cfe-commits, modimo, dexonsmith, modocache. Herald added a project: clang. lxfind requested review of this revision. In https://reviews.llvm.org/D87470 I added the chang

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

v.g.vassilev added a comment. @shafik, I suppose that with a good amount of effort we may be able to test it in a unittest setup. In my point of view, this patch is rather fixing an interface inconsistency which was discovered in the context of cling. The ASTImporter already makes a promise to

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. I don't see any support for verifying fix-its in the test cases so unsure how i could go about testing this change. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:18 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticParse.h" #include

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 created this revision. njames93 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 requested review of this revision. If a static assert has a message as the right side of an and condition, suggest a fix it of replacing the '&&' to '

Re: [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello bot owners, I see a lot of builders went down and not connecting back to the production buildbot. Could you check your bots to make sure they are up and running, please? And report connectivity issues if any with quotes from the logs directly to me. Thanks Galina On Thu, Oct 8, 2020 at

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. AIX has different layout dumping format from other itanium abis. And for

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

ASDenysPetrov added a comment. @NoQ @steakhal Hi, guys. I've just uploaded a patch for solving this and related D77062 . Welcome to review D89055 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 8568113 - Fix Wparentheses warning. NFCI.

Author: Simon Pilgrim Date: 2020-10-08T20:02:19+01:00 New Revision: 85681131019db5d6831fb3980aec683d517e1674 URL: https://github.com/llvm/llvm-project/commit/85681131019db5d6831fb3980aec683d517e1674 DIFF: https://github.com/llvm/llvm-project/commit/85681131019db5d6831fb3980aec683d517e1674.diff

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. Thank you for working on this check! Have you run the check over LLVM to see how much it reports? One of the concerns I have with this is that it's not always appropriate to replace a `const std::string&` with an `llvm::StringRef` and so I'm wondering what the "fa

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. I see. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936

[libunwind] 504bc07 - [runtimes] Use int main(int, char**) consistently in tests

Author: Louis Dionne Date: 2020-10-08T14:28:13-04:00 New Revision: 504bc07d1afc7bad7b980a977141696ec8298e7e URL: https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e DIFF: https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e.diff

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks added a comment. diff for hwasan + -O1: 14a15 > @__hwasan_shadow = external global [0 x i8] 72a74,109 > declare void @__hwasan_loadN(i64, i64) > > declare void @__hwasan_load1(i64) > > declare void @__hwasan_load2(i64) > > declare void @__hwasan_load4(i64) > > declare void @__hwasan_l

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan added a comment. To what extent does the IR change? My only concern is the right codegen is still produced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936 _

[clang] 3cc1f1f - [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

Author: Joseph Huber Date: 2020-10-08T14:00:22-04:00 New Revision: 3cc1f1fc1d97952136185f4eafb827694875de17 URL: https://github.com/llvm/llvm-project/commit/3cc1f1fc1d97952136185f4eafb827694875de17 DIFF: https://github.com/llvm/llvm-project/commit/3cc1f1fc1d97952136185f4eafb827694875de17.diff

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

aaron.ballman added a comment. In D88833#2319799 , @lebedev.ri wrote: > I think the current behavior should instead be configurable, with a way to > opt-in into weaker guarantees. I think that's a good idea, thank you! Repository: rG LLVM Github Mono

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:139 + + switch (E->getStmtClass()) { + case Stmt::UnaryOperatorClass: { sepavloff wrote: > Actually this is not correct, because subclass relations are not preserved in > this case. F

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. *ping* Any objections to this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D87451: add new option -mignore-xcoff-visibility

dmgreen added a comment. Hello. I added a power-pc REQUIRES clause to the new clang test here in a15bd0bfc20c2b2955c59450a67b6e8efe89c708 . Hope that looks OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a15bd0b - [AIX] Add REQUIRES for powerpc test. NFC

Author: David Green Date: 2020-10-08T18:40:09+01:00 New Revision: a15bd0bfc20c2b2955c59450a67b6e8efe89c708 URL: https://github.com/llvm/llvm-project/commit/a15bd0bfc20c2b2955c59450a67b6e8efe89c708 DIFF: https://github.com/llvm/llvm-project/commit/a15bd0bfc20c2b2955c59450a67b6e8efe89c708.diff L

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. This is quite low priority, compared to the other branches of work, but it was almost ready work, so I decided to polish it and send it to review now. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:238

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

lebedev.ri added a comment. I think the current behavior should instead be configurable, with a way to opt-in into weaker guarantees. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable feature (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https

[clang] 64c0792 - [clang][feature] Add cxx_abi_relative_vtable feature

Author: Leonard Chan Date: 2020-10-08T10:30:54-07:00 New Revision: 64c0792946b792839b2f39e4e208fdd7398aaea0 URL: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0 DIFF: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0.diff

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

aaron.ballman added a comment. In D88833#2319118 , @fiesh wrote: > @aaron.ballman valid point. It would seem natural to diagnose both since the > user is voluntarily causing the decay? I'm on the fence. If the argument to the function is one that's defi

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. *PING!* Any feedback? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 297008. jhuber6 added a comment. Updating tests after landing D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files: clang/l

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297003. jhuber6 added a subscriber: ABataev. jhuber6 added a comment. Removing the _loc suffix. The Mapper API hasn't been officially released in Clang 11.x so we're still free to make changes. Currently working on augmenting the mapper API with variable dec

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 297006. eduucaldas added a comment. Replace `auto .. = std::vector();` with `std::vector ..;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

shafik added a comment. This looks reasonable, I am guessing we can't test this b/c it would only come up in a cling use case? Was there ever a design document that Hal and JF were asking for? I was reading through the cfe-dev thread and I don't see it. Repository: rG LLVM Github Monorepo

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ, martong, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 297001. eduucaldas added a comment. Reorganize methods to minimize diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne updated this revision to Diff 297000. ldionne added a comment. Try to fix test failure on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89001/new/ https://reviews.llvm.org/D89001 Files: clang/lib/Driver/ToolChains/Darwin.cpp clan

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 296996. eduucaldas added a comment. Better comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/To

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 296994. eduucaldas added a comment. - [SyntaxTree] Provide iterator for `List` that iterates through `ElementAndDelimiter`s even for not well-defined lists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8810

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. I think it makes sense - IIUC, for most of the clang tests, noundef won't be the attribute of interest. For brevity of tests, I think the change is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://revi

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2318203 , @jyknight wrote: > It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, then. > I'm not sure why you want it to be 8? /// Return the alignment that is suitable for storing

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:44 +// Returns true if \p Query can be found as a sub-scope inside \p Scope. +bool approximateScopeMatch(llvm::StringRef Scope, sammccall wrote: > kadircet wrote: > > sammccall

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet updated this revision to Diff 296992. kadircet marked 3 inline comments as done. kadircet added a comment. - Switch from substring to subscope matching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88814/new/ https://reviews.llvm.org/D888

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2095 +if (!GCCReg.empty() && !PhysRegOutputs.insert(GCCReg).second) + CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + Diagnostics in Clang are typic

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 reopened this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Closed accidentally, had the wrong revision link in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.ll

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 closed this revision. jhuber6 added a comment. Screwed up and put the wrong revision in the commit message. Closed in rGd564409946a5a13cb6391fc0fec54dcbd6f6d249 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] d564409 - [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

Author: Joseph Huber Date: 2020-10-08T12:09:34-04:00 New Revision: d564409946a5a13cb6391fc0fec54dcbd6f6d249 URL: https://github.com/llvm/llvm-project/commit/d564409946a5a13cb6391fc0fec54dcbd6f6d249 DIFF: https://github.com/llvm/llvm-project/commit/d564409946a5a13cb6391fc0fec54dcbd6f6d249.diff

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rGd564409946a5: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by… (authored by jhuber6). Herald added a subscriber: mgorny. Changed prior to commit: https://reviews.llvm.org/D

[clang] b922554 - DeferredDiagnosticsEmitter crashes

Author: Geoff Levner Date: 2020-10-08T11:42:21-04:00 New Revision: b9225543e844bee5091aa16108e0c54bd2abe485 URL: https://github.com/llvm/llvm-project/commit/b9225543e844bee5091aa16108e0c54bd2abe485 DIFF: https://github.com/llvm/llvm-project/commit/b9225543e844bee5091aa16108e0c54bd2abe485.diff

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9225543e844: DeferredDiagnosticsEmitter crashes (authored by glevner, committed by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https:

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

dexonsmith added reviewers: rsmith, teemperor. dexonsmith added a comment. Hmm, that's right, to support user-provided libc++ headers it's simpler if we prefer the toolchain / next-to-clang. The reason we need to invert it is transitional. The status quo is that we have no headers in the SDKs (

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. Good enough for us... Thanks, @hans and @yaxunl! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked 2 inline comments as done. alanphipps added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1169 +createBranchRegion(S->getCond(), BodyCount, + subtractCounters(CondCount, BodyCount)); } vsk wro

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

hans added a comment. In D88949#2319392 , @yaxunl wrote: > I can help you commit it to trunk. For cherrypick to release branch, we may > need help of @hans It's most likely too late for 11.0.0, but I will put it on my list of 11.0.1 candidates. Reposi

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:37 + clangLex + clangSerialization clangTidy Why do serialization and lex need to be pulled in? Comment at: clang-tools-extra/c

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 296972. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Remove emit errors for oversized long long bitfield and related testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet updated this revision to Diff 296971. kadircet added a comment. - Fix a bug in FileSymbols profiling. - Add unittests to ensure tree structure is as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88414/new/ https://reviews.llvm.or

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM though I may have spotted a potential improvement (it can be handled in a follow-up if you want). Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61 + // below. + auto const ConditionalOperator

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

stefanp updated this revision to Diff 296970. stefanp added a comment. Added the missing header file. Added the license comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/unittests/Tool

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 296968. hokein added a comment. fix unexpected format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/Basic/LangOptions.def clang

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl added a subscriber: hans. yaxunl added a comment. I can help you commit it to trunk. For cherrypick to release branch, we may need help of @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 _

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. nemanjai wrote: > fpetrogall

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17 +llvm::TargetOptions +lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) { + return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple); MaskRay wr

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 296965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aix-data-sections.c clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp lld/Comm

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein created this revision. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Not intent to land it now, we need to run internal experiments to make sure this is not crashy. It is ready for review, all ch

[PATCH] D89045: [AST][RecoveryExpr] Don't perform early typo correction in C.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. The dependent mechanism for C error-recovery is mostly finished, this is the only place we have missed. Repository: rG LLVM Github Monorepo https://review

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

hokein added a comment. In D89036#2319320 , @kadircet wrote: > Tests seem to be failing on premerge bots: > > - https://reviews.llvm.org/harbormaster/unit/view/177841/ > - https://reviews.llvm.org/harbormaster/unit/view/177842/ opps, sorry -- I made a few

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

hokein updated this revision to Diff 296961. hokein added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89036/new/ https://reviews.llvm.org/D89036 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clan

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2292505 , @whisperity wrote: > I'd like to resurrect the discussion about this. Unfortunately, the concept > of `experimental-` group (in D76545 ) has > fallen silent, too. We will

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

kadircet added a comment. Tests seem to be failing on premerge bots: - https://reviews.llvm.org/harbormaster/unit/view/177841/ - https://reviews.llvm.org/harbormaster/unit/view/177842/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89036/new/ https

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet requested review of this revision. kadircet added a comment. Bad news, I was testing this with remote-index, hence background-index was turned off. Unfortunately traversing all of the slabs in `FileSymbols` takes quite a while in this case (~15ms for LLVM). I don't think it is feasible

  1   2   >