[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:78 +llvm::cl::desc("Delay between index hot reload checks (in seconds)"), +llvm::cl::init(90), +llvm::cl::Hidden, this was 30 before. not that it matte

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

kadircet added a comment. Thanks for figuring this one out! I think the final result looks pretty good, I especially loved only disabling when there's a request in question. My only hesitation is around logging all severities when we are outside a request, I suppose it shouldn't cause too much

[PATCH] D90590: [clangd] Improve remote-index test

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

kbobyrev abandoned this revision. kbobyrev added a comment. As discussed in PM, it probably doesn't make sense right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90587/new/ https://reviews.llvm.org/D90587

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev abandoned this revision. kbobyrev added a comment. In favor of D90526 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 _

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev reclaimed this revision. kbobyrev added a comment. Actually, maybe I should just postone and build on top of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 __

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev planned changes to this revision. kbobyrev added a comment. Herald added a subscriber: dexonsmith. Not needed yet, waiting for myself to start adding some PP-based FoldingRanges to continue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

atanasyan added a comment. What's a goal of this change? Do you want to suppress an error message when the option provided to Clang? If so, is it a real-life case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90570/new/ https://reviews.llvm.org/D

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

sammccall added a comment. In D90526#2367659 , @kadircet wrote: > Thanks for figuring this one out! > > I think the final result looks pretty good, I especially loved only disabling > when there's a request in question. > My only hesitation is around logg

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90528/new/ https://reviews.llvm.org/D90528 _

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added a subscriber: tstellar. hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + Anastasia wrote: > hans wrote: > > akyrtzi wrote: > > > Hi Anastasia, apologies for not catching this ea

[PATCH] D90590: [clangd] Improve remote-index test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0beda1b6661: [clangd] Improve remote-index test (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang-tools-extra] d0beda1 - [clangd] Improve remote-index test

Author: Kirill Bobyrev Date: 2020-11-02T10:55:17+01:00 New Revision: d0beda1b66617cda8a1f54978fca72832496b1fb URL: https://github.com/llvm/llvm-project/commit/d0beda1b66617cda8a1f54978fca72832496b1fb DIFF: https://github.com/llvm/llvm-project/commit/d0beda1b66617cda8a1f54978fca72832496b1fb.diff

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet updated this revision to Diff 302230. kadircet marked 4 inline comments as done. kadircet added a comment. - Mention possibility of returning null SymbolIDs in comments. - Mark bool conversion operator explicit, fix the bug in returned value. (and run tests :)) Repository: rG LLVM Gi

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolID.h:58 + bool isNull() const { return HashValue != std::array{}; } + operator bool() const { return isNull(); } + sammccall wrote: > sammccall wrote: > > nit: I think you want thi

[PATCH] D90397: [clangd] Value initialize SymbolIDs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0df197516b69: [clangd] Value initialize SymbolIDs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang-tools-extra] 0df1975 - [clangd] Value initialize SymbolIDs

Author: Kadir Cetinkaya Date: 2020-11-02T11:37:47+01:00 New Revision: 0df197516b69a4477a4c8f02b7c4dccacda5f23f URL: https://github.com/llvm/llvm-project/commit/0df197516b69a4477a4c8f02b7c4dccacda5f23f DIFF: https://github.com/llvm/llvm-project/commit/0df197516b69a4477a4c8f02b7c4dccacda5f23f.dif

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 302236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGCall.cpp clang/test/CXX/except/except.spec/p14-ir.cpp clang/test/CodeGen/arm64-microsof

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson marked an inline comment as done. CJ-Johnson added a comment. In D17993#2367447 , @rsmith wrote: > Thanks! We should also have a test for the behavior when targeting the MS > ABI, where we sometimes don't emit the `nonnull dereferenceable` beca

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:782 + +EXPECT_EQ(Ref1->Container, Ref2->Container); + }; can y

[PATCH] D90291: [clangd] Add lit tests for remote index

hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" Could this use `PYTHON_EXECUTABLE` instead? I see other tests using that, a

[PATCH] D90595: [clangd] Fix race in background index rebuild, where index could stay stale.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The BackgroundQueue worker that fini

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ArcsinX added a comment. In D90116#2353440 , @kbobyrev wrote: > Hmm, I see. From the looks of it, the solution for several projects would be > > add_compile_options("$<$:/utf-8>") > add_compile_options("$<$:/utf-8>") > > But I'm not sure if it makes se

[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

sammccall added a comment. This doesn't feel quite right to me - we're going to need to get PP conditional regions, include blocks etc from the ParsedAST (they're not in ASTContext). My sense is that we'll need a fairly random subset of ParsedAST, and so ParsedAST is a reasonable abstraction unl

[PATCH] D80961: [clang][AST] Ignore template instantiations if not in AsIs mode

aaron.ballman added a comment. In D80961#2353384 , @steveire wrote: > Many of the changes which were part of a previous iteration of this change > were related to the change of default behavior of matchers. As the default is > no longer changed, those ch

[PATCH] D90599: Fix a leak in `ASTUnit::LoadFromCommandLine()` wehn compiler invocation fails

bstaletic created this revision. bstaletic added a reviewer: aprantl. bstaletic added projects: clang, clang-c. Herald added a subscriber: cfe-commits. bstaletic requested review of this revision. 1. Here

[PATCH] D80961: [clang][AST] Ignore template instantiations if not in AsIs mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops, forgot to click the important bit to actually accept the review. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/

[clang-tools-extra] a07a2c8 - Use --use-color in run-clang-tidy.py

Author: David Sanders Date: 2020-11-02T08:38:20-05:00 New Revision: a07a2c88d96cc48d7d381a0300565090c24b9770 URL: https://github.com/llvm/llvm-project/commit/a07a2c88d96cc48d7d381a0300565090c24b9770 DIFF: https://github.com/llvm/llvm-project/commit/a07a2c88d96cc48d7d381a0300565090c24b9770.diff

[PATCH] D90110: [clang-tidy] Use --use-color in run-clang-tidy.py

aaron.ballman closed this revision. aaron.ballman added a comment. In D90110#2367596 , @dsanders11 wrote: > No one has raised any concerns, so if someone with commit access wants to > commit this on my behalf it would be appreciated.. Thanks! I've commit

[PATCH] D90553: Rename CXXUnresolvedConstructExpr::arg_size for consistency

aaron.ballman added a reviewer: rsmith. aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor linting nits. Thanks! Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1617 +TE

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc, Why is this inheriting from a `Na

[clang] d28de0d - [Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`)

Author: Caroline Concatto Date: 2020-11-02T14:03:35Z New Revision: d28de0d7f257bbe4703f3449f1672f1744cf306b URL: https://github.com/llvm/llvm-project/commit/d28de0d7f257bbe4703f3449f1672f1744cf306b DIFF: https://github.com/llvm/llvm-project/commit/d28de0d7f257bbe4703f3449f1672f1744cf306b.diff

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd28de0d7f257: [Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`) (authored by CarolineConcatto, committed by awarzynski). C

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added a comment. In D88381#2357123 , @sameeranjoshi wrote: > I would wait for a couple of more days for someone to review from community > may be from Nvidia's side if someone would verify the initial design. As there were no new reviews, I a

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:263 + DeclContextLookupResult LookupResult; + switch (DC->getDeclKind()) { + case Decl::TranslationUnit: explain this list somewhat? e.g. these are the declcontexts which

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

kadircet added a comment. In D90526#2367782 , @sammccall wrote: > So I can't remember anymore why I put this as an enum `-log=public` rather > than an independent switch `-log-public` or so that could combine with any > log level. > Sounds like the latte

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added a comment. In D87449#2358579 , @balazske wrote: > I think the name of this checker should be changed. It could in future not > only check for the SIG30-C rule. (Plan is to include C++ checks too, and > SIG31-C could be checked in this

[PATCH] D90291: [clangd] Add lit tests for remote index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" hans wrote: > Could this use `PYTHON_EXECUTABLE` instead? I see other t

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:313 + AST_POLYMORPHIC_SUPPORTED_TYPES(Decl, Stmt, TypeLoc), + std::string, MacroName) { // Verifies that the statement' beginning an

[PATCH] D90442: [PS4] Support dllimport/export attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGff2e24a741e4: [PS4] Support dllimport/export attributes (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM G

[clang] ff2e24a - [PS4] Support dllimport/export attributes

Author: Ben Dunbobbin Date: 2020-11-02T14:25:34Z New Revision: ff2e24a741e4cee903fa71ec5c8c1909a89f66a3 URL: https://github.com/llvm/llvm-project/commit/ff2e24a741e4cee903fa71ec5c8c1909a89f66a3 DIFF: https://github.com/llvm/llvm-project/commit/ff2e24a741e4cee903fa71ec5c8c1909a89f66a3.diff LOG:

[PATCH] D90291: [clangd] Add lit tests for remote index

hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" kadircet wrote: > hans wrote: > > Could this use `PYTHON_EXECUTABLE` instea

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

tschuett added inline comments. Comment at: llvm/docs/LangRef.rst:19494 + + declare void @llvm.ubsantrap(i32 immarg) cold noreturn nounwind + This is still i32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/ https://reviews.llvm.org/D899

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman added a comment. In D90042#2360042 , @flx wrote: > In D90042#2357078 , @aaron.ballman > wrote: > >> In D90042#2356265 , @flx wrote: >> >>> In D90042#2356180

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

chrish_ericsson_atx added a comment. Is anything planned or in progress that would address this issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D86743 ___ cfe-com

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; Should this attribute also be supported on things like ObjC

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman closed this revision. aaron.ballman added a comment. In D72218#2364297 , @ffrankies wrote: > @aaron.ballman Can you please commit this on my behalf? My github username is > ffrankies . I've commit on your behal

[clang-tools-extra] 43a38a6 - Add a new altera kernel name restriction check to clang-tidy.

Author: Frank Derry Wanye Date: 2020-11-02T10:11:38-05:00 New Revision: 43a38a65233039b5e71797a644d41a890f8d7f2b URL: https://github.com/llvm/llvm-project/commit/43a38a65233039b5e71797a644d41a890f8d7f2b DIFF: https://github.com/llvm/llvm-project/commit/43a38a65233039b5e71797a644d41a890f8d7f2b.d

[clang-tools-extra] 5a7bc5e - Fix link to a new check within the release notes.

Author: Aaron Ballman Date: 2020-11-02T10:19:24-05:00 New Revision: 5a7bc5e2595903e51f0b31e3faf82024e965c962 URL: https://github.com/llvm/llvm-project/commit/5a7bc5e2595903e51f0b31e3faf82024e965c962 DIFF: https://github.com/llvm/llvm-project/commit/5a7bc5e2595903e51f0b31e3faf82024e965c962.diff

[clang-tools-extra] c883904 - Revert "Add a new altera kernel name restriction check to clang-tidy."

Author: Nico Weber Date: 2020-11-02T10:30:42-05:00 New Revision: c88390468cdd1de4283b2c5c7889f16c477791cd URL: https://github.com/llvm/llvm-project/commit/c88390468cdd1de4283b2c5c7889f16c477791cd DIFF: https://github.com/llvm/llvm-project/commit/c88390468cdd1de4283b2c5c7889f16c477791cd.diff LO

Re: [clang-tools-extra] 43a38a6 - Add a new altera kernel name restriction check to clang-tidy.

The test in this commit doesn't pass. I've reverted this for now in c88390468cdd1de4283b2c5c7889f16c477791cd Please run the tests you're adding before committing a change. On Mon, Nov 2, 2020 at 10:12 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Frank Derry W

Re: [clang-tools-extra] 43a38a6 - Add a new altera kernel name restriction check to clang-tidy.

On Mon, Nov 2, 2020 at 10:32 AM Nico Weber wrote: > > The test in this commit doesn't pass. I've reverted this for now in > c88390468cdd1de4283b2c5c7889f16c477791cd Thanks for the revert. Can you link to a bot for the failure? The only failure I saw was with the documentation building and I had

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. In D84362#2365153 , @rjmccall wrote: > I may not have been clear. I'm not saying SourceLocation is a meaningful > concept in the driver. Likewise, I should be more careful with respect to how I refer to `SourceLocation` (a cl

[clang] 22e7182 - [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator

Author: Kirstóf Umann Date: 2020-11-02T16:41:17+01:00 New Revision: 22e7182002b5396539c69603b1c8c924b5f661e7 URL: https://github.com/llvm/llvm-project/commit/22e7182002b5396539c69603b1c8c924b5f661e7 DIFF: https://github.com/llvm/llvm-project/commit/22e7182002b5396539c69603b1c8c924b5f661e7.diff

[PATCH] D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG22e7182002b5: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator (authored by Szelethus). Changed p

[PATCH] D90618: chained diff

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90618 Files: clang-tools-extra/docs/new_file.txt Index: clang-tools-extra/docs/

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk added a comment. I might've missed it, but the debug location merging behavior could use a test. Here's one way to write it: https://godbolt.org/z/Yb9PY9. In `@_Z13keep_locationPi`, the !dbg attachment on the trap should match `!DILocation(line: 1`. In `@_Z15merge_locationsPi`, the attachme

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. I think this is a dead end approach. I don't see the connection to the original problem you are trying to solve. Can you send me an IR testcase that this is supposed to help? Repos

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:34 + hasName("barrier"), + hasName("work_group_barrier") +

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1283 + return true; +// We are ignoring friends here. if (!CurrentMethod) This should probably have a FIXME? Comment at: clang/lib/Analysis/Threa

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 302298. compnerd added a comment. rebase, clang-format, add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files: clang/include/clang/APINotes/APINotesYAML

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

thakis created this revision. thakis added a reviewer: rjmccall. thakis requested review of this revision. Just skip (non-bitfield) zero-sized fields, like we do with empty bases. The class->struct conversion in the test is because -std=c++20 else deletes some default methods due to non-accessib

[PATCH] D90518: [clangd] Make tests depend on Clang

smeenai abandoned this revision. smeenai added a comment. Cool, thanks for fixing it better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90518/new/ https://reviews.llvm.org/D90518 ___ cfe-commits maili

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

smeenai added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90528/new/ https://reviews.llvm.org/D90528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e4ab8e0152b: [clang] Limit scope of CLANG_VENDOR definition (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4e4ab8e - [clang] Limit scope of CLANG_VENDOR definition

Author: Shoaib Meenai Date: 2020-11-02T09:04:43-08:00 New Revision: 4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 URL: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 DIFF: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90.diff

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

aaron.ballman added a comment. In D90180#2366418 , @trixirt wrote: > I am trying to address problems treewide so around 100 changes per fix. > Doing that requires consensus that the fix is generally ok for every > subsystem in the code base. > So while cl

[clang-tools-extra] 6bd01b8 - [clangd] Account for vendor in version string

Author: Shoaib Meenai Date: 2020-11-02T09:04:44-08:00 New Revision: 6bd01b8184de93979756331c71af69b422f71103 URL: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103 DIFF: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103.diff

[PATCH] D90517: [clangd] Account for vendor in version string

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd01b8184de: [clangd] Account for vendor in version string (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90517/new/ https://reviews.

[clang] 415f7ee - [Clang] Add the ability to map DLL storage class to visibility

Author: Ben Dunbobbin Date: 2020-11-02T17:08:23Z New Revision: 415f7ee8836944942d8beb70e982e95a312866a7 URL: https://github.com/llvm/llvm-project/commit/415f7ee8836944942d8beb70e982e95a312866a7 DIFF: https://github.com/llvm/llvm-project/commit/415f7ee8836944942d8beb70e982e95a312866a7.diff LOG:

[PATCH] D89970: Add the ability to map DLL storage class to visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG415f7ee88369: [Clang] Add the ability to map DLL storage class to visibility (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Ch

[clang] 5024d3a - Revert "[Clang] Add the ability to map DLL storage class to visibility"

Author: Ben Dunbobbin Date: 2020-11-02T17:33:54Z New Revision: 5024d3aa1855d4c17c7e875048d5ad20b8b2d8ce URL: https://github.com/llvm/llvm-project/commit/5024d3aa1855d4c17c7e875048d5ad20b8b2d8ce DIFF: https://github.com/llvm/llvm-project/commit/5024d3aa1855d4c17c7e875048d5ad20b8b2d8ce.diff LOG:

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

amyk added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3312 +// if the type is invalid. +bool Sema::CheckPPCValidType(QualType Type, SourceLocation TypeLoc) { + if (Type->isPointerType() || Type->isArrayType()) Would `CheckPPCMMAType` be a bett

[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Thanks Baptiste. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81748/new/ https://reviews.llvm.org/D81748 __

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added a reviewer: NoQ. aaron.ballman added a subscriber: NoQ. aaron.ballman added a comment. Herald added a subscriber: Charusso. In D83717#2366598 , @gamesh411 wrote: >> Just to make sure we're on the same page -- the current approach is not

[clang] 2e2be3d - Correct the nomerge attribute documentation

Author: Aaron Ballman Date: 2020-11-02T12:49:40-05:00 New Revision: 2e2be3d964fb8f5a70faff1edbca4598bbb6ea94 URL: https://github.com/llvm/llvm-project/commit/2e2be3d964fb8f5a70faff1edbca4598bbb6ea94 DIFF: https://github.com/llvm/llvm-project/commit/2e2be3d964fb8f5a70faff1edbca4598bbb6ea94.diff

[PATCH] D90246: [clang-format] Improve BAS_DontAlign+AllowAllArgumentsOnNextLine=false

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG906b9dbc9d74: [clang-format] Improve BAS_DontAlign+AllowAllArgumentsOnNextLine=false (authored by arichardson). Repository: rG LLVM Github Monorep

[clang] 906b9db - [clang-format] Improve BAS_DontAlign+AllowAllArgumentsOnNextLine=false

Author: Alex Richardson Date: 2020-11-02T17:52:37Z New Revision: 906b9dbc9d7487ee923b6a516c36777a2be0ca35 URL: https://github.com/llvm/llvm-project/commit/906b9dbc9d7487ee923b6a516c36777a2be0ca35 DIFF: https://github.com/llvm/llvm-project/commit/906b9dbc9d7487ee923b6a516c36777a2be0ca35.diff LO

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 302326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le created this revision. j0le added reviewers: rogfer01, rnk. j0le added a project: clang. Herald added a subscriber: cfe-commits. j0le requested review of this revision. Hello everyone, I think, I have found the reason, why there is a difference between C and C++ for the keyword __unaligned:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. Given that some parts of this confused me, I'd like to make sure I'm clear on the approach you're taking. Based on the fact that labels are statements (defined as [stmt.label], in the statment production, etc), I would expect that attributes which appertain to lab

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, this basically looks correct to me, aside from some formatting details. Do you want me to apply those fixes and land this for you? I see that was done for your last patch, but it's best to a

[clang] ba18bc4 - [Sema] adds -Wfree-nonheap-object member var checks

Author: Christopher Di Bella Date: 2020-11-02T11:03:28-08:00 New Revision: ba18bc4925d8cbd4a9354629617cbcafbbd48941 URL: https://github.com/llvm/llvm-project/commit/ba18bc4925d8cbd4a9354629617cbcafbbd48941 DIFF: https://github.com/llvm/llvm-project/commit/ba18bc4925d8cbd4a9354629617cbcafbbd4894

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90572/new/ https://reviews.llvm.org/D90572 ___ cfe-com

[PATCH] D90269: adds -Wfree-nonheap-object member var checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGba18bc4925d8: [Sema] adds -Wfree-nonheap-object member var checks (authored by cjdb, committed by george.burgess.iv). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. kindly ping for help to submit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 302349. gulfem marked 3 inline comments as done. gulfem added a comment. Addressed the comments about the documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 F

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane created this revision. erichkeane added reviewers: rjmccall, aaron.ballman. Herald added subscribers: mgrang, kristof.beyls. erichkeane requested review of this revision. As described here: https://devblogs.microsoft.com/oldnewthing/20150220-00/?p=44623 In order to allow Lambdas to be

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as not done. gulfem added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3909 +The ``leaf`` attribute is used as a compiler hint to improve dataflow analysis in library functions. +Functions marked as ``leaf`` attribute are not

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3909 +The ``leaf`` attribute is used as a compiler hint to improve dataflow analysis in library functions. +Functions marked as ``leaf`` attribute are not allowed to enter their caller's tran

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > Should this attribute also be supported on

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > Should this attrib

[PATCH] D78899: [Driver] Add callback to Command execution

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

tra added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D78899: [Driver] Add callback to Command execution

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:118 + /// Callback called after the command has been executed. + std::function PostCallback; Can you comment what `int` means? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

sammccall updated this revision to Diff 302360. sammccall added a comment. Use separate flag for log-public vs log level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90526/new/ https://reviews.llvm.org/D90526 Files: clang-tools-extra/clangd/ind

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

sfantao added a comment. @tra, thank you for the patch. This makes sense. The patch looks good but it has to be someone else to okay it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436

[clang-tools-extra] c29513f - [clangd] Fix check-clangd with no clang built

Author: Sam McCall Date: 2020-11-02T21:10:43+01:00 New Revision: c29513f7e023f125c6d221db179dc40b79e5c074 URL: https://github.com/llvm/llvm-project/commit/c29513f7e023f125c6d221db179dc40b79e5c074 DIFF: https://github.com/llvm/llvm-project/commit/c29513f7e023f125c6d221db179dc40b79e5c074.diff LO

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc29513f7e023: [clangd] Fix check-clangd with no clang built (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D90528?vs=3

[clang] 9f151df - Change Module::ASTFile and ModuleFile::File => Optional, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-02T15:11:51-05:00 New Revision: 9f151df17800e1668c32e5314a290ae94c8f2dd3 URL: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f2dd3 DIFF: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f

  1   2   >