[clang] 89d41f3 - [AMDGPU] Add gfx1033 target

Author: Tim Renouf Date: 2020-11-03T16:27:48Z New Revision: 89d41f3a2b820c17edeb86a2e9d458ca69eca34e URL: https://github.com/llvm/llvm-project/commit/89d41f3a2b820c17edeb86a2e9d458ca69eca34e DIFF: https://github.com/llvm/llvm-project/commit/89d41f3a2b820c17edeb86a2e9d458ca69eca34e.diff LOG:

[clang] ee3e642 - [AMDGPU] Add gfx90c target

Author: Tim Renouf Date: 2020-11-03T16:27:43Z New Revision: ee3e642627575bc8fb0a7008f8a02c891e172b7b URL: https://github.com/llvm/llvm-project/commit/ee3e642627575bc8fb0a7008f8a02c891e172b7b DIFF: https://github.com/llvm/llvm-project/commit/ee3e642627575bc8fb0a7008f8a02c891e172b7b.diff LOG:

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. In D89980#2371270 , @hliao wrote: > In D89980#2368506 , @arsenm wrote: > >> I think this is a dead end approach. I don't see the connection to the >> original problem you are trying to

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2368506 , @arsenm wrote: > I think this is a dead end approach. I don't see the connection to the > original problem you are trying to solve. Can you send me an IR testcase that > this is supposed to help? That's

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98 + +def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>; jackmanb wrote: > Per Alexei's email comments let's call this BPF_FETCH? I can do this. Note naming in llvm may not be

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:21 /// Build a syntax tree for the main file. +syntax::TranslationUnit *buildSyntaxTree(Arena ,

[clang] b091af7 - [ASTMatchers] Made isExpandedFromMacro Polymorphic

Author: Nathan James Date: 2020-11-03T14:36:51Z New Revision: b091af790f192c5532b59159fc029f9c368285c0 URL: https://github.com/llvm/llvm-project/commit/b091af790f192c5532b59159fc029f9c368285c0 DIFF: https://github.com/llvm/llvm-project/commit/b091af790f192c5532b59159fc029f9c368285c0.diff LOG:

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb091af790f19: [ASTMatchers] Made isExpandedFromMacro Polymorphic (authored by njames93). Changed prior to commit:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added a comment. @beanz This patch looks good to me, can you confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 ___ cfe-commits mailing

[PATCH] D90682: [clangd][NFC] Make Located::operator->() use pointer sematics

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This enables using the arrow

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:488-489 + +The memory representation of a dense boolean vector is the smallest fitting +integer. The alignment is the number of bits rounded up to the next +power-of-two but at most the maximum vector

[PATCH] D90595: [clangd] Fix race in background index rebuild, where index could stay stale.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:848 +// The first two times the queue goes idle, add a couple more tasks. +// This should caute OnIdle to run again. +if (++IdleCount <= 2) {

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3910 +in library functions. Functions marked with the ``leaf`` attribute are not allowed +to jump back into the caller's translation unit, whether through invoking a +callback function, a

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff updated this revision to Diff 302563. sepavloff added a comment. Added documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl updated this revision to Diff 302560. yaxunl added a comment. updated manual CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302562. erichkeane added a comment. update comment as @aaron.ballman requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 Files: clang/lib/Sema/SemaLambda.cpp

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 302559. simoll marked 13 inline comments as done. simoll added a comment. - Addressed comments. - Made ext_vector_type bool un-castable (as any other ext_vector_type) - with tests. - Made bool vector element access illegal - with tests. - Rebased.

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2369317 , @Mordante wrote: > Then me try to clear up the confusion. > The parser first parses the `LabelDecl` and tries to attach the attributes to > this declaration. If that fails instead of issue a diagnostic

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky updated this revision to Diff 302558. aronsky retitled this revision from "Include attribute details when dumping AST in JSON" to "Include more attribute details when dumping AST in JSON". aronsky edited the summary of this revision. aronsky added a comment. Updated the relevant

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 updated this revision to Diff 302552. njames93 added a comment. Removed support for using clang-tidy that will happen in a follow up as its a more involved change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/

[PATCH] D90311: [CUDA][HIP] Fix linkage for -fgpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGabd8cd9199d1: [CUDA][HIP] Fix linkage for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] abd8cd9 - [CUDA][HIP] Fix linkage for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2020-11-03T08:07:19-05:00 New Revision: abd8cd9199d1e14cae961e1067b78df7044179a3 URL: https://github.com/llvm/llvm-project/commit/abd8cd9199d1e14cae961e1067b78df7044179a3 DIFF:

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we are ensuring that the default-free/default-member and + /// call-operator calling convention are generated as well. + if (S.getLangOpts().MSVCCompat) {

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436

[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

nullptr.cpp updated this revision to Diff 302544. nullptr.cpp added a comment. Implement whole P1825R0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from testing request. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:313 + AST_POLYMORPHIC_SUPPORTED_TYPES(Decl,

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2370336 , @rjmccall wrote: > I agree this is useful. However, you need to update the manual to cover > `faststd`. will update the manual. Comment at: clang/test/CodeGenCUDA/fp-contract.cu:203 + +//

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 302542. balazske added a comment. Rename of the checker. Using canonical decl for system function detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files:

[PATCH] D80961: [clang][AST] Ignore template instantiations if not in AsIs mode

sammccall added a comment. This seems to make asan buildbots unhappy: http://lab.llvm.org:8011/#/builders/5/builds/744 I can't see anything immediately suspicious, but I don't know the matcher internals that well :-\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

steakhal added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:916-918 + virtual const CXXInheritedCtorInitExpr *getOriginExpr() const { +return cast(AnyFunctionCall::getOriginExpr());

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98 + +def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>; Per Alexei's email comments let's call this BPF_FETCH? Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:765 +

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6a468d622b2: [clang-tidy] adding --config-file=file-path to specify custom config file. (authored by Hiralo, committed by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] d6a468d - [clang-tidy] adding "--config-file=" to specify custom config file.

Author: Hiral Oza Date: 2020-11-03T11:59:46Z New Revision: d6a468d622b2d48c40c47290aa54d6d910c5a6bf URL: https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf DIFF: https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf.diff LOG:

[PATCH] D90654: [clangd] Add index server request logging

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:43 args.index_file, args.project_root - ], + ] + args.server_arg, stderr=subprocess.PIPE) this breaks

[clang] ff02ae2 - Add test missing from previous commit

Author: Stephen Kelly Date: 2020-11-03T11:06:52Z New Revision: ff02ae2139eebbe3fbd66d4204ad7589d475a355 URL: https://github.com/llvm/llvm-project/commit/ff02ae2139eebbe3fbd66d4204ad7589d475a355 DIFF: https://github.com/llvm/llvm-project/commit/ff02ae2139eebbe3fbd66d4204ad7589d475a355.diff

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Looks good to me now! Thanks for addressing my concerns. Comment at: clang/tools/apinotes-test/APINotesTest.cpp:15 + +static

[PATCH] D90673: yet another commit

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90673 Files: clang-tools-extra/docs/new_file.txt Index:

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. In D89936#2370712 , @DmitryPolukhin wrote: > In D89936#2370163 , @Hiralo wrote: > >> When this patch will be merged and available in master? > > @Hiralo I can push this changes to master

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

mstorsjo added a comment. In D90572#2370716 , @sberg wrote: > Smells like this breaks various bots due to a -fsanitize=...,... option now > listing 18 instead of 17 items, see > http://lab.llvm.org:8011/#builders/76/builds/363, >

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

sberg added a comment. Smells like this breaks various bots due to a -fsanitize=...,... option now listing 18 instead of 17 items, see http://lab.llvm.org:8011/#builders/76/builds/363, http://lab.llvm.org:8011/#builders/93/builds/430, http://lab.llvm.org:8011/#builders/66/builds/315,

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. In D89936#2370163 , @Hiralo wrote: > When this patch will be merged and available in master? @Hiralo I can push this changes to master for you. Please let me know if you need it. Repository: rG LLVM Github Monorepo

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Follow-up on https://reviews.llvm.org/D88553#inline-837013 Repository: rG LLVM

[PATCH] D90654: [clangd] Add index server request logging

kadircet added a comment. I wish there was an easy way to check redacted error logs too :/ Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:335 return std::make_unique(OS, LogLevel); +llvm::errs() << "non redacted logger\n"; + }

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen requested changes to this revision. sdesmalen added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/LanguageExtensions.rst:3039 +useful for specifying the optimal width/count of the set of target +architectures supported by your

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

steven.zhang added a comment. LGTM now and thank you for the double check. But please hold on for some days in case someone has concern on enabling the new macros(we are enabling the __LONG_DOUBLE_IBM128__ by default now). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le marked an inline comment as done. j0le added a comment. In D90630#2368984 , @rnk wrote: > Thanks, this basically looks correct to me, aside from some formatting > details. Do you want me to apply those fixes and land this for you? I see > that was

[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

sammccall added a comment. In D90588#2370604 , @kbobyrev wrote: > In D90588#2368021 , @sammccall wrote: > >> This doesn't feel quite right to me - we're going to need to get PP >> conditional regions, include

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le updated this revision to Diff 302496. j0le edited the summary of this revision. j0le added a comment. Moved comment into the else-if block. Changed Summary of the diff, so that it is better suited for a commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90630/new/

[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

kbobyrev added a comment. In D90588#2368021 , @sammccall wrote: > This doesn't feel quite right to me - we're going to need to get PP > conditional regions, include blocks etc from the ParsedAST (they're not in > ASTContext). > My sense is that we'll

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks for the feedback. @Bigcheese do you have anything to add? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 302488. qiucf marked an inline comment as done. qiucf added a comment. Keep the `FIXME`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:122 if (LongDoubleWidth == 128) { Builder.defineMacro("__LONG_DOUBLE_128__"); Builder.defineMacro("__LONGDOUBLE128"); steven.zhang wrote: > Can you please double check if we

[clang] d3bd06f - [clang] Fix the fsanitize.c testcase after eaae6fdf67e1f. NFC.

Author: Martin Storsjö Date: 2020-11-03T10:21:29+02:00 New Revision: d3bd06f5c709fe073739a06e0d5a22020f0bf90c URL: https://github.com/llvm/llvm-project/commit/d3bd06f5c709fe073739a06e0d5a22020f0bf90c DIFF:

<    1   2