[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. In D92024#2431452 , @Quuxplusone wrote: > The subject line says "access checking on specializations and > instantiations," but I don't see any tests for explicit instantiations here — > just specializations. In particular, I'm ver

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Yes, here's my reply: https://bugs.llvm.org/show_bug.cgi?id=47161#c2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits ma

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro created this revision. evandro added reviewers: Hsiang-Kai, craig.topper, rogfer01, frasercrmck. Herald added subscribers: dexonsmith, NickHung, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, e

[PATCH] D92714: Make -fno-pic respect -fno-direct-access-external-data

MaskRay created this revision. MaskRay added reviewers: hjl.tools, rnk, tmsriram. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D92633 added -f[no-]direct-access-external-data to supersede -m[no-

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-gemb

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

dblaikie added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: njames93 wrote: > dblaikie wrote: > > Are there many uses that rely on this? I don't think i

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e953a274b2a: [RISCV] Define preprocessor definitions for 'V' extension. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92650/new/ h

[clang] 5e953a2 - [RISCV] Define preprocessor definitions for 'V' extension.

Author: Hsiangkai Wang Date: 2020-12-05T08:34:32+08:00 New Revision: 5e953a274b2ada5bfa54b3d765e391abb03f474f URL: https://github.com/llvm/llvm-project/commit/5e953a274b2ada5bfa54b3d765e391abb03f474f DIFF: https://github.com/llvm/llvm-project/commit/5e953a274b2ada5bfa54b3d765e391abb03f474f.diff

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb226cdf4cf9: [objc] diagnose protocol conformance in categories with direct members (authored by arphaman). Repository: rG LLVM Github Monorepo

[PATCH] D92355: [clang] add a `swift_async_name` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGeddd1d192bca: [clang] add a `swift_async_name` attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D92355?vs=309582&id=309690#toc Repository: rG LLVM Github Monorepo

[PATCH] D92354: [clang] add a new `swift_attr` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG03dcd57ecf99: [clang] add a new `swift_attr` attribute (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm

[clang] db226cd - [objc] diagnose protocol conformance in categories with direct members

Author: Alex Lorenz Date: 2020-12-04T15:55:34-08:00 New Revision: db226cdf4cf91f350267da1a5b95dda42dd23413 URL: https://github.com/llvm/llvm-project/commit/db226cdf4cf91f350267da1a5b95dda42dd23413 DIFF: https://github.com/llvm/llvm-project/commit/db226cdf4cf91f350267da1a5b95dda42dd23413.diff L

[clang] eddd1d1 - [clang] add a `swift_async_name` attribute

Author: Alex Lorenz Date: 2020-12-04T15:55:29-08:00 New Revision: eddd1d192bcaf11e449b34a3a569b85eb390e4f2 URL: https://github.com/llvm/llvm-project/commit/eddd1d192bcaf11e449b34a3a569b85eb390e4f2 DIFF: https://github.com/llvm/llvm-project/commit/eddd1d192bcaf11e449b34a3a569b85eb390e4f2.diff L

[clang] 03dcd57 - [clang] add a new `swift_attr` attribute

Author: Alex Lorenz Date: 2020-12-04T15:53:24-08:00 New Revision: 03dcd57ecf99b31021644b868cae422897d520f8 URL: https://github.com/llvm/llvm-project/commit/03dcd57ecf99b31021644b868cae422897d520f8 DIFF: https://github.com/llvm/llvm-project/commit/03dcd57ecf99b31021644b868cae422897d520f8.diff L

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added a comment. LGTM Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; nickdesaulniers wrote: > lebedev.ri wrote: > > jdoerfert wrote:

[PATCH] D92704: [clangd] Publish config file errors over LSP

sammccall updated this revision to Diff 309688. sammccall added a comment. Handle diagnostics without a filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92704/new/ https://reviews.llvm.org/D92704 Files: clang-tools-extra/clangd/ClangdServe

[PATCH] D92704: [clangd] Publish config file errors over LSP

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We don't act as a language server for these files (e.g. don't get ope

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers added a comment. Sorry, I should not have waiting this long to update this patch... Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline";

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 309682. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebased, s/Inline/Inlining/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:235-239 + for (const auto &Opt : Options) { +std::string Val = HNOption.General.lookup(Opt.first); +if (Val.empty()) + HNOption.General.insert({Opt.first,

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D92699: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Add a `FileEntryRef` overload of `SourceManager::translateFile`, and migrate `ParseD

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[clang] d126943 - Index: Remove unused internal header SimpleFormatContext.h, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T15:10:27-08:00 New Revision: d126943251d0cd77e572bced5ab6c23595acd468 URL: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595acd468 DIFF: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595ac

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay added inline comments. Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:4-5 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2 +// RUN: %clangxx_asan

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay updated this revision to Diff 309675. MaskRay marked 6 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Pre-committed test improvement in 190b4374c00a9cf090ea73f9eddf3d8f71b11ec8

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

rengolin added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, craig.topper wrote: > bruno wrot

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

This revision was automatically updated to reflect the committed changes. Closed by commit rG6333871f8540: Add diagnostic for for-range-declaration being specificed with thread_local (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 6333871 - Add diagnostic for for-range-declaration being specificed with thread_local

Author: shafik Date: 2020-12-04T15:06:35-08:00 New Revision: 6333871f85403d07abc62fdb6182f288ff60ccd8 URL: https://github.com/llvm/llvm-project/commit/6333871f85403d07abc62fdb6182f288ff60ccd8 DIFF: https://github.com/llvm/llvm-project/commit/6333871f85403d07abc62fdb6182f288ff60ccd8.diff LOG: A

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + hoy wrote: > lxfind wrote: > > hoy wrote: > > > hoy

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Just a minor comment but LGTM overall. Comment at: llvm/test/CodeGen/PowerPC/paired-vector-intrinsics.ll:15 + +; This test is to check that the paired vector intrinsics

[clang] b4f4fc6 - ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:45:59-08:00 New Revision: b4f4fc6872fbe4e296d3270d297a0e4afbda6670 URL: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda6670 DIFF: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f4fc6872fb: ASTImporter: Migrate to the FileEntryRef overload of SourceManager… (authored by dexonsmith). Repository: rG LLVM Github Monorepo C

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

amyk added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1427 + if (Target.getTriple().isPPC64() && + Target.hasFeature("paired-vector-memops")) { +if (Target.hasFeature("mma")) { Is it better to do `hasFeature()` over `PairedVectorMemops` a

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D92597: ARCMigrate: Initialize fields in EditEntry inline, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae0a46f2bbf: ARCMigrate: Initialize fields in EditEntry inline, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92597/new/ http

[clang] 9ae0a46 - ARCMigrate: Initialize fields in EditEntry inline, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:43:22-08:00 New Revision: 9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f URL: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f DIFF: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[clang] 1b023f5 - Frontend: Use translateLineCol instead of translateFileLineCol, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:37:48-08:00 New Revision: 1b023f54b61737552242868bdfc385487f1c3e74 URL: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c3e74 DIFF: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Map

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309661. njames93 added a comment. Update bugprone-not-null-terminated-result incorrect option name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files: clang-tools

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 removed a subscriber: Charusso. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctionsAvailable`` is set to ``Yes``, `

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

scott.linder added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 marked 6 inline comments as done and 2 inline comments as done. njames93 added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: dblaikie wrote: > A

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

bruno added a reviewer: bruno. bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 ___ cfe-commits

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, bruno wrote: > Looks like th

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

bruno added a reviewer: bruno. bruno added inline comments. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocName<"M68k">; def m_mips_Features_Group : OptionGroup<"">, Look

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22 +// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side. +// CHECK-NOT: {{-dwarf-version=[^2]}} // CHECK: "-triple" "x86_64 -

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434766 , @MaskRay wrote: > In D92633#2434714 , @tmsriram wrote: > >> Correct me if I am wrong, but I do see that this behavior is touched. Line >> 10 in -fdirect-access-externa

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Charusso added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctionsAvailable`` is set to ``Yes``, ``y`` or non-zero and it is + ``AreSafeFu

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434714 , @tmsriram wrote: > Correct me if I am wrong, but I do see that this behavior is touched. Line > 10 in -fdirect-access-external-data.c : > > // RUN: %clang -### -c -target aarch64 %s -fpic -fdirect-access-exter

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd764ad72e5fe: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs. (authored by ABataev). Repository: rG LLVM Github Monorepo

[clang] d764ad7 - [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

Author: Alexey Bataev Date: 2020-12-04T13:08:54-08:00 New Revision: d764ad72e5fe7ae1cd9b345ad72f4447355a11b2 URL: https://github.com/llvm/llvm-project/commit/d764ad72e5fe7ae1cd9b345ad72f4447355a11b2 DIFF: https://github.com/llvm/llvm-project/commit/d764ad72e5fe7ae1cd9b345ad72f4447355a11b2.diff

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + lxfind wrote: > hoy wrote: > > hoy wrote: > > > With t

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} abidh wrote: > jroelofs wrote: > > Small string has an implicit conversion to std::string, so you can just > > `return SysRoot

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + return std::string(SysRootDir); +} did `return SysRootDir;` not work? Why do you need the explicit std::string ctor call? CHANGES SINCE LAST ACTION https://reviews

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} jroelofs wrote: > Small string has an implicit conversion to std::string, so you can just

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh updated this revision to Diff 309637. abidh added a comment. Handled review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https://reviews.llvm.org/D92677 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib/Driver/ToolChains/BareMetal.h clang/test

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram added a comment. In D92633#2434511 , @MaskRay wrote: > In D92633#2434337 , @tmsriram wrote: > >> In D92633#2434267 , @MaskRay wrote: >> >>> In D92633#2434231

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D92671#2434154 , @shafik wrote: > The problem with this approach is given: > > for (static thread_local int a : A()) {} > > it

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added a comment. The compilationdatabase changes won't be landed as part of this patch, they've been sent separately for review. I can try the git gymnastics to get them out of this patch, but if you don't mind ignoring them that's easier :-) There might be a sensible way to split thi

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

scott.linder added inline comments. Comment at: clang/test/Driver/debug-options.c:364-366 +// GEMBED_2: warning: debug information option '-gembed-source' is not supported for target // NOGEMBED_5-NOT: "-gembed-source" +// NOGEMBED_2-NOT: warning: debug information option '-

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92439/new/ https://reviews.llvm.org/D92439 ___ cfe-commits mailing list cfe-commits

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194 + static std::unique_ptr + loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg); + usaxena95 wrote: >

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92682/new/ https://reviews.llvm.org/D92682

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall updated this revision to Diff 309630. sammccall marked an inline comment as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92640/new/ https://reviews.llvm.org/D92640 Files: clang/

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: jfb, guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. The variables used in atomic construct should be captured in outer tas

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12752 Error = 4; break; } Incidentally, why is this case here to begin with? Loop variables can totally be `register`. (But I guess it's moot at this point; clearly no Clang

[PATCH] D92646: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG650e04e179c9: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92671: Add diagnostic for for-range-declaration being specificed with thread_local

Quuxplusone added a comment. Spoilsport. ;) LGTM, fwiw. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92671/new/ https://reviews.llvm.org/D92671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] 650e04e - [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

Author: Sam McCall Date: 2020-12-04T21:54:55+01:00 New Revision: 650e04e179c9d355cd6d8f9a108d60c7969d24ca URL: https://github.com/llvm/llvm-project/commit/650e04e179c9d355cd6d8f9a108d60c7969d24ca DIFF: https://github.com/llvm/llvm-project/commit/650e04e179c9d355cd6d8f9a108d60c7969d24ca.diff LO

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 __

[PATCH] D92355: [clang] add a `swift_async_name` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list

[PATCH] D92355: [clang] add a `swift_async_name` attribute

doug.gregor accepted this revision. doug.gregor added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92680: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, JDevlieghere, arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Use `FileManager::getVirtualFileRef` to get the virtual file for stdin, and add an o

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:105 + + if (!llvm::sys::fs::exists(SysRootDir)) +return std::string(); Why not always add

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd10f9863a5ac: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC (authored by dexonsmith). Repository: rG LLVM Github Monore

[clang] d10f986 - ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-04T12:34:49-08:00 New Revision: d10f9863a5ac1cb681af07719650c44b48f289ce URL: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f289ce DIFF: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f2

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 309618. ychen added a comment. - fix rebase error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cl

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

dblaikie added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: Are there many uses that rely on this? I don't think it's really worth all this infrastruct

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276 + // Never ignore these. +} else if (!Context.isCheckEnabled(Error.D

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added subscribers: scott.linder, JDevlieghere. dblaikie added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22 +// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side. +// CHECK-NOT: {{-dw

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I think there's still some more work to be done after this which might move some of this around: - DocumentSymbol support: Currently categories show up as (anonymous) or (see here

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for this cleanup! Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafeFunctions

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434337 , @tmsriram wrote: > In D92633#2434267 , @MaskRay wrote: > >> In D92633#2434231 , @tmsriram wrote: >> >>> Sorry just one more thing

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added inline comments. Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:4-5 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2 +// RUN: %clangxx_a

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman updated this revision to Diff 309611. dgoldman added a comment. - Rebase + refactor, sorry for the long delay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover

[clang] 88c21f8 - [clang-format] NFC update in the overall clang-formatted status

Author: mydeveloperday Date: 2020-12-04T20:10:10Z New Revision: 88c21f8488646b6809d46c197077cfb40b5ac15b URL: https://github.com/llvm/llvm-project/commit/88c21f8488646b6809d46c197077cfb40b5ac15b DIFF: https://github.com/llvm/llvm-project/commit/88c21f8488646b6809d46c197077cfb40b5ac15b.diff LOG

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309605. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files: clang-tools-extra/docs/clang-tidy/checks/bugprone-argument-

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 marked 3 inline comments as done. njames93 added a subscriber: Charusso. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60 - If copy to the destination array can overflow [1] and - ``AreSafe

  1   2   3   >