Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

oh, fair - I didn't stop to notice this was over in Clang/non-llvm-namespace'd code, so yeah, sounds good! On Mon, Dec 21, 2020 at 10:49 PM Sam McCall wrote: > Yeah. I don't actually know those details, the phab revision referenced > (should have been a URL, oops) is all I know. > > The new vers

[PATCH] D93452: [clangd] Trim memory periodically

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8c37153d539: [clangd] Trim memory periodically when using glibc malloc (authored by qchateau, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang-tools-extra] b8c3715 - [clangd] Trim memory periodically when using glibc malloc

Author: Quentin Chateau Date: 2020-12-22T08:54:28+01:00 New Revision: b8c37153d5393aad96feefe0b4689b7b62bc160d URL: https://github.com/llvm/llvm-project/commit/b8c37153d5393aad96feefe0b4689b7b62bc160d DIFF: https://github.com/llvm/llvm-project/commit/b8c37153d5393aad96feefe0b4689b7b62bc160d.dif

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

pcc added inline comments. Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76 +#endif + return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag; +} xiangzhangllvm wrote: > Hello @pcc I think here seems some problem, the ptr is user passing point, > *(pt

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

xiangzhangllvm added inline comments. Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76 +#endif + return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag; +} Hello @pcc I think here seems some problem, the ptr is user passing point, *(ptr + n) should h

[PATCH] D93452: [clangd] Trim memory periodically

sammccall accepted this revision. sammccall added a comment. In D93452#2467046 , @qchateau wrote: > I did not use the CMke option as the default value for the command line > option: IMO this CMake option is only useful if you encounter build problems > r

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

Yeah. I don't actually know those details, the phab revision referenced (should have been a URL, oops) is all I know. The new version with the qualifier is better than the old one in any case though, so no need to ever remove it. (At least, we try to always spell the llvm qualifiers in clangd) O

Re: [clang] 638867a - DR2064: decltype(E) is only a dependent type if E is type-dependent, not

I've bisected https://crbug.com/1161059 down to this change. Would you like a reduced repro? clang++: /b/s/w/ir/cache/builder/src/third_party/llvm/clang/lib/AST/ItaniumMangle.cpp:5763: void {anonymous}::CXXNameMangler::addSubstitution(uintptr_t): Assertion `!Substitutions.count(Ptr) && "Substitutio

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. > There are 792 files in llvm/test, most of which are in test/Transform (119) > and test/CodeGen(655). > The transition will be swiftly done (if there's no other issue hopefully) by > the next weekend. Thinking about these again, do we need to make a poison copy for test

[clang] dbb0153 - scan-view: Remove Reporter.py and associated AppleScript files

Author: Tom Stellard Date: 2020-12-21T19:24:35-08:00 New Revision: dbb01536f6f49fa428f170e34466072ef439b3e9 URL: https://github.com/llvm/llvm-project/commit/dbb01536f6f49fa428f170e34466072ef439b3e9 DIFF: https://github.com/llvm/llvm-project/commit/dbb01536f6f49fa428f170e34466072ef439b3e9.diff

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb01536f6f4: scan-view: Remove Reporter.py and associated AppleScript files (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

Would be handy to include a comment to document which compiler version, etc - so we know when we can remove this/don't waste time trying to remove it too soon. On Thu, Dec 17, 2020 at 3:51 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Date: 2020-12-17

[PATCH] D92806: Single function compilation mode.

hoy updated this revision to Diff 313221. hoy added a comment. Herald added subscribers: cfe-commits, dexonsmith, dang, steven_wu, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added a project: clang. Adding LTO, linker and clang suppor

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

nemanjai added a comment. Seems that conversion diagnostic test cases are completely missing. Comment at: clang/include/clang/Basic/TargetInfo.h:680 + /// Return the mangled code of __ibm128. + virtual const char *getIbm128Mangling() const { return "g"; } + T

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 313218. kuzkry retitled this revision from "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option" to "[clang-format][PR47290] Add ShortNamespaceLines format option". kuzkry added a comment. Renamed MaxUnwrappedLinesForShortNamespace to

[PATCH] D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef

njames93 added inline comments. Comment at: clang/include/clang/Format/Format.h:2946-2951 +/// Like above but accepts an unnamed buffer. +inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, + bool AllowUnknownOp

[PATCH] D93452: [clangd] Trim memory periodically

qchateau updated this revision to Diff 313215. qchateau marked 3 inline comments as done. qchateau added a comment. The log is back, I renamed the CMake option and the command line option and reduced the number of preprocessor directives. I chose not to modify the files for the `gn` build system,

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rnk. leonardchan added a project: clang. Herald added subscribers: dexonsmith, dang. leonardchan requested review of this revision. This is a more concentrated version of D85802 whi

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313211. hliao added a comment. Herald added a subscriber: mgorny. Fix the cmake to distribute that header wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files:

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bbb04a732cd: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables (authored by MaskRay). Repository: rG LLVM Github Mon

[clang] 6bbb04a - [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2020-12-21T15:32:35-08:00 New Revision: 6bbb04a732cdf203282f93b95d5a89cfc6fed8f4 URL: https://github.com/llvm/llvm-project/commit/6bbb04a732cdf203282f93b95d5a89cfc6fed8f4 DIFF: https://github.com/llvm/llvm-project/commit/6bbb04a732cdf203282f93b95d5a89cfc6fed8f4.diff

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay updated this revision to Diff 313208. MaskRay edited the summary of this revision. MaskRay added a comment. Improve BE test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 Files: clang/docs/Releas

[PATCH] D93596: [ASTMatchers] Traverse-ignore range-for implementation details

steveire updated this revision to Diff 313205. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93596/new/ https://reviews.llvm.org/D93596 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/lib/ASTMatchers

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/ppc-features.cpp:45 +// PPC64: "-munwind-tables" +// PPC64-SAME: "-mfloat-abi" "hard" Curious - how come no ch

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313199. hliao added a comment. These functions are pure C functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/lib/Headers/__clang_hip_runtime_wrappe

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2463 +**MaxUnwrappedLinesForShortNamespace** (``unsigned``) + The maximal number of unwrapped lines that a short namespace spans. HazardyKnusperkeks wrote: > curdeius wrote: > >

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441164 , @glaubitz wrote: > In D52050#2441141 , @jrtc27 wrote: > >> What gets done currently for i386? That suffers potentially the same problem >> given both /usr/lib/gcc/x86_6

[PATCH] D93648: Revert "[AMDGPU][HIP] Switch default DWARF version to 5"

This revision was automatically updated to reflect the committed changes. Closed by commit rGffba47df7646: Revert "[AMDGPU][HIP] Switch default DWARF version to 5" (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93648/new/

[clang] ffba47d - Revert "[AMDGPU][HIP] Switch default DWARF version to 5"

Author: Scott Linder Date: 2020-12-21T21:43:51Z New Revision: ffba47df76460905965df4b54cf6ba945d2eb1ce URL: https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce DIFF: https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce.diff LOG:

[PATCH] D93648: Revert "[AMDGPU][HIP] Switch default DWARF version to 5"

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93648/new/ https://reviews.llvm.org/D93648 ___ cfe

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis added a comment. In D85788#2449299 , @aqjune wrote: > In D85788#2444136 , @guiand wrote: > >> IMO it's better to just one-and-done programatically add `-Xclang >> -disable-noundef-analysis` to all the tests

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313187. hoy marked an inline comment as done. hoy added a comment. Addressing feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: clang/lib/CodeGen/BackendU

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy marked 2 inline comments as done. hoy added inline comments. Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:881 +void DISubprogram::replaceRawLinkageName(MDString *LinkageName) { + replaceOperandWith(3, LinkageName); +} tmsriram wrote: > Nit, Move the body to

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Uhm, yeah, indeed. Let's remove it, thanks! I doubt people even use scan-view at this point (but i'd rather keep it) (scan-build is definitely used). Comment at: clang/tools/scan

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

tmsriram added inline comments. Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:881 +void DISubprogram::replaceRawLinkageName(MDString *LinkageName) { + replaceOperandWith(3, LinkageName); +} Nit, Move the body to DebugInfoMetadata.h itself? Co

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This looks like an improvement, so LGTM, but I have a couple of comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:160-161 -namespace { -template stru

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

HazardyKnusperkeks added a comment. So, I've tested a bit: //= Die ID //~ foo bar //~ EinWort Ein langer Text der fortgesetzt wird //: Dies ist ein langer Kommentar //: der umgebrochen wird tr("Foo"); Results in Foo Dies ist ein langer Kommentar der umgebrochen

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

rengolin added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2089 + static const char *const M68kTriples[] = { + "m68k-linux-gnu", "m68k-unknown-linux-gnu", "m68k-suse-linux"}; + jrtc27 wrote: > rengolin wrote: > > The front-end supports

[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:338 +const std::vector &Values) { + for (const std::string& Value : V

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2466689 , @tmsriram wrote: > https://reviews.llvm.org/D73307#1932131 rnk@ mentioned this : "At a higher > level, should this just be an IR pass that clang adds into the pipeline when > the flag is set? It should be safe t

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:27 +static cl::opt UniqueDebugAndProfileNames( +"unqiue-debug-profile-names", cl::init(false), cl::Hidden, +cl::desc("Uniqueify debug and profile symbol Names")); -

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

tmsriram added a comment. https://reviews.llvm.org/D73307#1932131 rnk@ mentioned this : "At a higher level, should this just be an IR pass that clang adds into the pipeline when the flag is set? It should be safe to rename internal functions and give private functions internal linkage. It wou

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a minor nit. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4722 bool isI64 = Ty->isIntegerType() && getContext().getTypeSize(Ty) == 64; - bool isInt = - Ty->isIntegerType() || Ty->isPointerType()

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 313174. ffrankies added a comment. - Addressed comments from @njames93 - Rebased with latest master branch to make sure there are no merge issues with the latest committed altera check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ http

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

tmsriram added a comment. I too was currently working on changing the raw linkage names, DW_AT_linkage_name, and was about to send out a patch along these lines :). Thanks for doing this! I will take a look at it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. `UniqueInternalLinkageNamesPass` is useful to CSSPGO, especially when pseudo probe is

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

MaskRay added a comment. Should this have some tests? Even if guarded by `REQUIRES:` if some feature is needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 _

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman added a comment. In D84924#2465745 , @njames93 wrote: > In D84924#2446075 , @aaron.ballman > wrote: > >> In D84924#2184132 , @njames93 wrote: >> >>> This is ve

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

jdoerfert resigned from this revision. jdoerfert added a comment. In D93638#2466333 , @hliao wrote: > In D93638#2466097 , @jdoerfert wrote: > >>> The device compilation should not relies on the host STL implementati

[PATCH] D93596: [ASTMatchers] Traverse-ignore range-for implementation details

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93596/new/ https://reviews.llvm.org/D93596 __

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa2d37eb3f8: [clangd][NFC] Improve clangd status messages (authored by qchateau, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9354

[clang-tools-extra] 3fa2d37 - [clangd][NFC] Improve clangd status messages

Author: Quentin Chateau Date: 2020-12-21T20:19:25+01:00 New Revision: 3fa2d37eb3f8acddcfde749ca822f2cc7d900cbb URL: https://github.com/llvm/llvm-project/commit/3fa2d37eb3f8acddcfde749ca822f2cc7d900cbb DIFF: https://github.com/llvm/llvm-project/commit/3fa2d37eb3f8acddcfde749ca822f2cc7d900cbb.dif

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

sammccall added a comment. It's up to you - it's easy for me/others to land them on your behalf. Having your own commit access gives you more control, ability to deal with build breakages quickly, fix trivial things without review etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

sammccall added a comment. I've put a version of the reading part in D93653 . This seems a bit less invasive to me - I'm still not sure if it's worth the readability hit though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D93653: [clangd] Avoid reallocating buffers for each message read:

sammccall created this revision. sammccall added a reviewer: njames93. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - reuse std::string we read mes

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

qchateau added a comment. Sure ! Email: quentin.chat...@gmail.com I guess I'll need to ask for commit access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93546/new/ https://reviews.llvm.org/D93546 ___

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["enable", "disable", "numeric", "assume_safety", "full"], - ["Enable", "Disable",

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this version seems just as clear as the original to me, and fewer allocations is nice :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LG - want me to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93546/new/ https://reviews.llvm.org/D93546 ___

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

sammccall added a comment. Thanks, this looks like a good idea to me, but some quibbles with the details: - for any string, we statically know whether it's path or WD-relative - we should make sure all the IO gets cached Comment at: clang-tools-extra/clangd/QueryDriverDatabase

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 313145. MoritzS added a comment. Rebased onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/include/clang/Analysis/PathDiagnostic.h Index: cla

[PATCH] D93452: [clangd] Trim memory periodically

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome! Some nits on naming and stuff, but the only real substantial question for me is the exact availability/behavior of the command-line flag. Even there, as long as the default beha

[clang] bb8d20d - [cuda][hip] Fix typoes in header wrappers.

Author: Michael Liao Date: 2020-12-21T13:02:47-05:00 New Revision: bb8d20d9f3bb955ae6f6143d24749faf61d573a9 URL: https://github.com/llvm/llvm-project/commit/bb8d20d9f3bb955ae6f6143d24749faf61d573a9 DIFF: https://github.com/llvm/llvm-project/commit/bb8d20d9f3bb955ae6f6143d24749faf61d573a9.diff

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added a comment. In D93638#2466097 , @jdoerfert wrote: > Disclaimer: I request changes because of the next sentence, other than that I > have no objection but also cannot review this. > All `cuda_wrapper` headers say something about complex in the f

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313138. hliao added a comment. Fix license. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h clang/lib/Headers/c

[PATCH] D93648: Revert "[AMDGPU][HIP] Switch default DWARF version to 5"

scott.linder created this revision. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. scott.linder requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This reverts commit c4d10e7e9bb47b77fad43d

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313136. hliao added a comment. Fix typo again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h clang/lib/Header

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2466284 , @aqjune wrote: > The transition will be swiftly done (if there's no other issue hopefully) by > the next weekend. Oops, I meant this weekend hopefully. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2464841 , @spatel wrote: > Besides changing IRBuilder and shufflevector's definition, I think we'll also > need updates in the vectorizers, InstSimplify, and other places in > InstCombine that use UndefValue for InsertEl

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

aaron.ballman added a comment. In D92006#2466114 , @DavidSpickett wrote: > The last update didn't update the expected errors. I have done so in > 9a93f95fce91fb4616cee0f307b564b253789282 >

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Hi, community. I kindly ask you to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-com

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

DavidSpickett added a comment. The last update didn't update the expected errors. I have done so in 9a93f95fce91fb4616cee0f307b564b253789282 and it's now passing. (I think it missed the bots since they don't build examples)

[clang] 9a93f95 - [clang] Fix expected errors in plugin attribute example

Author: David Spickett Date: 2020-12-21T16:47:23Z New Revision: 9a93f95fce91fb4616cee0f307b564b253789282 URL: https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282 DIFF: https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282.diff LOG

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Disclaimer: I request changes because of the next sentence, other than that I have no objection but also cannot review this. All `cuda_wrapper` headers say something about compl

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["enable", "disable", "numeric", "assume_safety", "full"], - ["Enable", "Disable", "Num

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1322-1323 + TranslationState = translationState; + if (Kind == tok::wide_string_literal) +TranslationState = TranslateToSystemCharset; + else if (isUTFLiteral(Kind)) ---

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313116. hliao added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h clang/lib/Headers/cuda

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added a comment. Beyond the enabling of the compilation with `` on Windows, I really have the concern on the current approach supporting `` compilation in the device compilation. The device compilation should not relies on the host STL implementation. That results in inconsistent compilat

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov updated this revision to Diff 313114. ASDenysPetrov added a comment. @steakhal I've precisely inspected your reports and find the bug. I've fixed it. I also verified all the rest and find some other vulnerabilities and fixed them as well. Thank you for your testing, and I would as

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 11 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for str

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 313112. abhina.sreeskantharajan added a comment. Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch: - add translation for UCN strings, update testcase - fix helptext for fexec-charse

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:205 +/// Collect the macro definitions provided by the given preprocessor +/// options into the parser options. +void collectMacroDefinitions( --

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao created this revision. hliao added reviewers: tra, yaxunl. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - MSVC has different `` implementation which calls into functions declared in ``. Instead of through builtins or inline

[PATCH] D93637: [libTooling] Add support for smart pointers to releveant Transformer `Stencil`s.

ymandel created this revision. ymandel added reviewers: tdl-g, sbenza. ymandel requested review of this revision. Herald added a project: clang. Stencils `maybeDeref` and `maybeAddressOf` are designed to handle nodes that may be pointers. Currently, they only handle native pointers. This patch ext

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228 + // Note: GCC drops anything following an end-of-line character. + llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r"

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2463068 , @MyDeveloperDay wrote: > Maybe @JVApen can help as they logged > https://bugs.llvm.org/show_bug.cgi?id=48539 > > I'm not a Qt developer so I can't really comment beyond fixing what was in > the bug rpeort We

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman updated this revision to Diff 313108. FarisRehman edited the summary of this revision. FarisRehman added a comment. Address review comments Address comments with the following changes: - Add a dedicated method to adding preprocessing options in Flang.cpp - Change preprocessorOpts to

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1976 + tok::kw_co_yield, tok::equal, tok::kw_delete, + tok::kw_sizeof, tok::kw_throw) || PrevToken->isOneOf(TT_BinaryOperator, TT

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:55 + +MATCHER_P2(ContainsN, InnerMatcher, N, + describeContainsN(InnerMatcher, N, negation)) { I'm not sure where custom Google Test matchers go. I guess

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows us to verify that we don't emit options multiple times. In most cases, that w

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. Ping 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2463 +**MaxUnwrappedLinesForShortNamespace** (``unsigned``) + The maximal number of unwrapped lines that a short namespace spans. curdeius wrote: > MyDeveloperDay wrot

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsandifo-arm added a comment. Thanks for the reviews. In D77056#2463959 , @rsmith wrote: > That said, I'm concerned that the design of this feature will severely limit > its utility. For classes and enums, operators are typically defined in an > associa

[PATCH] D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef

njames93 created this revision. njames93 added reviewers: MyDeveloperDay, fodinabor, JakeMerdichAMD. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This overload should be used for better diagnostics when parsing configurations. N

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:539 + if (V->isNullValue() && !DestTy->isX86_MMXTy() && !DestTy->isX86_AMXTy() + && opc != Instruction::AddrSpaceCast) return Constant::getNullValue(DestTy); Operation should at th

[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This infrastructure can be used ~30 mor

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

aaron.ballman closed this revision. aaron.ballman added a comment. In D92006#2465239 , @psionic12 wrote: > Hi, could anyone help to commit this? I'm happy to do so, sorry about not asking earlier. I've commit on your behalf in b2ba6867eac10874bd279c73963

[clang] b2ba686 - Refactoring the attribute plugin example to fit the new API

Author: Yafei Liu Date: 2020-12-21T08:24:09-05:00 New Revision: b2ba6867eac10874bd279c739639bdb9e60c1996 URL: https://github.com/llvm/llvm-project/commit/b2ba6867eac10874bd279c739639bdb9e60c1996 DIFF: https://github.com/llvm/llvm-project/commit/b2ba6867eac10874bd279c739639bdb9e60c1996.diff LOG

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko created this revision. Herald added a subscriber: jdoerfert. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this commit, expression statements could not be annotated with statement attributes. Whenever parser

[PATCH] D93543: clang-tidy: Leave the possibility of opting out having coloured diagnostic messages.

njames93 added a comment. Would it be wise to use `os.isatty(sys.stdout.fileno())` as the value if left unspecified. As we capture stdout from clang-tidy, clang-tidy assumes we aren't connected to a terminal and thus disables colours, unless explicitly enabled. Therefore if our python script is

  1   2   >