[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 317157. nathawes edited the summary of this revision. nathawes added a comment. Moved the change combining OverlayFSDirIterImpl and VFSFromYamlDirIterImpl in a single implementation into a separate NFC patch (https://reviews.llvm.org/D94857) CHANGES SINCE

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

rjmccall added a comment. Hmm. The way you'd test it on the Clang side would be to just write a test case that passes such an aggregate and tests that it's passed as an `i8`. But I'm not sure it's at all unreasonable to pass this as an `i1` rather than an `i8`; seems like something that Swift

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe68c9222b85: [NFC] Add -std=c11 to attr-availability.c (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.o

[clang] be68c92 - [NFC] Add -std=c11 to attr-availability.c

Author: Douglas Yung Date: 2021-01-15T21:05:49-08:00 New Revision: be68c9222b85815612e6bd8bc606a87e3111a0fb URL: https://github.com/llvm/llvm-project/commit/be68c9222b85815612e6bd8bc606a87e3111a0fb DIFF: https://github.com/llvm/llvm-project/commit/be68c9222b85815612e6bd8bc606a87e3111a0fb.diff

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94808/new/ https://reviews.llvm.org/D94808 ___ cfe-commits mailin

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 ___ cfe-commits mailin

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple added a comment. I don't know how to test this on the LLVM-side (is there a way to do it?). Here's the Swift side test which trips over right now (but is fixed with this patch) by attempting a zext from an i8 to an i1 in Swift's `NativeConventionSchema::mapIntoNative`. +++

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple created this revision. varungandhi-apple added reviewers: aschwaighofer, rjmccall. Herald added a subscriber: jfb. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes rdar://72999296. Repository: rG

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8049dc3c8a4: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as… (authored by mtrofin). Repository: rG LLVM Github Monorep

[clang] e8049dc - [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

Author: Mircea Trofin Date: 2021-01-15T17:59:38-08:00 New Revision: e8049dc3c8a46ccd75ce2a4f438d695d20feb660 URL: https://github.com/llvm/llvm-project/commit/e8049dc3c8a46ccd75ce2a4f438d695d20feb660 DIFF: https://github.com/llvm/llvm-project/commit/e8049dc3c8a46ccd75ce2a4f438d695d20feb660.diff

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

pcc added a comment. This causes us to reject the following (reduced from AOSP): int sprintf(char* __s, const char* __fmt, ...) __attribute__((__format__(printf, 2, 3))) ; int sprintf(char* dest, const char* format) __attribute__((overloadable)) __attribute__((enable_if(((__

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin updated this revision to Diff 317133. mtrofin added a comment. Herald added subscribers: wenlei, steven_wu. updated with all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94825/new/ https://reviews.llvm.org/D94825 Files: clang/test

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan added a comment. In D91466#2395297 , @pcc wrote: > How does Zircon handle tagged addresses in syscalls? Are they handled > equivalently to Linux's tagged address ABI? Woops, accidentally let this slide. I'm guessing you saw this in the Fuchsi

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 317118. leonardchan added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. Locally I'm able to build and run the `bringup.arm64` config (that is launch the shell and run some commands). Repository: rG LL

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a reviewer: dexonsmith. dexonsmith added a comment. In D94844#2502725 , @nathawes wrote: > Yeah, certainly. Let me put that up separately and update this diff. Thanks! (Optionally, you can link them using the "edit related revisions" fea

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes planned changes to this revision. nathawes added a comment. Yeah, certainly. Let me put that up separately and update this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94844/new/ https://reviews.llvm.org/D94844

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a comment. > This patch also refactors OverlayFileSystem's directory iterator > implementation (OverlayFSDirIterImpl) and VFSFromYamlDirIterImpl into a > single implementation, addressing a FIXME about their conceptual similarity. Can the `OverlayFSDirIterImpl` part be split in

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

MaskRay updated this revision to Diff 317112. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94735/new/ https://reviews.llvm.org/D94735 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/X86/x86_64-arg

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit = Loc.isValid() ? getOrCreateFile(Loc) : nullptr; + const unsigned Line = getLineNumber(Loc); MaskRa

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit = Loc.isValid() ? getOrCreateFile(Loc) : nullptr; + const unsigned Line = getLineNumber(Loc); dblaiki

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes created this revision. nathawes added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. nathawes requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously file entries in the -ivfsoverlay

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

justice_adams added a comment. @dyung I don't have commit access, would you mind commiting this for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.org/D94829 ___ cfe-c

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin marked 2 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always == -

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +Manda

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin marked 2 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always == -

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks added a comment. overall looks good, just a couple small comments Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always == -

[PATCH] D94825: [NewPM]i[Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin updated this revision to Diff 317085. mtrofin added a comment. patched tests other than Other/ ones. We want to rationalize emitting remarks, see also D94334 ; I'd prefer first landing the always inlining refactoring, because that would impact the remark

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

kuhar added a comment. Wow, this is fantastic. When I first started working on the domtree updater back in 2017, SimplifyGFG seemed like one of the most difficult passes to handle, and I wasn't sure if we ever get there. Very impressive work, @lebedev.ri! Repository: rG LLVM Github Monorepo

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks added a comment. In D93986#2495561 , @MyDeveloperDay wrote: > I think I would remove the code examples from the "AlignConsecutive style" to > avoid confusion (that would be the first change) > > then perhaps regenerate and update the d

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks added a comment. *ping* And I don't have a better name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 ___ cfe-commits mailing list cfe-commit

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.org/D94829 ___ cfe

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Couple of optional pieces. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3340 + const SourceLocation Loc = RD->getLocation(); + llvm::DIFile *DefUnit = Loc.isValid

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

justice_adams created this revision. justice_adams added reviewers: nigelp-xmos, aaron.ballman. justice_adams added a project: clang. justice_adams requested review of this revision. This test will fail with any toolchains that don't default to C11. Adding this switch to the clang invocation in t

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

lebedev.ri created this revision. lebedev.ri added reviewers: fhahn, jdoerfert, arsenm, mkazantsev, kuhar, brzycki, nikic. lebedev.ri added projects: LLVM, AMDGPU. Herald added subscribers: wenlei, kerbowa, steven_wu, hiraditya, nhaehnle, jvesely. lebedev.ri requested review of this revision. Her

[PATCH] D94825: [NewPM]i[Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

mtrofin created this revision. mtrofin added a reviewer: aeubanks. Herald added subscribers: hiraditya, eraman. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Expanding from D94808

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} Is it possible to check that we imported four fold expr

[clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Author: Christopher Di Bella Date: 2021-01-15T21:38:47Z New Revision: 4a47da2cf440c2f2006d9b04acfef4292de1e263 URL: https://github.com/llvm/llvm-project/commit/4a47da2cf440c2f2006d9b04acfef4292de1e263 DIFF: https://github.com/llvm/llvm-project/commit/4a47da2cf440c2f2006d9b04acfef4292de1e263.dif

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl added a comment. In D85223#2452363 , @JonChesterfield wrote: > I concede that making the variables external, and trying to give them unique > names, does work around static variables not working. I believe static > variables are subjected to more

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. A concern I have is that the round-tripping might be too low level since it requires each group of options to opt-in somehow. Having something at the top-level that doesn't have to be touched again would be easier to validate / understand, and might better serve the

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek created this revision. phosek added reviewers: davidxl, vsk, gulfem. Herald added subscribers: dexonsmith, wenlei, dang, jdoerfert, steven_wu, hiraditya, mgorny. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits

[clang] a1be47b - [CodeView][DebugInfo] Add test case to show that linkage names are not

Author: Amy Huang Date: 2021-01-15T12:05:33-08:00 New Revision: a1be47b4771467998d7549dcd1b9f9cebdaa9af9 URL: https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9 DIFF: https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9.diff LOG

[PATCH] D94814: [HIP] Support `__managed__` attribute

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: dexonsmith, jdoerfert, hiraditya, mgorny. Herald added a reviewer: aaron.ballman. yaxunl requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This patch implem

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 updated this revision to Diff 317038. jhuber6 added a comment. Fixed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94806/new/ https://reviews.llvm.org/D94806 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_m

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. I started trying to work on a patch, but I'm still unpacking from a move and don't have all my machines set up - trying to enable and build tests filled up my hard drive (even after I removed the easy-to-remove stuff), so I don't think I'm going to be able to create

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 317027. tomrittervg added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-ex

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:661 FunctionAnalysisManager &FAM, Module &M) { + if (Mandatory) { +OwnedAdvisor = std::make_unique(FAM); mtrofin wrote: > This should move to line 675: i

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

mtrofin added a comment. I think InlineAdvisor::getAdvice needs to take a bool MandatoryOnly, which Inliner then passes. This allows us to then use the same advisor for both the always case and the policy-driven inliner instances, which allows that advisor to correctly book-keep any module wide

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2501312 , @njames93 wrote: > My only question is does this try and index lambdas, under the hood they are > declared as a CXXRecordDecl, defined in function scope? I would not expect that to happen as it is an anonymo

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317015. usaxena95 added a comment. Added tests for not indexing lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-tools-extra/clangd/index/FileI

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94806/new/ https://reviews.llvm.org/D94806 ___

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks added a comment. Wondering if this makes sense to you (before I go and finish cleaning up all the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94808/new/ https://reviews.llvm.org/D94808 ___

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks created this revision. Herald added subscribers: hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94808 Files: clang/t

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. The custom mapper AP

[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Hmm, that would still require us to keep a list of options we've converted. It's better than hard-coding it like this patch does, but I'd like it to be more automatic. I've updated D94472 with

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:363 const FunctionSamples *CalleeSamples; uint64_t CallsiteCount; + // Call site distribution factor to p

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1839 +OptName = Dash + OptTable.getOptionName(OPT_stdlib_EQ); +Args.emplace_back(SA(OptName + "libc++")); + } I plan to move the prefixing of the option name and se

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check only runs in debug mode during serialization, but assert()-fail on: struct S { const int& x = 7; }; in C++ m

[PATCH] D94472: [clang][cli] Manually generate header search arguments

jansvoboda11 updated this revision to Diff 317003. jansvoboda11 added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add (improved) round-trip mechanism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472

[PATCH] D94803: [clang][cli] Generate HeaderSearch options separately

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94803 Files: clang/lib

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6227069bdce6: [DebugInfo][CodeView] Change in line tables only mode to emit type information (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D94639?vs=316779&id=317001#toc Repo

[clang] 6227069 - [DebugInfo][CodeView] Change in line tables only mode to emit type information

Author: Amy Huang Date: 2021-01-15T09:28:27-08:00 New Revision: 6227069bdce6b0c3c22f0a0c8f1aef705985125a URL: https://github.com/llvm/llvm-project/commit/6227069bdce6b0c3c22f0a0c8f1aef705985125a DIFF: https://github.com/llvm/llvm-project/commit/6227069bdce6b0c3c22f0a0c8f1aef705985125a.diff LOG

[PATCH] D94802: [clang][cli] Parse HeaderSearch options separately

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[clang] bc84f89 - [OpenCL][Docs] Fixed cross-section reference in OpenCLSupport

Author: Anastasia Stulova Date: 2021-01-15T17:20:13Z New Revision: bc84f89c71ab62d510973f64f022bee31e53af96 URL: https://github.com/llvm/llvm-project/commit/bc84f89c71ab62d510973f64f022bee31e53af96 DIFF: https://github.com/llvm/llvm-project/commit/bc84f89c71ab62d510973f64f022bee31e53af96.diff

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5047d762f39: [clangd] Update CC Ranking model with better sampling. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang-tools-extra] d5047d7 - [clangd] Update CC Ranking model with better sampling.

Author: Utkarsh Saxena Date: 2021-01-15T18:13:24+01:00 New Revision: d5047d762f391c94939d67fc84cae25b24125694 URL: https://github.com/llvm/llvm-project/commit/d5047d762f391c94939d67fc84cae25b24125694 DIFF: https://github.com/llvm/llvm-project/commit/d5047d762f391c94939d67fc84cae25b24125694.diff

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added a reviewer: martong. balazske added a comment. Herald added a subscriber: rnkovacs. There is a related bug report: https://bugs.llvm.org/show_bug.cgi?id=48004 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.l

[PATCH] D94787: [clang][AST] Add get functions for CXXFoldExpr paren locations.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94787 Files: clang

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

njames93 added a comment. Thank you for taking the time to fix this and the performance measurements to boot. My only question is does this try and index lambdas, under the hood they are declared as a CXXRecordDecl, defined in function scope? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposi

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

usaxena95 updated this revision to Diff 316969. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94697/new/ https://reviews.llvm.org/D94697 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-ext

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Previously we did not record local class declarations. Now with features like fi

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

pengfei added a comment. > This doesn't add metadata to llvm intrinsics that are not constrained. Oh, right. I misunderstood what's doing in these patches and thought we can add metadata to any intrinsics by CGFPOptionsRAII now. :-) > If a relevant #pragma is used then without this change the m

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1744f4c67641: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members (authored by jansvoboda11). Repository: rG LLVM Github Monor

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcd3aeb0fb: [clang][cli] NFC: Parse some LangOpts after the defaults are set (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG383262933045: [clang][cli] NFC: Add PIE parsing for precompiled input and IR (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94679/

[clang] 1744f4c - [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: 1744f4c676411ebd2e38afd5a6b56e5dd533c6ac URL: https://github.com/llvm/llvm-project/commit/1744f4c676411ebd2e38afd5a6b56e5dd533c6ac DIFF: https://github.com/llvm/llvm-project/commit/1744f4c676411ebd2e38afd5a6b56e5dd533c6ac.diff L

[clang] a7dcd3a - [clang][cli] NFC: Parse some LangOpts after the defaults are set

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa URL: https://github.com/llvm/llvm-project/commit/a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa DIFF: https://github.com/llvm/llvm-project/commit/a7dcd3aeb0fb58ad774bc89428ed6c925f31f8aa.diff L

[clang] 3832629 - [clang][cli] NFC: Add PIE parsing for precompiled input and IR

Author: Jan Svoboda Date: 2021-01-15T16:41:34+01:00 New Revision: 383262933045e1c138362105be4ee4d1b62ab4cc URL: https://github.com/llvm/llvm-project/commit/383262933045e1c138362105be4ee4d1b62ab4cc DIFF: https://github.com/llvm/llvm-project/commit/383262933045e1c138362105be4ee4d1b62ab4cc.diff L

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:102 + +// CHECK-NEXT: ![[LOOP7]] = distinct !{![[LOOP7]], [[MP]], [[GEN8]], [[GEN11:![0-9]+]], [[GEN3]]} +// CHECK-NEXT: [[GEN11]] = !{!"llvm.loop.vectorize.width", i32 4}

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:102 + +// CHECK-NEXT: ![[LOOP7]] = distinct !{![[LOOP7]], [[MP]], [[GEN8]], [[GEN11:![0-9]+]], [[GEN3]]} +// CHECK-NEXT: [[GEN11]] = !{!"llvm.loop.vectorize.width", i32 4} ---

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316945. tbaeder added a comment. Sorry about the last change, that was the wrong patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/c

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316944. Herald added a subscriber: martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/S

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ created this revision. Herald added a subscriber: rogfer01. malharJ requested review of this revision. Herald added subscribers: cfe-commits, vkmr. Herald added a project: clang. This ensures that the Clang loop pragma vectorize_predicate([enable|disable]) is ignored when vectorize_width(

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG791634b999e3: [clang][cli] Parse & generate options necessary for LangOptions defaults… (authored by jansvoboda11). Changed prior to commit: https

[clang] 791634b - [clang][cli] Parse & generate options necessary for LangOptions defaults manually

Author: Jan Svoboda Date: 2021-01-15T15:38:43+01:00 New Revision: 791634b999e33e029aeeda91eeb5fae13757dcdc URL: https://github.com/llvm/llvm-project/commit/791634b999e33e029aeeda91eeb5fae13757dcdc DIFF: https://github.com/llvm/llvm-project/commit/791634b999e33e029aeeda91eeb5fae13757dcdc.diff L

[clang] d1862a1 - [OpenCL][Docs] Fixed malformed table in OpenCLSupport

Author: Anastasia Stulova Date: 2021-01-15T14:27:26Z New Revision: d1862a16310379179a40b309a9721318ae7e3254 URL: https://github.com/llvm/llvm-project/commit/d1862a16310379179a40b309a9721318ae7e3254 DIFF: https://github.com/llvm/llvm-project/commit/d1862a16310379179a40b309a9721318ae7e3254.diff

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added a comment. This patch contains very useful improvements to the design along with the behavioral fixes. I see that it opens more opportunities to bring the implementation in line with the conventional flow and therefore simplify the further development of new functionality. More

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2500829 , @lebedev.ri wrote: > Tests missing I mistakenly missed that file in the last commit. I'll add it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri added a comment. Tests missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77c3d1d18cd: [clangd] Set correct CWD when using compile_flags.txt (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94699/new/ https://r

[clang-tools-extra] c77c3d1 - [clangd] Set correct CWD when using compile_flags.txt

Author: Adam Czachorowski Date: 2021-01-15T14:26:24+01:00 New Revision: c77c3d1d18cdd58989f9d35bbf6c31f5fda0a125 URL: https://github.com/llvm/llvm-project/commit/c77c3d1d18cdd58989f9d35bbf6c31f5fda0a125 DIFF: https://github.com/llvm/llvm-project/commit/c77c3d1d18cdd58989f9d35bbf6c31f5fda0a125.d

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. Thanks for this, I think it's looking more promising! I'd still like to see some test coverage for the changes so long as it doesn't turn into a slog. Tests like `clang\test\AST\ast-dump-color.cpp` show roughly how it's done in the frontend. If it turns out that t

[PATCH] D94719: [clangd] Make ExpandAutoType not available on template params.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeaeb9e6bdc9: [clangd] Make ExpandAutoType not available on template params. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94719/new/

[clang-tools-extra] aeaeb9e - [clangd] Make ExpandAutoType not available on template params.

Author: Adam Czachorowski Date: 2021-01-15T14:19:05+01:00 New Revision: aeaeb9e6bdc90d9c4b839ac0e4edc6255021cced URL: https://github.com/llvm/llvm-project/commit/aeaeb9e6bdc90d9c4b839ac0e4edc6255021cced DIFF: https://github.com/llvm/llvm-project/commit/aeaeb9e6bdc90d9c4b839ac0e4edc6255021cced.d

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Quality.cpp:349 + }; + DeriveASTSignals(); // Declarations are scoped, others (like macros) are assumed global. Maybe it's just me, but using a lambda like this seems quite confusing. I don't

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the `auto` usage. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5346 +AST_POLYMORPHIC_SUPPORTED_TYPES(BinaryOperator, CXXOperato

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 316908. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Add include-module test Update the regression test to check the behaviour of -I with an INCLUDE line in the source code. Also add a regression test to check the behaviour

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:38 +!- +! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST +!

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor NFC improvements. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:957 + + void getArgKinds(ASTNodeKind ThisKind, unsigned Ar

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1994 + return None; +return FD->getNumParams() > 0 ? UO_PostInc : UO_PreInc; +

  1   2   >