[PATCH] D95714: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons

poelmanc updated this revision to Diff 320286. poelmanc added a comment. Fix test failure in `modernize-use-nullptr-cxx20.cpp` by replacing `#include ` with some minimal equivalent `std` code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714 Fil

[PATCH] D95726: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons - hasGrandparent version

poelmanc added a comment. Fix test failure in `modernize-use-nullptr-cxx20.cpp` by replacing `#include ` with some minimal equivalent `std` code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95726/new/ https://reviews.llvm.org/D95726 ___ cf

[PATCH] D95726: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons - hasGrandparent version

poelmanc added a comment. Fixed test failure in `modernize-use-nullptr-cxx20.cpp` by replacing `#include ` with some minimal equivalent `std` code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95726/new/ https://reviews.llvm.org/D95726 ___

[PATCH] D95726: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons - hasGrandparent version

poelmanc updated this revision to Diff 320284. poelmanc added a comment. Fix test failure in `modernize-use-nullptr-cxx20.cpp` by replacing `#include ` with some minimal equivalent `std` code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95726/new/ https://reviews.llvm.org/D95726 Fil

[PATCH] D95726: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons - hasGrandparent version

poelmanc created this revision. poelmanc added reviewers: aaron.ballman, angelgarcia, hokein. poelmanc added a project: clang-tools-extra. Herald added a subscriber: yaxunl. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As in htt

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4297 + ? S.Context.getQualifiedType(T1, T1Quals.withoutAddressSpace()) + : cv1T1; // Not reference-related. Create a temporary and bind to that. Should we be rejecting th

[PATCH] D95725: clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

poelmanc created this revision. poelmanc added reviewers: sammccall, ilya-biryukov. poelmanc added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D95714: clang-tidy: modernize-use-nullptr mistakenly fixes rewritten spaceship operator comparisons

poelmanc created this revision. poelmanc added reviewers: aaron.ballman, angelgarcia, hokein. poelmanc added a project: clang-tools-extra. Herald added a subscriber: yaxunl. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `clang-ti

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320257. nathawes marked an inline comment as done. nathawes edited the summary of this revision. nathawes set the repository for this revision to rG LLVM Github Monorepo. nathawes added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-c

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mtrofin updated this revision to Diff 320256. mtrofin added a comment. indent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 Files: clang/test/Driver/amdgpu-macros.cl clang/test/Driver/cuda-detect.cu

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

MaskRay added inline comments. Comment at: clang/test/Driver/rocm-device-libs.cl:82 // RUN: %s \ -// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,COMMON-UNSAFE,GFX803,WAVE64 %s +// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,GFX803,WAVE64 %s mtrofin wr

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mtrofin added inline comments. Comment at: clang/test/Driver/rocm-device-libs.cl:82 // RUN: %s \ -// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,COMMON-UNSAFE,GFX803,WAVE64 %s +// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,GFX803,WAVE64 %s MaskRay wr

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mtrofin updated this revision to Diff 320246. mtrofin marked an inline comment as done. mtrofin added a comment. cleaned up the RUN line for rocm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 Files: cla

[PATCH] D95706: [clangd] Expose more dependent-name detail via semanticTokens

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This change makes dependentName a

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. My apologies for misrepresenting the meaning of the docs and stirring up this confusion. I did not read the docs carefully enough. Replying on the mailing list ... Comment at: clang/CMakeLists.txt:1 cmake_minimum_required(VERSION 3.13.4) -

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem marked an inline comment as done. gulfem added a comment. In D94355#2530225 , @lebedev.ri wrote: > Can you please add an explanation to the patch's description as to why > we don't want to instead convert non-relative/relative LUT's elsewhere, > ple

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. I'm picking up this change again after D83154 landed. I did some tracing and it looks like `FileManager` already returns a relative path when relative path was passed to the compiler as you'd expect so I don't think we need to change any

[PATCH] D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95704/new/ https://reviews.llvm.org/D95704 _

[PATCH] D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: aprantl. varungandhi-apple requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. swifttailcc is a new calling convention in LLVM introduced in https://

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG282aca10aeb0: [RISCV] Update the version number to v0.10 for vector. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D9

[clang] 282aca1 - [RISCV] Update the version number to v0.10 for vector.

Author: Hsiangkai Wang Date: 2021-01-30T07:20:05+08:00 New Revision: 282aca10aeb03bdaef0a8d4f3faa4c2ff236e527 URL: https://github.com/llvm/llvm-project/commit/282aca10aeb03bdaef0a8d4f3faa4c2ff236e527 DIFF: https://github.com/llvm/llvm-project/commit/282aca10aeb03bdaef0a8d4f3faa4c2ff236e527.diff

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere added a comment. Thanks for brining this up on the mailing list, I think that's a good place to discuss! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

HsiangKai added a comment. In D95680#2530775 , @asb wrote: > LGTM modulo one additional request: please update the comment at the top of > RISCVInstrInfoV.td to say "0.10" rather than "0.9". Thanks for pointing it out. I will do it. Repository: rG LL

[PATCH] D95702: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, cebowleratibm. ZarkoCA added a project: PowerPC. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Opening this revision to better address comments by @hu

[PATCH] D95701: [clangd] Add semanticTokens modifiers for function/class/file/global scope

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. These allow (function-) local var

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall updated this revision to Diff 320218. sammccall added a comment. Add tests for 'abstract' and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77811/new/ https://reviews.llvm.org/D77811 Files: clang-tools-extra/clangd/ClangdLSPSe

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. @rsmith I did my bet to address your comments. What do you think of current state? Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); + serge-

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

tskeith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1018 + an USE statement. The default is the current directory.}]>,Group; +def module_dir : Separate<["-"], "module-dir">, Flags<[FlangOption,FC1Option]>, MetaVarName<"">, Alias; def dsym_dir : J

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 320212. serge-sans-paille added a comment. Extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier updated this revision to Diff 320204. fcloutier added a comment. Updating the diff using arcanist, which I'm told produces better results. Sorry for the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95695/new/ https://reviews.llvm

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic updated this revision to Diff 320199. rsanthir.quic marked an inline comment as done. rsanthir.quic added a comment. Corrected register ordering for sm4e and removed redundant argument in sm3ss1 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic marked 2 inline comments as done. rsanthir.quic added a comment. Thank you for taking a look at this @labrinea ! Comment at: llvm/test/CodeGen/AArch64/neon-sm4-sm3.ll:77 +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:sm4e v1.4s, v0.4s +; CHECK-NEXT:mov

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks updated this revision to Diff 320196. HazardyKnusperkeks added a comment. The previous one broke a (format) test in polly. This lead me to change the one breaking behavior, no it is not breaking anymore. A comment starting with `}` will only be indented if it is in a comment se

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

This revision was automatically updated to reflect the committed changes. Closed by commit rG632545e8ce84: [clang-tidy] Fix linking tests to LLVMTestingSupport (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang-tools-extra] 632545e - [clang-tidy] Fix linking tests to LLVMTestingSupport

Author: Michał Górny Date: 2021-01-29T21:54:09+01:00 New Revision: 632545e8ce846ccaeca8df15a3dc5e36d01a1275 URL: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275 DIFF: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275.diff

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier created this revision. fcloutier added reviewers: jkorous, dcoughlin. fcloutier added a project: clang. Herald added a subscriber: Charusso. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. Since it gained a new

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

MaskRay added a comment. https://lists.llvm.org/pipermail/llvm-dev/2021-January/148229.html "Python version requirement" for the version discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2530791 , @thakis wrote: > Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 > . > Someone should file a PR to make sure that gets merged to

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. @JDevlieghere I personally have no skin in this game. This is actually quite an obnoxious development for me since my linux machine is stuck on an old version and Python 3.5 is the newest version in the repos. I sent a message to llvm-dev so hopefully this will get has

[PATCH] D95694: [clang][RelativeVTablesABI] Place non-local vtables in comdat groups

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. Herald added a subscriber: pengfei. leonardchan requested review of this revision. Currently, it's possible for vtables that fit precisely in a mergable constants group to not be

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D95635#2529027 , @ctetreau wrote: > In D95635#2528851 , @JDevlieghere > wrote: > >>> However, t

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320188. arnamoy10 added a comment. Added test for the driver-help, also contains all the changes that was done in the previous diff (Aliasing `-J` and `-module-dir`, changing data structures etc). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D954

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added inline comments. BRANCHES main /clang/lib/Driver/ToolChains/Clang.cpp:4672-4678 This seems to be saying that `-maltivec` rather actively implies `-mabi=vec-default` (on AIX) even in cases where `-maltivec` really makes no difference. I suggest just removing this.

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320184. arnamoy10 added a comment. Addressing reviewers' comments with the following changes: 1. Aliasing of -module-dir and -J to avoid code duplication 2. Moving the code to set the module and search directories from `FrontendActions.cpp` to `CompilerInv

[clang] 0703b07 - [CMake] Actually require python 3.6 or greater

Author: Christopher Tetreault Date: 2021-01-29T11:47:21-08:00 New Revision: 0703b0753c40dad30f1683403f6600bd2cb42055 URL: https://github.com/llvm/llvm-project/commit/0703b0753c40dad30f1683403f6600bd2cb42055 DIFF: https://github.com/llvm/llvm-project/commit/0703b0753c40dad30f1683403f6600bd2cb420

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0703b0753c40: [CMake] Actually require python 3.6 or greater (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added subscribers: ZarkoCA, hubert.reinterpretcast, cfe-commits. BRANCHES main Users: ZarkoCA (Author) https://reviews.llvm.org/rGcaaaebcde462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight. aaron.ballman requested review of this revision. https://wg21.link/P2173 is making its way through WG21 currently and has not been formally adopted yet. This feature provides very useful functionality

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. https://bugs.llvm.org/show_bug.cgi?id=48668 already exists as a bug report linked to this review. I'm not sure "the Zeek project would like to start using this" is a good enough reason to block an LLVM release though. I'm fairly certain there aren't a whole lot of people

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

dyung added a comment. PS4 changes lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] caaaebc - [AIX] Actually push back "-mabi=vec-extabi" when option is on.

Author: Zarko Todorovski Date: 2021-01-29T14:12:46-05:00 New Revision: caaaebcde462bf681498ce85c2659d683a07fc87 URL: https://github.com/llvm/llvm-project/commit/caaaebcde462bf681498ce85c2659d683a07fc87 DIFF: https://github.com/llvm/llvm-project/commit/caaaebcde462bf681498ce85c2659d683a07fc87.di

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

MaskRay added inline comments. Comment at: clang/test/Driver/rocm-device-libs.cl:82 // RUN: %s \ -// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,COMMON-UNSAFE,GFX803,WAVE64 %s +// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,GFX803,WAVE64 %s Since you

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0217f1c7a31b: Make the profile-filter.c test compatible with 32-bit systems (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 0217f1c - Make the profile-filter.c test compatible with 32-bit systems

Author: Petr Hosek Date: 2021-01-29T09:58:32-08:00 New Revision: 0217f1c7a31ba44715bc083a60cddc2192ffed96 URL: https://github.com/llvm/llvm-project/commit/0217f1c7a31ba44715bc083a60cddc2192ffed96 DIFF: https://github.com/llvm/llvm-project/commit/0217f1c7a31ba44715bc083a60cddc2192ffed96.diff LO

[clang] c5e7e64 - [AArch64][Clang][Linux] Enable out-of-line atomics by default.

Author: Pavel Iliin Date: 2021-01-29T17:44:45Z New Revision: c5e7e649d537067dec7111f3de1430d0fc8a4d11 URL: https://github.com/llvm/llvm-project/commit/c5e7e649d537067dec7111f3de1430d0fc8a4d11 DIFF: https://github.com/llvm/llvm-project/commit/c5e7e649d537067dec7111f3de1430d0fc8a4d11.diff LOG: [

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e7e649d537: [AArch64][Clang][Linux] Enable out-of-line atomics by default. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

tskeith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4133 def fconvert_EQ : Joined<["-"], "fconvert=">, Group; -def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group; +def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-len

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags) { jansvoboda11 wrote: > dexonsmith wrote: >

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman updated this revision to Diff 320145. FarisRehman added a comment. Remove -fno-fixed-form and -fno-free-form Remove options `-fno-fixed-form` and `-fno-free-form` allowing for help messages to be added to `-ffixed-form` and `-ffree-form`. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Alternatively, there's `LinkerIsLLD` in the driver code, maybe the driver wants to check that in some way (if only to emit a better diag if it's false, I guess) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/ https

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

erichkeane added a comment. For target-specific builtins I ended up implementing this: https://github.com/llvm/llvm-project/commit/81a73fde5cea304d31294fd26c2f051f1685e97c at one point to make sure that 'host' builtins get looked up in the aux-target if necessary. Repository: rG LLVM Github

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 . Someone should file a PR to make sure that gets merged to the 12.0 branch. We can then reland on trunk once there are clear instructions for f

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

yaxunl added a comment. I tried this patch with our CI and it breaks HIP and OpenMP. I suspect it may also break CUDA. It seems in device compilation, when a host function calls a builtin with long double argument, the builtin is not found. My guess is that the target for checking builtin needs

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320142. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChai

[clang] 1608ba0 - Revert "Disable rosegment for old Android versions."

Author: Nico Weber Date: 2021-01-29T11:20:48-05:00 New Revision: 1608ba09462d877111230e9461b895f696f8fcb1 URL: https://github.com/llvm/llvm-project/commit/1608ba09462d877111230e9461b895f696f8fcb1 DIFF: https://github.com/llvm/llvm-project/commit/1608ba09462d877111230e9461b895f696f8fcb1.diff LO

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

frasercrmck accepted this revision. frasercrmck added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://reviews.llvm.org/D95680 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

asb accepted this revision. asb added a comment. LGTM modulo one additional request: please update the comment at the top of RISCVInstrInfoV.td to say "0.10" rather than "0.9". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://revie

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. This breaks us too: https://bugs.chromium.org/p/chromium/issues/detail?id=1172291 Given that this breaks at least 3 distinct build configs, let's revert this for now until we've figured out a path forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith added inline comments. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] jansvoboda11 wrote: > Where is the empty remark co

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:684-685 + if (!GeneratedStringsEqual) +llvm::report_fatal_error("Mismatch between arguments generated during " + "round-trip"); + jansvoboda11

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

yaxunl added a comment. LGTM for amdgpu changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D95575: clang-cl: Accept /std:c11, /std:c17 flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGd087d805acb6: clang-cl: Accept /std:c11, /std:c17 flags (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[clang] d087d80 - clang-cl: Accept /std:c11, /std:c17 flags

Author: Nico Weber Date: 2021-01-29T09:59:00-05:00 New Revision: d087d805acb664e885e9c31a916f6cfa5dbc2186 URL: https://github.com/llvm/llvm-project/commit/d087d805acb664e885e9c31a916f6cfa5dbc2186 DIFF: https://github.com/llvm/llvm-project/commit/d087d805acb664e885e9c31a916f6cfa5dbc2186.diff LO

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

erichkeane added a comment. Can you show any tests where this builtin would be a part of the aux-triple, and not in active code? So an nvptx triple, x86_64 aux-triple, and in non-device code? (such as in a CUDA app)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

This revision was automatically updated to reflect the committed changes. Closed by commit rG82847436e925: clang-cl: Invent a /winsysroot concept (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95534?vs=319949&id=320126#toc Repository:

[clang] 8284743 - clang-cl: Invent a /winsysroot concept

Author: Nico Weber Date: 2021-01-29T09:47:00-05:00 New Revision: 82847436e9258a12503dcfadb5dc373cb42fea43 URL: https://github.com/llvm/llvm-project/commit/82847436e9258a12503dcfadb5dc373cb42fea43 DIFF: https://github.com/llvm/llvm-project/commit/82847436e9258a12503dcfadb5dc373cb42fea43.diff LO

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/atlmfc/include" hans wrote: > could the

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM too. One nit inlined that can be addressed before committing. Comment at: clang/test/Driver/aarch64-features.c:47 +// CHECK-OUTLINE-ATOMICS-ON: "-ta

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. \o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://reviews.llvm.org/D95680 ___ cf

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, evandro. Herald added subscribers: vkmr, NickHung, jdoerfert, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edwar

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320123. ilinpv added a comment. Tests for "-m[no]outline-atomics" options added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/Tool

[clang-tools-extra] 7d1b499 - Revert "[clangd] Extract symbol-scope logic out of Quality, add tests. NFC"

Author: Sam McCall Date: 2021-01-29T14:59:16+01:00 New Revision: 7d1b499caef6ebde09a2697a97b43b89f7fa35c8 URL: https://github.com/llvm/llvm-project/commit/7d1b499caef6ebde09a2697a97b43b89f7fa35c8 DIFF: https://github.com/llvm/llvm-project/commit/7d1b499caef6ebde09a2697a97b43b89f7fa35c8.diff LO

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

njames93 added a comment. In D95653#2530163 , @mgorny wrote: > In D95653#2529776 , @njames93 wrote: > >> I think I introduced this failure due to my abysmal In D95653#2530163

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

jansvoboda11 updated this revision to Diff 320119. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: cl

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags, dexonsmith wrote: > Can we n

[clang-tools-extra] d0817b5 - [clangd] Extract symbol-scope logic out of Quality, add tests. NFC

Author: Sam McCall Date: 2021-01-29T14:44:28+01:00 New Revision: d0817b5f18c7bb435012d214f293d4a7839e492e URL: https://github.com/llvm/llvm-project/commit/d0817b5f18c7bb435012d214f293d4a7839e492e DIFF: https://github.com/llvm/llvm-project/commit/d0817b5f18c7bb435012d214f293d4a7839e492e.diff LO

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags) { dexonsmith wrote: > Can you rename this

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

jansvoboda11 updated this revision to Diff 320118. jansvoboda11 added a comment. Rebase, inline lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95369/new/ https://reviews.llvm.org/D95369 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:584-589 +static bool Equal(const ArgStringList &A, const ArgStringList &B) { + auto StrEq = [](const char *AElem, const char *BElem) { +return StringRef(AElem) == StringRef(BElem); + }

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

curdeius added a comment. I don't think it can go into 12.x. But if you have a good reason and a related bug report you might add this bug ticket as a release blocker of https://llvm.org/PR48902. BTW, would you mind updating clang/docs/ReleaseNotes.rst? Repository: rG LLVM Github Monorepo

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 320115. jansvoboda11 added a comment. Improve error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

labrinea added inline comments. Comment at: llvm/test/CodeGen/AArch64/neon-sm4-sm3.ll:24 + +define <4 x i32> @test_vsm3ss1(<4 x i32> %a, <4 x i32> %b, <4 x i32> %c, <4 x i32> %d) { +; CHECK-LABEL: test_vsm3ss1: The forth argument (<4 x i32> %d) is redundant. =

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe90e455d2a0c: [Syntax] Add syntax-tree-dump in clang-check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e90e455 - [Syntax] Add syntax-tree-dump in clang-check.

Author: Haojian Wu Date: 2021-01-29T14:10:27+01:00 New Revision: e90e455d2a0cc6e04b930a43355c3551e2c6f0e0 URL: https://github.com/llvm/llvm-project/commit/e90e455d2a0cc6e04b930a43355c3551e2c6f0e0 DIFF: https://github.com/llvm/llvm-project/commit/e90e455d2a0cc6e04b930a43355c3551e2c6f0e0.diff LO

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

hokein updated this revision to Diff 320112. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95526/new/ https://reviews.llvm.org/D95526 Files: clang/test/Tooling/cla

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95653/new/ https://reviews.llvm.org/D95653 ___ cfe-commits mailing list c

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. @FarisRehman, thank you for addressing my comments! I've just realised that `gfortran` doesn't actually support `-fno-fixed-form` or `-fno-free-form`: $ gfortran -ffixed-form -fno-fixed-form test.f gfortran: error: unrecognized command line option ‘-fno-fixed-form

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); rsmit

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42a21778f61c: [test] Use host platform specific error message substitution in lit tests (authored by abhina.sreeskantharajan). Repository: rG LLVM

[clang] 42a2177 - [test] Use host platform specific error message substitution in lit tests

Author: Abhina Sreeskantharajan Date: 2021-01-29T07:16:30-05:00 New Revision: 42a21778f61cdc8462ce2cfb6ad7bc1992b2063c URL: https://github.com/llvm/llvm-project/commit/42a21778f61cdc8462ce2cfb6ad7bc1992b2063c DIFF: https://github.com/llvm/llvm-project/commit/42a21778f61cdc8462ce2cfb6ad7bc1992b2

  1   2   >