SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land.
Thanks, LGTM too. One nit inlined that can be addressed before committing. ================ Comment at: clang/test/Driver/aarch64-features.c:47 +// CHECK-OUTLINE-ATOMICS-ON: "-target-feature" "+outline-atomics" +// CHECK-OUTLINE-ATOMICS-OFF-NOT: "-target-feature" "+outline-atomics" ---------------- Probably better to just check for the OFF case: "-target-feature" "-outline-atomics" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
