[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333657. alexreinking added a comment. Uses write_basic_package_version_file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

jdoerfert added a comment. In D99432#2653483 , @ABataev wrote: > In D99432#2653474 , @jdoerfert wrote: > >> Can we please always do the globalization, even in the `target teams >> distribute parallel for` case you

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

jdoerfert accepted this revision. jdoerfert added a subscriber: tra. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, @tra might have input on the cuda change but it seems reasonable and we can do that post commit. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. > I am guessing this will only be supported by 1 target in clang? Then target > address spaces make sense otherwise you can also extend the language address > space enum. Are you also planning to add `__flashN`? >

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. In D99426#2653869 , @abhina.sreeskantharajan wrote: > In D99426#2653725 , @MaskRay wrote: > >> This touches a lot of files. I am a bit worried that it would not be easy >> for a

[PATCH] D99445: [OPENMP]Fix PR49052: Clang crashed when compiling target code with assert(0).

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99445/new/ https://reviews.llvm.org/D99445

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + steveire wrote: > Did you consider using `write_basic_package_version_file` instead of adding > these files? Ah, sorry, I see

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Herald added a subscriber: dcaballe. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + Did you consider using `write_basic_package_version_file` instead of adding these files?

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > >> On SystemZ we need

[PATCH] D99445: [OPENMP]Fix PR49052: Clang crashed when compiling target code with assert(0).

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to insert a basic block during generation of the target region to

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

rsmith added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", oToToT wrote: > yaxunl wrote: > > I am not sure if this test tests the code you change since

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. This touches a lot of files. I am a bit worried that it would not be easy for a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > On SystemZ we need to open text files in text mode, Why can't it be served without CRLF translation? Repository:

[PATCH] D98554: Save strings for CC_PRINT env vars

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e0cc45ced23: [SystemZ][z/OS] Save strings for CC_PRINT env vars (authored by SeanP, committed by muiez). Changed prior to commit: https://reviews.llvm.org/D98554?vs=332836=333625#toc Repository: rG

[clang] 7e0cc45 - [SystemZ][z/OS] Save strings for CC_PRINT env vars

Author: Sean Perry Date: 2021-03-26T16:38:36-04:00 New Revision: 7e0cc45ced230b4ef3a9d8eaedfbe92e75f21916 URL: https://github.com/llvm/llvm-project/commit/7e0cc45ced230b4ef3a9d8eaedfbe92e75f21916 DIFF: https://github.com/llvm/llvm-project/commit/7e0cc45ced230b4ef3a9d8eaedfbe92e75f21916.diff

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

keryell added a comment. In D73967#2653250 , @erichkeane wrote: > >> It comes from an FPGA tool programmer who knows about HLS *and* modern C++, >> so probably a very rare specie. :-) >> The typical FPGA programmer and tool writer is often more

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a comment. In D99433#2653586 , @everton.constantino wrote: > @fhahn That was my first idea however its not as simple as it looks. I tried > moving the adds but splats make it considerably harder to find a pattern that > catches this and

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

jdoerfert added a comment. In D99433#2653528 , @everton.constantino wrote: > @jdoerfert Which tests do you have in mind? I added one for SEMA and one for > CodeGen. Tests for everything you placed in `llvm/`. Your tests are all in `clang/`.

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. We need to capture the local variables into a record in task untied

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2577172 , @benshi001 wrote: > In D96853#2577133 , @aykevl wrote: > >> I am not very familiar with Clang so I can't say much about it. Although I >> wonder whether a macro is

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino added a comment. @fhahn That was my first idea however its not as simple as it looks. I tried moving the adds but splats make it considerably harder to find a pattern that catches this and fuses the multiplies specially with bigger matrices. My real wish was to actually add

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a comment. Thanks for putting up the patch! Do you think it would be possible to get the desired behavior without a new builtin? We should be able to combine the add with the initial multiply for each vector, as long as we have the right fast-math flags? IIUC reassociate should be

[clang] 706c1dc - [OpenCL][Docs] Minor update about C++ for OpenCL in UsersManual.

Author: Anastasia Stulova Date: 2021-03-26T19:24:07Z New Revision: 706c1dc266d247232243b83a06a4904f527dc245 URL: https://github.com/llvm/llvm-project/commit/706c1dc266d247232243b83a06a4904f527dc245 DIFF: https://github.com/llvm/llvm-project/commit/706c1dc266d247232243b83a06a4904f527dc245.diff

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added a comment. @NoQ, what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I would like to hold off committing this for a day or two to see if there is any input from @azabaznov or anyone else. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino added a comment. @jdoerfert Which tests do you have in mind? I added one for SEMA and one for CodeGen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99433/new/ https://reviews.llvm.org/D99433

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2653454 , @bader wrote: >> Yesterday, we chatted offline and agreed that the main issue is missing >> documentation for Clang extensions being added for SYCL. To address this >> issue we are adding SYCL architecture

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

jdoerfert added a comment. [Drive by] LLVM test missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99433/new/ https://reviews.llvm.org/D99433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino created this revision. everton.constantino added reviewers: anemet, rjmccall, rsmith, Bigcheese, fhahn. Herald added subscribers: dexonsmith, tschuett, hiraditya. everton.constantino requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2653476 , @abhina.sreeskantharajan wrote: > In D99363#2653201 , @aganea wrote: > >> I'm just wondering if D96363 and all >> attached subsequent

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", yaxunl wrote: > I am not sure if this test tests the code you change since the mangled >

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc2c662d9c0: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8bc2c66 - [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

Author: Giorgis Georgakoudis Date: 2021-03-26T11:49:42-07:00 New Revision: 8bc2c662d9c0f241fb8538979f8db1af7f2e353e URL: https://github.com/llvm/llvm-project/commit/8bc2c662d9c0f241fb8538979f8db1af7f2e353e DIFF:

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2653474 , @jdoerfert wrote: > Can we please always do the globalization, even in the `target teams > distribute parallel for` case you need it if a thread shares the address of a > local variable with the team and

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2653201 , @aganea wrote: > I'm just wondering if D96363 and all > attached subsequent patches shouldn't be reverted for now. This is a quite > trivial case uncovered by

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

jdoerfert added a comment. Can we please always do the globalization, even in the `target teams distribute parallel for` case you need it if a thread shares the address of a local variable with the team and another thread uses it. There is no argument other than "doesn't escape" that Clang can

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to perform general analysis on SPMD kernels to correctly identify the

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. > Yesterday, we chatted offline and agreed that the main issue is missing > documentation for Clang extensions being added for SYCL. To address this > issue we are adding SYCL architecture design document, which we are going to > update along with adding new features.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2652459 , @bader wrote: > In D89909#2624284 , @aaron.ballman > wrote: > >> Based on the discussion so far, would these be acceptable steps to take? >> >> 0) Complete review on

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.md:857 +The main address space semantic difference of SYCL mode from OpenCL is that +SYCL doesn't assign OpenCL generic address space to a declaration's type without +explicit address space attribute. Similar

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

aaron.ballman added a comment. In D73967#2653042 , @keryell wrote: > An FPGA programmer is hitting this issue from your unit test: > > c++ > signed _ExtInt(1) m; // expected-error{{signed _ExtInt must have a bit > size of at least 2}} > > Why do

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, wenlei, okura, kuter, cmtice, martong, steven_wu, gbedwell, hiraditya, qcolombet, MatzeB. Herald added a reviewer: bollu. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb. Herald added a

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

ggeorgakoudis updated this revision to Diff 333584. ggeorgakoudis marked an inline comment as done. ggeorgakoudis added a comment. Update for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99415/new/ https://reviews.llvm.org/D99415 Files:

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet created this revision. kpet added a reviewer: Anastasia. kpet added a project: clang. Herald added subscribers: ldrumm, kristof.beyls, yaxunl. kpet requested review of this revision. Herald added a subscriber: cfe-commits. Ensure that the cl_khr_3d_image_writes pragma is enabled by making

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

thakis added a comment. Zombie comment time! I kind of don't love this change. clang's libBasic shouldn't depend on llvm/lib/IR: Practically there's no reason that building clang-format should build lib/IR and its deps, and more importantly semantically the dependency feels off too. The dep

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#2653246 , @keryell wrote: > In D73967#2653044 , @erichkeane > wrote: > >> In D73967#2653042 , @keryell wrote: >> >>> > > > >>> Why do

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

keryell added a comment. In D73967#2653044 , @erichkeane wrote: > In D73967#2653042 , @keryell wrote: > >> >> Why do you not allow a type able to represent `{-1, 0}`? > > Our FPGA team didn't see any value in

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added a comment. In D99250#2651953 , @probinson wrote: > In D99250#2651204 , @dblaikie wrote: > >> Does anyone else have a DWARFv3 consumer they care about? (@aprantl and >> @probinson) >> >> Does anyone

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Target/TargetOptions.h:112 +SCE, // Tune debug info for SCE targets (e.g. PS4). +DBX // Tune debug info for dbx. };

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added a comment. Thanks for your comments @dblaikie @probinson . Sent out a mail to llvm-dev for continuous discussion. https://lists.llvm.org/pipermail/llvm-dev/2021-March/149446.html Welcome your comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333581. bader added a comment. Add links to SYCL specification with address space behavior description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files:

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. I'm just wondering if D96363 and all attached subsequent patches shouldn't be reverted for now. This is quite trivial case uncovered by tests. On re-land, I would then add a test validating the issue on Windows: $ cat -A

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2652907 , @abhina.sreeskantharajan wrote: > In D99363#2652899 , @aganea wrote: > >> Sorry, but after this patch, I still see the issue mentioned in >>

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. fixes https://bugs.llvm.org/show_bug.cgi?id=31568 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 added a comment. fully fixes https://bugs.llvm.org/show_bug.cgi?id=39251 partially fixes https://bugs.llvm.org/show_bug.cgi?id=46140 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 ___

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than those typos Comment at: clang/include/clang/Basic/riscv_vector.td:161 + // This builtin supports non-masked function overloading api. + // All

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong updated this revision to Diff 333570. martong added a comment. - Rename test case name to something meaningful Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99421/new/ https://reviews.llvm.org/D99421 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unhandled-exception-at-new.cpp:143 + f_est_noexcept_dependent_used(); +} aaron.ballman wrote: > You have tests for placement new with `nothrow_t`, but I think other

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong created this revision. martong added reviewers: teemperor, shafik, balazske, steakhal. Herald added subscribers: whisperity, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. martong requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari added a comment. In D99360#2652523 , @jhenderson wrote: > It might make sense to do the llvm-readobj portions of this patch in a > separate review, since they are somewhat independent. I agree. I actually have them in two patches, but I

[PATCH] D93164: [AST] Add generator for source location introspection

mgorny added a comment. This change breaks cross-compilation now, as it tries running an executable built for the target system: FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json cd /home/mgorny/llvm-project/build.arm64/tools/clang/lib/Tooling &&

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#2653042 , @keryell wrote: > An FPGA programmer is hitting this issue from your unit test: > > c++ > signed _ExtInt(1) m; // expected-error{{signed _ExtInt must have a bit > size of at least 2}} > > Why do you

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

keryell added a comment. Herald added a subscriber: dexonsmith. An FPGA programmer is hitting this issue from your unit test: c++ signed _ExtInt(1) m; // expected-error{{signed _ExtInt must have a bit size of at least 2}} Why do you not allow a type able to represent `{-1, 0}`?

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

t.p.northover added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:641 + }); + if ((ItSHA2 != Features.rend()) || (ItSHA2 != Features.rend())) +Features.push_back("-crypto"); Both of these checks are identical. And could we get

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

yaxunl added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", I am not sure if this test tests the code you change since the mangled variable name does not

[PATCH] D99372: [OpenMP][NFC] Generate check lines with update script

jdoerfert added inline comments. Comment at: clang/test/OpenMP/cancel_codegen.cpp:83 +// OMP-LABEL: @main( +// OMP-NEXT: entry: +// OMP-NEXT:[[RETVAL:%.*]] = alloca i32, align 4 ABataev wrote: > I think it may fail in release mode, where no symbol names are

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e46f0b62830: [OpenCL] Fix AST check in address-space-templates test (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit:

[clang] 6e46f0b - [OpenCL] Fix AST check in address-space-templates test

Author: Anastasia Stulova Date: 2021-03-26T14:24:30Z New Revision: 6e46f0b628308ba39feb13872cb21166b857dfdb URL: https://github.com/llvm/llvm-project/commit/6e46f0b628308ba39feb13872cb21166b857dfdb DIFF: https://github.com/llvm/llvm-project/commit/6e46f0b628308ba39feb13872cb21166b857dfdb.diff

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Cool, thanks. LGTM, two nits. Comment at: llvm/utils/UpdateTestChecks/common.py:532 + and _prefix_filecheck_ir_name: + var = _prefix_filecheck_ir_name + var

[clang] 6f91cf7 - [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target

Author: Fanbo Meng Date: 2021-03-26T10:10:33-04:00 New Revision: 6f91cf75d7f55c7beadeebeac7c1010a2e7c6553 URL: https://github.com/llvm/llvm-project/commit/6f91cf75d7f55c7beadeebeac7c1010a2e7c6553 DIFF: https://github.com/llvm/llvm-project/commit/6f91cf75d7f55c7beadeebeac7c1010a2e7c6553.diff

[PATCH] D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f91cf75d7f5: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98514: [RGT] Fix ASTMatchersTest so all assertions are executed

probinson abandoned this revision. probinson added a comment. Problem has gone away, test assertions are now executed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98514/new/ https://reviews.llvm.org/D98514

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2652899 , @aganea wrote: > Sorry, but after this patch, I still see the issue mentioned in > https://reviews.llvm.org/D96363#2650460 > @abhina.sreeskantharajan are you able to confirm the issue on your

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. Sorry, but after this patch, I still see the issue mentioned in https://reviews.llvm.org/D96363#2650460 @abhina.sreeskantharajan are you be able to confirm the issue on your end? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

ggeorgakoudis created this revision. Herald added a subscriber: arichardson. ggeorgakoudis requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99415 Files:

[clang] a819256 - [OpenCL][Docs] Update status of OpenCL 3.0 development

Author: Anastasia Stulova Date: 2021-03-26T13:07:06Z New Revision: a81925664bbbc62dc854df919e1b5180f0abfa56 URL: https://github.com/llvm/llvm-project/commit/a81925664bbbc62dc854df919e1b5180f0abfa56 DIFF: https://github.com/llvm/llvm-project/commit/a81925664bbbc62dc854df919e1b5180f0abfa56.diff

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. > Our practice has been for a "tuning" option to, effectively, expand into > other options to control various bits of behavior. Basically, there should > never be behavior that can be controlled _only_ via the tuning option. This > is a design decision that was debated

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added a comment. In D99250#2651394 , @jsji wrote: > The list is growing, but sure, we will post a thread in llvm-dev about what > we met so far. > Two big one would be that DBX not supporting string section(DW_FORM_strp) and > column-info

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. Sorry for taking so long. I created a patch that should fix the missing `SourceManager`: D99414 @rupprecht can you confirm this works for your use-case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing

jansvoboda11 created this revision. jansvoboda11 added a reviewer: rupprecht. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D84673 , we started using `DiagnosticsEngine` during

[PATCH] D99402: [AMDGPU][OpenMP] Add /include to the search path

JonChesterfield added a comment. The general problem looks harder but important to fix. Finding the right headers but the wrong shared library is bad, and iirc we currently have to use LD_LIBRARY_PATH to bodge the latter which is not a good UX. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99402: [AMDGPU][OpenMP] Add /include to the search path

pdhaliwal added a comment. I was not aware that it was a general problem. I will check if I could get a general solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99402/new/ https://reviews.llvm.org/D99402

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5d4bcc2deb: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bc5d4bc - [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

Author: Abhina Sreeskantharajan Date: 2021-03-26T07:12:46-04:00 New Revision: bc5d4bcc2deb71ab647270c9754a83484b3d6f87 URL: https://github.com/llvm/llvm-project/commit/bc5d4bcc2deb71ab647270c9754a83484b3d6f87 DIFF:

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 333526. oToToT added a comment. Remove redundant whitespace in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews.llvm.org/D99407 Files: clang/lib/AST/ItaniumMangle.cpp

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT created this revision. oToToT added reviewers: rsmith, gbenyei, MaskRay, yaxunl. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As `ArrayType::ArrayType` mentioned in `clang/lib/AST/Type.cpp`, a DependentSizedArrayType

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I don't know. I think it's already way better than it was. I think we can reiterate this later. I want to get the `llvm_unreachable("Unknown SVal kind")` statements back. Besides those, I

[PATCH] D99344: [Analyzer] Track RValue expressions

steakhal added a comment. Some minor logical issues inline. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1944-1945 +return; + if (!BO->isMultiplicativeOp()) +return; + There are only 3 multiplicative operators: ```

[PATCH] D99402: [AMDGPU][OpenMP] Add /include to the search path

lebedev.ri added a comment. Any chance you might be interested in fixing the more general problem, benefiting every clang openmp user, not just amdgpu? D55725 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder updated this revision to Diff 333511. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99338/new/ https://reviews.llvm.org/D99338 Files: clang/lib/Parse/ParseDecl.cpp Index: clang/lib/Parse/ParseDecl.cpp === ---

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 333510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/test/Parser/cxx0x-attributes.cpp

[PATCH] D99402: [AMDGPU][OpenMP] Add /include to the search path

pdhaliwal created this revision. pdhaliwal added reviewers: ronlieb, JonChesterfield, jdoerfert. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

jhenderson added a comment. It might make sense to do the llvm-readobj portions of this patch in a separate review, since they are somewhat independent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360

[PATCH] D99344: [Analyzer] Track RValue expressions

martong added a comment. Guys, thanks for the review! :) Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1945 + + auto IsZero = [](const Optional ) { +if (!CI) NoQ wrote: > `SVal::isZeroConstant()` please ^.^ Yeah good catch, I wish I

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 333508. martong marked 5 inline comments as done. martong added a comment. - Use isZeroConstant() - Make trackRValueExpression private (static function) - Fix clang-tidy report: auto *BO ---> const auto *BO Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

shchenz created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. add new tuning debugger type DBX for XCOFF DWARF. Based on this debugger

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. In D89909#2624284 , @aaron.ballman wrote: > Based on the discussion so far, would these be acceptable steps to take? > > 0) Complete review on this patch for any technical concerns related to it and > commit when it's ready (this

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

ruiling added a comment. Then what do you think of my initial change for the issue (D99051 ) considering it does not show regression in any existing test? @nikic @nlopes It has a test showing the initial problem I want to solve. @lebedev.ri helped writing this