[clang] 09d1f6e - [clang] Fix copy constructor of CompilerInvocation

Author: Jan Svoboda Date: 2021-04-14T09:13:35+02:00 New Revision: 09d1f6e6b74c9330d80c0346a271a43efbe0384d URL: https://github.com/llvm/llvm-project/commit/09d1f6e6b74c9330d80c0346a271a43efbe0384d DIFF: https://github.com/llvm/llvm-project/commit/09d1f6e6b74c9330d80c0346a271a43efbe0384d.diff L

[PATCH] D99568: [clang] Fix copy constructor of CompilerInvocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09d1f6e6b74c: [clang] Fix copy constructor of CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

scw created this revision. scw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This extends smart pointer support beyond the existing `maybeDeref` and `maybeAddressOf`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1004

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

dblaikie added subscribers: MaskRay, dblaikie. dblaikie added a comment. @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch is approved without any text. Please include some text when approving patches to make sure there's a record on the mailing list. (@maskray has a br

[clang-tools-extra] 530456c - [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

Author: Balázs Kéri Date: 2021-04-14T09:33:11+02:00 New Revision: 530456caf9088b8eb237c0ab75086722ce0f2950 URL: https://github.com/llvm/llvm-project/commit/530456caf9088b8eb237c0ab75086722ce0f2950 DIFF: https://github.com/llvm/llvm-project/commit/530456caf9088b8eb237c0ab75086722ce0f2950.diff L

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG530456caf908: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'. (authored by balazske). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

dblaikie added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; njames93 wrote: > This is a slight change in behaviour, The

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

dyung added a comment. This appears to be failing on the PS4 linux bot likely due to the PS4 target has exceptions disabled by default. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/2441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; dblaikie wrote:

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. Sorry, I thought this had already gone in! LG, sorry for the back and forth. Comment at: clang-tools-extra/clangd/ClangdServ

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

dblaikie added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; njames93 wrote: > dblaikie wrote: > > njames93 wrote: > > >

[clang-tools-extra] bda2028 - [clang-tidy] Add exception flag to bugprone-unhandled-exception-at-new test.

Author: Balázs Kéri Date: 2021-04-14T10:01:05+02:00 New Revision: bda20282cb94faa97b2e50cb592eff3dec94f6b0 URL: https://github.com/llvm/llvm-project/commit/bda20282cb94faa97b2e50cb592eff3dec94f6b0 DIFF: https://github.com/llvm/llvm-project/commit/bda20282cb94faa97b2e50cb592eff3dec94f6b0.diff L

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; dblaikie wrote:

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

dblaikie added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; njames93 wrote: > dblaikie wrote: > > njames93 wrote: > > >

[PATCH] D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch documents the reason `CompilerInvocationBase` exists and renames it to more de

[clang] 1c4108a - [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386 abi.

Author: Liu, Chen3 Date: 2021-04-14T16:44:54+08:00 New Revision: 1c4108ab661d43e21b1d1c804d8a403e5b0cf7d6 URL: https://github.com/llvm/llvm-project/commit/1c4108ab661d43e21b1d1c804d8a403e5b0cf7d6 DIFF: https://github.com/llvm/llvm-project/commit/1c4108ab661d43e21b1d1c804d8a403e5b0cf7d6.diff LO

[PATCH] D78564: [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386 abi.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c4108ab661d: [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386… (authored by LiuChen3). Herald added a project: clang.

[PATCH] D78564: [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386 abi.

LiuChen3 added a comment. Thanks for your review. Hope this patch won't cause too many ABI issues in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78564/new/ https://reviews.llvm.org/D78564

Re: [clang] 1c4108a - [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386 abi.

Reminder to please ensure that all reviews are subscribed to the appropriate mailing lists. This one omitted cfe-dev. On Wed, Apr 14, 2021 at 11:47 AM via cfe-commits wrote: > > > Author: Liu, Chen3 > Date: 2021-04-14T16:44:54+08:00 > New Revision: 1c4108ab661d43e21b1d1c804d8a403e5b0cf7d6 > > URL

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

whisperity added subscribers: dblaikie, erik.pilkington, martong, whisperity. whisperity added a reviewer: shafik. whisperity added a comment. Adding a few subscribers I could find from the original bugzilla entry, + perhaps a few reviewers to help us. CHANGES SINCE LAST ACTION https://review

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. In D94355#2665532 , @gulfem wrote: >> Would you be ok with reverting this change until I can sort that out, or can >> we disable the pass for those targets until then? > > I will disable the pass for those targets for now. > When

[PATCH] D100460: [clang] Move deep copy into CompilerInvocation::clone

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: martong, usaxena95, kadircet, arphaman, javed.absar. jansvoboda11 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-com

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107 +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb In D92024#2677857 , @krisb wrote: > Do we still need the following tests: > > - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp > - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp > > ? We can remove **p11.cpp** and

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +template void func11(A::C, A::D, int) {} +template void func12() {} krisb wrote: > aorlov wrote: > > krisb wrote: > > > Before this

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASStr

[PATCH] D100466: clang-format: [JS] merge import lines.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst requested review of this revision. Herald added a project: clang. Multiple lines importing from the same URL can be merged: import {X} from 'a'; import {Y} from 'a'; Merge to: import {X, Y} from 'a'; This change i

[clang] 3637c5c - [clang] [AArch64] Fix Windows va_arg handling for larger structs

Author: Martin Storsjö Date: 2021-04-14T14:51:53+03:00 New Revision: 3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2 URL: https://github.com/llvm/llvm-project/commit/3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2 DIFF: https://github.com/llvm/llvm-project/commit/3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2.diff

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3637c5c8ec3d: [clang] [AArch64] Fix Windows va_arg handling for larger structs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100374/n

[PATCH] D100467: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. The documentation says that for variadic functions, all composites are tr

[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100468

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2684450 , @tentzen wrote: > Hi, > (Last call for review!!) Please refer to https://llvm.org/docs/CodeReview.html > Is there any more comments? This review has lasted for more than a year now. > I believe I had ad

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 337416. urnathan added a comment. Remove orthogonal lbstdc++ FIXME comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/S

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. Adds extra error diagnostics when using unsupported t

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

MyDeveloperDay added a comment. can you clang-format so it passes the pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 ___ cfe-commits mailing lis

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8977 + "};\n", + NoEmptyLines); verifyFormat("struct foo {\n" if you left a line between this test or added your test at the end it wouldn't ha

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

peter.smith accepted this revision. peter.smith added reviewers: compnerd, rengolin. peter.smith added a comment. This revision is now accepted and ready to land. I think this is the right thing to do. GCC changed to unconditionally set the macro with https://gcc.gnu.org/legacy-ml/gcc-patches/201

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added a comment. I would prefer if we try to take a slightly different route i.e. if two features are identical (e.g. `cl_khr_fp64` and `__opencl_c_fp64`) we make sure that they are both set identical in Target options or command-line interface using early check and a diagnostic in th

[PATCH] D100466: clang-format: [JS] merge import lines.

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:154 +// Merge module references: +// After sorting, find all references that import named symbols from the Would it be better if this were a named function? ==

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added a comment. Ok, this looks like a straightforward addition. I will finalize this review once the parent review is completed though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396

[PATCH] D99330: [clang-tidy] [test] Tweak a regex pattern to accommodate for quirks in MSYS based grep

mstorsjo abandoned this revision. mstorsjo added a comment. Not needed, handled by D99938 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99330/new/ https://reviews.llvm.org/D99330 _

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} Hmm

[PATCH] D100473: [clang] Implement CompilerInvocation copy assignment

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the copy assignment for `CompilerInvocation`. Eventually, the deep-

[PATCH] D99231: [AST] Add introspection support for more base nodes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; steveire wro

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/invalid-kernel.clcpp:44 +kernel void trivial_v(Trivial in) {} //expected-error{{'__private Trivial' cannot be used as the type of a kernel parameter}} +kernel void trivial_p(__global Trivial*__private in) {}

[clang] 856c49d - [OpenCL][Docs] Update OpenCL 3.0 implementation status

Author: Sven van Haastregt Date: 2021-04-14T13:56:26+01:00 New Revision: 856c49d79c0d717fb3e9ff6deebfe740a4f752e2 URL: https://github.com/llvm/llvm-project/commit/856c49d79c0d717fb3e9ff6deebfe740a4f752e2 DIFF: https://github.com/llvm/llvm-project/commit/856c49d79c0d717fb3e9ff6deebfe740a4f752e2.

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia resigned from this revision. Anastasia added a comment. In D97669#2687419 , @benshi001 wrote: > In D97669#2685698 , @Anastasia wrote: > >> In D97669#2678460 , @bens

[clang] 92aba5a - CPUDispatch- allow out of line member definitions

Author: Erich Keane Date: 2021-04-14T06:19:49-07:00 New Revision: 92aba5ae49a6970c43bead0afd1e52c83fe44e6e URL: https://github.com/llvm/llvm-project/commit/92aba5ae49a6970c43bead0afd1e52c83fe44e6e DIFF: https://github.com/llvm/llvm-project/commit/92aba5ae49a6970c43bead0afd1e52c83fe44e6e.diff L

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 337433. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/Toke

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 337441. bader marked 5 inline comments as done. bader added a comment. Applied more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASString

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers requested changes to this revision. gregrodgers added a comment. This revision now requires changes to proceed. I have two serious concerns with this tool . 1. It does not provide the infrastructure to identify runtime capabilities to satisfy requirements of a compiled image. 2.

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

aaron.ballman added a comment. In D97653#2681458 , @njames93 wrote: > Use implicit capture instead of default capture. > > @aaron.ballman, Unfortunately the AST dump tests don't work as implicit > captures don't appear to show up in the textual representa

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. In D99949#2688869 , @gregrodgers wrote: > 1. It does not provide the infrastructure to identify runtime capabilities to > satisfy requirements of a compiled image. I believe we only require a value for '-march=' to unbloc

[PATCH] D100480: Add flag for showing skipped headers in -H / --show-includes output

hans created this revision. hans added reviewers: thakis, rnk. Herald added subscribers: jansvoboda11, dang. hans requested review of this revision. Herald added a project: clang. Consider the following set of files: a.cc: #include "a.h" a.h: #ifndef A_H #define A_H #include "b.

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

olestrohm updated this revision to Diff 337450. olestrohm added a comment. Added more exhaustive tests, as well as fixed the diagnostic to allow reference types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/ https://reviews.llvm.org/D100471 Files: clang/lib/Sema/SemaDecl

[PATCH] D100466: clang-format: [JS] merge import lines.

mprobst updated this revision to Diff 337456. mprobst added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100466/new/ https://reviews.llvm.org/D100466 Files: clang/lib/Format/SortJavaScriptImports.cpp clang/

[PATCH] D99501: ignore -flto= options recognized by GCC

doko added a comment. that's now https://reviews.llvm.org/D100484 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D100466: clang-format: [JS] merge import lines.

mprobst marked 3 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:92 + // reference needs re-formatting. + bool SymbolsMerged; // The source location just after { and just before } in the import.

[PATCH] D100480: Add flag for showing skipped headers in -H / --show-includes output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf29dcbdde10c: Add flag for showing skipped headers in -H / --show-includes output (authored by hans). Repository: rG LLVM Github Monorepo CHANGES

[clang] f29dcbd - Add flag for showing skipped headers in -H / --show-includes output

Author: Hans Wennborg Date: 2021-04-14T17:01:51+02:00 New Revision: f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e URL: https://github.com/llvm/llvm-project/commit/f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e DIFF: https://github.com/llvm/llvm-project/commit/f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e.diff

[PATCH] D100466: clang-format: [JS] merge import lines.

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100466/new/ https://reviews.llvm.org/D100466 ___ c

[clang] d45df0d - clang-format: [JS] merge import lines.

Author: Martin Probst Date: 2021-04-14T17:20:07+02:00 New Revision: d45df0d29f7005d3c25357f3982002eaf339f875 URL: https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875 DIFF: https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875.diff

[clang] 4d195f1 - review comments

Author: Martin Probst Date: 2021-04-14T17:20:08+02:00 New Revision: 4d195f1b4dd6e3978776d69f49840439933a2543 URL: https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543 DIFF: https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543.diff

[PATCH] D100466: clang-format: [JS] merge import lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rGd45df0d29f70: clang-format: [JS] merge import lines. (authored by mprobst). Changed prior to commit: htt

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. Hello. Due to the time zone difference, I think our communication is a bit inefficient. Can we arrange a convenient time for you to focus on the discussion? We use CST. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100484/new/ https://reviews.llvm.org/D100484 ___ cfe-commits mailing list cfe-com

[PATCH] D99501: ignore -flto= options recognized by GCC

tejohnson added a comment. Just approved the test case patch. Sorry I missed the lack of test on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-com

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

Jonathan.Crowther created this revision. Jonathan.Crowther added reviewers: abhina.sreeskantharajan, anirudhp, muiez, zibi, yusra.syeda, rnk, amccarth. Herald added subscribers: wenlei, hiraditya. Jonathan.Crowther requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D100368: [X86] Support some missing intrinsics

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9593 +/// locations starting at location \a base_addr at packed 32-bit integer indices +/// stored in the lower half of \a vindex scaled by \a scale them in dst. +/// "scale them i

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. At this point I am not convinced this patch will provide benefit for the default use case when `-entropic=1`. I am hesitant to add complexity to the code for unsure benefit. If you request a FuzzBench experiment

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Instead of using a MinVersion and MaxVersion field, encode the version of a b

[clang] af7ab81 - [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

Author: Thomas Lively Date: 2021-04-14T09:19:27-07:00 New Revision: af7ab81ce3104418b4971b2398c1e028238ed90f URL: https://github.com/llvm/llvm-project/commit/af7ab81ce3104418b4971b2398c1e028238ed90f DIFF: https://github.com/llvm/llvm-project/commit/af7ab81ce3104418b4971b2398c1e028238ed90f.diff

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7ab81ce310: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100411/new/

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne added a comment. Well, one way to see things is that this patch only makes yet another step in a direction that we're already rather far in (in terms of CMake complexity). And as I said, I think the separation of `__config_site` in its own platform-specific directory makes a lot of sens

[clang] 2fe4909 - clang-format: fix undefined behavior.

Author: Martin Probst Date: 2021-04-14T19:41:18+02:00 New Revision: 2fe4909748b5f14499e83b0647b7e9ddd0068a15 URL: https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15 DIFF: https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15.diff

[clang] af7925b - [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s, u}

Author: Thomas Lively Date: 2021-04-14T10:42:45-07:00 New Revision: af7925b4dd6519ebf0126ac8a18d791eb26968c9 URL: https://github.com/llvm/llvm-project/commit/af7925b4dd6519ebf0126ac8a18d791eb26968c9 DIFF: https://github.com/llvm/llvm-project/commit/af7925b4dd6519ebf0126ac8a18d791eb26968c9.diff

[clang] 1c57172 - [libTooling] Add smart pointer support to the `access` Stencil

Author: Shu-Chun Weng Date: 2021-04-14T10:45:59-07:00 New Revision: 1c5717225e89d4b266784f1a1fe482530bc4b6f2 URL: https://github.com/llvm/llvm-project/commit/1c5717225e89d4b266784f1a1fe482530bc4b6f2 DIFF: https://github.com/llvm/llvm-project/commit/1c5717225e89d4b266784f1a1fe482530bc4b6f2.diff

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7925b4dd65: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u} (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100425/new/ https

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5717225e89: [libTooling] Add smart pointer support to the `access` Stencil (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100450/new/ ht

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

scw added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} ymandel wrote: > Hmm. Looks like we could use smart pointer support in tooling::buildAddress

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > FYI, I pushed the fix for the aarch64-coff issue now (D99572 > , rGd5c5cf5ce8d921fc8c5e1b608c298a1ffa688d37 > ) and > pushed another commit to remove the code for disa

[clang] c1554f3 - [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

Author: Alex Lorenz Date: 2021-04-14T11:29:25-07:00 New Revision: c1554f32e3b3fafab64698fdb5b806b1bda4aa8a URL: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a DIFF: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a.diff L

[PATCH] D100428: [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1554f32e3b3: [clang][FileManager] Support empty file name in getVirtualFileRef for… (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D100428?vs=337289&id=337507#toc Repository

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. As discussed offline, I think this is fine. This layout seems to be closest to what other compilers use. @phosek said he would send out an RFC to make the multiarch layout become the defaul

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne added a comment. Oh, and can you make sure the Runtimes build passes CI before shipping this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-comm

[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100468/new/ https://reviews.llvm.org/D100468 ___ cfe-c

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

rsmith added inline comments. Comment at: clang/include/clang/Basic/ABI.h:182 + /// an ABI-specific comparator. + const CXXMethodDecl *BaseMethod; + Instead of the changes you made to `GlobalDecl`, I think this should be a `GlobalDecl` itself. Different functi

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

rsanthir.quic added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:36 + bool HasSHA3; + bool HasSM4; bool HasUnaligned; Would it make sense to further differentiate SM3 and SM4? I see that we differentiate between the two in arm_neon.td ("AR

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added inline comments. Comment at: clang/lib/AST/VTableBuilder.cpp:1155-1157 + // Override it. Note that there may or may not be a thunk already. + VTableThunks.erase(Idx); + VTableThunks.insert({Idx, *TI}); rsmith wrote: > Can you modif

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Personally, I'm not a fan of boolean function parameters because of the inline comments necessary to make the call site understandable. But it appears to be consistent with LLVM Coding St

[PATCH] D100502: Allow lib64 in driver test

troyj created this revision. troyj added a reviewer: clang. troyj added a project: clang. troyj requested review of this revision. Herald added a subscriber: cfe-commits. The test clang/test/Driver/rocm-detect.hip does not consider that "lib" may be "lib64" instead. Repository: rG LLVM Github

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers added a comment. Dependence on hsa is not necessary. The amdgpu and nvidia drivers both use PCI codes available in /sys . We should use architecture independent methods as much as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107 +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; aheejin wrote: > Not related to this CL, but we write encoding

[clang] 6559ebd - [AST] Replace asserts with a condition

Author: Stephen Kelly Date: 2021-04-14T21:14:05+01:00 New Revision: 6559ebd91b70f8d2ed82e19539ee09c5220159c2 URL: https://github.com/llvm/llvm-project/commit/6559ebd91b70f8d2ed82e19539ee09c5220159c2 DIFF: https://github.com/llvm/llvm-project/commit/6559ebd91b70f8d2ed82e19539ee09c5220159c2.diff

[clang] d2bb3cb - Make test runnable on read-only file systems.

Author: Sterling Augustine Date: 2021-04-14T13:29:51-07:00 New Revision: d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f URL: https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f DIFF: https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f.

[clang] f347f0e - [AST] Add introspection support for more base nodes

Author: Stephen Kelly Date: 2021-04-14T21:31:23+01:00 New Revision: f347f0e0b869be4f9b97f26663cf8e4eac2c4868 URL: https://github.com/llvm/llvm-project/commit/f347f0e0b869be4f9b97f26663cf8e4eac2c4868 DIFF: https://github.com/llvm/llvm-project/commit/f347f0e0b869be4f9b97f26663cf8e4eac2c4868.diff

[PATCH] D99231: [AST] Add introspection support for more base nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGf347f0e0b869: [AST] Add introspection support for more base nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D99231?vs=336813&id=337537#toc Repository: rG LLVM Gith

[clang] 6a18cc2 - [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

Author: Thomas Lively Date: 2021-04-14T13:43:09-07:00 New Revision: 6a18cc23efad410db48a3ccfc233d215de7d4cb9 URL: https://github.com/llvm/llvm-project/commit/6a18cc23efad410db48a3ccfc233d215de7d4cb9 DIFF: https://github.com/llvm/llvm-project/commit/6a18cc23efad410db48a3ccfc233d215de7d4cb9.diff

  1   2   >