[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert created this revision. jdoerfert added reviewers: ABataev, JonChesterfield, ggeorgakoudis, tianshilei1992. Herald added subscribers: jfb, guansong, hiraditya, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits, cfe-

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. NOTE: not all tests have been updated, only *codegen.cpp ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 ___ cfe-commits mailin

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 343301. jdoerfert added a comment. Remove itantium mangle change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. https://gist.github.com/MaskRay/2d4dfcfc897341163f734afb59f689c6 has more information about -fno-semantic-interposition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/ https://reviews.llvm.org/D101873 _

[clang] 5d8d994 - [OpenMP] Make sure classes work on the device as they do on the host

Author: Johannes Doerfert Date: 2021-05-06T02:10:30-05:00 New Revision: 5d8d994dfbe38fe86b1d883daa9fd8e47cdc1376 URL: https://github.com/llvm/llvm-project/commit/5d8d994dfbe38fe86b1d883daa9fd8e47cdc1376 DIFF: https://github.com/llvm/llvm-project/commit/5d8d994dfbe38fe86b1d883daa9fd8e47cdc1376.d

[clang] 3f14596 - [OpenMP] Ensure the DefaultMapperId has a location

Author: Johannes Doerfert Date: 2021-05-06T02:10:36-05:00 New Revision: 3f14596700093bce436ae27178c307e842398b65 URL: https://github.com/llvm/llvm-project/commit/3f14596700093bce436ae27178c307e842398b65 DIFF: https://github.com/llvm/llvm-project/commit/3f14596700093bce436ae27178c307e842398b65.d

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8d994dfbe3: [OpenMP] Make sure classes work on the device as they do on the host (authored by jdoerfert). Repository: rG LLVM Github Monorepo C

[PATCH] D100621: [OpenMP] Ensure the DefaultMapperId has a location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f1459670009: [OpenMP] Ensure the DefaultMapperId has a location (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D10062

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf729e2b82b3: [OpenMP] Overhaul `declare target` handling (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + probinson wrote: > probinson wrote: > > TWeaver wrote: > > > nj

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert abandoned this revision. jdoerfert added a comment. Herald added a subscriber: yaxunl. Herald added a reviewer: bollu. replaced by D101976 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https:/

[PATCH] D101979: [WebAssembly] Fix argument types in SIMD narrowing intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The builtins were updated to

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

lebedev.ri added a comment. Thank you for looking into this! This also fixes the problem of not being able to find `libomp`, right? Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain &TC, +

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 added a comment. Thanks Paul! Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Paul-C-Anagnostopoulos wrote: > jansvoboda11 wrote: > > Paul-C-Anagnostopoulos wrote

[PATCH] D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`

hvdijk added a comment. Herald added a subscriber: cfe-commits. Apparently Phabricator detected the presence of "revert D100625 " in my alternative D101851 's description and marked that as reverting this one. Of course, as thi

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. @ggeorgakoudis `Clang::parallel_for_codegen.cpp` is failing on some of our bots: https://lab.llvm.org/buildbot/#/builders/43/builds/5751 https://lab.llvm.org/buildbot/#/builders/107/builds/7585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 343321. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/Unwr

[PATCH] D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`

Abpostelnicu abandoned this revision. Abpostelnicu added a comment. In D100625#2741385 , @hvdijk wrote: > Apparently Phabricator detected the presence of "revert D100625 > " in my alternative D101851 >

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

sberg added a comment. Bisecting shows that this started to break $ cat test.cc void f() noexcept { __try {} __finally {} } $ clang-cl -EHs -c test.cc clang-cl: ~/github.com/llvm/llvm-project/clang/lib/CodeGen/CGCleanup.h:568: void clang::CodeGen::EHScopeStack::popTerminate(): Assertion

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

kadircet added a comment. Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as that's where the underlying change lies. To disambiguate properties and ivars, what if we used modifiers? I suppose we can mark properties with `abstract` modifier, but i am not an obj-c person so

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal added a comment. Overall, it looks promising. But I don't quite get this test. There is no invocation yaml in the temp directory. So, you are probably not testing the right thing. You wanted to test if the invocation yaml exists, and could be opened **but the parsing fails**. You should

[clang] a437bef - [clang-format] Add more support for C# 8 nullables

Author: Eliza Velasquez Date: 2021-05-06T11:58:38+02:00 New Revision: a437befa8f8580b3b4f2226b208a05da078c8b20 URL: https://github.com/llvm/llvm-project/commit/a437befa8f8580b3b4f2226b208a05da078c8b20 DIFF: https://github.com/llvm/llvm-project/commit/a437befa8f8580b3b4f2226b208a05da078c8b20.dif

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa437befa8f85: [clang-format] Add more support for C# 8 nullables (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1017

[clang] ec725b3 - [clang-format] Fix C# nullable-related errors

Author: Eliza Velasquez Date: 2021-05-06T12:11:15+02:00 New Revision: ec725b307f3fdc5656459047bab6e69669d9534f URL: https://github.com/llvm/llvm-project/commit/ec725b307f3fdc5656459047bab6e69669d9534f DIFF: https://github.com/llvm/llvm-project/commit/ec725b307f3fdc5656459047bab6e69669d9534f.dif

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGec725b307f3f: [clang-format] Fix C# nullable-related errors (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/ne

[clang] cdf3396 - [clang-format] Rename common types between C#/JS

Author: Eliza Velasquez Date: 2021-05-06T12:12:58+02:00 New Revision: cdf33962d9768fbd8d6b193aff463a21eaa984f3 URL: https://github.com/llvm/llvm-project/commit/cdf33962d9768fbd8d6b193aff463a21eaa984f3 DIFF: https://github.com/llvm/llvm-project/commit/cdf33962d9768fbd8d6b193aff463a21eaa984f3.dif

[PATCH] D101862: [clang-format] Rename common types between C#/JS

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdf33962d976: [clang-format] Rename common types between C#/JS (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo marked an inline comment as done. wingo added a comment. Thanks for the review! Regarding the address space name -- the intention with "object" was to rhyme a bit with "object capabilities", somehow, but I see that it is confusing. How about `WASM_ADDRESS_SPACE_MANAGED` ? I.e. this addre

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISD.def:48 + +// Reference Types +HANDLE_MEM_NODETYPE(GLOBAL_GET) tlively wrote: > sbc100 wrote: > > Is this just for ref types or also for global that hold integers too (like > > `_

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 343344. wingo added a comment. Rename "object" address space to "managed"; address feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Ta

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay added a comment. In D101462#2733726 , @flip1995 wrote: >> I'll keep this open for a few days as it touches too many things. > > Sounds good 👍 > >> but you'll need to provide your name and email > > ~~I used `arc diff`. The commits I made with `git

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632ebc4ab437: [MC] Untangle MCContext and MCObjectFileInfo (authored by flip1995, committed by MaskRay). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

jrtc27 added a comment. In D101462#2739404 , @MaskRay wrote: > In D101462#2733726 , @flip1995 > wrote: > >>> I'll keep this open for a few days as it touches too many things. >> >> Sounds good 👍 >> >>> but you'll

[PATCH] D33029: [clang-format] add option for dangling parenthesis

blandcr added a comment. @jakar I did a bit of sleuthing (google `catskul github`, which I feel a little weird about but whatever) and I think I found their changes in a fork: https://github.com/catskul/llvm-project/tree/catskul/dangling-parenthesis-as-bracket-alignment It seems there are a few d

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343346. OikawaKirie added a comment. In D101763#2741536 , @steakhal wrote: > Overall, it looks promising. But I don't quite get this test. > There is no invocation yaml in the temp directory. So, you are probably

[PATCH] D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

joechrisellis created this revision. joechrisellis added reviewers: bsmith, DavidTruby, peterwaller-arm. Herald added a subscriber: hiraditya. joechrisellis requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This commit remov

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal added a comment. Okay, so you 'just' want an indication for the given open call. What about using `strace`? `strace -e trace=openat %clang_cc1 ... 2>&1 | grep '"invocations.yaml"' | FileCheck %s` This way the given test file could contain the contents of the `importer.c`. CHANGES SIN

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture &C) { + return C

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101787/new/ https://reviews.llvm.org/D101787 ___ cfe-commits mailing lis

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101973/new/ https://reviews.llvm.org/D101973 ___

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

aaron.ballman added a comment. I agree that all the comments labeled `FIXME` are ones where I'd expect to see the diagnostic triggered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101790/new/ https://reviews.llvm.org/D101790 ___ cfe-commit

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:65-68 + asm volatile("barrier.sync %0;" + : + : "r"(barrier) + : "memory"); Why not `__syncthreads`? It is safer to use `

[PATCH] D101926: [amdgpu-arch] Fix rpath to run from build dir

JonChesterfield added a comment. It does indeed fix that comment from D99949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101926/new/ https://reviews.llvm.org/D101926 _

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 343360. wingo added a comment. yarr, shiver me timbers, fix me typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets/WebAssembly.h cl

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. I could not find anything in the cmake files which could point to the issue mentioned here. @davezarzycki, are you on fedora/redhat? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D9994

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 343363. reikdas added a comment. Address @rsmith comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Expr.h clang/include/clan

[clang] b24e9f8 - [amdgpu-arch] Fix rpath to run from build dir

Author: Jon Chesterfield Date: 2021-05-06T13:07:00+01:00 New Revision: b24e9f82b71f325214c41fdc3f106207cc2244a6 URL: https://github.com/llvm/llvm-project/commit/b24e9f82b71f325214c41fdc3f106207cc2244a6 DIFF: https://github.com/llvm/llvm-project/commit/b24e9f82b71f325214c41fdc3f106207cc2244a6.di

[PATCH] D101926: [amdgpu-arch] Fix rpath to run from build dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb24e9f82b71f: [amdgpu-arch] Fix rpath to run from build dir (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 343367. wingo added a comment. Rename "object" to "managed", and add test for stack id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: clang/lib/Basic/Targets/

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia closed this revision. Anastasia added a comment. Closed by https://reviews.llvm.org/rGe994e74bca49831eb649e7c67955e9de7a1784b6 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101168/new/ https://reviews.llvm.org/D101168 ___ cfe-commit

[clang] c28a602 - [OpenCL] Remove subgroups pragma in enqueue kernel and pipe builtins.

Author: Anastasia Stulova Date: 2021-05-06T13:59:38+01:00 New Revision: c28a602329a78db5c02cc85679b5035aaf6753b4 URL: https://github.com/llvm/llvm-project/commit/c28a602329a78db5c02cc85679b5035aaf6753b4 DIFF: https://github.com/llvm/llvm-project/commit/c28a602329a78db5c02cc85679b5035aaf6753b4.d

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel and pipe builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc28a602329a7: [OpenCL] Remove subgroups pragma in enqueue kernel and pipe builtins. (authored by Anastasia). Herald added a subscriber: ldrumm. Heral

[clang] d40a0b8 - [TableGen] [Clang] Clean up Options.td and add asserts.

Author: Paul C. Anagnostopoulos Date: 2021-05-06T09:32:25-04:00 New Revision: d40a0b8af771f9b37dd2985fc692443c0ac5473e URL: https://github.com/llvm/llvm-project/commit/d40a0b8af771f9b37dd2985fc692443c0ac5473e DIFF: https://github.com/llvm/llvm-project/commit/d40a0b8af771f9b37dd2985fc692443c0ac5

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd40a0b8af771: [TableGen] [Clang] Clean up Options.td and add asserts. (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101

[clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

Author: Nemanja Ivanovic Date: 2021-05-06T08:37:36-05:00 New Revision: ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8 URL: https://github.com/llvm/llvm-project/commit/ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8 DIFF: https://github.com/llvm/llvm-project/commit/ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8.di

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

peter.smith added a comment. In D101873#2741299 , @MaskRay wrote: > https://gist.github.com/MaskRay/2d4dfcfc897341163f734afb59f689c6 has more > information about -fno-semantic-interposition. > >> Can Clang default to -fno-semantic-interposition? > > I th

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. The failing test line is: // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 It passes if you have the X86 backend enabled but fails if you do not. Our bots usually have only Arm o

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good, but please wait for others to state their opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-com

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3399 +by the pragma behaves as though the command-line option +``-ffp-eval-method=source`` is enabled, returning floating point evaluation +method to the default setting. ==

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

Looks like this breaks tests: http://45.33.8.238/linux/45985/step_7.txt , https://lab.llvm.org/buildbot/#/builders/139/builds/3818 (Is there a phab link for this?) On Thu, May 6, 2021 at 9:37 AM Nemanja Ivanovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nemanja Ivanovic >

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

Reverted in 3761b9a2345aff197707d23a68d4a178489f60e4 for now. On Thu, May 6, 2021 at 9:58 AM Nico Weber wrote: > Looks like this breaks tests: http://45.33.8.238/linux/45985/step_7.txt , > https://lab.llvm.org/buildbot/#/builders/139/builds/3818 > > (Is there a phab link for this?) > > On Thu, M

[clang] 3761b9a - Revert "[PowerPC] Provide some P8-specific altivec overloads for P7"

Author: Nico Weber Date: 2021-05-06T10:01:16-04:00 New Revision: 3761b9a2345aff197707d23a68d4a178489f60e4 URL: https://github.com/llvm/llvm-project/commit/3761b9a2345aff197707d23a68d4a178489f60e4 DIFF: https://github.com/llvm/llvm-project/commit/3761b9a2345aff197707d23a68d4a178489f60e4.diff LO

[clang] e4b790c - [OpenMP] Temporarily require X86 target for parallel_for_codegen.cpp test

Author: David Spickett Date: 2021-05-06T14:16:43Z New Revision: e4b790c5e3653053819182a67c593bc65de860ac URL: https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac DIFF: https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac.diff LOG

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. I've required X86 target for this test to get our bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 ___ cfe-commi

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 343399. nicovank marked 7 inline comments as done. nicovank added a comment. Fix some style comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files: clang-t

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:294 + } else { +if ((MakeCall ? MakeCall->getNumArgs() : CtorCall->getNumArgs()) == 0) { + Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange( ---

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. We can have that as a workaround sure. > Either way this seems like a bug given that clang usually doesn't requi

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:65-68 + asm volatile("barrier.sync %0;" + : + : "r"(barrier) + : "memory"); ABataev wrote: > Why not `__syncthreads`? I

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343409. dgoldman added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman added a comment. In D101785#2741535 , @kadircet wrote: > Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as > that's where the underlying change lies. > > To disambiguate properties and ivars, what if we used modifiers? I s

[clang] 1faf3b1 - [PowerPC] Re-commit ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8

Author: Nemanja Ivanovic Date: 2021-05-06T09:50:12-05:00 New Revision: 1faf3b195e71dbc469d658d450949439dbf92f9f URL: https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f DIFF: https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f.di

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. Herald added subscribers: dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_amini, rupprecht, gbedwell, hir

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 343417. azabaznov added a comment. Rebased to use `::validateOpenCLTarget`. Decided to use explicit simulatneous extensions/feature disabling in command line due to API spec limitations: clGetDeviceInfo: Will not describe support for the cl_khr_3d_image_wr

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added a comment. > This change removes the requirement on pragma when atomic types from the > extensions are supported because the behavior is not conformant. With this > change, the developers can use atomic types from the extensions if they are > supported without enabling the prag

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: openmp/libomptarget/deviceRTLs/interface.h:421 + bool UseGenericStateMachine, + bool RequiresFullRu

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil abandoned this revision. jankratochvil added a comment. IIUC it will get replaced by D101950 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 _

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. Just to be clear, I am not sure when/if D101950 is ready. It's mostly blocked by me not having the time to work on it, so depending how my schedule is this might land soon or far in the future. Just linked it here as this (temporary)

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. What are the required semantics of the barrier operations? Amdgcn builds them on shared memory, so probably needs a change to the corresponding target_impl to match

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. In D101976#2742166 , @JonChesterfield wrote: > What are the required semantics of the barrier operations? Amdgcn builds them > on shared memory, so probably needs a change to the corresponding target_impl > to match I have *

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

svenvh added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1748 +With this extension it is possible to enable bitfields in structs +or unions using regular OpenCL extension pragma mechanism detailed in +`the OpenCL Extension Specification, section 1.2 ---

[clang-tools-extra] 159dd44 - [clangd][ObjC] Highlight Objc Ivar refs

Author: David Goldman Date: 2021-05-06T11:41:49-04:00 New Revision: 159dd447fe98f558879343d660b5bfe90779609f URL: https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f DIFF: https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f.diff

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG159dd447fe98: [clangd][ObjC] Highlight Objc Ivar refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

DavidSpickett added a comment. Thanks! I'll test our Arm build and revert the requires once I've confirmed it passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 _

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

jdoerfert added a comment. In D101952#2742237 , @DavidSpickett wrote: > Thanks! I'll test our Arm build and revert the requires once I've confirmed > it passes. This is not the fix you need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Yes. Libomp and libomptarget are in the same directory, so the rpath/runpath change catches both of them. Libomptarget then needs to find the plugins to load, either through library path or something equivalent to the above. Comment at: clang/

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. Thanks David for the workaround. I agree with Johannes's comments below. It looks like a bug. Repository:

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

dyung added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + jubnzv wrote: > probinson wrote: > > probinson wrote: > > > TWea

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 343438. ggeorgakoudis added a comment. Update regex for removing old checklines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files: clang/utils/refactor_cc

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. Can we split this patch now and make progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___ cfe-commits mailing list cfe-commits

[PATCH] D102001: [Index] Ignore nullptr decls for indexing

ahoppen created this revision. Herald added a subscriber: arphaman. ahoppen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can end up with a call to `indexTopLevelDecl(D)` with `D == nullptr` in non-assert builds e.g. when indexing a m

[clang] b198b9b - [WebAssembly] Fix argument types in SIMD narrowing intrinsics

Author: Thomas Lively Date: 2021-05-06T10:07:45-07:00 New Revision: b198b9b8974b19c9e8493f8d70c85ac54182597a URL: https://github.com/llvm/llvm-project/commit/b198b9b8974b19c9e8493f8d70c85ac54182597a DIFF: https://github.com/llvm/llvm-project/commit/b198b9b8974b19c9e8493f8d70c85ac54182597a.diff

[PATCH] D101979: [WebAssembly] Fix argument types in SIMD narrowing intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb198b9b8974b: [WebAssembly] Fix argument types in SIMD narrowing intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D33029: [clang-format] add option for dangling parenthesis

catskul added a comment. It's all good for me. Sorry for slow responses. My time to work on this is few and far between. I'm happy if anyone picks it up or any energy put into this. Would love to see it land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llv

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2735336 , @yaxunl wrote: > Decls in Sema::DeclsToCheckForDeferredDiags is supposed to be unique. > Therefore the fact that '1,734,387,685 out of 1,734,404,000 elements are the > same' is surprising. Did this happen wh

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. This LGTM! `MANAGED` sounds like a good address space name to me. @sbc100, do you have any final comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 accepted this revision. sbc100 added a comment. managed seems reasonable yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 ___ cfe-commits mailing lis

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + Actually, should we enforce that

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + tlively wrote: > Actually, should

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 Sorry to throw more pain

  1   2   >