[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! That was quick! Thanks. Please wait for @baramin to validate the fix before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1067

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361590. saiislam added a comment. Herald added a subscriber: ormris. 1. Simplified the nested loop to look for repeated SDLs. 2. Minimized creation of std::string in favour of StringRef wherever possible. 3. Added test cases Repository: rG LLVM Github Mon

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361591. saiislam added a comment. Couple of wrong files got added in the last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolC

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94098/new/ https://reviews.llvm.org/D94098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

baramin added a comment. LGTM! It solves my problem. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106773/new/ https://reviews.llvm.org/D106773 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:236-242 + const BugMessageMap BugMessages = { + {&BT_FileNull, "Assuming opening the stream fails here"}, + {&BT_UseAfterClose, "Stream closed here"}, + {&BT_UseAfterOp

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam marked 5 inline comments as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7674-7687 +StringRef GPUArchName; +if ((CurKind == Action::OFK_OpenMP)) { + // Extract GPUArch from -march argument in TC argument list. +

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105819/new/ https://reviews.llvm.org/D105819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3800 + FormatStyle Style = getLLVMStyle(); + Style.BreakBeforeInlineASMColon = true; verifyFormat( HazardyKnusperkeks wrote: > I already gave my go in the past, bu

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361597. AMDChirag added a comment. Rebase to current main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_p

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361598. AMDChirag added a comment. Removed parent line in summary, it was not longer relevant and caused build failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D933

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Then I am sorry that I've missed that before. But you need to change your `bool` to an `enum` and also model the current behavior, so that there is no change

[clang-tools-extra] 0a3c796 - Revert "Revert D106562 "[clangd] Get rid of arg adjusters in CommandMangler""

Author: Kadir Cetinkaya Date: 2021-07-26T11:13:22+02:00 New Revision: 0a3c7960cba15b57f679159c2bb4d20d10b86a5c URL: https://github.com/llvm/llvm-project/commit/0a3c7960cba15b57f679159c2bb4d20d10b86a5c DIFF: https://github.com/llvm/llvm-project/commit/0a3c7960cba15b57f679159c2bb4d20d10b86a5c.dif

[clang-tools-extra] e9274af - Revert "[clangd] Avoid range-loop init-list lifetime subtleties."

Author: Sam McCall Date: 2021-07-26T11:38:47+02:00 New Revision: e9274af7189333d1f50e47098d9ae30522d7193f URL: https://github.com/llvm/llvm-project/commit/e9274af7189333d1f50e47098d9ae30522d7193f DIFF: https://github.com/llvm/llvm-project/commit/e9274af7189333d1f50e47098d9ae30522d7193f.diff LO

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361605. AMDChirag added a comment. Minor test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp clan

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change provides a way to conveniently declare types that have addr

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna added a comment. Change to `LanguageExtensions.rst` assumes there is a section about the utility on official C++ for OpenCL documentation. However, it is not yet documented Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https:/

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. I am just curious, was this revealed from a real world test that used an offset that is so large that it doesn't fit into 32 bits? Repository: rG LLVM Gith

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

frasercrmck added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:127 + +bool RISCVISAInfo::isSupportedExtensionFeature(StringRef Ext) { + bool IsExperimental = stripExperimentalPrefix(Ext); This looks like a `find_if` if that'd make it any simple

[PATCH] D106787: [clang][driver] NFC: Move InputInfo.h from lib to include

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, Jim, kadircet, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc2

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. After speaking with @dexonsmith, the laziness is probably not necessary when dealing with a short bit vector. I'll also explore using `llvm::BitVector` instead of `std::vector`. Repository: rG LLVM Github Monorepo

[PATCH] D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch exposes `InputInfo` in `Job` instead of plain filenames. This is use

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also use it in other places that performed it on their own. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 updated this revision to Diff 361626. jansvoboda11 added a comment. Also ignore cc1 jobs that have inputs that are not source files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 Files: c

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Requesting re-review, since there are two changes: - `-cc1` commands that don't read a source file are ignored (e.g. jobs generated by `-fembed-bitcode`), - test now have `-target arm64-apple-macosx11.0.0` to ensure th

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 updated this revision to Diff 361630. jansvoboda11 added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 Files: clang/include/clang/Tooling/Tooling.h clang/lib/Tooli

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

lei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15133 +bool IsLE = getTarget().isLittleEndian(); +auto StoreSubVec = [&](unsigned Width, unsigned Offset, unsigned EltNo) { + switch (Width) { I find the nested switch to be a bit

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

aaron.ballman added a comment. In D103385#2900967 , @jwtowner wrote: > It should be good to go. I do not have commit access so feel free to commit. > Thanks! Thanks! What name and email address would you like me to use for patch attribution? ===

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361633. saiislam marked 2 inline comments as done. saiislam added a comment. Added instructions to generate a fat archive and reduced the size of attached libFatArchive.a used for testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2902091 , @jyknight wrote: > In D106577#2901654 , @rsmith wrote: > >> I think this patch as it stands would cause problems with libc >> implementations that put their `#d

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

hans created this revision. hans added reviewers: thakis, rnk. hans requested review of this revision. Herald added a project: clang. For some reason, Microsoft declares _m_prefetch to take a const void*, but _m_prefetchw to take a /volatile/ const void*. I can't think of any downside to just ca

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin updated this revision to Diff 361639. cor3ntin added a comment. Herald added a project: clang-tools-extra. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106577/new/ https://reviews.llvm.org/D106577 Files: clang-tools-extra/te

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. @fhahn addressed your broadcast comment. Would you prefer that I create the initialisation implementation patch before we get this in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

MaskRay added a comment. I remember that we even converted some `*.md` to `*.rst` to remove the number of supported documentation formats, so I agree that adding support the even less used `*.docx` may not be the proper direction. Thanks for splitting this off. Repository: rG LLVM Github Mo

Re: [PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

Sorry, commented on incorrect patch. On Mon, Jul 26, 2021 at 2:34 PM Saurabh Jha via Phabricator < revi...@reviews.llvm.org> wrote: > SaurabhJha added a comment. > > @fhahn addressed your broadcast comment. Would you prefer that I create > the initialisation implementation patch before we get thi

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

anjankgk added a comment. Gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106688/new/ https://reviews.llvm.org/D106688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D106791: [clang-cl] Expose -fmodules and related flags in the driver (PR43391)

hans created this revision. hans added reviewers: thakis, rnk. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. I don't know how well this works with clang-cl, but people want to try it out, and I think we want to make it work, so exposing th

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:304 + +def pp_pragma_include_instead_not_sysheader : Error< + "'#pragma clang include_instead

[clang] 8160016 - [OpenCL] Change default standard version to CL1.2

Author: Anastasia Stulova Date: 2021-07-26T15:04:34+01:00 New Revision: 81600160b3f926746d02c52003d81180941fe9d0 URL: https://github.com/llvm/llvm-project/commit/81600160b3f926746d02c52003d81180941fe9d0 DIFF: https://github.com/llvm/llvm-project/commit/81600160b3f926746d02c52003d81180941fe9d0.d

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81600160b3f9: [OpenCL] Change default standard version to CL1.2 (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: c

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

amyk added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15111 +if (IsLE) { + Constant *Zero = llvm::Constant::getNullValue(ResTy); + SmallVector Consts; Maybe we can pull out this line and do the following: ``` Constant *Zero = llvm:

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361646. kadircet added a comment. - Preserve no diagnostic behaviour in case of an empty driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/inclu

[clang] 4761321 - [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

Author: Gabor Marton Date: 2021-07-26T16:27:23+02:00 New Revision: 4761321d49db01dce1e308f900add033cc26fb47 URL: https://github.com/llvm/llvm-project/commit/4761321d49db01dce1e308f900add033cc26fb47 DIFF: https://github.com/llvm/llvm-project/commit/4761321d49db01dce1e308f900add033cc26fb47.diff

[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4761321d49db: [Analyzer][solver][NFC] print constraints deterministically (ordered by their… (authored by martong). Changed prior to commit: https

[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

martong added a comment. In D106642#2900397 , @NoQ wrote: > Thanks! > > You got me thinking whether two symbols can have the same dump. We definitely > don't want this to happen but there's also no reason to believe it doesn't, > given that this wouldn'

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat created this revision. Herald added a subscriber: xazax.hun. werat requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The encoding used for opening files depends on the OS and might be different from UTF-8 (e.g. on Windows it

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, kerbowa, guansong, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. T

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jdoerfert added a comment. We need a driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106793/new/ https://reviews.llvm.org/D106793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361656. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D106794: Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Set driver mode before parsing

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

nemanjai updated this revision to Diff 361658. nemanjai added a comment. Cleaned up some of the control flow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 Files: clang/include/clang/Basic/BuiltinsPPC

[clang] 3274cdc - [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

Author: Shilei Tian Date: 2021-07-26T11:00:44-04:00 New Revision: 3274cdc83ecdf2af569ad4f564d55d0e43b1072e URL: https://github.com/llvm/llvm-project/commit/3274cdc83ecdf2af569ad4f564d55d0e43b1072e DIFF: https://github.com/llvm/llvm-project/commit/3274cdc83ecdf2af569ad4f564d55d0e43b1072e.diff L

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3274cdc83ecd: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1 (authored by tianshilei1992). Repository: rG LLVM Github Monor

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 updated this revision to Diff 361667. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106793/new/ https://reviews.llvm.org/D106793 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/

[PATCH] D106796: [clangd] Record remote index usage

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a gauage metric that se

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

aaron.ballman added a comment. Thank you for working on this, I think it's really useful functionality! Comment at: clang/docs/LanguageExtensions.rst:3875 + #define MIN(x, y) x < y ? x : y + #pragma clang deprecated("MIN", "use std::min instead") + Rather t

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaron.ballman added a comment. This seems reasonable to me, but I leave it to @delesley for the final sign-off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. In D106005#2896080 , @SaurabhJha wrote: > In D106005#2895716 , @fhahn wrote: > >> Thank you very much for working on this! Are you planning on implementing >> the new specification as well

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

DylanFleming-arm updated this revision to Diff 361675. DylanFleming-arm added a comment. Added getVScaleRange interface to TargetInfo and removed related AArch64 specific code from CodeGenFunction.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the always inline attribute to the outlined fun

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz added a comment. Will update the patch later today with your feedback. Comment at: clang/docs/LanguageExtensions.rst:3875 + #define MIN(x, y) x < y ? x : y + #pragma clang deprecated("MIN", "use std::min instead") + aaron.ballman wrote: > Rather than

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This is amazing and I think we should land this and see how it goes. Comment at: clang/test/Analysis/self-assign.cpp:1 -// RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=cor

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Anastasia added a comment. Generally LGTM, but I think we should guard the `else` blocks with CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards because the spec says: The C11 style atomic functions in this sub-section require support for OpenCL 2.0 or newer. Howev

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

sdesmalen added a comment. You'll want to rebase your patch on top of latest main, since D105432 moved around the call to `getMaxVScale()` in AArch64TargetTransformInfo.cpp. Comment at: clang/lib/Basic/Targets/AArch64.cpp:433 + } + if (has

[clang] e8a64e5 - [clang][pp] adds '#pragma include_instead'

Author: Christopher Di Bella Date: 2021-07-26T16:07:45Z New Revision: e8a64e5491260714c79dab65d1aa73245931d314 URL: https://github.com/llvm/llvm-project/commit/e8a64e5491260714c79dab65d1aa73245931d314 DIFF: https://github.com/llvm/llvm-project/commit/e8a64e5491260714c79dab65d1aa73245931d314.dif

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a64e549126: [clang][pp] adds '#pragma include_instead' (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3875 + #define MIN(x, y) x < y ? x : y + #pragma clang deprecated("MIN", "use std::min instead") + beanz wrote: > aaron.ballman wrote: > > Rather than use a string literal, did

[PATCH] D106715: Thread safety analysis: Drop special block handling

aaron.ballman added a comment. I think this looks reasonable, but @delesley should weigh in. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2415 bool LocksetInitialized = false; SmallVector SpecialBlocks; for (CFGBlock::const_pred_iterator PI = CurrBlock->pred_b

[clang] 240dde9 - [PowerPC] Change altivec indexed load/store builtins argument type

Author: Qiu Chaofan Date: 2021-07-27T00:26:50+08:00 New Revision: 240dde948252ab9ef0428c46ca578c06127d3799 URL: https://github.com/llvm/llvm-project/commit/240dde948252ab9ef0428c46ca578c06127d3799 DIFF: https://github.com/llvm/llvm-project/commit/240dde948252ab9ef0428c46ca578c06127d3799.diff L

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG240dde948252: [PowerPC] Change altivec indexed load/store builtins argument type (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

qiucf added a comment. In D106530#2903938 , @nemanjai wrote: > LGTM. Thanks for fixing this. > I am just curious, was this revealed from a real world test that used an > offset that is so large that it doesn't fit into 32 bits? No :-) It's found in back

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1970 +OpenCL v1.0 s2.3.12 +`_. + I think we should migrate this description into here for now and make this

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added a comment. I would like @svenvh to take a look from the clang header's design point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 ___ cfe-com

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff created this revision. sepavloff added reviewers: efriedma, kpn, thopre, jonpa, cameron.mcinally, RKSimon, craig.topper. Herald added a subscriber: mgorny. sepavloff requested review of this revision. Repository: rT test-suite https://reviews.llvm.org/D106804 Files: SingleSource/U

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

lei accepted this revision. lei added a comment. thx for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D100582: [WIP][OpenMP][Offloading] New device runtime library - Not for review

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Herald added a subscriber: ormris. We're moving to D106803 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100582/new/ https://reviews.llvm.or

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

ye-luo added a comment. Not clear from the summary what is the new driver option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106793/new/ https://reviews.llvm.org/D106793 ___ cfe-commits mailing list c

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

amyk accepted this revision. amyk added a comment. Thanks for addressing the comment and adding back the tests! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 _

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

jansvoboda11 added a comment. Sorry, I'm not sure I follow. In D105881#2890134 , @awarzynski wrote: > Apologies, it has taken me a bit longer to get back to this. @jansvoboda11 , > now I'm realising the key disadvantage of using `OptInFFlag/OptOutFFlag

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. Perhaps a reasonable path forward here to address the BSD issue can be to add a targetinfo method: /* Returns true if the expected encoding of wchar_t changes at runtime depending on locale for this target. Note that clang always encodes wide character liter

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff updated this revision to Diff 361707. sepavloff added a comment. Updated patch - Rebased, - Applied small enhancement to integer implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. I tested this patch downstream on Windows with Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64 I used c++20, x++latest default and c++17 with the stl header files (standa

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

JonChesterfield added a comment. Can we call this something other than new? We don't tend to remove command line arguments and this won't make much sense once it's the only runtime. I'd be inclined to add an argument called 'use_legacy_runtime' or similar, which defaults to true Repository:

[PATCH] D104854: Introduce intrinsic llvm.isnan

tschuett added inline comments. Comment at: llvm/docs/LangRef.rst:20983 + +These functions get properties of floating point values. + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:229 + options::OPT_fno_openmp_target_new_runtime, false)) +BitcodeSuffix = "new-amdgcn-" + GPUArch; + else Likewise here, how about amdgcn

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam created this revision. saiislam added reviewers: jdoerfert, yaxunl, grokos. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Earlier BundleEntryID used to be --. This used to work because the clang-offload-bundler

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2886328 , @efriedma wrote: >> The options '-ffast-math' and '-fno-honor-nans' imply that FP operation >> operands are never NaNs. This assumption however should not be applied >> to the functions that check FP number

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff updated this revision to Diff 361718. sepavloff added a comment. Fixed documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added inline comments. Comment at: llvm/docs/LangRef.rst:20983 + +These functions get properties of floating point values. + tschuett wrote: > Fixed, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra added a comment. In D106401#2903114 , @nikic wrote: > Would the variant of the original patch at D106769 > be sufficient for your purposes? Or are > you also interested in the optimizations that introduce new memse

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. In D106005#2904424 , @fhahn wrote: > In D106005#2896080 , @SaurabhJha > wrote: > >> In D106005#2895716 , @fhahn wrote: >> >>> Thank you very m

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. In D105821#2903606 , @RedDocMD wrote: > The following code **emits** a warning for leaked memory: > ... > Why does the following command not display the warnings? Wait, what's the difference between this command and the command that

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 added a comment. In D106793#2904661 , @ye-luo wrote: > Not clear from the summary what is the new driver option. It's a rewrite of the current device runtime. This option will enable it. In D106793#2904771

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri added a subscriber: efriedma. lebedev.ri added a comment. @rsmith @efriedma ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105728/new/ https://reviews.llvm.org/D105728 ___ cfe-commits mail

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

rsmith added a comment. In D106577#2904078 , @aaron.ballman wrote: > In D106577#2902091 , @jyknight > wrote: > >> In D106577#2901654 , @rsmith wrote: >> >>> I think this

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 361734. tstellar added a comment. Add test case for local symbols and reformat version script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CM

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

v.g.vassilev created this revision. v.g.vassilev added reviewers: teemperor, rsmith, lhames, hfinkel, sgraenitz. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. We have the basic infrastructure in place. We can recover from simple errors (recovering from errors

  1   2   >