Re: [clang] c411c1b - Fix missing qualifier in template type diffing

Perhaps the test case could be stripped down a bit? template class Array {}; template class S {}; template Array Make(); void Call() { Array> v = Make>(); } Seems to exhibit the same issue, by the looks of it. On Mon, Aug 16, 2021 at 6:38 PM via cfe-commits wrote: > > Author:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added subscribers: samitolvanen, pcc. v.g.vassilev added a comment. In D96033#2948243 , @leonardchan wrote: >> @leonardchan, @phosek, I am not aware of such flag. Do you know how much >> memory does LTO + clang-repl consume and would it make

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG198e6771e24f: [analyzer] Add option to SATest.py for extra checkers (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 198e677 - [analyzer] Add option to SATest.py for extra checkers

Author: Deep Majumder Date: 2021-08-17T10:42:57+05:30 New Revision: 198e6771e24fb5d8d9f3b155445ecc2a4f211004 URL: https://github.com/llvm/llvm-project/commit/198e6771e24fb5d8d9f3b155445ecc2a4f211004 DIFF: https://github.com/llvm/llvm-project/commit/198e6771e24fb5d8d9f3b155445ecc2a4f211004.diff

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. It seems we need not adding this test, since a similiar test is added in https://reviews.llvm.org/rGb31199bab4865deef4e778d7a028c8ec64285654 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

This revision was automatically updated to reflect the committed changes. Closed by commit rGb31199bab486: [AVR][clang] Improve search for avr-libc installation path (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/

[clang] b31199b - [AVR][clang] Improve search for avr-libc installation path

Author: Ben Shi Date: 2021-08-17T11:51:35+08:00 New Revision: b31199bab4865deef4e778d7a028c8ec64285654 URL: https://github.com/llvm/llvm-project/commit/b31199bab4865deef4e778d7a028c8ec64285654 DIFF: https://github.com/llvm/llvm-project/commit/b31199bab4865deef4e778d7a028c8ec64285654.diff LOG:

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

tstellar added a comment. > Not all downstream users may want to build all tools shipped with clang. > clang-repl for us in particular can sometimes lead to flaky builds when > testing a toolchain built with LTO. Can we just fix clang-repl instead? I think there needs to be a more compelling

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

jyknight added a comment. It appears as though this commit was reverted in Apple's XCode Clang fork -- the behavior currently in XCode matches the behavior of upstream Clang prior to this patch. Presuming that's correct, I think we should revert this upstream as well. There doesn't seem to be

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/

[clang] c411c1b - Fix missing qualifier in template type diffing

Author: Weverything Date: 2021-08-16T18:34:18-07:00 New Revision: c411c1bd7f7d3550d24333f80980c0be6481d34a URL: https://github.com/llvm/llvm-project/commit/c411c1bd7f7d3550d24333f80980c0be6481d34a DIFF: https://github.com/llvm/llvm-project/commit/c411c1bd7f7d3550d24333f80980c0be6481d34a.diff

[PATCH] D67149: Fix argument order for BugType instation for

MTC added a comment. Herald added a subscriber: martong. Hi @NoQ, sorry to bother you. This patch has been on hold for a very long time. It should not have been fixed yet. What's next? Abandon the patch, or improve it yourself? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

bcain created this revision. bcain added reviewers: sidneym, kparzysz. bcain added a project: clang. Herald added subscribers: s.egerton, simoncook. bcain requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108178 Files:

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); +

[PATCH] D107296: Treat inttypes.h as a built-in header

vsapsai added a comment. In general it is correct but there is no test case. I have a test case but it fails for other reasons. And I wasn't able to find time to address these "other reasons". I'll post my version of the test case soon. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

leonardchan added a comment. > @leonardchan, @phosek, I am not aware of such flag. Do you know how much > memory does LTO + clang-repl consume and would it make sense to ping some of > the LTO folks for their advice? I played around a bit with adding a flag and it turned out to be not as

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed4a94d6451: [clang] Expose unreachable fallthrough annotation warning (authored by nathanchance). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: clang/CMakeLists.txt:468 +option(CLANG_BUILD_CLANG_REPL_DEFAULT "Build clang-repl by default." OFF) + Apart from name bikeshedding, it's more likely we'll want this

[clang] 9ed4a94 - [clang] Expose unreachable fallthrough annotation warning

Author: Nathan Chancellor Date: 2021-08-16T17:14:55-07:00 New Revision: 9ed4a94d6451046a51ef393cd62f00710820a7e8 URL: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 DIFF:

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan created this revision. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Not all downstream users may want to build all tools shipped with clang. `clang-repl` for us in particular can sometimes lead to flaky builds

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common (1/8)

bcain updated this revision to Diff 366766. bcain retitled this revision from "add sanitizer support to hexagon" to "[sanitizer] Add hexagon support to sanitizer-common (1/8)". bcain edited the summary of this revision. bcain added a comment. Decomposed to just the sanitizer-common portion. Now

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added a comment. > Can we either emit that [`a &= foo()`] as a suggestion if the code looks like > `a = a & foo()`? Or simply not emit a warning? The problem is that if `a` is boolean, then `a = a & something` is 99% for sure a typo — 99% of the time, the programmer meant `a = a &&

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith added inline comments. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] arichardson wrote: > jansvoboda11 wrote: > >

[clang] d8a08fa - Clean up test for -f{, no-}implicit-modules-uses-lock

Author: Duncan P. N. Exon Smith Date: 2021-08-16T16:23:04-07:00 New Revision: d8a08fae0af9aa09c108b3e7c60f192249dd2098 URL: https://github.com/llvm/llvm-project/commit/d8a08fae0af9aa09c108b3e7c60f192249dd2098 DIFF:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 366760. a.elovikov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Another version. My main goal here is to gradually move more stuff from clang/ to llvm/ so I'm open to other suggestions in doing so. Repository:

[PATCH] D107296: Treat inttypes.h as a built-in header

dexonsmith resigned from this revision. dexonsmith added reviewers: bruno, vsapsai. dexonsmith added subscribers: bruno, vsapsai. dexonsmith added a comment. @bruno or @vsapsai, any chance one of you knows whether this is correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947914 , @vitalybuka wrote: > Do we have public bot for hexagon? I think we have one intended to for checking hexagon-unknown-elf and perhaps not one for hexagon-unknown-linux-musl. I believe that only the Linux

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947907 , @vitalybuka wrote: > Can you cut this into separate peaces, at least patch per sanitizer for "asan > lsan ubsan scudo scudo_standalone cfi safestack"? Sure, that's no problem. While I'm breaking it up, us

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

kile added a comment. Apologies, reporting on the incorrect revision :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 ___ cfe-commits mailing list

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Do we have public bot for hexagon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 ___ cfe-commits mailing list

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Can you cut this into separate peaces, at least patch per sanitizer for "asan lsan ubsan scudo scudo_standalone cfi safestack"? Some common peaces could be probably extracted as well. Comment at:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

cjdb added a comment. @JonasToth, @aaron.ballman suspects that there's enough overlap between this patch and D107873 to consider merging the two efforts. I'm happy to collaborate, but we should probably check that our goals are aligned. Are you active on the

[clang] f22ba51 - [Remarks] Emit optimization remarks for atomics generating CAS loop

Author: Anshil Gandhi Date: 2021-08-16T14:56:01-06:00 New Revision: f22ba51873509b93732015176b778465f40c6db5 URL: https://github.com/llvm/llvm-project/commit/f22ba51873509b93732015176b778465f40c6db5 DIFF: https://github.com/llvm/llvm-project/commit/f22ba51873509b93732015176b778465f40c6db5.diff

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance updated this revision to Diff 366733. nathanchance marked an inline comment as not done. nathanchance edited the summary of this revision. nathanchance added a comment. - Update commit message (forgot to use `arc diff --edit --verbatim`) [David] Repository: rG LLVM Github

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added a comment. The order in X86Parser.def is determined by how bits are allocated in to feature vector in libgcc. They're not in any priority order that I know of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Ah, thanks for the details! On Mon, Aug 16, 2021 at 1:26 PM Kostya Kortchinsky wrote: > Apologies. > As explained in another thread, this was a mistake of mine as I reverted 2 > CLs instead of 1 (mine). > This was resolved with the original author. > My own CL ended up breaking some 32-bit

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Apologies. As explained in another thread, this was a mistake of mine as I reverted 2 CLs instead of 1 (mine). This was resolved with the original author. My own CL ended up breaking some 32-bit builders. On Mon, Aug 16, 2021 at 1:22 PM David Blaikie wrote: > Please include in the commit

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Please include in the commit message a reason for a revert. On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kostya Kortchinsky > Date: 2021-08-16T11:13:05-07:00 > New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384 > > URL:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93d08acaacec: [clang-offload-wrapper] Add standard notes for ELF offload images (authored by vzakhari). Repository: rG LLVM Github Monorepo

[clang] 93d08ac - [clang-offload-wrapper] Add standard notes for ELF offload images

Author: Vyacheslav Zakharin Date: 2021-08-16T13:09:01-07:00 New Revision: 93d08acaacec951dbb302f77eeae51974985b6b2 URL: https://github.com/llvm/llvm-project/commit/93d08acaacec951dbb302f77eeae51974985b6b2 DIFF:

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

arsenm accepted this revision. arsenm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

dblaikie added a comment. Patch description probably needs an update - looks like it's out of date ("Add -Wimplicit-fallthrough-unreachable, which is default enabled with -Wimplicit-fallthrough" should read, I guess "Add -Wunreachable-code-fallthrough, which is default enabled with

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 366717. nickdesaulniers added a comment. - reorder diag vs note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 Files: clang/docs/ReleaseNotes.rst

[PATCH] D108150: [Remarks] Emit optimization remarks for atomics generating hardware instructions

rampitec added a comment. - Add [AMDGPU] to the title. - Rebase on top of D106891 . - Add tests to atomics-remarks-gfx90a.ll as well, including LDS with matching and non-matching rounding mode. Comment at:

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2947255 , @ASDenysPetrov wrote: > In D104285#2943449 , @aaron.ballman > wrote: > >> One thing I think is worth asking in this thread is whether what you're >>

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2944625 , @phosek wrote: > In D96033#298 , @leonardchan > wrote: > >> We're still hitting the OOMs when building clang-repl with LTO even with >>

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added a comment. Are these in the same order in X86TargetParser.Def? Can we make some comment in that file to make sure that we keep them in the order (see comment in original x86Target.def)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: pengfei. a.elovikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...instead of redeclaring them in clang's own

[PATCH] D108150: [Remarks] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 created this revision. gandhi21299 added reviewers: rampitec, arsenm, b-sumner. Herald added subscribers: foad, kerbowa, jfb, hiraditya, Anastasia, nhaehnle, jvesely. gandhi21299 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Will do, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec accepted this revision. rampitec added a comment. LGTM, but please wait for others too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366683. gandhi21299 added a comment. - ORE does not need to be a pointer anymore, it is constructed as local variable with this patch as requested by reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108074: [MemorySSA] Remove unnecessary MSSA dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG570c9beb8ebb: [MemorySSA] Remove unnecessary MSSA dependencies (authored by nikic). Herald added subscribers: cfe-commits, ormris, steven_wu. Herald

[clang] 570c9be - [MemorySSA] Remove unnecessary MSSA dependencies

Author: Nikita Popov Date: 2021-08-16T20:40:55+02:00 New Revision: 570c9beb8ebb4bdcc807101518cc36ad5e20797c URL: https://github.com/llvm/llvm-project/commit/570c9beb8ebb4bdcc807101518cc36ad5e20797c DIFF: https://github.com/llvm/llvm-project/commit/570c9beb8ebb4bdcc807101518cc36ad5e20797c.diff

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

aeubanks added a comment. In D108003#2944714 , @xbolva00 wrote: > In D108003#2944178 , @aeubanks > wrote: > >> I ran this over Chrome and ran into a use case that looks legitimate. It >> seems like the pattern

[PATCH] D108073: [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a031449b2c7: [PassBuilder] Dont use MemorySSA for standalone LoopRotate passes (authored by nikic). Herald added a project: clang. Herald added a

[clang] 0a03144 - [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes

Author: Nikita Popov Date: 2021-08-16T20:34:18+02:00 New Revision: 0a031449b2c757400090b23bd6ddf4d896d32643 URL: https://github.com/llvm/llvm-project/commit/0a031449b2c757400090b23bd6ddf4d896d32643 DIFF: https://github.com/llvm/llvm-project/commit/0a031449b2c757400090b23bd6ddf4d896d32643.diff

[PATCH] D108083: add sanitizer support to hexagon

sidneym added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { bcain wrote: > @sidneym Can you confirm that this

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

kile added a comment. Hi Petr, This looks to be the change that most likely broke a test on Windows Debug - would you mind taking a look? Here's the relevant test and stack trace: FAIL: LLVM :: Instrumentation/InstrProfiling/linkage.ll (56524 of 77140) - TEST 'LLVM ::

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(); auto = TPC->getTM(); rampitec wrote: > gandhi21299 wrote: > > rampitec wrote: > > > Is there a reason to construct it upfront and not just

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(); auto = TPC->getTM(); gandhi21299 wrote: > rampitec wrote: > > Is there a reason to construct it upfront and not just use a local variable >

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(); auto = TPC->getTM(); rampitec wrote: > Is there a reason to construct it upfront and not just use a local variable > only when needed?

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(); auto = TPC->getTM(); Is there a reason to construct it upfront and not just use a local variable only when needed? Like in

[clang] 80ed75e - Revert "[NFC] Fix typos"

Author: Kostya Kortchinsky Date: 2021-08-16T11:13:05-07:00 New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384 URL: https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384 DIFF:

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from… (authored by gAlfonso-bit, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8bc72de - [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

Author: Alfsonso Gregory Date: 2021-08-16T19:07:50+01:00 New Revision: 8bc72dede68ccbbf828c0421276d962d369ba70f URL: https://github.com/llvm/llvm-project/commit/8bc72dede68ccbbf828c0421276d962d369ba70f DIFF:

[clang] b7425e9 - [NFC] Fix typos

Author: Rong Xu Date: 2021-08-16T10:15:30-07:00 New Revision: b7425e956be60a73004d7ae5bb37da85872c29fb URL: https://github.com/llvm/llvm-project/commit/b7425e956be60a73004d7ae5bb37da85872c29fb DIFF: https://github.com/llvm/llvm-project/commit/b7425e956be60a73004d7ae5bb37da85872c29fb.diff LOG:

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 39. gAlfonso-bit added a comment. Rearranged if statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D107296: Treat inttypes.h as a built-in header

markrowe added a comment. @dexonsmith Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107296/new/ https://reviews.llvm.org/D107296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. In D104285#2943449 , @aaron.ballman wrote: > One thing I think is worth asking in this thread is whether what you're > analyzing is undefined behavior? Technically you are right. Every exit out of an array extent is UB

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. I'm not sure i'm sold on this, even though i'm aware that selects hurt vectorization. How does this Simplify the CFG? I think it would be best to teach LV selects, or at worst do this in LV itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. In D107719#2946159 , @c-rhodes wrote: > In D107719#2945656 , @gAlfonso-bit > wrote: > >> Not sure about the timing of base patch, but maybe this patch is also >> candidate for llvm

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947080 , @jyu2 wrote: >>> I am not sure I can do that. Do you mean when generate map adding coding >>> code to look though reduction clause and generate map for it? > > > >> Yes, exactly. > > We are missing mappable

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. >> I am not sure I can do that. Do you mean when generate map adding coding >> code to look though reduction clause and generate map for it? > Yes, exactly. We are missing mappable checking for example: #pragma omp target parallel for reduction(task, +: b[0:2][2:4][1])

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947053 , @jyu2 wrote: > Hi ABataev, > Thanks for reviedw. > > In D108132#2946927 , @ABataev wrote: > >> Why it can not be performed in codegen? > > I am not sure I can do

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Hi ABataev, Thanks for reviedw. In D108132#2946927 , @ABataev wrote: > Why it can not be performed in codegen? I am not sure I can do that. Do you mean when generate map adding coding code to look though reduction clause and

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I think this is incremental progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

kmclaughlin created this revision. kmclaughlin added reviewers: david-arm, fhahn, dmgreen, craig.topper, lebedev.ri. Herald added subscribers: ctetreau, ormris, wenlei, steven_wu, hiraditya, kristof.beyls. kmclaughlin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. @RKSimon could you commit for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

aaron.ballman added a comment. It seems like there may be some considerable overlap between this check and the one proposed in https://reviews.llvm.org/D54943. I know the other check is more about C++ Core Guidelines so it's not perfect overlap. But I do wonder if it'd make sense to combine

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. The code looks great, I don't see any major problems. We still need tests, I can't stress this enough. All the real-world cornercases you've covered here as you updated the patch deserve a test case. Some of these changes should probably be separated into other patches,

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. OK then we can just merge this in main only then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Also, would be good to see a runtime test, which reveals the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Why it can not be performed in codegen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); +

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 366630. pengfei added a comment. 1. Address Yuanke's comments. 2. Add missed strict FP handling. 3. Refactor the repeated declarations for strict FP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. A new rule is added in 5.0: If a list item appears in a reduction, lastprivate or linear clause on a combined

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. @mizvekov Thanks for the help! I recently got commit access, so I think I can commit this myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732

[clang] 2d3668c - [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Author: Kristóf Umann Date: 2021-08-16T16:19:00+02:00 New Revision: 2d3668c997faac1f64cd3b8eb336af989069d135 URL: https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135 DIFF: https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135.diff

[PATCH] D104975: Implement P1949

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1622-1623 + + const bool isIDStart = isAllowedInitiallyIDChar(CodePoint, LangOpts); + const bool isIDContinue = isIDStart || isAllowedIDChar(CodePoint, LangOpts); +

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > Since the other branch has never been used I wonder if we should just remove > it instead? I don't think removing the other branch entirely is a good approach because

[clang] c019142 - [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Author: Kristóf Umann Date: 2021-08-16T15:03:22+02:00 New Revision: c019142a89b477cd247434c1d8f571662d26e19d URL: https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d DIFF: https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d.diff

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc019142a89b4: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract… (authored by Szelethus). Repository: rG LLVM Github

  1   2   >