[clang] d280a76 - [Driver][Linux] Fix regression when -DLIBCXX_LIBDIR_SUFFIX=64

Author: Lin Sun Date: 2021-08-25T23:50:17-07:00 New Revision: d280a76908e841da9e956a113d219e35247272bf URL: https://github.com/llvm/llvm-project/commit/d280a76908e841da9e956a113d219e35247272bf DIFF: https://github.com/llvm/llvm-project/commit/d280a76908e841da9e956a113d219e35247272bf.diff LOG:

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd280a76908e8: [Driver][Linux] Fix regression when -DLIBCXX_LIBDIR_SUFFIX=64 (authored by Lin Sun , committed by MaskRay). Changed

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6da811fd5c71: [clang][deps] Reset non-modular language and preprocessor options (authored by jansvoboda11). Changed prior to commit: https://revie

[clang] 6da811f - [clang][deps] Reset non-modular language and preprocessor options

Author: Jan Svoboda Date: 2021-08-26T08:43:21+02:00 New Revision: 6da811fd5c7158eecaf25f0e417131f2e7dfb35f URL: https://github.com/llvm/llvm-project/commit/6da811fd5c7158eecaf25f0e417131f2e7dfb35f DIFF: https://github.com/llvm/llvm-project/commit/6da811fd5c7158eecaf25f0e417131f2e7dfb35f.diff L

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki planned changes to this revision. linjamaki added a comment. Thanks. I will make a patch for adding spirv triples and new target info and update this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D10

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @rsmith ping again. Could you help take a look at this patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 ___ cfe-com

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +if (OSLibDir != "lib") { + addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); drop

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin marked an inline comment as done. sunlin added a comment. Hi @MaskRay , The patch is updated as your comment. Please review again. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin updated this revision to Diff 368812. sunlin added a comment. Update for do not add duplicate path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 Files: clang/lib/Driver/ToolChains/Linux.cpp I

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki added a comment. Thanks for the review. In an upcoming HIPSPV patch there will be a test that depends on this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367 ___

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added a comment. We have llvm::DINode::DIFlags CGDebugInfo::getCallSiteRelatedAttrs() const { // Call site-related attributes are only useful in optimized programs, and // when there's a possibility of debugging backtraces. if (!CGM.getLangOpts().Optimize || DebugKind

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); + } MaskRay wrote: > Add `if (OSLibDir != "lib")` thumbs up. Repos

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Eh, sure, don't mind about the test either way (the other test cases are optimization agnostic, I think - so they could all be lumped in together - there might also be a flag to turn on ca

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song updated this revision to Diff 368805. yonghong-song added a comment. - rename test file names properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106618/new/ https://reviews.llvm.org/D106618 Files: clang/lib/CodeGen/CGDebugInfo.

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added inline comments. Comment at: clang/test/CodeGen/attr-btf_tag-disubprogram-2.c:5-14 +#define __tag2 __attribute__((btf_tag("tag2"))) + +struct t1 { + int a; +}; + +extern int __tag1 __tag2 foo(struct t1 *); dblaikie wrote: > Any particular rea

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); +

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham updated this revision to Diff 368798. bnbarham marked 2 inline comments as done. bnbarham added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updated error handling and added the clang-format `#include` changes in. Repository: rG LLVM Github Monor

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. @MaskRay Any more questions for this line change? Thanks : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 ___ cfe-commits mailing lis

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:160 + // enabled. + I = Features.find("sse4.2"); + if (I != Features.end() && I->getValue() && craig.topper wrote: > I guess I don't understa

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368795. tianqing marked an inline comment as done. tianqing added a comment. Use existing code in X86.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files: cl

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie added inline comments. Comment at: clang/test/CodeGen/attr-btf_tag-disubprogram-2.c:5-14 +#define __tag2 __attribute__((btf_tag("tag2"))) + +struct t1 { + int a; +}; + +extern int __tag1 __tag2 foo(struct t1 *); Any particular reason this needs to be sp

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:160 + // enabled. + I = Features.find("sse4.2"); + if (I != Features.end() && I->getValue() && I guess I don't understand why this is coded differently than mmx, popcnt, and xsave

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:158 + // Enable CRC32 if SSE4.2 is enabled and CRC32 is not explicitly set. + I = Features.find("sse4.2"); craig.topper wrote: > Why doesn't

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368793. tianqing added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files: clang/docs/ClangCommandLineReference.rst clang/

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Allowing multiple PartialDiagnostic to be in-flight/delayed is a nice goal but it's not clear if it's worth it. Also I'm not sure it is worth investing into making delayed diagnostic easier

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. Then I'm OK with this change. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset Imp

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:106 + assert(RVVBitsMin % 128 == 0 && + "RVV requires vector length in multiples of 128!"); + assert(RVVBitsMax % 128 == 0 && RISC-V require VLEN in power of 2, m

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; ---

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song updated this revision to Diff 368789. yonghong-song added a comment. - add annotations to DISubprogram generated for extern functions called in the current cu and add a test for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1066

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added a comment. In D106618#2965546 , @dblaikie wrote: > The clang side might benefit from a test with a function declaration, a call > to that function, but no definition of it - with optimizations enabled, clang > should emit the DISubpr

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham updated this revision to Diff 368781. bnbarham added a comment. Ended up just using DiagnosticError and reading the args from PartialDiagnostic. Still not really happy with this, but I think the alternative of allowing multiple in-flight diagnostics should be a separate PR regardless (

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin created this revision. Herald added a subscriber: dexonsmith. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to The Unicode standard, line feed and vertical tab should be considered line breaks. See notably htt

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc05d30e444a1: [clang][Emscripten] Define __unix family of macros (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] c05d30e - [clang][Emscripten] Define __unix family of macros

Author: Sam Clegg Date: 2021-08-25T19:24:47-04:00 New Revision: c05d30e444a1208a8a872002d1146b5cf55e370a URL: https://github.com/llvm/llvm-project/commit/c05d30e444a1208a8a872002d1146b5cf55e370a DIFF: https://github.com/llvm/llvm-project/commit/c05d30e444a1208a8a872002d1146b5cf55e370a.diff LOG

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422-423 -ExprResult ArgExpr( -Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); +ExprResult ArgExpr(Actions.CorrectDelayedTyposInExpr( +ParseAttribut

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri added a comment. Thanks everyone! I don't expect that there will be any further feedback, so i plan on landing this tomorrow, unless there is further feedback before then. Comment at: llvm/test/CodeGen/MIR/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass=none

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

amyk accepted this revision as: amyk. amyk added a comment. We wanted `vec_clr_first` to translate to vclrrb for LE, and to vclrlb for BE, and the opposite mapping for `vec_clr_last`, so I think this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

sbc100 added a comment. Landing this will allow us to land https://github.com/emscripten-core/emscripten/pull/14953 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108735/new/ https://reviews.llvm.org/D108735 ___

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

sbc100 created this revision. Herald added subscribers: wingo, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This will allow us to remove these from the downstream driver: https://github.com/emscripten-core/emscrip

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexId

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 368746. cor3ntin added a comment. Fix comments following Aaron's feedback, remove braces deemed unecessary by the guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368744. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Add `-march=x86-64` that i forgot :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D10866

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added inline comments. Comment at: llvm/test/CodeGen/MIR/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass=none -o - %s | FileCheck %s + Needs to add -march/-mtriple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri added a comment. @arsenm are you happy with the test coverage here? In D108661#2963519 , @craig.topper wrote: > Wild speculation. This may be a historical artifact of LoadInst and StoreInst > having their getAlignment() function written like

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3d029fbe09: Effectively revert 33c3d8a916c / D33782 (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D108720?vs=368693&id=36

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108702/new/ https://reviews.llvm.org/D108702 _

[clang] db3d029 - Effectively revert 33c3d8a916c / D33782

Author: Reid Kleckner Date: 2021-08-25T14:41:26-07:00 New Revision: db3d029fbe09925ea42a3279b1abb244fa547cff URL: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff DIFF: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff.diff

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

jdoerfert added a comment. Seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368722. lebedev.ri added a comment. Address rest of nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 Files: clang/include/clang/Sema/Sema.h clang/test/CXX

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#2964740 , @aaron.ballman wrote: > In D108643#2964190 , @rjmccall > wrote: > >> I agree with James; I know you've reached out to the Itanium ABI group about >> mangling, but

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368719. lebedev.ri added a comment. @arsenm i do not understand how i can avoid having IR there, but addressed other nits. thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 5 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368716. stevewan marked an inline comment as done. stevewan added a comment. Avoid unannotated fall-through between cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107

[clang] 9dc92bb - [OpenCL][NFC] Fix code example in __remove_address_space documentation.

Author: Justas Janickas Date: 2021-08-25T21:24:32+01:00 New Revision: 9dc92bba6c742216096e33402a1a8aebf5ca48b7 URL: https://github.com/llvm/llvm-project/commit/9dc92bba6c742216096e33402a1a8aebf5ca48b7 DIFF: https://github.com/llvm/llvm-project/commit/9dc92bba6c742216096e33402a1a8aebf5ca48b7.dif

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added inline comments. Comment at: llvm/test/CodeGen/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass machine-cp -o - %s | FileCheck %s + Should use -run-pass=none, and go in test/CodeGen/MIR/X86 Comment at: llvm/test/CodeGen/X86/

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM with after adding a comment to the testcase. Thanks for explaining! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108710/new/ https

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

rnk added a comment. In D108720#2965642 , @zero9178 wrote: > Just a heads up, the patch added `/permissive` and `/permissive-`, but made > neither the default as to not be a breaking change. That means that clang-cl > still parses operator keywords and

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"command": "clang -fsyntax-only DIR/tu.c -fmodules -fimplicit-module-maps -fmodules-cache-path=DIR/cache -include DIR/header.h -o DIR/tu

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: jfb. aaron.ballman added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; cor3ntin wrote: > aaron.ballman wrote:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > stevew

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Re-requesting review, since the test does cover the changes to `ModuleDepCollector.cpp`. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"co

[PATCH] D108308: [WIP] Cleanup identifier parsing.

aaron.ballman added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:701 // Helper functions to lex the remainder of a token of the specific type. + bool LexIdentifierContinue(Token &Result, const char *CurPtr); Something like this then? Repos

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexIdentifierContinue(Token &Result, const char

[PATCH] D108308: [WIP] Cleanup identifier parsing.

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. In general, I'm in favor of these changes. They help identify (pun *totally* intended) where we're improperly expecting ASCII identifiers in places, which can hopefully be addressed i

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368702. stevewan added a comment. Herald added a subscriber: jfb. Add recursive check for typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

zero9178 accepted this revision. zero9178 added a comment. Thanks a lot for the patch :) Wanted this bit of code to be removed for quite some time. > Since D103773 , clang-cl's default mode > completely disables C++ operator > names. That means that query.h com

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems reasonable to me. The changes for `/permissive` and `/permissive-` I think are a better way about this, and now that there is a trivial workaround (`QUERY_H_RESTRICTION_PER

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, minor comments below. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2639-2643 +if (UnrolledCLI) { + OMPLoopNestStack.push_back(UnrolledCLI); +} else {

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

rnk created this revision. rnk added reviewers: zero9178, mibintc, erichkeane. rnk requested review of this revision. Herald added a project: clang. This change would treat the token `or` in system headers as an identifier, and elsewhere as an operator. As reported in llvm.org/pr42427, many users

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. Fixup: https://reviews.llvm.org/D108718 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 ___ cfe-commits mailing list cfe-commit

[clang] ea1c01d - PR51105: look through ConstantExpr when looking for a braced string literal initialization.

Author: Richard Smith Date: 2021-08-25T11:36:11-07:00 New Revision: ea1c01dde03b45e0b33d3883147d3b4fb489978c URL: https://github.com/llvm/llvm-project/commit/ea1c01dde03b45e0b33d3883147d3b4fb489978c DIFF: https://github.com/llvm/llvm-project/commit/ea1c01dde03b45e0b33d3883147d3b4fb489978c.diff

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir added a comment. In D108712#2965433 , @aaron.ballman wrote: > LGTM! There is no way for this to be null because `emitRethrow()` is what > should be called in that case. > > I'll land this on your behalf sometime shortly (perhaps as late as tomo

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie added a comment. The clang side might benefit from a test with a function declaration, a call to that function, but no definition of it - with optimizations enabled, clang should emit the DISubprogram for that function for the purpose of call site DWARF, I think? (or maybe that behavio

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff updated this revision to Diff 368687. sepavloff added a comment. Updated patch - Moved tests into header files. It should facilitate writing tests for various modes (strict exceptions, fast math etc), - Added Makefile, - Enhanced diagnostics if test fails, - Avoid C++, it makes easier

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. I'm getting test failures for the newly added llvm/test/CodeGen/X86/attr-dontcall.ll, thought there's not much info other than > Exit Code: 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://revie

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"command": "clang -fsyntax-only DIR/tu.c -fmo

[clang] 666906a - [test] Fix indention. NFC.

Author: Michael Kruse Date: 2021-08-25T12:48:59-05:00 New Revision: 666906a8032709e59ca6c9fb7b7a5e05cafbd3bf URL: https://github.com/llvm/llvm-project/commit/666906a8032709e59ca6c9fb7b7a5e05cafbd3bf DIFF: https://github.com/llvm/llvm-project/commit/666906a8032709e59ca6c9fb7b7a5e05cafbd3bf.diff

[clang] 66e37c9 - [Preprocessor] Elide empty line(s) at start of file.

Author: Michael Kruse Date: 2021-08-25T12:48:59-05:00 New Revision: 66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7 URL: https://github.com/llvm/llvm-project/commit/66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7 DIFF: https://github.com/llvm/llvm-project/commit/66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7.diff

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There is no way for this to be null because `emitRethrow()` is what should be called in that case. I'll land this on your behalf sometime shortly (perhaps as late as tomorr

[PATCH] D106030: [Clang] add support for error+warning fn attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG846e562dcc6a: [Clang] add support for error+warning fn attrs (authored by nickdesaulniers). Changed prior to commit: https://reviews.llvm.org/D106030?vs=366717&id=368678#toc Repository: rG LLVM Githu

[clang] 846e562 - [Clang] add support for error+warning fn attrs

Author: Nick Desaulniers Date: 2021-08-25T10:34:18-07:00 New Revision: 846e562dcc6a9a611d844dc0d123da95629a0567 URL: https://github.com/llvm/llvm-project/commit/846e562dcc6a9a611d844dc0d123da95629a0567 DIFF: https://github.com/llvm/llvm-project/commit/846e562dcc6a9a611d844dc0d123da95629a0567.di

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane. schittir added a project: clang. schittir requested review of this revision. Herald added a subscriber: cfe-commits. Avoid nullptr dereferencing of 'Constraint'; NFC Klocwork static code analysis exposed this bug

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc4bfd7f59d5: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1070

[clang] cc4bfd7 - [Sema][ObjC] Allow conversions between pointers to ObjC pointers and

Author: Akira Hatanaka Date: 2021-08-25T10:22:29-07:00 New Revision: cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b URL: https://github.com/llvm/llvm-project/commit/cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b DIFF: https://github.com/llvm/llvm-project/commit/cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b.diff

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a number of language and preprocessor options that are reset in the `

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 + +template constexpr const GV &getAMDGPUGridValues() { + static_assert(wavesize == 32 || wavesize == 64, ""); Want to resolve this at compile time for the

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield created this revision. JonChesterfield added reviewers: dpalermo, jdoerfert, tianshilei1992, ronlieb, ye-luo, grokos. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision.

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368663. kstoimenov added a comment. Upload after submitting the main patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrument

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:158 + // Enable CRC32 if SSE4.2 is enabled and CRC32 is not explicitly set. + I = Features.find("sse4.2"); Why doesn't this say "not explicitly disabled" like the others above?

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; ---

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG832aae738bec: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM Github

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368650. kstoimenov added a comment. Updated from the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td l

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. pengfei wrote: > hjl.tools wrot

[clang] e5646b9 - Revert "Revert "[analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs""

Author: Balazs Benics Date: 2021-08-25T17:19:06+02:00 New Revision: e5646b9254e0150e7897bd2658fa0b19eef39070 URL: https://github.com/llvm/llvm-project/commit/e5646b9254e0150e7897bd2658fa0b19eef39070 DIFF: https://github.com/llvm/llvm-project/commit/e5646b9254e0150e7897bd2658fa0b19eef39070.diff

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D107775#2964937 , @dgoldman wrote: > Does this change the behavior of TypePrinter or DeclPrinter - not sure if > there are existing tests for those with ObjC code? I put a case for it in the declprinter so it is handled

[PATCH] D108673: [CodeExtractor] Preserve topological order for the return blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e192ab1f457: [CodeExtractor] Preserve topological order for the return blocks. (authored by vzakhari). Herald added a project: clang. Herald added a

[clang] 2e192ab - [CodeExtractor] Preserve topological order for the return blocks.

Author: Vyacheslav Zakharin Date: 2021-08-25T08:09:01-07:00 New Revision: 2e192ab1f457918484d3f41b9d2271a9dd8a9de3 URL: https://github.com/llvm/llvm-project/commit/2e192ab1f457918484d3f41b9d2271a9dd8a9de3 DIFF: https://github.com/llvm/llvm-project/commit/2e192ab1f457918484d3f41b9d2271a9dd8a9de3

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modifies OpenCL 3.0 optional core feature macro definitions so that the

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;

  1   2   >