[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

steakhal added a comment. 'using' is the same as 'typedef' AFAIK. So, you could simply use only typedefs and implement the test in the c test file. Seeing all the tests close together would aid readability IMO. WDYT Denys? Btw does the SVval::getType return a canonical type in all cases? Reposi

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal accepted this revision. steakhal added a comment. Good work. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list cfe-

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

phosek added a comment. Is this needed even with D110888 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110889/new/ https://reviews.llvm.org/D110889 ___ cfe-commits mai

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376425. kbobyrev added a comment. Rebase on top of main. Now ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/In

[PATCH] D77598: Integral template argument suffix and cast printing

v.g.vassilev added a comment. In D77598#3035449 , @dblaikie wrote: > Came across this while trying to do "simplified template names" - producing > template names in DWARF without template parameter lists as part of the > textual name, then rebuilding tha

[PATCH] D110278: Adding doWithCleanup abstraction

dblaikie added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:553-565 + bool HasBegunSourceFile = false; + std::function Operation = [&]() { +return BeginSourceFileImpl(CI, RealInput, HasBegunSourceFile); + }; + std::function Cleanup = [&]() { +if

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29bb877499ce: [PowerPC] Fix lharx and lbarx builtin signatures (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D110273?vs

[clang] 29bb877 - [PowerPC] Fix lharx and lbarx builtin signatures

Author: Albion Fung Date: 2021-09-30T22:36:13-05:00 New Revision: 29bb877499ce328f8f4a5d61e9bae94e5f97f908 URL: https://github.com/llvm/llvm-project/commit/29bb877499ce328f8f4a5d61e9bae94e5f97f908 DIFF: https://github.com/llvm/llvm-project/commit/29bb877499ce328f8f4a5d61e9bae94e5f97f908.diff L

[PATCH] D110899: [Driver][XRay][test] XFAIL on linux with no environment specified

tstellar created this revision. tstellar added a reviewer: dberris. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110899 Files: clang/test/Driver/XRay/xray-instr

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 8:05 PM Hubert Tong wrote: > > On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits > wrote: >> >> We talked about this with the IWG (Infrastructure Working Group) just >> last week coincidentally. >> Two major blocking tracks that were identified at the roundtable

[PATCH] D77598: Integral template argument suffix and cast printing

dblaikie added a comment. Came across this while trying to do "simplified template names" - producing template names in DWARF without template parameter lists as part of the textual name, then rebuilding that name from the structural representation of template parameters in DWARF (DW_TAG_templa

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We talked about this with the IWG (Infrastructure Working Group) just > last week coincidentally. > Two major blocking tracks that were identified at the roundtable > during the LLVM Dev Meeting exac

[PATCH] D110898: Pass template parameters when printing template argument lists for function templates

dblaikie created this revision. dblaikie added a reviewer: rsmith. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Improve the application of D77598 by passing the template parameter list, allowin

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added a comment. > In principle I agree but did you have this failure mode actually happen? No failure happens for now, but may happen in the future if we continue to use -SAME. Pls read the example I gave in last comment. > Not sure I like crazy long lines, but I see that -NEXT then -

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:33 -// X86_64: note: valid target CPU values are: nocona, core2, penryn, bonnell, -// X86_64-SAME: atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, -// X86_64

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the sign-extending test is added. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-load-store-reversed.ll:52 define dso_local zeroext i16 @

[PATCH] D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Please run clang-format on the patch (only the modified lines). Comment at: clang/lib/Headers/altivec.h:7164 +vec_orc(vector double __a, vector double __b) { + ret

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as you add the back end test. Comment at: clang/test/CodeGen/ppc-mma-types.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

wolfgangp added a comment. In D110783#3035158 , @dyung wrote: > Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot > after your change. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Seems lik

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM with the test nit addressed. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fetch-cas-64bit-only-error.c:1 +// NOTE: Assertions have been autogenerated by uti

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1643 - return Param == Arg? Sema::TDK_Success : Sema::TDK_NonDeducedMismatch; + return ParDesug == ArgDesug ? Sema::TDK_Success + : Sema::TDK_NonDeduc

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin created this revision. mtrofin added a reviewer: aeubanks. Herald added subscribers: ormris, wenlei, hiraditya, eraman. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This also removes the need to disable

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: > > > > On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >> >> Does something like Rust's "bors" bot satisfy the herald rules need? > > > > sorry, maybe I was thinking of the high-five bot. And it looks like that's > not quite a match for herald.

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1643 - return Param == Arg? Sema::TDK_Success : Sema::TDK_NonDeducedMismatch; + return ParDesug == ArgDesug ? Sema::TDK_Success + : Sema::TDK_NonDeduc

Re: [llvm-dev] Phabricator Creator Pulling the Plug

We talked about this with the IWG (Infrastructure Working Group) just last week coincidentally. Two major blocking tracks that were identified at the roundtable during the LLVM Dev Meeting exactly 2 years ago are still an issue today: 1) Replacement for Herald rules. This is what allows us to subs

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 marked an inline comment as done. jcking1034 added inline comments. Comment at: clang/include/clang/AST/ASTTypeTraits.h:472 + assert(ASTNodeKind::getFromNodeKind().isBaseOf(NodeKind)); + return *static_cast(reinterpret_cast(Storage)); +}

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

dyung added a comment. Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot after your change. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1107

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376389. jcking1034 added a comment. Construct an object of the derived type, instead of the base type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files: cla

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: cryptoad, kristof.beyls, mgorny. leonardchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After D110888

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6116 + +- ``skip`` doesn't zero any call-used registers. +- ``used`` only zeros call-used registers used in the function. By ``used``, we void wrote: > nickdesaulniers wrote: > > Might

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. Hmm...not working on Linux sounds bad. I'll investigate. Comment at: clang/include/clang/Basic/AttrDocs.td:6116 + +- ``skip`` doesn't zero any call-used registers. +- ``used`` only zeros call-used registers used in the function. By ``used``, we ---

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 376386. void marked 3 inline comments as done. void added a comment. Fixed some spelling and variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: cla

[PATCH] D98143: [HIP] Diagnose aggregate args containing half types

tra added a comment. In D98143#3034672 , @yaxunl wrote: > On gcc11 and below, since gcc does not support fp16, it is common practice to > use short to pass fp16 in struct. Then gcc and clang has different ABI: > https://godbolt.org/z/zqhT7x7qo > > Basica

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3032626 , @v.g.vassilev wrote: > Thanks for working on this!How hard would it be to support: > > using size_t = __SIZE_TYPE__; > template struct Id { typedef T type; }; > int main() { > struct S {} s; >

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > akhuang wrote: > > aaron.ballman wrote: > > > I'm pretty

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. @ASDenysPetrov , thank you for the comment. I added a test case per your suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 __

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376374. vabridgers added a comment. update per comments from Denys Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

beanz added a comment. In D110656#3034083 , @xbolva00 wrote: > Why just no special case "= {0};" pattern and do not warn in that case? This case did show up, but was not the majority of issues for LLVM (although might be the majority we care about). The

[PATCH] D110871: [RISCV] Remove Zbproposedc extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGa21c557955c6: [RISCV] Remove Zbproposedc extension (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] a21c557 - [RISCV] Remove Zbproposedc extension

Author: Craig Topper Date: 2021-09-30T14:23:05-07:00 New Revision: a21c557955c6ea5cd02b9a145ad6469c608446c7 URL: https://github.com/llvm/llvm-project/commit/a21c557955c6ea5cd02b9a145ad6469c608446c7 DIFF: https://github.com/llvm/llvm-project/commit/a21c557955c6ea5cd02b9a145ad6469c608446c7.diff

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 376363. manas added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/A

[PATCH] D110880: [msan] Remove StackTrace::tag

vitalybuka updated this revision to Diff 376351. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110880/new/ https://reviews.llvm.org/D11

[PATCH] D98143: [HIP] Diagnose aggregate args containing half types

yaxunl added a comment. In D98143#3034419 , @tra wrote: > Is this patch still relevant? Looks like I've missed it. > > What exactly is the difference between gcc and clang regarding fp16 and why > does it matter for aggregate arguments? > On a trivial exa

[clang] 2443320 - [AIX] Rename binder option for PGO support

Author: Jinsong Ji Date: 2021-09-30T19:58:42Z New Revision: 2443320d68387c83c9d13ffb5e5de44c2159125c URL: https://github.com/llvm/llvm-project/commit/2443320d68387c83c9d13ffb5e5de44c2159125c DIFF: https://github.com/llvm/llvm-project/commit/2443320d68387c83c9d13ffb5e5de44c2159125c.diff LOG: [A

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. We'll probably need to investigate code gen a little. A mainline linux kernel defconfig built with `CONFIG_ZERO_CALL_USED_REGS=y` enabled doesn't boot, for example.

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

thakis added a comment. In D110276#3032448 , @tejohnson wrote: > In D110276#3031133 , @thakis wrote: > >> It's my personal bot. It doesn't send email. IMHO the problem of how to make >> bots send emails hasn't be

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

xbolva00 added a comment. Please next time give a bit more time to potential reviewers / other folks outside your org. The whole lifecycle of this patch (postee - landed) took < 24h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

HazardyKnusperkeks added a comment. In D110833#3033849 , @MyDeveloperDay wrote: > I feel this is going the way of BraceWrapping in that it should be: > > SpaceBeforeParens: > - BeforeMacro: false > - BeforeFunction: true So replace the enum

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4195ed995993: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws (authored by Conanap). Changed prior to commit: https://reviews.llvm.org

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6108 + let Content = [{ +This attribute, when attached to a funcditon, causes the compiler to zero a +subset of all call-used registers before the function returns. It's used to

[PATCH] D110871: [RISCV] Remove rvbproposedc extension

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, evandro, HsiangKai, frasercrmck, jrtc27, PaoloS, kito-cheng, khchen, arcbbb. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psn

[clang] e31899c - Reland "[clang-cl] Accept `#pragma warning(disable : N)` for some N"

Author: Nico Weber Date: 2021-09-30T15:03:23-04:00 New Revision: e31899c7080f93c3d86b492af5f6bc9c3a1d1105 URL: https://github.com/llvm/llvm-project/commit/e31899c7080f93c3d86b492af5f6bc9c3a1d1105 DIFF: https://github.com/llvm/llvm-project/commit/e31899c7080f93c3d86b492af5f6bc9c3a1d1105.diff LO

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. Thanks for the revert. The problem was that this `continue` was in the wrong spot: diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 9450e8b154c5..369c12aea523 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

kamaub updated this revision to Diff 376312. kamaub added a comment. Rebasing patch to get past intermittent test-suite failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/ https://reviews.llvm.org/D110824 Files: clang/lib/Sema/Sema

[PATCH] D98143: [HIP] Diagnose aggregate args containing half types

tra added a comment. Is this patch still relevant? Looks like I've missed it. What exactly is the difference between gcc and clang regarding fp16 and why does it matter for aggregate arguments? On a trivial example both clang and gcc appear to treat _Float16 similarly: https://godbolt.org/z/8Wx

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. The way I select the registers to zero out seems rather fragile. Is there a nicer way to do this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 ___

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void created this revision. void added reviewers: kees, nickdesaulniers, jyknight. Herald added subscribers: dexonsmith, dang, jdoerfert, pengfei, hiraditya. Herald added a reviewer: aaron.ballman. void requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76902079e429: [clang] Don't modify OptRemark if the argument is not relevant (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7690207 - [clang] Don't modify OptRemark if the argument is not relevant

Author: Arthur Eubanks Date: 2021-09-30T11:36:30-07:00 New Revision: 76902079e42958118f01b4550d68a9b54c9e8e7e URL: https://github.com/llvm/llvm-project/commit/76902079e42958118f01b4550d68a9b54c9e8e7e DIFF: https://github.com/llvm/llvm-project/commit/76902079e42958118f01b4550d68a9b54c9e8e7e.diff

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dfbe9b0aeb6: [clang] Make crash reproducer work with clang-cl (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 8dfbe9b - [clang] Make crash reproducer work with clang-cl

Author: Nico Weber Date: 2021-09-30T14:33:14-04:00 New Revision: 8dfbe9b0aeb6d45975d453dfed828068c63c225e URL: https://github.com/llvm/llvm-project/commit/8dfbe9b0aeb6d45975d453dfed828068c63c225e DIFF: https://github.com/llvm/llvm-project/commit/8dfbe9b0aeb6d45975d453dfed828068c63c225e.diff LO

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376302. jcking1034 added a comment. Restore original formatting on unchanged lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files: clang/include/clang/AS

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers don't compatibly include source type qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbaa40833693: [clang] do not emit note for bad conversion when destination type qualifiers… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub updated this revision to Diff 376300. kamaub added a comment. Rebasing this patch and addressing review comments An upstream commit removed the need for this patch to modify a few test cases so it has been rebased to remain up-to-date, also addressing review comments. Repository: rG LL

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers don't compatibly include source type qualifiers

zequanwu updated this revision to Diff 376299. zequanwu added a comment. Add a testcase that from and to type are differ and qualification are incompatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110780/new/ https://reviews.llvm.org/D110780

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa32fd3bf7c0: [clang] Remove duplication in types::getCompilationPhases() (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110770/new/ https://reviews.llvm.org/D110770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fa32fd3 - [clang] Remove duplication in types::getCompilationPhases()

Author: Nico Weber Date: 2021-09-30T14:17:14-04:00 New Revision: fa32fd3bf7c070e62487e5ccba00557d57b2ee5c URL: https://github.com/llvm/llvm-project/commit/fa32fd3bf7c070e62487e5ccba00557d57b2ee5c DIFF: https://github.com/llvm/llvm-project/commit/fa32fd3bf7c070e62487e5ccba00557d57b2ee5c.diff LO

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. In D106102#3032888 , @steakhal wrote: > Okay, I don't see any problems besides this typo. Oops! > BTW do you plan to implement other rules besides this in the future? > E.g. we currently miss this: > 'x < y' is `true` if `max(x) <

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

nickdesaulniers added a comment. In D110065#3033050 , @labrinea wrote: > That said my current approach will be breaking the current tools behavior: > when the user only specifies the triple and not -march then they will be > targeting the intersection,

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Phases.h:25 IfsMerge, -LastPhase = IfsMerge, }; thakis wrote: > hans wrote: > > Any reason not to keep th

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kees added a comment. Is https://bugs.llvm.org/show_bug.cgi?id=50322 and dup of https://bugs.llvm.org/show_bug.cgi?id=23280 ? (Can both be closed?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

nathanchance added a comment. I can test this on the Linux kernel tonight and report the results tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110656/new/ https://reviews.llvm.org/D110656

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

xbolva00 added a subscriber: nathanchance. xbolva00 added a comment. >> If there are other patterns, I'd love to know what they are. Well, I dont know :) but something may arise so some testing would be useful. If possible, @beanz could share list of new warnings from LLVM build here? Also mayb

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 376279. xbolva00 added a comment. Updated warning-wall.c test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/Diagnostic

[PATCH] D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, kamaub, saghir. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. Conanap requested review of this revision. The builtin for vec_orc has support for the following two signatures, but currentl

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

aaron.ballman added a comment. In D110656#3034083 , @xbolva00 wrote: > Why just no special case "= {0};" pattern and do not warn in that case? This was what I was thinking. I was basing that on the idea that `= { 0 }` to zero init the entire array is fa

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

sbenza added inline comments. Comment at: clang/include/clang/AST/ASTTypeTraits.h:472 + assert(ASTNodeKind::getFromNodeKind().isBaseOf(NodeKind)); + return *static_cast(reinterpret_cast(Storage)); +} The create/get don't seem to match. We are constr

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

xbolva00 added a comment. Why just no special case "= {0};" pattern and do not warn in that case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110656/new/ https://reviews.llvm.org/D110656 ___ cfe-commit

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. As far as I am aware, this iteration of the patch has no instances in the Linux kernel now. The instances I found with the first iteration of the patch only had a right hand side with side effects, not both sides, so this warning is effectively a no-op now (not tha

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 marked an inline comment as done. xbolva00 added a comment. @rpbeltran @nathanchance @aaron.ballman Are you OK with the current state of this patch? Well, it is clear that some code in linux kernel/Chromium/etc needs to adjusted, but I think in many cases it would (atleast) improve read

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. inline-calls.ll failed on gfx908 due to the change in SIISelLowering.cpp, line 3015. Without the change, there is a failure in AMDGPUResourceAnalysis.cpp, line 65 because Op.getGlobal() is not a Function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D110485: Support [[no_unique_address]] for all targets.

aaron.ballman added a comment. In D110485#3033889 , @expnkx wrote: > https://github.com/microsoft/STL/issues/1364 > > As Microsoft said, the reason why things like msvc::no_unique_address exist > are because clang does not support it. In fact, it has bec

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

beanz added a comment. Even just building Clang with this enabled revealed... a lot... Some of them are easy to address (having tablegen disable the warning in generated code), some of them are exactly the kind of thing I wanted to warn on, and some of them are more complicated. Based on that

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 reclaimed this revision. gandhi21299 added a comment. Sorry, that was a mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mai

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane updated this revision to Diff 376257. erichkeane added a comment. Change the skip-until code after a requires-clause failed parse. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641 Files: clang/lib/Parse/ParseTemplate.cpp clang/te

[PATCH] D110485: Support [[no_unique_address]] for all targets.

erichkeane added a comment. In D110485#3033889 , @expnkx wrote: > In D110485#3030874 , @erichkeane > wrote: > >> In D110485#3030853 , @expnkx wrote: >> >>> clang simply j

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3030874 , @erichkeane wrote: > In D110485#3030853 , @expnkx wrote: > >> clang simply just does not truly support everything msvc supports. There are >> no things that deals [[m

[PATCH] D110825: [clangd] Handle members of anon structs in SelectionTree

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:446 return true; + // Make sure anonymous structs don't end up owning tokens. + if (auto *ME = llvm:

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8456 class AttrImporter { - Error Err = Error::success(); + Error &Err; ASTImporter &Importer; I am enthusiastic about reference members if we can somehow avoid them. Can we use a stru

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. I feel this is going the way of BraceWrapping in that it should be: SpaceBeforeParens: - BeforeMacro: false - BeforeFunction: true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://revie

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. First impressions is `ControlStatementsAndFunctionDefinitionsExceptControlMacros` is a mouthful... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376245. cor3ntin added a comment. Add support for attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

fcambus added a comment. @xgupta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110836/new/ https://reviews.llvm.org/D110836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:923 + // Skip until the semi-colon or a '}'. + SkipUntil(tok::r_brace, StopAtSemi | StopBeforeMatch); + TryConsumeToken(tok::semi); erichkeane wrote: > aaron.ballman

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:923 + // Skip until the semi-colon or a '}'. + SkipUntil(tok::r_brace, StopAtSemi | StopBeforeMatch); + TryConsumeToken(tok::semi); aaron.ballman wrote: > erichkeane wr

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:876 +/// In C++20: +/// template-head: [C++ temp.pre] +/// template '<' template-parameter-list '>' requires-clause[opt] erichkeane wrote: > aaron.ballman wrote: > >

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! And @fcambus If you want to continue contributing to the llvm-project, I would suggest you ask for commit access so you can directly commit typo fixes without opening revisions.

[PATCH] D110825: [clangd] Handle members of anon structs in SelectionTree

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:443 // It would be nice if RAV handled this (!shouldTraverseImplicitCode()). if (auto *CTI = llvm::dyn_cast(S)) if (CTI->isImplicit()) sammccall wrote: > kadircet wrote:

[PATCH] D110825: [clangd] Handle members of anon structs in SelectionTree

kadircet updated this revision to Diff 376238. kadircet marked 4 inline comments as done. kadircet added a comment. - Use `isImplicit` rather than `earlyClaim` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110825/new/ https://reviews.llvm.org/D1108

  1   2   >