[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked 12 inline comments as done. mizvekov added inline comments. Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:180 )cpp", - // FIXME: it'd be nice if this resolved to the alias instead - "struct Foo", + // It's so

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

nathanchance added a comment. In D110656#3034181 , @nathanchance wrote: > I can test this on the Linux kernel tonight and report the results tomorrow > morning. My apologies, I did not have time to get to this last night or today and I am going to be

Maintenance works at llvm lab today at 7PM PST

Hello everyone, LLVM lab and build bot will be unavailable for about an hour starting from 7:00 PM PST today for some maintenance work. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. In D49864#2857630 , @janosimas wrote: > That makes sense. > Should I add it somewhere? Or do I need to talk to someone? Please update clang-tools-extra/docs/ReleaseNotes.rst. It looks like there's no other docs for this script.

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. I'll take a look at this over the weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == [0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + cchen wrote: > Do we really expect `sa[1].f.b` be the same

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

cchen added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == [0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + Do we really expect `sa[1].f.b` be the same as `[0]`?

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

reames added a comment. In D110745#3035975 , @nikic wrote: > Sorry, but the fact that there is still no way to opt-in to the old behavior > is still a blocker from my side. If we can't use `dereferenceable + nofree` > arguments for that purpose, then

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On 10/1/21 2:59 PM, Josh Stone wrote: > On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: >> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >>> >>> >>> >>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: Does something like Rust's "bors" bot satisfy the herald rules need? >>> >>>

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: > On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >> >> >> >> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >>> >>> Does something like Rust's "bors" bot satisfy the herald rules need? >> >> >> >> sorry, maybe I was thinking of the

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman updated this revision to Diff 376635. dgoldman marked an inline comment as done. dgoldman added a comment. Minor fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.org/D110954 Files:

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Headers/altivec.h:3178 + : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) * \ + (vector float)(vector unsigned)((0x7f - (__b)) << 23 & 0x1F)),

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3033489 , @rmaz wrote: > In D109632#3032381 , @vsapsai wrote: > >> What's interesting, I was able to trigger more diagnostic. Specifically, I >> got warnings about `length`

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 376630. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Herald added a subscriber: steven.zhang. - Only truncate **b** and not result - Add a proper test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

sbenza added inline comments. Comment at: clang/unittests/AST/ASTTypeTraitsTest.cpp:212 + DynTypedNode Node = DynTypedNode::create(tl); + EXPECT_TRUE(Node == Node); + EXPECT_FALSE(Node < Node); I don't know what we are trying to check with this self

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:178 -// Unsure if this case could ever come up, but prevents an unreachable -

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376610. jcking1034 added a comment. Clean up unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files: clang/include/clang/AST/ASTTypeTraits.h

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c31969e8df2: [AIX] Dont pass namedsects in LTO mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/

[clang] 9c31969 - [AIX] Don't pass namedsects in LTO mode

Author: Jinsong Ji Date: 2021-10-01T19:22:40Z New Revision: 9c31969e8df2f4b41b05e415fc9a66ff0bfa0802 URL: https://github.com/llvm/llvm-project/commit/9c31969e8df2f4b41b05e415fc9a66ff0bfa0802 DIFF: https://github.com/llvm/llvm-project/commit/9c31969e8df2f4b41b05e415fc9a66ff0bfa0802.diff LOG:

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji updated this revision to Diff 376595. jsji added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org/D110955 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index:

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

shafik added a comment. In D110927#3036647 , @ASDenysPetrov wrote: > In D110927#3036436 , @steakhal > wrote: > >> I'm pretty sure that `int x4 = ((char*)arr)[1];` is supposed to be valid in >> your summary. >>

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

quinnp added a comment. I think the commit message needs to be updated. > This patch updates the vec_popcnt builtins to take a signed int as the second > parameter... Should be: This patch updates the return type of the vec_popcnt builtins to vector unsigned... Other than that, lgtm.

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added a subscriber: inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LTO don't need binder option , don't pass it in LTO mode. Repository: rG

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Support enums in C

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

quinnp added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/ https://reviews.llvm.org/D110935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined",

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110665/new/ https://reviews.llvm.org/D110665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77598: Integral template argument suffix and cast printing

dblaikie added a comment. In D77598#3035591 , @v.g.vassilev wrote: > In D77598#3035449 , @dblaikie wrote: > >> Came across this while trying to do "simplified template names" - producing >> template names in

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3;>P1073R3 - No + Partial cor3ntin wrote: > erichkeane wrote: > > I'm trying to evaluate our consteval support, and I am having trouble >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3;>P1073R3 - No + Partial erichkeane wrote: > I'm trying to evaluate our consteval support, and I am having trouble finding > any

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

daltenty added a comment. This doesn't appear to be true for 64-bit AIX: extern "C" int printf(const char *, ...); int main() { printf("wchar_t: %ld\nunsigned short: %ld\n",sizeof(wchar_t),sizeof(unsigned short)); return 0; } $ clang++ -m64 foo.cc $ ./a.out

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 376559. gandhi21299 added a comment. - Since callees may alias to a function pointer, it makes sense for `getCalleeFunction(...)` to return a `Function` which is a cast of the operand of a `GlobalAlias`. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 376564. gandhi21299 added a comment. - eliminated changes in SIISelLowering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files:

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

dblaikie added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; mtrofin wrote: > wenlei wrote: > > mtrofin wrote: > > > wenlei wrote: > > > > curious why do we need anonymous namespace here? > > >

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked 3 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; wenlei wrote: > mtrofin wrote: > > wenlei wrote: > > > curious why do we need anonymous

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/ASTTypeTraitsTest.cpp:207 + auto matches = match(traverse(TK_AsIs, typeLoc().bind("tl")), context); + for (auto : matches) { +

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined",

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; mtrofin wrote: > wenlei wrote: > > curious why

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3;>P1073R3 - No + Partial I'm trying to evaluate our consteval support, and I am having trouble finding any unsuperceded part of P1073R3

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; wenlei wrote: > curious why do we need anonymous namespace here? iiuc it's preferred we place

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; curious why do we need anonymous namespace here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376573. jcking1034 marked an inline comment as done. jcking1034 added a comment. Fix typing for `create` and add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531 + // Get the result of the previous import attempt (can be used only once). + llvm::Expected getResult() { +if (Err) steakhal wrote: > aaron.ballman wrote: > >

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

aaron.ballman added inline comments. Comment at: clang/test/Sema/MicrosoftExtensions.cpp:9-10 + return (p32u == p32s) + + (p32u == p64) + + (p32s == p64); +} akhuang wrote: > aaron.ballman wrote: > > (Side question, not directly about this patch

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110428/new/ https://reviews.llvm.org/D110428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong added a comment. @ASDenysPetrov This looks promising! Please address the nits which @steakhal found, than I think it is good to land. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1641 + // FIXME: Take array dimension into account to prevent exceeding its

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. In D110927#3036436 , @steakhal wrote: > I'm pretty sure that `int x4 = ((char*)arr)[1];` is supposed to be valid in > your summary. > I think it's allowed by the standard to access any valid object via a `char*` > -

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d0b5805e5f: [analyzer] Fix deprecated plistlib functions (authored by manas, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a3d0b58 - [analyzer] Fix deprecated plistlib functions

Author: Manas Date: 2021-10-01T17:07:24+02:00 New Revision: a3d0b5805e5ff2fd870df5be5c3197eee0bb74a0 URL: https://github.com/llvm/llvm-project/commit/a3d0b5805e5ff2fd870df5be5c3197eee0bb74a0 DIFF: https://github.com/llvm/llvm-project/commit/a3d0b5805e5ff2fd870df5be5c3197eee0bb74a0.diff LOG:

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

Orlando added a comment. In D110783#3036403 , @thakis wrote: >> Hopefully better after ec4a82286674c44c9216e9585235b0fa5df4ae9f >> > > Your bot cycled green after that change: >

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

steakhal added a comment. I'm gonna get back to this on Monday. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1699-1701 + ProgramStateRef OldState; + do { +OldState = State; IMO we should have a `llvm::Statistic` here, tracking the

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. It seems like it doesn't build with GCC 8.3.0 on a Debian system. Could you investigate? llvm-project/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1029:13: error: explicit specialization in non-namespace scope 'class {anonymous}::SymbolicRangeInferrer'

[libunwind] 532783f - [libunwind] Fix cfi_register for float registers.

Author: Daniel Kiss Date: 2021-10-01T16:51:51+02:00 New Revision: 532783f9e1e65c7bd48b1592d2376e9dd47c5a73 URL: https://github.com/llvm/llvm-project/commit/532783f9e1e65c7bd48b1592d2376e9dd47c5a73 DIFF: https://github.com/llvm/llvm-project/commit/532783f9e1e65c7bd48b1592d2376e9dd47c5a73.diff

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

manas added a comment. In D107312#3036421 , @steakhal wrote: > I'm not using this script. I'm assuming you run it and verified that it works. > Thanks for cleaning this up. I have run it. It is working. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. In D106102#3036474 , @steakhal wrote: > In D106102#3036220 , @manas wrote: > >> I do not have landing rights. > > Please add your name and email on whom behalf I should commit this patch.

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376526. vabridgers added a comment. Use canonical types for comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files:

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. In D106102#3036220 , @manas wrote: > I do not have landing rights. Please add your name and email on whom behalf I should commit this patch. Mine is `Balazs Benics` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC, clang. amyk requested review of this revision. This patch updates the vec_extract builtins to take a signed int as the second parameter, as defined by the Power Vector Intrinsics

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC, clang. amyk requested review of this revision. This patch updates the vec_popcnt builtins to take a signed int as the second parameter, as defined by the Power Vector Intrinsics

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

steakhal added a subscriber: shafik. steakhal added a comment. I'm pretty sure that `int x4 = ((char*)arr)[1];` is supposed to be valid in your summary. I think it's allowed by the standard to access any valid object via a `char*` - according to the strict aliasing rule. @shafik WDYT?

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm not using this script. I'm assuming you run it and verified that it works. Thanks for cleaning this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2108 +LLVM_NODISCARD ProgramStateRef +EquivalenceClass::removeMember(ProgramStateRef State, const SymbolRef Old) { + Remove `const ` Comment

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

thakis added a comment. > Hopefully better after ec4a82286674c44c9216e9585235b0fa5df4ae9f > Your bot cycled green after that change: https://lab.llvm.org/buildbot/#/builders/139/builds/10976 Repository: rG LLVM Github

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

thakis added a comment. In D110783#3035158 , @dyung wrote: > Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot > after your change. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Hopefully

[clang] ec4a822 - [clang] Try to unbreak crash-report.cpp on PS4 bot after 8dfbe9b0a

Author: Nico Weber Date: 2021-10-01T09:33:13-04:00 New Revision: ec4a82286674c44c9216e9585235b0fa5df4ae9f URL: https://github.com/llvm/llvm-project/commit/ec4a82286674c44c9216e9585235b0fa5df4ae9f DIFF: https://github.com/llvm/llvm-project/commit/ec4a82286674c44c9216e9585235b0fa5df4ae9f.diff

[clang] 369d785 - [PowerPC] Optimal sequence for doubleword vec_all_{eq|ne} on Power7

Author: Nemanja Ivanovic Date: 2021-10-01T08:27:15-05:00 New Revision: 369d785574f5a22c086d0c40268a39a64bdd7217 URL: https://github.com/llvm/llvm-project/commit/369d785574f5a22c086d0c40268a39a64bdd7217 DIFF:

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. In D110668#3034576 , @xbolva00 wrote: > Please next time give a bit more time to potential reviewers / other folks > outside your org. The whole lifecycle of this patch (posted - landed) took < > 24h. Is there anything wrong

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just nits (This review addresses comments on https://reviews.llvm.org/rGdea48079b90d40f2087435b778544dffb0ab1793) Comment at:

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

DavidSpickett added a comment. > Can you read the latest example I comment? I think you misunderstand the > extra outputs I mentioned. Or if I'm wrong, can you give an inline example? I understood but yes your example is one that a SAME cannot catch, that's true. My point was that SAME does

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

manas added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107312/new/ https://reviews.llvm.org/D107312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. In D106102#3035598 , @steakhal wrote: > Good work. Land it. I do not have landing rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: aaron.ballman, martong, steakhal, NoQ, r.stahl. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev updated this revision to Diff 376488. kbobyrev added a comment. Get rid of SM in getOrCreateID & getID Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 Files:

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM,

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

steakhal added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531 + // Get the result of the previous import attempt (can be used only once). + llvm::Expected getResult() { +if (Err) aaron.ballman wrote: > steakhal wrote: > > If it can

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531 + // Get the result of the previous import attempt (can be used only once). + llvm::Expected getResult() { +if (Err) steakhal wrote: > If it can be used only once,

Re: [llvm-dev] Phabricator Creator Pulling the Plug

Hi folks, Arcanist not working any longer is really unfortunate. Phroge also has a fork of Arcanist, however I haven't seen any SSL-related patches: https://we.phorge.it/source/arcanist/browse/master/ 1) Replacement for Herald rules. I suppose the notification problem is solvable. I just took

Re: [llvm-dev] Phabricator Creator Pulling the Plug

I would like to add a third blocker to Mehdi's list: 3) We first would need to finish our ongoing Bugzilla to GitHub Issues migration: At the moment the plan is to use the old bug ID in bugzilla as issue ID on GitHub. However issues and Pull Requests share the same namespace. So once we start

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: > Does something like Rust's "bors" bot satisfy the herald rules need? > sorry, maybe I was thinking of the high-five bot. And it looks like that's not quite a match for herald. > re: #2 I have done this on GHE and it's mildly awkward but it

Re: [llvm-dev] Phabricator Creator Pulling the Plug

Does something like Rust's "bors" bot satisfy the herald rules need? re: #2 I have done this on GHE and it's mildly awkward but it does work. And yes normalizing force pushes is the unfortunate state of GitHub PRs. Comments are preserved. Code-anchored comments like review comments are marked as

Re: [llvm-dev] Phabricator Creator Pulling the Plug

How far are we from a workflow that leverages Github's Pull Requests? Is there some consensus that it's a desired end goal, but some features are missing? Or do we prefer to use a workflow like this for the long term? On Thu, Sep 30, 2021, 4:54 PM Chris Tetreault via llvm-dev <

RE: [llvm-dev] Phabricator Creator Pulling the Plug

As I, and others have noticed, it seems that as of today, there’s some certificate issue with arcanist. (See: https://lists.llvm.org/pipermail/llvm-dev/2021-September/153019.html) The fix seems simple, and a PR is up, but looking through the PR activity, it seems that the PR will not be

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. Just adding a few more clang-format big guns as reviewers, its probably good to get some more input before embarking on what is going to probably be a reasonably sized change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. The use of "Custom" would kind of match the BraceWrapping, as for `SpaceBeforeParensCustom` either that or `SpaceBeforeParensStyles` , `SpaceBeforeParensSettings`, `SpaceBeforeParensOptions` I guess I don't really mind, (I always find naming things hard!) maybe

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

haonanya updated this revision to Diff 376467. haonanya added a comment. Fix format issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 Files: clang/lib/Headers/opencl-c.h clang/lib/Sema/OpenCLBuiltins.td clang/lib/Sema/Sema.cpp

[PATCH] D110825: [clangd] Handle members of anon structs in SelectionTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG512aa8485010: [clangd] Handle members of anon structs in SelectionTree (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110825/new/

[clang-tools-extra] 512aa84 - [clangd] Handle members of anon structs in SelectionTree

Author: Kadir Cetinkaya Date: 2021-10-01T12:38:18+02:00 New Revision: 512aa8485010009f6ec1b8d9deea3effe67e0106 URL: https://github.com/llvm/llvm-project/commit/512aa8485010009f6ec1b8d9deea3effe67e0106 DIFF:

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

steakhal added a comment. In D110625#3035974 , @ASDenysPetrov wrote: > In D110625#3035929 , @steakhal > wrote: > >> I thought that `SVal::getType` should return an already canonical >> `QualType`. If it

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Sorry, but the fact that there is still no way to opt-in to the old behavior is still a blocker from my side. If we can't use `dereferenceable + nofree` arguments for that purpose,

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

ASDenysPetrov added a comment. In D110625#3035929 , @steakhal wrote: > I thought that `SVal::getType` should return an already canonical `QualType`. > If it doesn't do that we would need to do canonicalization at each callsite, > which is less than

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

crayroud added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3649 ``SBPO_ControlStatementsExceptForEachMacros`` remains an alias for backward compatibility. MyDeveloperDay wrote: > Now I look back here, why where these Macro

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3649 ``SBPO_ControlStatementsExceptForEachMacros`` remains an alias for backward compatibility. Now I look back here, why where these Macro considered the same

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

steakhal added a comment. The patch seems reasonable, but I will need slightly more time to digest it. I'll get back to this. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:390-396 /// Try to simplify a given symbolic expression's

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

ASDenysPetrov added a comment. In D110911#3035911 , @steakhal wrote: > Please mark both of them `LLVM_DUMP_METHOD`s. This way they will be stripped > from release builds according to their documentation. And `Range::dump` as well. Repository: rG

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:62 std::string ABI; + StringRef getArchProfile() const; tmatheson wrote: > The equivalent in the ARM backend is named `getCPUProfile` That's arguably a worse name though.

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:62 std::string ABI; + StringRef getArchProfile() const; The equivalent in the ARM backend is named `getCPUProfile` CHANGES SINCE LAST ACTION

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

steakhal added a comment. In D110625#3035843 , @ASDenysPetrov wrote: > In D110625#3035616 , @steakhal > wrote: > >> WDYT Denys? Btw does the SVval::getType return a canonical type in all cases? > >

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

nlopes accepted this revision. nlopes added a comment. This revision is now accepted and ready to land. LGTM. We have discussed this before. It's important to fix the reference types in C++. Comment at: llvm/test/Analysis/BasicAA/dereferenceable.ll:66 ; CHECK: Function:

  1   2   >