[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added a comment. Thanks for your input @mgartmann ! No apologies needed, nothing is ever perfect on the first release :) Just wanted to check if you would agree with the fix or if there's some detail I've missed. I'll add the tests asked by @whisperity CHANGES SINCE LAST ACTION

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin updated this revision to Diff 377091. mtrofin marked 2 inline comments as done. mtrofin added a comment. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 Files:

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

v.g.vassilev added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:223 + void LoadRequestedPlugins(); + /// } sgraenitz wrote: > This could have a minimal doxygen comment now that it's part of the public > interface. I somewhat

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81fb640f83b6: [clang-repl] Allow loading of plugins in

[clang] 81fb640 - [clang-repl] Allow loading of plugins in clang-repl.

Author: Vassil Vassilev Date: 2021-10-05T05:20:30Z New Revision: 81fb640f83b6a5d099f9124739ab3049be79ea56 URL: https://github.com/llvm/llvm-project/commit/81fb640f83b6a5d099f9124739ab3049be79ea56 DIFF: https://github.com/llvm/llvm-project/commit/81fb640f83b6a5d099f9124739ab3049be79ea56.diff

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem is happening when user passes lambda function

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

lattner accepted this revision. lattner added a comment. This is really great, thank you for doing this. I'd love to see reduced out of headers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111049/new/ https://reviews.llvm.org/D111049

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110676/new/ https://reviews.llvm.org/D110676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. Type alignment (16), choice of GPRs for argument passing (first available including r10), `va_arg` invocations, order of components (big endian), and calls to double/float conversions all check out. It may be reasonable to locate existing tests for these

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106044/new/ https://reviews.llvm.org/D106044

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

HsiangKai added a comment. Herald added a subscriber: achieveartificialintelligence. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106044/new/ https://reviews.llvm.org/D106044 ___ cfe-commits

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae created this revision. python3kgae added a reviewer: clang. python3kgae added a project: clang. python3kgae requested review of this revision. Herald added a subscriber: cfe-commits. When AnnotateAttr is on a function, AddGlobalAnnotations is only called in

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Herald added a reviewer: ctetreau. In D110663#3029577 , @phosek wrote: > This is going to break Fuchsia as implemented. We assume that > `{x86_64,aarch64}-unknown-fuchsia` and `{x86_64,aarch64}-fuchsia` behave > identically and

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks created this revision. Herald added subscribers: dexonsmith, dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to save memory for Clang compiles. Measuring building PassBuilder.cpp under /usr/bin/time, max rss

[PATCH] D76169: [WIP][AST] Allow ExprConstant to evaluate structs in C.

nickdesaulniers added a subscriber: erichkeane. nickdesaulniers added a comment. Looks like @erichkeane was in the neighborhood in 606a734755d1fb6c35a17680d0c251f834b79334 ("[PR47636] Fix tryEmitPrivate to handle

[clang] 95f824a - Revert "[clang][Fuchsia] Re-enable compiler-rt tests in runtimes build"

Author: Leonard Chan Date: 2021-10-04T16:11:43-07:00 New Revision: 95f824ad7c2da1e8142dbade4e4e12f389f1eb78 URL: https://github.com/llvm/llvm-project/commit/95f824ad7c2da1e8142dbade4e4e12f389f1eb78 DIFF: https://github.com/llvm/llvm-project/commit/95f824ad7c2da1e8142dbade4e4e12f389f1eb78.diff

[PATCH] D111100: enable plugins for clang-tidy

vtjnash created this revision. Herald added a subscriber: mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes 32739 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D00 Files:

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

tomhughes added a comment. I'm hitting this in the codebase that I'm working on as well. What are the next steps (besides reformatting)? It's not completely clear to me from the comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3037501 , @vsapsai wrote: > My assumption was that all dependent modules are in memory at this point. And > we visit transitive modules only once, so I don't expect it to be a big > performance hit (though I can be

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG256828689231: [clang] Dont use the AST to display backend diagnostics (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110665/new/

[clang] 2568286 - [clang] Don't use the AST to display backend diagnostics

Author: Arthur Eubanks Date: 2021-10-04T14:14:32-07:00 New Revision: 2568286892310877f24313c8e1626e415f9ae406 URL: https://github.com/llvm/llvm-project/commit/2568286892310877f24313c8e1626e415f9ae406 DIFF:

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377033. ricejasonf added a comment. I rebased onto `main` and made one small style fix. I don't think the rebase changes anything. I do not understand why random things are failing in the CI. Even on my own build machine with a fresh build directory

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3040748 , @craig.topper wrote: > Looks like this fixes PR51282. I guess it does fix it, but the underlying implementation of alignment is very fragile. The alignment is stored in `AttributedType` nodes, which are

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8480063f25b8: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build (authored by leonardchan). Herald added a subscriber: abrachet.

[clang] 8480063 - [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

Author: Leonard Chan Date: 2021-10-04T14:11:49-07:00 New Revision: 8480063f25b8527d935722769d54d47f0c0d5689 URL: https://github.com/llvm/llvm-project/commit/8480063f25b8527d935722769d54d47f0c0d5689 DIFF: https://github.com/llvm/llvm-project/commit/8480063f25b8527d935722769d54d47f0c0d5689.diff

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added a comment. Hmm. Just found out about this, but for future reference, I think this will only work for `ninja check-runtimes` and `ninja check-runtimes-{target}`, but not necessarily `ninja -C runtimes/runtimes-{target} check-runtimes/check-compilter-rt`. Repository: rG

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110665/new/ https://reviews.llvm.org/D110665

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

v.g.vassilev updated this revision to Diff 377026. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110484/new/ https://reviews.llvm.org/D110484 Files:

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

rsmith added a comment. LGTM modulo existing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110484/new/ https://reviews.llvm.org/D110484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0e31cf511d: Update inline builtin handling to honor gnu inline attribute (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D111009?vs=376812=377023#toc Repository:

[clang] 0f0e31c - Update inline builtin handling to honor gnu inline attribute

Author: serge-sans-paille Date: 2021-10-04T22:26:25+02:00 New Revision: 0f0e31cf511def3e92244e615b2646c1fd0df0cd URL: https://github.com/llvm/llvm-project/commit/0f0e31cf511def3e92244e615b2646c1fd0df0cd DIFF:

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

leonardchan abandoned this revision. leonardchan added a comment. Herald added a subscriber: abrachet. In D110889#3035597 , @phosek wrote: > Is this needed even with D110888 ? Nope, at least after the updated patch this

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: Confirming that this case matches GCC on AIX: ``` ld 4,8(3) ld 3,0(3) blr ```

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG83289665200b: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions (authored by kamaub). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/

[clang] 8328966 - [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

Author: Kamau Bridgeman Date: 2021-10-04T14:45:36-05:00 New Revision: 83289665200b6b9212e0ff14e274b2c431a2e1fa URL: https://github.com/llvm/llvm-project/commit/83289665200b6b9212e0ff14e274b2c431a2e1fa DIFF:

[PATCH] D110252: Added note about Whatstyle and Unformat

MyDeveloperDay added a comment. IMHO is that I don't personally feel we need to endorse of someone else's that could be potentially incomplete, These tools are interesting (per say) but I have no idea how accurate they are in terms of using all the options or how much they keep pace, for

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56e72a40c198: Update `DynTypedNode` to support the conversion of `TypeLoc`s. (authored by jcking1034, committed by ymandel). Repository: rG LLVM

[clang] 56e72a4 - Update `DynTypedNode` to support the conversion of `TypeLoc`s.

Author: James King Date: 2021-10-04T19:25:24Z New Revision: 56e72a40c1985529399738f66c6f4c24029112d6 URL: https://github.com/llvm/llvm-project/commit/56e72a40c1985529399738f66c6f4c24029112d6 DIFF: https://github.com/llvm/llvm-project/commit/56e72a40c1985529399738f66c6f4c24029112d6.diff LOG:

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked an inline comment as done. mizvekov added a comment. In D110216#3040748 , @craig.topper wrote: > Looks like this fixes PR51282. Okay, interesting. This could be just papering over the bug. Do you still lose this alignment if it goes

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3d944a97cc: [PowerPC] Disable vector types when not supported by subtarget features (authored by lei). Repository: rG LLVM Github Monorepo

[clang] 8b3d944 - [PowerPC] Disable vector types when not supported by subtarget features

Author: Lei Huang Date: 2021-10-04T14:16:47-05:00 New Revision: 8b3d944a97cc944a24ed1296c801da5654896092 URL: https://github.com/llvm/llvm-project/commit/8b3d944a97cc944a24ed1296c801da5654896092 DIFF: https://github.com/llvm/llvm-project/commit/8b3d944a97cc944a24ed1296c801da5654896092.diff

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. Thanks for the feedback. I'll work on a follow-up that implements that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 ___ cfe-commits

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

craig.topper added a comment. Looks like this fixes PR51282. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley added a comment. Thanks! Could you help me commit again when you have time? (same info as here ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

mgartmann added a comment. Please excuse my late reply! I have been on vacation for the last two weeks and didn't have the time to respond to this thread until now. In D110614#3032760 , @carlosgalvezp wrote: > So the derived destructor only shows up

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei updated this revision to Diff 376969. lei added a comment. address line comment and update tc to reflect new behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109178/new/ https://reviews.llvm.org/D109178 Files:

[PATCH] D111079: [Clang] Add core papers added in the October 2021 WG21 plenary.

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in 922863e75f10db3bff001483279ba649d9735f46 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 922863e - Add core papers added in the October 2021 WG21 plenary

Author: Corentin Jabot Date: 2021-10-04T14:42:13-04:00 New Revision: 922863e75f10db3bff001483279ba649d9735f46 URL: https://github.com/llvm/llvm-project/commit/922863e75f10db3bff001483279ba649d9735f46 DIFF:

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376967. cor3ntin added a comment. Fix compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

craig.topper added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1032 if (const auto *S = dyn_cast()) { - EffectiveType = S->getDeducedType().getTypePtrOrNull(); - if (!EffectiveType) -return false; + QualType T =

[PATCH] D111079: [Clang] Add core papers added in the October 2021 WG21 plenary.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! (Don't worry about the extra paren I found, I'll handle that when I land this.) Comment at: clang/www/cxx_status.html:1341 + +

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. Making a change to whether a platform has `__int128` affects the ABI of libc++'s `std::chrono::file_clock`. We should make sure the mitigation patch is posted and accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

kamaub updated this revision to Diff 376962. kamaub added a comment. Moving test case to correct file before commiting as request in review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/ https://reviews.llvm.org/D110824 Files:

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376961. cor3ntin added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h

[PATCH] D110482: [clang] Implement if consteval (P1938)

aaron.ballman added a reviewer: rsmith. aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a nit, I think this is ready to go. Adding Richard in case he has the chance to give this a once-over before it lands.

[PATCH] D111079: [Clang] Add core papers added in the October 2021 WG21 plenary.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111079 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

aaron.ballman added a comment. In D110668#3038858 , @xbolva00 wrote: > In D110668#3036361 , @thakis wrote: > >> In D110668#3034576 , @xbolva00 >> wrote: >> >>> Please

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 376947. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch remove the override in AIX target, so the int128 is enabled in

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 376945. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. > What I mean, for example: > > def UnusedParameter : DiagGroup<"unused-parameter", 4100>; That's an interesting idea. Given how seldom this is used, I weakly prefer having actual code for this though: It makes it easy to see all of those mapped flags, and it keeps

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers added a comment. In D107613#3040402 , @dschuff wrote: > It looks like this error is intended to catch mismatches for attributes that > can affect codegen such as noreturn (in which case it makes sense to have it > as an error) but it

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea updated this revision to Diff 376942. labrinea edited the summary of this revision. labrinea added a comment. Change from last revision: The driver implicitly enables the 'A' profile features (as if -march=armv8-a was specified on the command line) when only the target triple is

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

dschuff added a comment. It looks like this error is intended to catch mismatches for attributes that can affect codegen such as noreturn (in which case it makes sense to have it as an error) but it also now fires for cases such as `__attribute__(warning())` which often do not duplicate the

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376944. jcking1034 added a comment. Fix pointer style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files: clang/include/clang/AST/ASTTypeTraits.h

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. Sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111049/new/ https://reviews.llvm.org/D111049

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376939. jcking1034 added a comment. Include additional expectation in unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files:

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang updated this revision to Diff 376936. akhuang added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110670/new/ https://reviews.llvm.org/D110670 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

sbenza accepted this revision. sbenza added inline comments. Comment at: clang/unittests/AST/ASTTypeTraitsTest.cpp:234 + EXPECT_TRUE(PointerTypeLocNode == PointerTypeLocNode); + EXPECT_FALSE(PointerTypeLocNode < PointerTypeLocNode); +} Maybe also check ```

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGExpr.cpp:4901 + llvm::Function *Fn = llvm::cast(CalleePtr); + llvm::Module = CGF.CGM.getModule(); +

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 376920. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 376914. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. In D97874#3014922 , @martong wrote: > @ASDenysPetrov I think the dependent patch https://reviews.llvm.org/D97296 is > too much and contains unnecessary things for this change. > > If

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

This revision was automatically updated to reflect the committed changes. zukatsinadze marked an inline comment as done. Closed by commit rG811b1736d91b: [analyzer] Add InvalidPtrChecker (authored by zukatsinadze). Changed prior to commit: https://reviews.llvm.org/D97699?vs=372237=376902#toc

[clang] 811b173 - [analyzer] Add InvalidPtrChecker

Author: Zurab Tsinadze Date: 2021-10-04T17:08:34+02:00 New Revision: 811b1736d91b301f59fbaa148ff55c32f90a3947 URL: https://github.com/llvm/llvm-project/commit/811b1736d91b301f59fbaa148ff55c32f90a3947 DIFF:

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 marked an inline comment as not done. jcking1034 added inline comments. Comment at: clang/unittests/AST/ASTTypeTraitsTest.cpp:212 + DynTypedNode Node = DynTypedNode::create(tl); + EXPECT_TRUE(Node == Node); + EXPECT_FALSE(Node < Node); sbenza

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376901. jcking1034 marked an inline comment as done. jcking1034 added a comment. Update unit test to better exercise `getNodeAs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 376896. ASDenysPetrov added a comment. Updated according to suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

HsiangKai updated this revision to Diff 376890. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 Files: clang/include/clang/Basic/IdentifierTable.h

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/initialization.cpp:132 + +char const glob_arr6[5] = "123"; +void glob_array_index4() { steakhal wrote: > Ah, it's somewhat confusing. > At first, when I looked at it, I assumed that this array

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90d57b6cc5f: [clangd] Improve PopulateSwitch tweak (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/

[clang-tools-extra] a90d57b - [clangd] Improve PopulateSwitch tweak

Author: David Goldman Date: 2021-10-04T10:15:37-04:00 New Revision: a90d57b6cc5f1237199fa6974eeb1cb168a7aed3 URL: https://github.com/llvm/llvm-project/commit/a90d57b6cc5f1237199fa6974eeb1cb168a7aed3 DIFF: https://github.com/llvm/llvm-project/commit/a90d57b6cc5f1237199fa6974eeb1cb168a7aed3.diff

[PATCH] D111045: [clang] Fix computation of number of dependencies using OpenMP iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfc8f9e9b0bd: [clang] Fix computation of number of dependencies using OpenMP iterator, (authored by ABataev). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bfc8f9e - [clang] Fix computation of number of dependencies using OpenMP iterator,

Author: Alexey Bataev Date: 2021-10-04T07:06:51-07:00 New Revision: bfc8f9e9b0bd2279ee3398ee62f255360a89f0e9 URL: https://github.com/llvm/llvm-project/commit/bfc8f9e9b0bd2279ee3398ee62f255360a89f0e9 DIFF: https://github.com/llvm/llvm-project/commit/bfc8f9e9b0bd2279ee3398ee62f255360a89f0e9.diff

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1641 + // FIXME: Take array dimension into account to prevent exceeding its size. + const int64_t I = Idx.getExtValue(); + uint32_t Code = ASDenysPetrov wrote: >

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1641 + // FIXME: Take array dimension into account to prevent exceeding its size. + const int64_t I = Idx.getExtValue(); + uint32_t Code = martong wrote: > steakhal

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. In D110927#3037118 , @shafik wrote: > IIUC the object is `const int arr[42]` and the `(char *)arr` is an expression > of pointer type and adding `1` to this is valid. The case you refer to in > D104285

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman added a comment. In D111041#3039637 , @carlosgalvezp wrote: > Thanks for the input! > >> release note mentions > > Sure thing! > >> documentation changes > > As we discussed in the separate mail thread, there is no documentation at all >

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1395 if (CMD->isVirtual()) -if (IdentifierAtCursor && SM.getSpellingLoc(CMD->getLocation()) == - IdentifierAtCursor->location()) {

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

RKSimon created this revision. RKSimon added reviewers: ychen, rnk, MaskRay, zturner, chandlerc, lattner. Herald added subscribers: dexonsmith, hiraditya. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits.

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. Thanks for the input! > release note mentions Sure thing! > documentation changes As we discussed in the separate mail thread, there is no documentation at all as to what default values an alias/main check has. Where should I put that? Or do you mean that now

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

whisperity added a comment. In D110614#3038519 , @carlosgalvezp wrote: > Hi! Are there any more issues I should address? It would be nice to get it > merged since it fixes quite a few FPs. I'm not seeing anything immediate to add. I like the proper

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D111041#3039590 , @carlosgalvezp wrote: > I wonder why I'm not getting automated pre-merge builds? Huh, that is strange.

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. I wonder why I'm not getting automated pre-merge builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 ___ cfe-commits mailing

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc2f4979cf5: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4fc2f49 - [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

Author: Stefan Pintilie Date: 2021-10-04T06:17:02-05:00 New Revision: 4fc2f4979cf56fdc87cbd5ed1b02ef3461916731 URL: https://github.com/llvm/llvm-project/commit/4fc2f4979cf56fdc87cbd5ed1b02ef3461916731 DIFF:

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

stefanp updated this revision to Diff 376857. stefanp added a comment. Rebased and added signext test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110771/new/ https://reviews.llvm.org/D110771 Files:

  1   2   >