[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e3c762098e: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in… (authored by fwolff, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] c3e3c76 - [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

Author: Fabian Wolff Date: 2021-11-15T07:41:35Z New Revision: c3e3c762098e8d425731bb40f3b8b04dac1013f3 URL: https://github.com/llvm/llvm-project/commit/c3e3c762098e8d425731bb40f3b8b04dac1013f3 DIFF: https://github.com/llvm/llvm-project/commit/c3e3c762098e8d425731bb40f3b8b04dac1013f3.diff LOG:

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp added a comment. I agree with the comments, but I didn't want to touch any code other than moving things around, since it's hard to see the changes in the diff otherwise. I was also unsure if this was "LLVM convention" or a mistake. I'm happy to fix in a separate patch if that's

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0),

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Please wait one or two days for other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

wristow added a comment. The Release Note change here says: Floating Point Support in Clang --- - The -ffp-model=precise now implies -ffp-contract=on rather than -ffp-contract=fast, and the documentation of these features has been clarified. Previously,

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:299 // CHECK-FIXES: {{^}} void v_Bad_Base_Method() override {} + void BadBaseMethodNoAttr() {} + // CHECK-FIXES: {{^}} void

[PATCH] D77598: Integral template argument suffix and cast printing

dblaikie added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1101 Out << ", "; -Args[I].print(Policy, Out); +if (TemplOverloaded || !Params) + Args[I].print(Policy, Out, /*IncludeType*/ true); rsmith wrote: > dblaikie wrote: > >

[clang] 50fdd7d - Add more test coverage for D77598

Author: David Blaikie Date: 2021-11-14T21:09:11-08:00 New Revision: 50fdd7df827137c8465abafa82a6bae7c87096c5 URL: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5 DIFF: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5.diff

[clang] b2589e3 - ast-print: Avoid extra whitespace before function opening brace

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: b2589e326ba4407d8314938a4f7498086e2203ea URL: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea DIFF: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea.diff

[clang] 604446a - ast-dump: Add missing identation of class template specializations

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 604446aa6b41461e2691c9f4253e9ef70a5d68e4 URL: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4 DIFF: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4.diff

[clang] 400eb59 - Add test for a case in D77598

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 400eb59adf43b29af3117c163cf770e6d6e514f7 URL: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7 DIFF: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7.diff

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:3193 +def mskip_rax_setup : Flag<["-"], "mskip-rax-setup">, Group, Flags<[NoXarchOption]>, + HelpText<"Skip setting up RAX register when passing variable arguments (x86 only)">; def

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei updated this revision to Diff 387147. pengfei marked 3 inline comments as done. pengfei added a comment. Herald added a subscriber: dexonsmith. Address review comments. 1. Add support for `-mno-skip-rax-setup` and its test; 2. Use module flag metadata instead of command line option in

[PATCH] D113664: [cmake] use project relative paths when generating ASTNodeAPI.json

stephenneuendorffer accepted this revision. stephenneuendorffer added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113664/new/ https://reviews.llvm.org/D113664

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 387144. ChuanqiXu added a comment. Fix a mismatch in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3115814 , @erichkeane wrote: > Either this or D108453 (which were > committed together!) caused this assert according to my git-bisect: > https://godbolt.org/z/4rqYKfW7K > >

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyContext.cpp:40 +#include +using namespace clang; +using namespace tidy; Shouldn't namespaces be used instead? Comment at:

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

leoetlino added a comment. While this patch doesn't introduce new regressions and does fix compilation of the code snippet mentioned earlier, I'm not sure this is the correct approach, considering there are a bunch of other similar template-related consteval bugs that this patch does *not*

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

FreddyYe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0),

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387133. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff created this revision. fwolff added reviewers: compnerd, alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52245. I've also added a

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

carlosgalvezp added a comment. I will push tomorrow so I have time to keep an eye on the bots ;) Btw @fwolff could you post your name and email so i add it to the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113708/new/ https://reviews.llvm.org/D113708

[clang] 5de3690 - Follow-up to D77598: Simplify API by passing template parameters only when used/to imply "TemplOverloaded/overloadable"

Author: David Blaikie Date: 2021-11-14T13:35:22-08:00 New Revision: 5de369056dee2c4de81625cb05a5c212a0bdc053 URL: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053 DIFF: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053.diff

[PATCH] D113844: [clang-format] [NFC] build clang-format with -Wall

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Is okay, but I think the compiler is a bit overreacting, since there is only one call (chain). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Awesome, thanks! Sure, I'm quite new here as well so I'll need to take some time to figure out how to commit on behalf of someone else, bear with me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113708/new/

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

leoetlino created this revision. leoetlino added a reviewer: rsmith. Herald added a subscriber: kristof.beyls. leoetlino requested review of this revision. Herald added a project: clang. If any arguments of a consteval function call are value-dependent, the call cannot be evaluated until

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff updated this revision to Diff 387121. fwolff added a comment. Thanks for your comments @salman-javed-nz! I have expanded the tests now according to your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113830/new/ https://reviews.llvm.org/D113830 Files:

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

fwolff updated this revision to Diff 387116. fwolff added a comment. Thanks for reviewing this @carlosgalvezp! I have removed the "dead" test and put it into a follow-up issue (PR#52502). If you are otherwise happy with the changes, could you commit them for me? CHANGES SINCE LAST ACTION

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp created this revision. carlosgalvezp added reviewers: aaron.ballman, whisperity. Herald added subscribers: rnkovacs, xazax.hun, mgorny. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently,

[clang] d0ac215 - [clang] Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2021-11-14T09:32:40-08:00 New Revision: d0ac215dd5496a44ce8a6660378ea40a6e1c148d URL: https://github.com/llvm/llvm-project/commit/d0ac215dd5496a44ce8a6660378ea40a6e1c148d DIFF: https://github.com/llvm/llvm-project/commit/d0ac215dd5496a44ce8a6660378ea40a6e1c148d.diff

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp created this revision. carlosgalvezp added reviewers: aaron.ballman, whisperity. Herald added subscribers: rnkovacs, xazax.hun. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Use NSDMI and remove

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaronpuchert added a subscriber: JonasToth. aaronpuchert added a comment. We could also introduce a separate (placeholder) type for initializer lists and perhaps also `ParenListExpr` if the dependent type seems misleading to you. CC @JonasToth for the changes to

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

aaronpuchert added a subscriber: Tyker. aaronpuchert added a comment. CC @Tyker for the changes to `SemaCXX/attr-annotate.cpp`. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5848-5849 def err_illegal_initializer_type : Error<"illegal initializer type %0">; +def

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks good! I'm not sure if it's OK to write "dead tests" though (the one with the `TODO` comment). Would it make sense to remove it from this patch, and add it in the patch

[PATCH] D113518: [clang] Create delegating constructors even in templates

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks great, thanks! I'm not comfortable reviewing the Sema part, maybe someone else can have a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/BraceInserter.cpp:21-56 +bool SupportsAnyAutomaticBraces(FormatStyle , bool insertion) { + if (insertion) { +if (Style.AutomaticBraces.AfterIf == FormatStyle::BIS_Always) + return true; +if

[PATCH] D113844: [clang-format] [NFC] build clang-format with -Wall

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. When building clang-format with -Wall on Visual Studio 20119 I see the following, prevent this

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfce3eed9f93a: [clang-format][c++2b] support removal of the space between auto and {} in… (authored by MyDeveloperDay). Repository: rG LLVM Github

[clang] fce3eed - [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

Author: mydeveloperday Date: 2021-11-14T14:13:44Z New Revision: fce3eed9f93afac512d809c22234db7be7a9d478 URL: https://github.com/llvm/llvm-project/commit/fce3eed9f93afac512d809c22234db7be7a9d478 DIFF: https://github.com/llvm/llvm-project/commit/fce3eed9f93afac512d809c22234db7be7a9d478.diff

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay updated this revision to Diff 387073. MyDeveloperDay added a comment. minor comment and unit test change before committing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113826/new/ https://reviews.llvm.org/D113826 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Okay, libcxx pipeline passes, disregarding the clang-format failure for pre-existing badness in those files, which would need to be fixed separately or else git loses track of the rename. The AIX failures also seem completely unrelated. Repository: rG LLVM Github

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:329 + + // FIXME: The fixes from ATOverridden should be propagated to the following call + a_vTitem.BadBaseMethod(); The fixes

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:1260 if (Decl->isMain() || !Decl->isUserProvided() || -Decl->size_overridden_methods() > 0) +Decl->size_overridden_methods() > 0 ||