[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3148501 , @Anastasia wrote: > Could you please clarify the interface to SPIRV-LLVM-Translator tool, > specifically: > > - Does clang lookup the path to the translator or assume any default path? HIPSPV primarily rel

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder added a comment. Hey @MaskRay, I know you've already approved but just to be sure: does the last round of changes look good? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 ___ cfe-c

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

nridge added a comment. In D114058#3150606 , @kadircet wrote: > thanks, lgtm! let me know of your email address (for commit attribution) if > you want me to land this for you. While I don't see it surfaced anywhere in the Phabricator UI, there is in fac

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

tstellar added a comment. @ZarkoCA If you are planning to do a lot of this, it might be good to write a script (or a clang-tidy check even) that we can add to CI, so these terms don't get re-introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. This is probably just a draft, but please let me know what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits ma

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389658. vtjnash added a comment. enable help Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389656. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/cl

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389655. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389653. vtjnash added a comment. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-ti

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389652. vtjnash added a comment. Herald added a subscriber: arphaman. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D114571: add release notes, docs mention, and test example

vtjnash created this revision. Herald added subscribers: arphaman, mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114571 Files: clang-tools-ext

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389650. SixWeining retitled this revision from "[clang][unittests]Fix a clang unittest linking issue" to "[clang][unittests] Fix a clang unittest linking issue". SixWeining edited the summary of this revision. SixWeining added a comment. Herald add

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, kbarton, PowerPC. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/D114143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 added a comment. Related discussions: D72498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 ___ cfe-commits mailing lis

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389638. lh123 added a comment. format code and add testcase for template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

rjmccall added subscribers: rsmith, rjmccall. rjmccall added a comment. If you aren't sure what a comment means, please feel free to CC Richard or me, and we might be able to help. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgalve

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai updated this revision to Diff 389630. vsapsai added a comment. Switch from checking module visibility to checking if a module is imported. Required to handle not re-exported modules - allow to deserialize decls from them even if the modules aren't visible. Repository: rG LLVM Github M

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

owenpan added a comment. In D114430#3152609 , @HazardyKnusperkeks wrote: > In D114430#3151082 , @klimek wrote: > >> Thanks for cleaning up after me, and sorry for the mess - do y'all have >> clang-format set up

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5536 +// GCC does not enforce these rules for GNU atomics, but we do, because if +// we didn't it would be very confusing. FIXME: For whom? How so? auto IsAllowedValueType = [&](QualType

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

andrew.w.kaylor added a comment. Thanks for the patch! This looks mostly good. I have just a few suggestions. Could you add test cases in clang/test/Driver/clang_f_opts.c to verify that the various driver inputs get overridden in the expected way? Without such a test, this behavior is likely to

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

HazardyKnusperkeks added a comment. In D114430#3151082 , @klimek wrote: > Thanks for cleaning up after me, and sorry for the mess - do y'all have > clang-format set up as a presubmit or do you just remember to format manually? I think one "problem" is t

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:471 - + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax. + + ``-Wthread-safety-attributes``: Validation checks on attribute syntax. + ``-Wthread-safety-analysis``: The cor

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:152 + } +MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgument) +MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgumentLoc) hokein wrote: > These are types that are not covered in t

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 updated this revision to Diff 389620. jcking1034 marked 3 inline comments as done. jcking1034 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei created this revision. masoud.ataei added reviewers: andrew.w.kaylor, aaron.ballman, erichkeane, bmahjour. masoud.ataei added a project: clang. masoud.ataei requested review of this revision. Herald added a subscriber: cfe-commits. Fining the bug number Bug 52565: https://bugs.llvm.o

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; m

[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

Quuxplusone added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:471 - + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax. + + ``-Wthread-safety-attributes``: Validation checks on attribute syntax. + ``-Wthread-safety-analysis``: The core

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, delesley, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114562 Files: clang/docs/T

[clang] 1ad7de9 - Headers: exclude `#include_next ` on MSVC

Author: Saleem Abdulrasool Date: 2021-11-24T12:52:16-08:00 New Revision: 1ad7de9e92bc2977698e5f6d6493202b50c912d5 URL: https://github.com/llvm/llvm-project/commit/1ad7de9e92bc2977698e5f6d6493202b50c912d5 DIFF: https://github.com/llvm/llvm-project/commit/1ad7de9e92bc2977698e5f6d6493202b50c912d5.

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

yaxunl added a comment. we also need a sema test like clang/test/SemaOpenCL/atomic-ops.cl Comment at: clang/test/CodeGenCUDA/atomic-ops.cu:30-32 + val = __hip_atomic_load(ptr, __HIP_MEMORY_SCOPE_SINGLETHREAD); + __hip_atomic_store(ptr, ptr2, 5); + flag = __hip_atomic_compare

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoD.td:489 +let Predicates = [HasStdExtZdinx] in { +def : InstAlias<"fabs.d $rd, $rs", (FSGNJX_D_INX GPRF64Op:$rd, GPRF64Op:$rs, GPRF64Op:$rs)>; Aren't these aliases only valid f

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:69 {"zfh", RISCVExtensionVersion{0, 1}}, +{"zfinx", RISCVExtensionVersion{1, 0}}, +{"zdinx", RISCVExtensionVersion{1, 0}}, Do we need to enforce that these can't be mix

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to postpone anlysis of the ranged for loops till the actual i

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:511 +RISCVPragmaHandler = std::make_unique(Actions); +PP.AddPragmaHandler(RISCVPragmaHandler.get()); + } Since this is a clang specific pragma should it be `#pragma clang ris

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

flx created this revision. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The matcher crashes when a variadic function pointer is invoked because the FunctionProtoType has fewer parameters than arguments. Matching of non-variadic argu

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/49558/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.ll

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In D114320#3151741 , @jessesna wrote: > In D114320#3148046 , > @MyDeveloperDay wrote: > >> O

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389577. gandhi21299 added a comment. removed changes in atomic-ops.cl, CUDA test may be sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 Files: clang

[clang] d42a643 - [NFC][clang]Inclusive language: remove remaining uses of sanity

Author: Zarko Todorovski Date: 2021-11-24T14:20:13-05:00 New Revision: d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb URL: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb DIFF: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb.di

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, b-sumner, t-tye, tra, rjmccall. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce __hip_atomic_load, __hip_atomic_store and __hip_atomic_compare_ex

[clang] c79345f - [NFC][Clang][test] Inclusive language: Remove and rephrase uses of sanity test/check in clang/test

Author: Zarko Todorovski Date: 2021-11-24T14:03:49-05:00 New Revision: c79345fb7b149d9c952f8506c9e6c6317a5b4cd8 URL: https://github.com/llvm/llvm-project/commit/c79345fb7b149d9c952f8506c9e6c6317a5b4cd8 DIFF: https://github.com/llvm/llvm-project/commit/c79345fb7b149d9c952f8506c9e6c6317a5b4cd8.di

[clang] dc1aa8e - [PowerPC] Add missed clang portion of c933c2eb3346

Author: Nemanja Ivanovic Date: 2021-11-24T12:42:58-06:00 New Revision: dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea URL: https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea DIFF: https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea.di

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote:

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to do the analysis of the captured expressions in the clauses

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp added a comment. @sammccall could you take a look at the other changes when you have time? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114100/new/ https://reviews.llvm.org/D114100 ___ c

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 06d4a76 - [NFC][AIX]Disable precompiled module file tests on AIX

Author: Steven Wan Date: 2021-11-24T13:22:09-05:00 New Revision: 06d4a76309cd97e25859770b3da29006ccac421a URL: https://github.com/llvm/llvm-project/commit/06d4a76309cd97e25859770b3da29006ccac421a DIFF: https://github.com/llvm/llvm-project/commit/06d4a76309cd97e25859770b3da29006ccac421a.diff LO

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan updated this revision to Diff 389535. stevewan added a comment. Explain the rationale Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodul

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3150298 , @rjmccall wrote: > Your builtin is using custom type-checking (`t`), which suppresses all the > normal conversions that happen on expressions. Specifically

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

jlebar added a comment. > Let me summon them. *I have no memory of this place.* Sorry to disappoint. That blame was four years ago, not counting covid-related time dilation. I do agree that disabling a test just to please a static analyzer is probably not the best way to go. Repository:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389522. sgatev marked an inline comment as done. sgatev added a comment. Document the role of the "Dynamic" suffix in the name of DataflowAnalysisDynamic and its members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 389520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3148046 , @MyDeveloperDay wrote: > Ok now I'm a little puzzled, shouldn't this be covered by > `AllowShortIfStatementsOnASingleLine`? That's exactly what i thought when i first stumbled over the behavior :D But I t

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. I think the problem here is encapsulated by adding the following tests Style.BraceWrapping.AfterFunction = true; Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; Style.AllowShortIfStatementsOnASingleLine = FormatStyle::SIS_AllIfsAndElse; S

[PATCH] D114540: Big-endian version of vpermxor

nemanjai added a comment. Please also add a test for this builtin to the front end test `clang/test/CodeGen/builtins-ppc-crypto.c` Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2499 (COPY_TO_REGCLASS $c, VSRC>; + def : Pa

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. > @curdeius > Alright, I'll create a report https://bugs.llvm.org/show_bug.cgi?id=52598 That is related. But I'd rather handle it separately because the fix for the function and the fix for a while or if will need to be different. It really comes down to this

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b96b2a0bf65: [clang][AST] Check context of record in structural equivalence. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6b96b2a - [clang][AST] Check context of record in structural equivalence.

Author: Balázs Kéri Date: 2021-11-24T17:36:15+01:00 New Revision: 6b96b2a0bf65ff838d4dbf909a5120d4d1083e29 URL: https://github.com/llvm/llvm-project/commit/6b96b2a0bf65ff838d4dbf909a5120d4d1083e29 DIFF: https://github.com/llvm/llvm-project/commit/6b96b2a0bf65ff838d4dbf909a5120d4d1083e29.diff L

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

flx added a comment. This looks great, but goes past my knowledge of the AST API :) While the existing and new test coverage provides good confidence, one other reviewer taking look would be good. Comment at: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp:112 +

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet updated this revision to Diff 389504. courbet added a comment. Rebase on submitted unit tests so that we can see the changes better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114539/new/ https://reviews.llvm.org/D114539 Files: clang-

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor nit. Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + Let's add a comment, to let folks know

[PATCH] D114540: Big-endian version of vpermxor

tislam created this revision. tislam added a reviewer: nemanjai. Herald added subscribers: kbarton, hiraditya. tislam requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. A big-endian version of `vpermxor`, named `vpermxor_be`,

[clang-tools-extra] 3b72448 - [clang-tidy] Add unit tests for `DeclRefExprUtils`.

Author: Clement Courbet Date: 2021-11-24T16:47:55+01:00 New Revision: 3b72448084052785b79566fa5bd374feb8ae3907 URL: https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907 DIFF: https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907.dif

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

KyrBoh added a comment. @MyDeveloperDay > What it seems is "AllowShortIfStatementsOnASingleLine" ONLY seems to work > when there are no {} AFAIR, there are 2 settings (in case of control statements): - AllowShortBlocksOnASingleLine --> whether to treat (curly-)braced blocks as a single statem

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. However if we add AllowShortBlocksOnASingleLine : Always then it will be class Foo { foo() { if (x) bar(); if (x) { bar(); } } }; but if we set BasedOnStyle: LLVM AllowShortIfStatementsOnASingleLine: Never ColumnLimit: 80 Allow

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added a comment. I think it's in pretty good shape, please have a look to help me move this forward. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114105/new/ https://reviews.llvm.org/D114105 ___ cfe-commits mailing list cfe-commits

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal updated this revision to Diff 389496. steakhal edited the summary of this revision. steakhal added a comment. Bitshifts have nothing to do with this issue, thus I'm simply matching for bitfield -> `int` implicit casts due to promotions. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. @KyrBoh, could you create a bug report for the problem you described, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114521/new/

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. In D114521#3151431 , @curdeius wrote: > LGTM, but I have one question. You mentioned in the bug ticket comment that > "this exposes a greater issue in AllowShortXXX". Have you found other cases > that misbehave? If so, th

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet created this revision. courbet added reviewers: flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. courbet requested review of this revision. Herald added a project: clang-tools-extra. This includes modifying `DeclRefExprUtils` to handle more cases. Repositor

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto &OpenCLFeaturesMap = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > azabaznov wrote: > > Anastasia wrote: > > > What test case cover

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3151482 , @lebedev.ri wrote: > In D114533#3151423 , @arsenm wrote: > >> Patch description should include this avoids a need to introduce >> ptrtoint/inttoptr pairs > > That is

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

KyrBoh added a comment. In D114521#3151431 , @curdeius wrote: > LGTM, but I have one question. You mentioned in the bug ticket comment that > "this exposes a greater issue in AllowShortXXX". Have you found other cases > that misbehave? If so, then it wo

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. In D114533#3151423 , @arsenm wrote: > Patch description should include this avoids a need to introduce > ptrtoint/inttoptr pairs That is a good point, but all the motivational cases seem to be about chaining the address spac

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay updated this revision to Diff 389488. MyDeveloperDay added a comment. Rebasing previously landed but reverted commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyle

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added a comment. In D114504#3151332 , @djtodoro wrote: > Thanks for doing this! Can you please update the summary, since it hard to > read with the format like this (at least, just try to reformat the debugger > output properly with the Phabricator

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

curdeius added a comment. LGTM, but I have one question. You mentioned in the bug ticket comment that "this exposes a greater issue in AllowShortXXX". Have you found other cases that misbehave? If so, then it would probably be good to add them. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

bmahjour added a comment. @nemanjai how come the changes in `altivec.h` and `clang/test/CodeGen/builtins-ppc-p8vector.c` have been removed in the latest diff and the commit above? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114088/new/ https://

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. Patch description should include this avoids a need to introduce ptrtoint/inttoptr pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 __

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. After rebasing these tests seem to work (on Windows) -- Testing: 24 tests, 16 workers -- PASS: Clang :: Format/dry-run-alias.cpp (1 of 24) PASS: Clang :: Format/remove-duplicate-includes.cpp (2 of 24) PASS: Clang :: Format/disable-format.cpp (3 of 24) PAS

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 389481. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files: clang/lib/Headers/unwind.h libunwind/include/libunwind

[PATCH] D114502: File Reorganization changes

mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) mehdi_amini wrote: > Is MLIR really coupled to Clang h

[PATCH] D114502: File Reorganization changes

yaxunl added a comment. could you please include a complete diff context in the patch? You can do that by using git diff -U Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HI

[PATCH] D114502: File Reorganization changes

mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) Is MLIR really coupled to Clang here? That seems suspi

[PATCH] D114502: File Reorganization changes

raramakr created this revision. raramakr added reviewers: yaxunl, msearles. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389352. mizvekov added a comment. - fix IntrospectionTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeN

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389298. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. - Avoid using any storage for an empty ElaboratedTYpeLoc. - But we still require pointer alignm

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. Is there an RFC? This quite seems like asking for problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 ___ cfe-commits mailing

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 created this revision. skc7 added reviewers: sameerds, arsenm. Herald added subscribers: dexonsmith, lxfind, jdoerfert, zzheng, hiraditya. skc7 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang, LLVM. When the addrspacec

[PATCH] D114527: [VE] Support multiple architectures installation

kaz7 updated this revision to Diff 389479. kaz7 added a comment. Update ve-toolchain.c and ve-toolchain.cpp using -ccc-install-dir option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews.llvm.org/D114527 Files: clang/li

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. Thanks for doing this! Can you please update the summary, since it hard to read with the format like this (at least, just try to reformat the debugger output properly with the Phabricator formatters)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

fcambus created this revision. fcambus added reviewers: emaste, mgorny. Herald added subscribers: krytarowski, arichardson. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All supported FreeBSD platforms do not have GCC in base anym

  1   2   >