[PATCH] D114527: [VE] Support multiple architectures installation

kaz7 updated this revision to Diff 391223. kaz7 added a comment. Rebase to the latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews.llvm.org/D114527 Files: clang/lib/Driver/ToolChains/VEToolchain.cpp clang/tes

[PATCH] D114890: [OpenMP] Make the new device runtime the default

JonChesterfield added a comment. This will definitely break amdgpu bot without D114865 landed first. However that patch is currently blocked by Matt, so we may want to land this and disable the amdgpu buildbot until the backend is fixed. Repository: rG LLV

[PATCH] D114849: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16b781e6d16d: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU (authored by skc7). Repository: rG LLVM Github Monorepo CHANGE

[clang] 16b781e - [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

Author: skc7 Date: 2021-12-02T05:53:25Z New Revision: 16b781e6d16dead414a7036c8b59f1700ea49251 URL: https://github.com/llvm/llvm-project/commit/16b781e6d16dead414a7036c8b59f1700ea49251 DIFF: https://github.com/llvm/llvm-project/commit/16b781e6d16dead414a7036c8b59f1700ea49251.diff LOG: [AMDGPU]

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

oontvoo accepted this revision. oontvoo added a comment. LG - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai added a subscriber: Bigcheese. vsapsai added a comment. Adding Michael who is infinitely better than me in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114833/new/ https://reviews.llvm.org/D114833

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai added a comment. As I was trying to replicate C++ behavior I've created a test case ambiguous-anonymous-enum-lookup.cpp. And it results in diagnostics clang/test/Modules/Output/ambiguous-anonymous-enum-lookup.cpp.tmp/test.cpp:6:10: warning: ambiguous use of internal linkage declarati

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. based on Shilei's last comment, do it in the morning ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list cfe

[PATCH] D114890: [OpenMP] Make the new device runtime the default

tianshilei1992 added a comment. In D114890#3165883 , @jhuber6 wrote: > In D114890#3165879 , @ronlieb wrote: > >> works for me, i think Greg is ok with it too, we chatted internally an hour >> or so ago > > Should

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 added a comment. In D114890#3165879 , @ronlieb wrote: > works for me, i think Greg is ok with it too, we chatted internally an hour > or so ago Should I just land it now and sleep or wait until tomorrow? Whichever causes the least downtime for

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai updated this revision to Diff 391189. vsapsai added a comment. Attempt to restore a previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114833/new/ https://reviews.llvm.org/D114833 Files: clang/lib/Sema/SemaDecl.cpp clang/te

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb accepted this revision. ronlieb added a comment. works for me, i think Greg is ok with it too, we chatted internally an hour or so ago Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 added a comment. In D114890#3165799 , @ronlieb wrote: > perhaps we can try this patch as is, and if it passes buildbot, let the new > DeviceRTL be the default upstream for all targets. > if it fails the AMDGPU buildbot, then perhaps apply the abo

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai updated this revision to Diff 391187. vsapsai added a comment. Add a test case for referencing an anonymous enum constant in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114833/new/ https://reviews.llvm.org/D114833 Files: clang/tes

[PATCH] D112626: Convert float to double on __builtin_dump_struct

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2090-2094 +// Variadic functions expect the caller to promote float to double. +if (CanonicalType == Context.FloatTy) { + FieldPtr = + CGF.Builder.CreateFPExt(FieldPtr, CGF.ConvertTy

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:636-638 +unsigned AS = PointeeType->isFunctionTy() + ? getDataLayout().getProgramAddressSpace() + : Context.getTargetAddressSpace(ETy); aa

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. perhaps we can try this patch as is, and if it passes buildbot, let the new DeviceRTL be the default upstream for all targets. if it fails the AMDGPU buildbot, then perhaps apply the above suggested change of leaving old runtime default for now for AMD. or consider some

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114890: [OpenMP] Make the new device runtime the default

gregrodgers requested changes to this revision. gregrodgers added a comment. This revision now requires changes to proceed. I forgot to add the "request changes" action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm

[PATCH] D114890: [OpenMP] Make the new device runtime the default

gregrodgers added a comment. We want amdgcn to remain on old deviceRTL till we have verified it . I made inline comments on how this could be done. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5905 // runtime. if (Args.hasFlag(options::OPT_fopenmp_target_n

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D114902: [Attrs] Elaborate on the trivial_abi documentation

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3217 +are balanced, and that this attribute can safely be applied to +reference-counting smart pointers. + I would change the first sentence here to: > Arguments of ``trivial_abi``

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

thakis added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG987a21522f2c: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 987a215 - [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

Author: Fabian Wolff Date: 2021-12-02T01:53:12+01:00 New Revision: 987a21522f2c7d799d0c2a720b3315a4fb6d1e74 URL: https://github.com/llvm/llvm-project/commit/987a21522f2c7d799d0c2a720b3315a4fb6d1e74 DIFF: https://github.com/llvm/llvm-project/commit/987a21522f2c7d799d0c2a720b3315a4fb6d1e74.diff

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese updated this revision to Diff 391166. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/ https://reviews.llvm.org/D114206 Files: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp clang/test/ClangScanDeps/modulemap-via-

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. In D111400#3164301 , @cor3ntin wrote: > If the issue is regarding the support and extension warning in C++20 and > older modes, it's something I can address by conserving the status quo in > older versions. I thi

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese added a comment. There were two issues for Windows. The first is an actual bug in the Clang VFS that should be fixed separately. You cannot pass just `main.m` as the input to Clang. Clang asks for its parent directory textually, which is `.`. It then tries to stat `.`, which the VFS

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff added a comment. In D114299#3164127 , @aaron.ballman wrote: > Hmm, the test case you added passes without the patch applied: > https://godbolt.org/z/T9TerMYGz You are right; I have fixed the test now, and I've also added your other example as a

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff updated this revision to Diff 391163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114299/new/ https://reviews.llvm.org/D114299 Files: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp clang-tools-extra/test/clang-tidy/checkers/readability-redundant-decl

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen updated this revision to Diff 391159. samitolvanen marked 5 inline comments as done. samitolvanen added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/ https://reviews.llvm.org/D108479 Files:

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

brooks added a comment. Thanks, this will kill off one of the patches in our ports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114530/new/ https://reviews.llvm.org/D114530 ___ cfe-commits mailing list

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith added a comment. In D114732#3159247 , @Quuxplusone wrote: > - D50119 has more extensive tests, and has > been live on https://p1144.godbolt.org/z/axx9Wj3r5 for a couple years now; if > the consensus is that Clan

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 391140. CJ-Johnson added a comment. Delete non-functional test cases (which were previously commented out) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

martong added a comment. In D114887#3165397 , @steakhal wrote: > Also, please provide the coverage of the new test case (only excercising the > new test case not the whole test file) I really want to make sure that it > will cover the loop as it suppose

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. To other reviewers: barring any additional comments, I will push this patch tomorrow morning (CJ doesn't have commit rights). Comment at: clang-tools-extra/test/clang-tid

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

steakhal added a comment. Also, please provide the coverage of the new test case (only excercising the new test case not the whole test file) I really want to make sure that it will cover the loop as it supposed to. Oh, I just now see that there is no test. Now I'm really courious. Repository

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

steakhal added a comment. I think I'm in favor of this change. However, Im also slightly in favor of reverting stuff instead of rushing things. Let's hope it will resolve the issue of the previous offending commit. Accepted. Comment at: clang/lib/StaticAnalyzer/Core/RangeCon

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks created this revision. aeubanks added a reviewer: rsmith. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A CXXDeductionGuideDecl references its class's template parameters (rather than cloning them). This causes us to cur

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong added a comment. I've had the confidence to commit D114887 , the test should not be flaky anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 __

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I really hate that we need to hardcode defaults like this but this is outside this patch. IMHO `cc`/`c++` should work everywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 20f8733 - [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

Author: Gabor Marton Date: 2021-12-01T22:23:41+01:00 New Revision: 20f8733d4b8d5bdb93080b8824de57b7fae31785 URL: https://github.com/llvm/llvm-project/commit/20f8733d4b8d5bdb93080b8824de57b7fae31785 DIFF: https://github.com/llvm/llvm-project/commit/20f8733d4b8d5bdb93080b8824de57b7fae31785.diff

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20f8733d4b8d: [Analyzer][solver] Simplification: Do a fixpoint ite

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

martong added a comment. I am attaching the performance measurement results: F20834663: removemember_revert_with_another_fixpoint.png F20834673: stats.html There is no any noticeable difference. I am going to commit thi

[PATCH] D114833: [modules] Fix ambiguous name lookup for enum constants from hidden submodules.

vsapsai added a comment. After more testing and thinking I've realized we are still not handling anonymous enums properly. On one hand anonymous EnumDecl aren't duplicates and we aren't making a hidden EnumDecl + EnumConstantDecl visible and don't have ambiguity problems. On the other hand, whe

[PATCH] D114849: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114849/new/ https://reviews.llvm.org/D114849 ___ cfe-commits mailing list cfe-

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

avogelsgesang added a comment. @aaron.ballman can you please commit this on my behalf? I don't have commit access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/ https://reviews.llvm.org/D112648 _

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. > but we could pick a couple of esoteric targets where integrals differ > significantly from what we have on x86_64 Turns out `wasm` and `darwin` also have a similar problem, I added them to the skip list for now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

avogelsgesang updated this revision to Diff 391121. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. Add missing dot to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/ https://reviews.llvm.org/D112648

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 391120. stevewan added a comment. Herald added subscribers: luke957, s.egerton, simoncook, fedor.sergeev, aheejin. Add targets we are interested in testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/n

[PATCH] D114902: [Attrs] Elaborate on the trivial_abi documentation

Quuxplusone added a comment. LgenerallyGTM! - I would say "special member functions" instead of "methods" - instead of "passed indirectly by address", consider saying "passed by hidden reference" — is this something people will get, or is it a me-ism? :) There are lots of Google hits for "by hi

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong added a comment. @thakis, if the issue is really disturbing and cannot wait until the review of D114887 finishes then please do a revert of this patch. But then the dependent child patch D103317 needs to be reverted a

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

ldionne marked an inline comment as done. ldionne added a comment. In D114649#3157040 , @Mordante wrote: > Since this patch requires both an update to both Clang and libc++ I think it > would land the Clang part in a separate patch. Then wait for the CI

[PATCH] D114903: [clang] Support array placement new in constant expressions

ldionne created this revision. ldionne added a reviewer: rsmith. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary for std::construct_at to work on arrays inside a constant expression. Repository: rG LLVM Github

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I had no idea... (As a follow-up question, should we be removing the `using` declarations starting around line 141 or so? Many of them are not used, and if the documentation dumper can't look through typedefs and gets th

[PATCH] D114902: [Attrs] Elaborate on the trivial_abi documentation

rnk created this revision. rnk added reviewers: aaron.ballman, rjmccall, dblaikie, ahatanak. rnk requested review of this revision. Herald added a project: clang. My team recently answered some questions about the trivial_abi attribute. This change attempts to distill those answers into user-focus

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

aaron.ballman closed this revision. aaron.ballman added a comment. In D113828#3165101 , @fwolff wrote: > In D113828#3164016 , @aaron.ballman > wrote: > >> LGTM! Can you add a release note about the bug fix? > > D

[clang-tools-extra] 844a8d3 - Fix false positives in `fuchsia-trailing-return` check involving deduction guides

Author: Fabian Wolff Date: 2021-12-01T15:28:01-05:00 New Revision: 844a8d3cecb4cc40e5d9694bcf111518910ea2ff URL: https://github.com/llvm/llvm-project/commit/844a8d3cecb4cc40e5d9694bcf111518910ea2ff DIFF: https://github.com/llvm/llvm-project/commit/844a8d3cecb4cc40e5d9694bcf111518910ea2ff.diff

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong added a comment. In D114619#3164898 , @thakis wrote: > The test sometimes fails flakily: http://45.33.8.238/macm1/22813/step_7.txt Thanks @thakis for the report, I am aware of the issue and addressing that in https://reviews.llvm.org/D114887 Re

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2218 +LLVM_NODISCARD +static SVal simplifyUntilFixpoint(SValBuilder &SVB, ProgramStateRef State, + const SymbolRef Sym) { Perhaps

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1735 + let Spellings = [Clang<"reference_counted">]; + let Subjects = SubjectList<[Record]>; + let Documentation = [Undocumented]; I've discussed a bit with Devin Coughlin yester

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

fwolff updated this revision to Diff 391102. fwolff added a comment. In D113828#3164016 , @aaron.ballman wrote: > LGTM! Can you add a release note about the bug fix? Done. Thank you for the review! Can you also commit it for me? You can use name and em

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small commenting nit. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:194 + // If we received a `const&` type, we nee

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added a comment. >> I think the safest bet is to be conservative and not allow mixing packs with >> variadics, and not allowing multiple packs. We should be able to diagnose >> that situation from ClangAttrEmitter.cpp to help attribute authors out. >> However, it'd be worth adding a

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

JonChesterfield added a comment. This works approximately as well as trunk does for me, provided D114865 is also applied. My baseline is not totally solid but I think there's a credible chance this would pass the buildbot, provided D114865

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 391099. ggeorgakoudis added a comment. Rebase, address comment, update few tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOp

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/Attr.td:544-546 + // Set to true for attributes that support parameter pack expansion in its + // argument

[PATCH] D114890: [OpenMP] Make the new device runtime the default

tianshilei1992 added a comment. In D114890#3164994 , @JonChesterfield wrote: > In D114890#3164899 , > @tianshilei1992 wrote: > >> Do we still want to run tests for the old device runtime? > > Maybe? We definitel

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay added a subscriber: felixonmars. MaskRay added a comment. I will wait until Dec 14 before committing. Hope Arch Linux folks can test this, too: @felixonmars @foutrelis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://revie

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. This is working well here on Gentoo. This brings some long-desired feature parity to Clang which we've been wanting downstream: GCC has had this option for quite a few years (after pus

[PATCH] D114890: [OpenMP] Make the new device runtime the default

JonChesterfield added a comment. In D114890#3164899 , @tianshilei1992 wrote: > Do we still want to run tests for the old device runtime? Maybe? We definitely don't want to run the tests for the new one twice Repository: rG LLVM Github Monorepo CHAN

[PATCH] D114859: [clang-format] Add better support for co-routinues

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22727 + +TEST_F(FormatTest, CoRoutineawait) { + verifyFormat("int x = co_await foo();"); MyDeveloperDay wrote: > Quuxplusone wrote: > > > naming of the tests is to allow easy r

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void updated this revision to Diff 391086. void marked an inline comment as done. void added a comment. Pretend that I've spoken English for most of my lyfe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:594 // If the predecessor's terminator is an "asm goto" that initializes - // the variable, then it won't be counted as "initialized" on the - // non-fallthrough paths.

[PATCH] D114890: [OpenMP] Make the new device runtime the default

tianshilei1992 added a comment. In D114890#3164885 , @JonChesterfield wrote: > D114891 enables this for the amdgpu tests. > > This patch will leave the nvptx tests running on the new runtime twice, and > not on the old

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

thakis added a comment. The test sometimes fails flakily: http://45.33.8.238/macm1/22813/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 ___ cfe-comm

[PATCH] D114890: [OpenMP] Make the new device runtime the default

JonChesterfield added a comment. D114891 enables this for the amdgpu tests. This patch will leave the nvptx tests running on the new runtime twice, and not on the old runtime at all, I think. lit.cfg should probably use old + new explicitly, instead of default

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Run a bunch of tests locally. This patch or something equivalent is a precondition on using the new device runtime on amdgpu, which we are very much out of time on (see D114890 which will break us as soon as it lands without th

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 updated this revision to Diff 391079. jhuber6 added a comment. Fixing driver tests that change with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 Files: clang/include/clang/Driver/Option

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3162140 , @rjmccall wrote: > Those all look good, thanks. Committed here Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114890: [OpenMP] Make the new device runtime the default

tianshilei1992 added a comment. That's quite the change! I think it's about time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list c

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 391076. mbenfield marked 8 inline comments as done. mbenfield added a comment. Replace DeclFD->getName() with just DeclFD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D1

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang marked 2 inline comments as done. avogelsgesang added a comment. Thanks for the instructions on how to build the documentation! I fixed a build issue in the docs (incorrect length of the table footer) and updated the wording slightly I am not planning any additional changes. If the

[clang] 3ee685f - [NFC][Clang] Fix some comments in clang

Author: Zarko Todorovski Date: 2021-12-01T13:36:46-05:00 New Revision: 3ee685f98abfc074419371b372681b56f7fd1a37 URL: https://github.com/llvm/llvm-project/commit/3ee685f98abfc074419371b372681b56f7fd1a37 DIFF: https://github.com/llvm/llvm-project/commit/3ee685f98abfc074419371b372681b56f7fd1a37.di

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 391075. avogelsgesang added a comment. Fix build error in documentation and update wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 Files: clang-tools-

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: dang, kerbowa, guansong, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG wit a nit Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1567 +} else + AggregatePtr = llvm::Constant::getNullValue(OMPBuilder.VoidPtr); ---

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 6eeda06 - [Clang] Fix nesting of discarded and immediate contexts.

Author: Corentin Jabot Date: 2021-12-01T12:58:32-05:00 New Revision: 6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 URL: https://github.com/llvm/llvm-project/commit/6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 DIFF: https://github.com/llvm/llvm-project/commit/6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880.diff

[libunwind] dc1244d - [runtimes] Move WARNING to FATAL_ERROR for folks using FOO_BUILD_32_BITS

Author: Louis Dionne Date: 2021-12-01T12:57:30-05:00 New Revision: dc1244dc4e76316ab24596545951d3dc47359875 URL: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875 DIFF: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875.diff

[libunwind] fa1c077 - [runtimes] Remove support for GCC-style 32 bit multilib builds

Author: Louis Dionne Date: 2021-12-01T12:57:01-05:00 New Revision: fa1c077b41ae1335332d65399802f2c68e82ca7b URL: https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b DIFF: https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b.diff

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 391068. CJ-Johnson added a comment. Add missing comment lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 391067. mbenfield added a comment. Revert spurious whitespace change. assert(D) No else after return. Allow attribute to be applied to static member functions and test this. Document that it can't be applied to a non-static member function. Repository:

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 391065. keith marked an inline comment as done. keith added a comment. Remove lld/lib directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 391064. Anastasia added a comment. - Exported full diff. - Added forgotten test cases. - Fixed typo in docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.llvm.org/D112410 Files: clang/docs/UsersManual.rst clang/in

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

reames abandoned this revision. reames added a comment. I'm stopping work on this. This has already exceeded the amount of work which is worthwhile for me, and it seems there is yet more work needed. On @nikic's prompting, I finally went ahead and got the test-suite setup and tested a clang ve

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective &S) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { arnamoy10

[clang] 6dd0bfa - [Clang][VE] Fix toolchain test when -DCLANG_DEFAULT_LINKER=lld in use

Author: Simon Moll Date: 2021-12-01T18:26:23+01:00 New Revision: 6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3 URL: https://github.com/llvm/llvm-project/commit/6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3 DIFF: https://github.com/llvm/llvm-project/commit/6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3.diff LO

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:198 +for (const ParmVarDecl *ParmDecl : collectParamDecls(Ctor, ParamDecl)) { + auto ParamTL = ParmDecl->getTypeSourceInfo()->getTypeLoc(); + auto RefTL = Pa

  1   2   >