[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 392662. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenHIP/hipspv-

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. Cherry-picking should work now, @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 392664. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 392665. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov updated this revision to Diff 392666. ASDenysPetrov added a comment. Fixed unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticA

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu updated this revision to Diff 392669. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115219/new/ https://reviews.llvm.org/D115219 Files: llvm/docs/Coroutines.rst llvm/lib/Transforms/Coroutines/CoroSplit.cpp llvm/test/Transforms

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: llvm/docs/Coroutines.rst:1395 +|| Landingpad | mark coroutine as done | mark coroutine done | +++-++---

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

ChuanqiXu added a comment. In D115222#3177269 , @rjmccall wrote: > Like a lot of the switched-resume lowering, this intrinsic is extremely tied > to C++ semantics. If C++ doesn't actually allow the optimization anymore, > then I completely agree that w

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay updated this revision to Diff 392674. MyDeveloperDay added a comment. Allow for option Raw String CharSequences CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIn

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 392675. linjamaki added a comment. - Add comments to clarify the limitation of the `--offload` option to one target. - Add test for multiple `--offload` option instances. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Thanks for the feedback. The `--offload` is meant to support multiple targets but right now it is restricted to one at most. The limitation comes from the HIPActionBuilder and CudaActionBuilderBase which currently expects a single target triple and toolchain for all o

[clang] 96b92d5 - [NFC] Only attach a declaration to global module fragment if it appears in a module

Author: Chuanqi Xu Date: 2021-12-08T17:16:31+08:00 New Revision: 96b92d5b3ec43be18146a346b65cc82766cf8b3a URL: https://github.com/llvm/llvm-project/commit/96b92d5b3ec43be18146a346b65cc82766cf8b3a DIFF: https://github.com/llvm/llvm-project/commit/96b92d5b3ec43be18146a346b65cc82766cf8b3a.diff LO

[PATCH] D115249: Clang-Tidy implicit bool conversion check use upercase suffixes

kili updated this revision to Diff 392678. kili added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115249/new/ https://reviews.llvm.org/D115249 Files: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:2589 + llvm::Regex RawStringRegex("R\"([A-Za-z]*)\\("); + SmallVector RawStringMatches; A raw s

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple amdgcn-am

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > How about pointers/references in th

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Requesting changes so that appears correctly in the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 ___

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Hi, just giving a progress update. This is just a early heads-up - no action needed from you at this stage. I have a rough prototype that seems promising. The big-O/time complexity is no longer dependent on the number of headers being included and the number of

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] e6d0b85 - [ARM][libunwind] add PACBTI-M support for libunwind

Author: Ties Stuij Date: 2021-12-08T09:44:45Z New Revision: e6d0b851f854849240bc1f02901b0dbb3be84388 URL: https://github.com/llvm/llvm-project/commit/e6d0b851f854849240bc1f02901b0dbb3be84388 DIFF: https://github.com/llvm/llvm-project/commit/e6d0b851f854849240bc1f02901b0dbb3be84388.diff LOG: [A

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d0b851f854: [ARM][libunwind] add PACBTI-M support for libunwind (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added a comment. Sorry for my late response, I'm busy with other things right now. I plan to come back to this in a couple of weeks. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:52 static bool areEquivalentNameSpecifier(const NestedNam

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:126 + bool HandleComment(Preprocessor &PP, SourceRange Range) override { +if (!isInsideMainFile(Range.getBegin(), SM) || Range.getBegin().isMacroID()) + return false; we'r

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392688. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve almost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: cl

[clang] 0a54c32 - Add note about inlining dllimport functions to the attribute docs

Author: Hans Wennborg Date: 2021-12-08T11:15:39+01:00 New Revision: 0a54c325beff37c57991e88799c213534c1fa6a9 URL: https://github.com/llvm/llvm-project/commit/0a54c325beff37c57991e88799c213534c1fa6a9 DIFF: https://github.com/llvm/llvm-project/commit/0a54c325beff37c57991e88799c213534c1fa6a9.diff

[PATCH] D115252: Add note about inlining dllimport functions to the attribute docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a54c325beff: Add note about inlining dllimport functions to the attribute docs (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115252/new/

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2605-2607 + if (!CharSequence.empty()) { +RawStringTermination = ")" + CharSequence + "\""; + } curdeius wrote: > Since `CharSequence` is empty, you might want to remo

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay added a comment. `So, you missed the digits and the characters: _{}[]#<>%:;.?*+-/^&|~!=,'.` The standard is nuts sometimes... let me add that madness in ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 __

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { erichkeane wrote: > So I was thinking about this overnight...

[clang] 5b6c083 - [clang][deps] Reset some benign codegen options

Author: Jan Svoboda Date: 2021-12-08T11:53:50+01:00 New Revision: 5b6c08379b437cb22fcd63707b94df1ede23d9db URL: https://github.com/llvm/llvm-project/commit/5b6c08379b437cb22fcd63707b94df1ede23d9db DIFF: https://github.com/llvm/llvm-project/commit/5b6c08379b437cb22fcd63707b94df1ede23d9db.diff L

[PATCH] D112923: [clang][deps] Reset some benign codegen options

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6c08379b43: [clang][deps] Reset some benign codegen options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112923/new/ https://

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392696. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 392703. MyDeveloperDay added a comment. Add some more unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files: clang/lib/Format/FormatToken.cpp clang/lib/Format/FormatToken.h clang/li

[clang] 9ae5810 - [HIPSPV] Convert HIP kernels to SPIR-V kernels

Author: Henry Linjamäki Date: 2021-12-08T12:18:15+03:00 New Revision: 9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 URL: https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 DIFF: https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0.dif

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10981

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392715. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index: llvm/include/llvm/ADT/Triple

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: shafik. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson.

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > curdeius wrote: > > How a

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392717. jansvoboda11 added a comment. Rebase on top of D115331 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files: clang

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &&SV, --

[PATCH] D115332: [clang][deps] Use lock_guard instead of unique_lock

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes uses of `std::unique_lock` to `std::lock_guard`. The `std::u

Re: TCE target nonconforming definition of long long and intmax_t

On Wed, Dec 8, 2021 at 2:20 AM Pekka Jääskeläinen wrote: > > Hi Aaron, > > Indeed the 32b TCE target is not fully compliant in this aspect; > its 64b emulation support is not complete, therefore we advertise > only these 32b limits. We have an in-progress 64b target where the > limits are 64b, but

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added a comment. Thanks for the review. Since I don't have commit access, so I want someone else to apply this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201

[clang] 8680f95 - Add __builtin_elementwise_ceil

Author: Jun Zhang Date: 2021-12-08T08:29:33-05:00 New Revision: 8680f951c21e675a110e79c9b8dc59bb94290b01 URL: https://github.com/llvm/llvm-project/commit/8680f951c21e675a110e79c9b8dc59bb94290b01 DIFF: https://github.com/llvm/llvm-project/commit/8680f951c21e675a110e79c9b8dc59bb94290b01.diff LOG

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the new functionality, I've committed on your behalf in 8680f951c21e675a110e79c9b8dc59bb94290b01 Comment at: clang/lib/Sema/S

[clang] ca70b80 - Removing some unused parameters from this test; NFC

Author: Aaron Ballman Date: 2021-12-08T08:35:07-05:00 New Revision: ca70b807ae655b3ff2378de7abfb9796cbf5d0b7 URL: https://github.com/llvm/llvm-project/commit/ca70b807ae655b3ff2378de7abfb9796cbf5d0b7 DIFF: https://github.com/llvm/llvm-project/commit/ca70b807ae655b3ff2378de7abfb9796cbf5d0b7.diff

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall marked an inline comment as done. sammccall added a comment. Thanks Dave! A last ping in case @rsmith has opinions here as clang owner. Otherwise I'd probably land this in a week or so. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2106 +TRY_TO(T

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

aaron.ballman added a comment. In D112881#3160590 , @paulaltin wrote: >> LGTM, with a few small nits. It'd be nice to update the patch summary with >> more information about why the option is needed. > > Thanks @aaron.ballman. I've made the changes to th

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392731. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c clang/test/Se

[PATCH] D115337: [X86][clang] Put the update of HasLongDouble into TargetInfo::adjust

pengfei created this revision. pengfei added reviewers: asavonic, erichkeane, nickdesaulniers, andrew.w.kaylor. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We found a problem that `-mlong-double-64` doesn't work with `-mno-x87`

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); HazardyKnusperkeks wrote: > curdeius wrote: > > curde

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp:291-293 +struct super_throws { + super_throws() noexcept(false) { throw 42; } +}; I think this needs additional test coverage. Dynamic exc

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { steffenlarsen wrote: > erichkeane wrote: > > So I was thinking ab

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel created this revision. ymandel added reviewers: gribozavr2, sgatev, xazax.hun. Herald added subscribers: rnkovacs, mgorny. ymandel requested review of this revision. Herald added a project: clang. Adds a general-purpose framework to support testing of dataflow analyses. Repository: rG

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392745. jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files: clan

[PATCH] D115337: [X86][clang] Put the update of HasLongDouble into TargetInfo::adjust

erichkeane added a comment. @craig.topper is the only one I know who can keep all of this straight, so perhaps he's willing to give a more in depth review? Comment at: clang/include/clang/Basic/TargetInfo.h:207 bool HasLongDouble; + bool Has80BitLongDouble; bool HasFPR

[PATCH] D115254: Use VersionTuple for parsing versions in Triple

jamesfarrell added a comment. In D115254#3177960 , @MaskRay wrote: > commit 219672b8dd06c4765185fa3161c98437d49b4a1b > says > `Revert "Revert "...""` > > For such commits, it is custo

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm a bit worried about using `hasAncestor()` (that has a tendency to match in surprising nested locations), but I can't come up with a test case that would be an issue, so this

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! sorry for taking so long. Comment at: clang-tools-extra/clangd/Headers.cpp:142 private: + // Level will be increased every time we enter the file and redu

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:49 - /// running out of file descriptors. + /// mismatching size of the file. static CachedFileSystemEntry createFileEntry(StringRef Filename,

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392753. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang-

[clang-tools-extra] eecfc73 - [clangd] Record IWYU pragma keep in the IncludeStructure

Author: Kirill Bobyrev Date: 2021-12-08T15:55:50+01:00 New Revision: eecfc73ae4b909dbf26bd2d85b8c6580927df9fc URL: https://github.com/llvm/llvm-project/commit/eecfc73ae4b909dbf26bd2d85b8c6580927df9fc DIFF: https://github.com/llvm/llvm-project/commit/eecfc73ae4b909dbf26bd2d85b8c6580927df9fc.diff

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeecfc73ae4b9: [clangd] Record IWYU pragma keep in the IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

FelixDombek removed a reviewer: EricWF. FelixDombek added a comment. This revision is now accepted and ready to land. @EricWF requested changes which have since been added, but he has been inactive for half a year; what is the process to go forward with this? CHANGES SINCE LAST ACTION https:/

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. D114072

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:495 + if (auto Edit = Inserter->insert(Name)) +return {Fix{llvm::formatv("Include {0}", Name).str(), {std::move(*Edit)}}}; + return {}; ---

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. Herald added a subscriber: hiraditya. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The minimizing and cachi

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you also add a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115124/new/ https://reviews.llvm.

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 updated this revision to Diff 392761. jansvoboda11 added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115346/new/ https://reviews.llvm.org/D115346 Files: clang/include/clang/Tooling/DependencyScannin

[clang-tools-extra] 2676759 - [clangd] Add fixes for clang "include " diagnostics

Author: Sam McCall Date: 2021-12-08T16:16:53+01:00 New Revision: 2676759bf22e45def4d37da74f09261b26a98d21 URL: https://github.com/llvm/llvm-project/commit/2676759bf22e45def4d37da74f09261b26a98d21 DIFF: https://github.com/llvm/llvm-project/commit/2676759bf22e45def4d37da74f09261b26a98d21.diff LO

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG2676759bf22e: [clangd] Add fixes for clang "include " diagnostics (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D114667?vs

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. Do either of you have thoughts on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107275/new/ https://reviews.llvm.org/D107275 ___ cfe-commits mailing list cfe-commits@

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c clang/test/Se

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

aaron.ballman added a comment. Mostly just nits from me. At a high level, I think this is good, but if someone else wanted to double-check the changes to the matcher statements themselves, that'd be good. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPoin

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM once D115259 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ htt

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev updated this revision to Diff 392772. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115235/new/ https://reviews.llvm.org/D115235 Files: clang/in

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev added a comment. Thanks everyone! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:32 +TypeErasedDataflowAnalysisState computeBlockInputState( +std::vector> &BlockStates, +const CFGBlock &Block, const Environment &InitEnv, -

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1194 SourceLocation Loc, - Sema::ConditionKind CK, +

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 392776. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 Files: clang/inclu

[PATCH] D115248: [clang] Fix Bug 28101

rZhBoYao updated this revision to Diff 392774. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. I added a test. There were 17 module and PCH related failed tests on my local machine; however, when I ran the test on then ToT

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

yaxunl added a comment. One drawback of this approach is that it does not work for LLVM modules generated from assembly or programmatically e.g. Tensorflow XLA. Another drawback is that if `__ockl_call_host_function` or `__ockl_fprintf_stderr_begin` are eliminated by optimizer, the module flag

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

steakhal marked an inline comment as done. steakhal added a comment. Sorry for my late response, I have a bunch of other tasks to do. --- In D115149#3175068 , @NoQ wrote: >> It can happen if the `Loc` was perfectly constrained to a concrete >> value (`n

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 392785. junaire added a comment. - Add extra type check to the vector elements. - Add comment about type restriction. - polish tests a little bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files: c

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:414 + auto &Includes = AST.getIncludeStructure(); + EXPECT_THAT(getUnused(AST, tran

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin created this revision. Herald added subscribers: dexonsmith, martong, hiraditya, MatzeB. Herald added a reviewer: shafik. Godin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. See https://wg21.link/cwg2237 Reposito

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unconventional-assign-operator.rst:12 + * The assignment may be from the class type by value, const lvalue +refe

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added a comment. It's been a year and a half since I heard anything about this patch and I'd honestly kind of forgotten about it. I'm still around/lurking though, and would assist with getting it landed if it's still good to go. Comment at: clang-tools-extra/clang-tid

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kbobyrev updated this revision to Diff 392810. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115345/new/ https://reviews.llvm.org/D115345 Files: clang-

[clang-tools-extra] b673bc3 - [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

Author: Kirill Bobyrev Date: 2021-12-08T18:07:40+01:00 New Revision: b673bc36eacd68c15262a222ce940f36f4be0cec URL: https://github.com/llvm/llvm-project/commit/b673bc36eacd68c15262a222ce940f36f4be0cec DIFF: https://github.com/llvm/llvm-project/commit/b673bc36eacd68c15262a222ce940f36f4be0cec.diff

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb673bc36eacd: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep (authored by kbobyrev). Repository: rG LLVM Github Monorepo

Re: TCE target nonconforming definition of long long and intmax_t

Hi Aaron, Indeed the 32b TCE target is not fully compliant in this aspect; its 64b emulation support is not complete, therefore we advertise only these 32b limits. We have an in-progress 64b target where the limits are 64b, but it's not upstreamed yet. Yes, TCE target is still maintained, but it

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:35 +TypeErasedDataflowAnalysis &Analysis) { + TypeErasedDataflowAnalysisState State = {Analysis.typeErasedInitialElement(), +

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added a comment. In D115283#3179651 , @yaxunl wrote: > One drawback of this approach is that it does not work for LLVM modules > generated from assembly or programmatically e.g. Tensorflow XLA. > > Another drawback is that if `__ockl_call_host_fu

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 392821. ASDenysPetrov added a comment. Improved dynamic type recognition. Provided `-fstrict-aliasing` compiler flag dependency. Still has issues with some cases (see it at the bottom of the test file). WIP. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman added a comment. In D112648#3165302 , @avogelsgesang wrote: > @aaron.ballman can you please commit this on my behalf? I don't have commit > access OMG, I'm sorry for missing this note! Yes, I'm happy to commit on your behalf. What name a

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, except I'd prefer the `#include`s be changed separately since that cleanup seems unrelated to this change. Comment at: lldb/unittests/Expression/CppModuleConfi

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 __

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

avogelsgesang added a comment. > What name and email address would you like me to use for patch attribution? Adrian Vogelsgesang, avogelsges...@salesforce.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/ https://reviews.llvm.org/D1126

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. It seems like your test file passes even before your patch. I've just checked it. My last pull from the baseline was on Nov 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115149/new/ https://reviews.llvm.org/D1151

  1   2   >