[clang] ba31cb4 - [CodeGen] Store element type in RValue

Author: Nikita Popov Date: 2021-12-17T09:05:59+01:00 New Revision: ba31cb4d388098e01df226090db95aaf8c06d271 URL: https://github.com/llvm/llvm-project/commit/ba31cb4d388098e01df226090db95aaf8c06d271 DIFF: https://github.com/llvm/llvm-project/commit/ba31cb4d388098e01df226090db95aaf8c06d271.diff

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal edited reviewers, added: a.sidorin, shafik, xazax.hun, teemperor; removed: hgabii. steakhal added a comment. We shouldn't skip mac targets. I CC ASTImporter folks, they probably have an M1 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. > no, I don't think that's quite what we want." :-) Sorry for not being specific enough :) What we want is to keep this (current user-facing behavior today): error: forgot to frobble the quux [bugprone-frobble-quux, cert-quux45-cpp] As opposed to: error: for

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3816 + Style.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; + Style.BreakBeforeBraces = FormatStyle::BS_Custom; + Style.BraceWrapping.AfterExternBlock = true; This line i

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9118 + NewFD->getKind() == Decl::Kind::CXXMethod && + NewFD->getName() == "__init" && D.isFunctionDefinition()) { +if (auto *def = Parent->getDefinition()) In our d

[PATCH] D115923: [RISCV][Don't Commit] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu created this revision. zixuan-wu added reviewers: asb, craig.topper, kito-cheng, luismarques, apazos, jrtc27, Jim, akuegel, jhenderson, MaskRay, sjarus. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, sameer.abuasal, s.egerton, be

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

arichardson added inline comments. Comment at: clang/test/Analysis/ctu-lookup-name-with-space.cpp:13 +// RUN: -verify %s + +void importee(); OikawaKirie wrote: > Adding this line here. Disabling the test on non- Linux is not a good idea IMO since it means we lo

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk I'm not certain but I think the only buildbot still using VS2017 is windows-gcebot2 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3195171 , @dblaikie wrote: > Ah, cool - could you include % growth on those rows Thanks, I edited the table in the previous comment. > (hmm, .debug_line and .debug_str shouldn't be changing in size with this > change, r

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added a comment. In D115503#3199459 , @Esme wrote: > In D115503#3195171 , @dblaikie > wrote: > >> Ah, cool - could you include % growth on those rows > > Thanks, I edited the table in the previous comment

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

ASDenysPetrov added a comment. @xazax.hun Many thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115883/new/ https://reviews.llvm.org/D115883 ___ cfe-commits mailing list cfe-commits@

[clang] da8bd97 - [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

Author: Denys Petrov Date: 2021-12-17T13:03:47+02:00 New Revision: da8bd972a33ad642d6237b5b95b31a2a20f46a35 URL: https://github.com/llvm/llvm-project/commit/da8bd972a33ad642d6237b5b95b31a2a20f46a35 DIFF: https://github.com/llvm/llvm-project/commit/da8bd972a33ad642d6237b5b95b31a2a20f46a35.diff

[clang] 9bf9173 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-17T12:11:50+01:00 New Revision: 9bf917394eba3ba4df77cc17690c6d04f4e9d57f URL: https://github.com/llvm/llvm-project/commit/9bf917394eba3ba4df77cc17690c6d04f4e9d57f DIFF: https://github.com/llvm/llvm-project/commit/9bf917394eba3ba4df77cc17690c6d04f4e9d57f.diff

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { +

[PATCH] D115879: [clang-format] extern with new line brace without indentation

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3819 + Style.IndentExternBlock = FormatStyle::IEBS_NoIndent; + verifyFormat("extern \"C\"\n{ /*13*/\n}", Style); + verifyFormat("extern \"C\"\n{\n" owenpan wrote: > curdeius wrot

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay updated this revision to Diff 395088. MyDeveloperDay added a comment. As always you are both correct - tidy up the unit tests to follow our pattern - reduce unnecessary style setting - try and tidy up the indent selection a little CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay marked 7 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1282-1300 if (FormatTok->Tok.is(tok::string_literal)) { nextToken(); if (FormatTok->Tok.is(tok::l_brace)) { +if (

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

ASDenysPetrov closed this revision. ASDenysPetrov added a comment. Closed with rGda8bd972a33ad642d6237b5b95b31a2a20f46a35 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115883/new

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov added a comment. @steakhal Thanks! I appreciate your comprehensive comment! I'll take everything you suggested into account. Comment at: clang/test/Analysis/Checkers/StrictAliasingChecker/strict-aliasing.cpp:2 +// RUN: %clang_cc1 -std=c++20 -analyze -analyzer-co

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

martong added a comment. In D115149#3195377 , @ASDenysPetrov wrote: > @martong > Thanks for clarification. > >> TLDR, it is recommended to use the arcanist. > > I'm not able to use arcanist. It doesn't work on Windows (at least I've tryed > several ways

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) {

[PATCH] D115931: [analyzer] Enable move semantics for CallDescriptionMap

gamesh411 created this revision. gamesh411 added reviewers: steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. gamesh411 requested review

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

martong created this revision. martong added reviewers: steakhal, NoQ, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

martong added a comment. In D115149#3181580 , @NoQ wrote: > Like, that's the whole reason why `nonloc::LocAsInteger` exists: so that we > could cast a pointer to an integer and actually have a way to represent the > resulting value as `NonLoc`. > I'm co

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:417 + // the member function of SValBuilder (?) + if (symRHS) +if (auto RLocAsInt = RHS.getAs()) { We should handle LHS as well. Repository: rG LLVM Github Monorepo

[clang] 4170ea9 - [clang][deps] NFC: Fix whitespace formatting

Author: Jan Svoboda Date: 2021-12-17T14:00:20+01:00 New Revision: 4170ea9445cc407ec1bf8cfa5bc5ce2d5295fa36 URL: https://github.com/llvm/llvm-project/commit/4170ea9445cc407ec1bf8cfa5bc5ce2d5295fa36 DIFF: https://github.com/llvm/llvm-project/commit/4170ea9445cc407ec1bf8cfa5bc5ce2d5295fa36.diff L

[clang] 195a529 - [clang][deps] NFC: Rename member variable

Author: Jan Svoboda Date: 2021-12-17T14:00:20+01:00 New Revision: 195a5294c28e982607cc11bc63c3be1c0e3c312b URL: https://github.com/llvm/llvm-project/commit/195a5294c28e982607cc11bc63c3be1c0e3c312b DIFF: https://github.com/llvm/llvm-project/commit/195a5294c28e982607cc11bc63c3be1c0e3c312b.diff L

[clang] af7a421 - [clang][deps] NFC: Remove explicit call to implicit constructor

Author: Jan Svoboda Date: 2021-12-17T14:00:20+01:00 New Revision: af7a421ef4aaf3d098ba78c1dda8ac35d31136cd URL: https://github.com/llvm/llvm-project/commit/af7a421ef4aaf3d098ba78c1dda8ac35d31136cd DIFF: https://github.com/llvm/llvm-project/commit/af7a421ef4aaf3d098ba78c1dda8ac35d31136cd.diff L

[clang] bcdf7f5 - [clang][deps] NFC: Take and store entry as reference

Author: Jan Svoboda Date: 2021-12-17T14:00:20+01:00 New Revision: bcdf7f5e9104cb87d06969d74f4feb0cc7aba08f URL: https://github.com/llvm/llvm-project/commit/bcdf7f5e9104cb87d06969d74f4feb0cc7aba08f DIFF: https://github.com/llvm/llvm-project/commit/bcdf7f5e9104cb87d06969d74f4feb0cc7aba08f.diff L

[clang] 3f3b5c3 - [clang][deps] NFC: Unify ErrorOr patterns

Author: Jan Svoboda Date: 2021-12-17T14:00:20+01:00 New Revision: 3f3b5c3ec0da8f4982a8645fdb403de582295f0b URL: https://github.com/llvm/llvm-project/commit/3f3b5c3ec0da8f4982a8645fdb403de582295f0b DIFF: https://github.com/llvm/llvm-project/commit/3f3b5c3ec0da8f4982a8645fdb403de582295f0b.diff L

[PATCH] D115934: [analyzer] Add range constructor to CallDescriptionMap

gamesh411 created this revision. gamesh411 added reviewers: steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. gamesh411 requested review

[PATCH] D115935: [clang][deps] NFC: Simplify handling of cached FS errors

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The return types of some `CachedFileSystemEntry` member function are needlessly

[PATCH] D115935: [clang][deps] NFC: Simplify handling of cached FS errors

jansvoboda11 updated this revision to Diff 395101. jansvoboda11 added a comment. Add more assertions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115935/new/ https://reviews.llvm.org/D115935 Files: clang/include/clang/Tooling/DependencyScannin

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 updated this revision to Diff 395102. jansvoboda11 added a comment. Implement new version that ensures the stat and contents of a file are always in sync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 updated this revision to Diff 395103. jansvoboda11 added a comment. Re-run CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966 Files: clang/include/clang/Tooling/DependencyScanning/Dependen

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

jansvoboda11 updated this revision to Diff 395104. jansvoboda11 added a comment. Rebase on top of new version of D114966 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://reviews.llvm.org/D114971

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113837/new/ https://reviews.llvm.org/D113837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D115936: [Clang] Add isInNamespace() to check if a Decl in a specific namespace

junaire created this revision. junaire added reviewers: rtrieu, ddunbar, CornedBee, gribozavr. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we can only check whether a Decl in namespace `std` or not. However, it will ve

[clang] a94f68a - Implement some constexpr vector unary operators, fix boolean-ops

Author: Erich Keane Date: 2021-12-17T06:08:36-08:00 New Revision: a94f68a2bd31db9712582b973e78746cee9a4e50 URL: https://github.com/llvm/llvm-project/commit/a94f68a2bd31db9712582b973e78746cee9a4e50 DIFF: https://github.com/llvm/llvm-project/commit/a94f68a2bd31db9712582b973e78746cee9a4e50.diff L

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa94f68a2bd31: Implement some constexpr vector unary operators, fix boolean-ops (authored by erichkeane). Herald added a project: clang. Repository:

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/27740 Ensure #define _u(str) u#str #defin

[PATCH] D115879: [clang-format] extern with new line brace without indentation

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1285-1287 +if (Style.BraceWrapping.AfterExternBlock) { + addUnwrappedLine(); } --

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

curdeius added a comment. When at it, should we also take care of `LR"(string)"`, `uR...`, `u8R` and `UR`? Cf. https://en.cppreference.com/w/cpp/language/string_literal From MS doc: // Raw string literals containing unescaped \ and " auto R0 = R"("Hello \ world")"; // const char* auto R1

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay added a comment. In D115938#3199832 , @curdeius wrote: > When at it, should we also take care of `LR"(string)"`, `R`, `uR`, `u8R` and > `UR`? Cf. https://en.cppreference.com/w/cpp/language/string_literal > From MS doc: > > // Raw string

[PATCH] D115934: [analyzer] Add range constructor to CallDescriptionMap

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:24-28 +static_assert( +std::is_constructible, + decltype(std::declval

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

curdeius added a comment. You shouldn't have added the outer quotes as `#str` adds them. This works: // clang-format off #define MyRawString(str) R#str void foo() { const auto * s1 = MyRawString((" Hello \ world ")); const auto * s2 = MyRawString(abc(" Hello \ world ")abc);

[PATCH] D115931: [analyzer] Enable move semantics for CallDescriptionMap

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:22 +static_assert(std::is_move_constructible>() && + std::is_move_assignable>()

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

steakhal added a comment. Many thanks for digging into this @martong. I really enjoyed it! I also believe that this is the fix for the underlying issue. I also think the `getAsSymbol()` should be somewhere where we can create new symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys added a comment. This is my first PR into this repo. I'd like to learn more about the process of submitting patches, specifically about: - Do I need to get LGTM from all the reviewers before I can submit it? - There are some build failures on the CI, but look unrelated, do I force sub

[clang] 9e45146 - [CodeGen] Fix element type for sret argument

Author: Nikita Popov Date: 2021-12-17T16:13:28+01:00 New Revision: 9e451467217be1325e95eca60bad7924d23e4fe4 URL: https://github.com/llvm/llvm-project/commit/9e451467217be1325e95eca60bad7924d23e4fe4 DIFF: https://github.com/llvm/llvm-project/commit/9e451467217be1325e95eca60bad7924d23e4fe4.diff

[PATCH] D115936: [Clang] Add isInNamespace() to check if a Decl in a specific namespace

junaire updated this revision to Diff 395125. junaire added a comment. Format patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115936/new/ https://reviews.llvm.org/D115936 Files: clang/include/clang/AST/DeclBase.h clang/lib/AST/DeclBase.cp

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added a comment. In D115738#3199879 , @peterstys wrote: > This is my first PR into this repo. I'd like to learn more about the process > of submitting patches, specifically about: > > - Do I need to get LGTM from all the reviewers before I

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang

ezhulenev added a subscriber: mehdi_amini. ezhulenev added a comment. There are two places where in MLIR you can put an attribute to coroutine functions: 1. https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp#L126 This is the point when coro

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei updated this revision to Diff 395128. pengfei added a comment. Split the LLVM datalayout to a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115441/new/ https://reviews.llvm.org/D115441 Files: clang/lib/Basic/TargetInfo.c

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei updated this revision to Diff 395129. pengfei added a comment. Split the LLVM datalayout to a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115441/new/ https://reviews.llvm.org/D115441 Files: clang/lib/Basic/TargetInfo.c

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei created this revision. pengfei added reviewers: rnk, andrew.w.kaylor, erichkeane, craig.topper. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MSVC currently doesn't s

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. This is split from D115441 . Add a targeted LLVM test. Thanks @rnk for the advise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 _

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys added a comment. In D115738#3199896 , @MyDeveloperDay wrote: > In D115738#3199879 , @peterstys > wrote: > >> This is my first PR into this repo. I'd like to learn more about the process >> of submitti

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added a comment. In D110622#3199233 , @linjamaki wrote: > Assuming that this patch is ready to land. @tra or @yaxunl, could you please > commit this patch to the LLVM for us? Thanks. I can help commit this patch. Repository: rG LLVM Github Mo

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added a comment. Thank you for the patch We'll need your name and email address for that, but yes we'll be happy to commit it for you. If you think you'd like to play some more, then you can apply for commit access. (not sure of the process for that now, but its probably in the

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay updated this revision to Diff 395135. MyDeveloperDay added a comment. Add the raw string literal cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115938/new/ https://reviews.llvm.org/D115938 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatT

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:275 + const auto &Entry1 = getOrEmplaceSharedEntryForUID(std::move(TEntry)); + const auto &Entry2 = getOrInsertSharedEntryForFilename(Filename, Entry1); + ret

[clang] 9fd4f80 - [ConstantFolding] Unify handling of load from uniform value

Author: Nikita Popov Date: 2021-12-17T17:05:06+01:00 New Revision: 9fd4f80e33a4ae4567483819646650f5735286e2 URL: https://github.com/llvm/llvm-project/commit/9fd4f80e33a4ae4567483819646650f5735286e2 DIFF: https://github.com/llvm/llvm-project/commit/9fd4f80e33a4ae4567483819646650f5735286e2.diff

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd4f80e33a4: [ConstantFolding] Unify handling of load from unifor

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115938/new/ https://reviews.llvm.org/D115938 ___ cfe-commits mailing list cfe-comm

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys added a comment. In D115738#3199988 , @MyDeveloperDay wrote: > Thank you for the patch We'll need your name and email address for that, but > yes we'll be happy to commit it for you. > > If you think you'd like to play some more, then you can

[clang] 33cbaab - [funcattrs] Consistently treat calling a function pointer as a non-capturing read

Author: Philip Reames Date: 2021-12-17T09:02:03-08:00 New Revision: 33cbaab1416b234d5a08b41e3110d64a00b0651c URL: https://github.com/llvm/llvm-project/commit/33cbaab1416b234d5a08b41e3110d64a00b0651c DIFF: https://github.com/llvm/llvm-project/commit/33cbaab1416b234d5a08b41e3110d64a00b0651c.diff

[PATCH] D115916: [funcattrs] Consistently treat calling a function pointer as a non-capturing read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33cbaab1416b: [funcattrs] Consistently treat calling a function pointer as a non-capturing… (authored by reames). Herald added a project: clang. Hera

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal updated this revision to Diff 395150. steakhal added a comment. Sorry for the late update, but here we are: Now, I properly handle all kinds of `NestedNameSpecifiers`. Basically, I verify if the decls are matching, then I use the nested name specifiers for finding mismatches. I look thr

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1291-1293 +((Style.IndentExternBlock == FormatStyle::IEBS_Indent) || + (Style.BraceWrapping.AfterExternBlock && + Style.IndentE

[PATCH] D115902: [OPENMP]Look through member function call base during implicit DSA analysis.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115902/new/ https://reviews.llvm.org/D115902 __

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1411 +CGM.getLLVMContext(), llvm::Attribute::Alignment, +CGM.getContext().getTypeAlignInChars(VarTy).getQuantity())); This doesn't work. If the type alignment

[clang] d976fb0 - [OpenMP][NFC] update status for 5.1 'fail' atomic extension

Author: Deepak Eachempati Date: 2021-12-17T11:46:37-06:00 New Revision: d976fb0204283b5aabf40d805e59ce6d1502d1d9 URL: https://github.com/llvm/llvm-project/commit/d976fb0204283b5aabf40d805e59ce6d1502d1d9 DIFF: https://github.com/llvm/llvm-project/commit/d976fb0204283b5aabf40d805e59ce6d1502d1d9.d

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd976fb020428: [OpenMP][NFC] update status for 5.1 'fail' atomic extension (authored by dreachem, committed by Chi-Chun, Chen

[PATCH] D115709: [RISCV] Remove Zvamo Extention

craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 6674854 - [OPENMP]Look through member function call base during implicit DSA analysis.

Author: Alexey Bataev Date: 2021-12-17T10:18:51-08:00 New Revision: 667485413fd32cf470d7cd6260b50e486fedaf5e URL: https://github.com/llvm/llvm-project/commit/667485413fd32cf470d7cd6260b50e486fedaf5e DIFF: https://github.com/llvm/llvm-project/commit/667485413fd32cf470d7cd6260b50e486fedaf5e.diff

[PATCH] D115902: [OPENMP]Look through member function call base during implicit DSA analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG667485413fd3: [OPENMP]Look through member function call base during implicit DSA analysis. (authored by ABataev). Repository: rG LLVM Github Monor

[clang] 62ead36 - [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

Author: mydeveloperday Date: 2021-12-17T18:29:32Z New Revision: 62ead3654795bfb09bf7296ef5db8deea0f758cb URL: https://github.com/llvm/llvm-project/commit/62ead3654795bfb09bf7296ef5db8deea0f758cb DIFF: https://github.com/llvm/llvm-project/commit/62ead3654795bfb09bf7296ef5db8deea0f758cb.diff LOG

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62ead3654795: [clang-format] Formatter does not handle c++11 string literal prefix with… (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay updated this revision to Diff 395165. MyDeveloperDay added a comment. Add additional test to show lambda's should be ok CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115903/new/ https://reviews.llvm.org/D115903 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittes

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay updated this revision to Diff 395166. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Address nits and review comments (remove unnecessary lines) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115879/new/ https://reviews.llvm.org/D115879 F

[clang] 163c13f - [clang-format] Fix formatting of the code that follows C# Lambda Expressions

Author: Peter Stys Date: 2021-12-17T10:42:15-08:00 New Revision: 163c13fed9f68c31a14b3d2409b994909f0600bb URL: https://github.com/llvm/llvm-project/commit/163c13fed9f68c31a14b3d2409b994909f0600bb DIFF: https://github.com/llvm/llvm-project/commit/163c13fed9f68c31a14b3d2409b994909f0600bb.diff LO

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG163c13fed9f6: [clang-format] Fix formatting of the code that follows C# Lambda Expressions (authored by peterstys, committed by owenpan). Repository

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 added a comment. I will split this into two revisions, one handling the return alignment attribute in the Attributor, and one adding alignment information to the `__kmpc_alloc_shared` OpenMP runtime call, turning it into an aligned allocation. Comment at: clang/lib/C

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan accepted this revision. owenpan added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115879/new/ https://reviews.llvm.org/D115879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 395176. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9118 + NewFD->getKind() == Decl::Kind::CXXMethod && + NewFD->getName() == "__init" && D.isFunctionDefinition()) { +if (auto *def = Parent->getDefinition()) Fznamznon

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 updated this revision to Diff 395182. jhuber6 added a comment. Removing OpenMP code, only adding support for return alignments. Fixing OpenMP will occur in a following patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https:/

[PATCH] D115959: [clangd] Fix undefined behavior when generating error message at rename with an invalid name

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet, hokein. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. `Message()` lambd

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 updated this revision to Diff 395187. jhuber6 added a comment. Removing else if, we should be able to check for all allocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https://reviews.llvm.org/D115888 Files: llvm/lib/T

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jdoerfert accepted this revision. jdoerfert added a comment. LG, don't forget to update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https://reviews.llvm.org/D115888 ___

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 395190. oleg.smolsky added a comment. Added a "two constructors" test case along with the support for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. In D114995#3198033 , @aaron.ballman wrote: > In D114995#3183240 , > @malcolm.parsons wrote: > >> In D114995#3180475 , >> @aaron.ballman wr

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, peterstys. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move the handling of brace wrap

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1641 case tok::equal: - // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType - // TT_FatArrow. They always start an expression or a child block if - // fo

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

NoQ added a comment. These checks are almost 2000 lines of code each and it looks like all they do is figure out if two statements are the same and we have a very flexible reusable solution for this sort of stuff - `CloneDetector`, but none of them use it. Your patch demonstrates that they all

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395207. tianshilei1992 added a comment. Herald added a project: Flang. update one test case and flang fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395208. tianshilei1992 added a comment. remove unexpected change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

NoQ added a comment. Oh nice, it's great to see these things moving. I have a couple observations for your specific approach: (1) Sounds like you're introducing a symbol `(long p)` that represents the exact same value as (and is used interchangeably with) `&SymRegion{$p} (as long)`. Ambiguity

  1   2   >