[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 405156. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

SharonXu added a comment. Hi @vsapsai, I checked out the apple `stable/20211026` llvm-project branch at https://github.com/apple/llvm-project/tree/stable/20211026, and ran check-clang locally, but the tested added in the patch `clang/test/Modules/merge-objc-interface.m` failed with the error

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

arphaman updated this revision to Diff 405155. arphaman added a reviewer: egorzhdan. arphaman added a comment. Fix test failure with asserts enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116052/new/ https://reviews.llvm.org/D116052 Files: clang/lib/Frontend/PrintPreprocessed

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:328 ExistingIncludes.try_emplace(trimInclude(IncludeToAdd.Name)).first; Iter->second.push_back(std::move(IncludeToAdd)); auto &CurInclude = Iter->second.back(); --

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko created this revision. ivanmurashko added reviewers: alexfh, DmitryPolukhin, sammccall, bruno. ivanmurashko added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. ivanmurashko requested review of this revision. Herald added subscribers: cfe-c

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80c52986e1b: [docs] Remove hard-coded version numbers from sphinx configs (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/

[PATCH] D118652: Cleanup header dependencies in LLVMCore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe188aae406f3: Cleanup header dependencies in LLVMCore (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] e188aae - Cleanup header dependencies in LLVMCore

Author: serge-sans-paille Date: 2022-02-02T06:54:20+01:00 New Revision: e188aae406f3fecaed65a1f7e6562205f0de937e URL: https://github.com/llvm/llvm-project/commit/e188aae406f3fecaed65a1f7e6562205f0de937e DIFF: https://github.com/llvm/llvm-project/commit/e188aae406f3fecaed65a1f7e6562205f0de937e.d

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, lei, kamaub, quinnp. amyk added projects: LLVM, PowerPC. Herald added subscribers: shchenz, kbarton. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `__builtin_pd

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added a comment. > Drive-by comment on the docs; otherwise this sounds awesome; as long as else > is easy to add later this SGTM (I'll let others do the code review). > (Although, if else {} and else requires {} would be easy to add now/soon, I > feel like it'd be worth it. Modelling a

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405137. void added a comment. Remove dead assign. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h:33 +/// declarations in header files. True by default. +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/ch

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added a comment. LGTM once @aaron.ballman is happy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:722 +def err_mmap_expected_lbrace_requires : Error< + "expected '{' to start rquires block">; def err_mmap_expected_rbrace : Error<"expected '}'">; Bigcheese wrote: >

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added subscribers: compnerd, MaskRay. MaskRay added a comment. I know that you want a place to be accessed by both clang driver and lld-link but I am a bit nervous about the MSVC library sitting inside llvm/lib/Support/. Is there a better place? @compnerd Repository: rG LLVM Github M

[PATCH] D118070: Make lld-link work in a non-MSVC shell

ychen added a comment. Thanks for doing this! Update the release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

iana added inline comments. Comment at: clang/include/clang/Basic/Module.h:249 + /// language options has the given feature. + static bool hasFeature(StringRef Feature, const LangOptions &LangOpts, + const TargetInfo &Target); Is `static

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

dexonsmith added a comment. Drive-by comment on the docs; otherwise this sounds awesome; as long as `else` is easy to add later this SGTM (I'll let others do the code review). (Although, if `else {}` and `else requires {}` would be easy to add now/soon, I feel like it'd be worth it. Modelling a

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese updated this revision to Diff 405133. Bigcheese added a comment. Add testing of empty blocks and nested blocks and make the missing `{` error clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118311/new/ https://reviews.llvm.org/D11

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:145 + LLVMContext &Ctx = M.getContext(); + bool UseX86FastCall = Triple(M.getTargetTriple()).getArch() == Triple::x86; + ychen wrote: > hans wrote: > > I still worry a bit about the t

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks planned changes to this revision. aeubanks added a comment. I'm seeing a similar crash with struct z { static z dc(z); z (*di)(z); }; z bar = z::dc({}); going to try to fix that here as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added a comment. > Is it possible to reference external module map from requires block? I mean > that in one context the module has some extra requirements but in a different > context doesn't have them. Can you provide an example where this would cause issues? > It would be nice to

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 405129. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118744/new/ https://reviews.llvm.org/D118744 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/test/CodeGenCXX/type-cac

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We clear the type cache when SkippedLayout is true and we're converting a function type. However, we then immediately put the computed entry in the cac

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Ping. This check has gone for a week without review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. Diff 405119 still kernel panics for me. This is building the linux-next tree. $ qemu-system-x86_64 --version QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-1) Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:516 + } + return MBBI = Fi

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3288485 , @nickdesaulniers wrote: > Hey! Looks like Diff 404763 for an x86 defconfig plus > CONFIG_ZERO_CALL_USED_REGS=y starts booting! Looks like it panics though > trying to launch `init`(pid 1) though. > > [0.

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

MaskRay added a comment. Can you dump the gcc search paths (include search paths and -L library search paths) with and without `--enable-version-specific-runtime-libs`, like the following? % gcc a.c -v -xc /dev/null |& sed -E 's/ "?-[iIL]/\n&/ ... #include "..." search starts here: #inc

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1269 + const TargetFrameLowering &TFI = *MF.getSubtarget().getFrameLowering(); + for (auto RestoreBlock : RestoreBlocks) +TFI.emitZeroCallUsedRegs(RegsToZero, *RestoreBlock);

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405119. void marked 5 inline comments as done. void added a comment. Remove debugging instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405117. void added a comment. - Don't use "llvm::for_each" or "auto" as much. - Don't zero out registers that are restored before exit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llv

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

arsenm added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1259 + +for (const MCPhysReg &SReg : + TRI.sub_and_superregs_inclusive(MO.getReg())) No reference Comment at: llvm/lib/CodeGen/PrologEpilogI

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. For example, Google Code Style strongly advises C++17 `inline variables`. There are company guides how to use them: `https://abseil.io/tips/168`, `https://abseil.io/tips/140`. I believe other codestyles also use the feature. //P.S. If this review is eventually approved,

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron created this revision. Izaron added reviewers: alexfh, rsmith, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++17 `inline variables`

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7dd7ad827a0: Revert "[ASan] Not linking asan_static library for DSO." (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] d7dd7ad - Revert "[ASan] Not linking asan_static library for DSO."

Author: Kirill Stoimenov Date: 2022-02-01T23:58:04Z New Revision: d7dd7ad827a0a78314f3c9b55f4778a6059840f3 URL: https://github.com/llvm/llvm-project/commit/d7dd7ad827a0a78314f3c9b55f4778a6059840f3 DIFF: https://github.com/llvm/llvm-project/commit/d7dd7ad827a0a78314f3c9b55f4778a6059840f3.diff L

[clang] 46add49 - [Driver][test] Fix fatal-warnings.c CHECK lines and fold the test into as-warnings.c

Author: Fangrui Song Date: 2022-02-01T15:11:17-08:00 New Revision: 46add4901fb08dcca14c4caaef908f86a108c27f URL: https://github.com/llvm/llvm-project/commit/46add4901fb08dcca14c4caaef908f86a108c27f DIFF: https://github.com/llvm/llvm-project/commit/46add4901fb08dcca14c4caaef908f86a108c27f.diff

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 updated this revision to Diff 405111. njames93 added a comment. Added release notes. Remove AST dump of bound nodes, typically isn't very helpful Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D118520 F

[PATCH] D111100: enable plugins for clang-tidy

vtjnash closed this revision. vtjnash added a comment. Closed by rG84f137a590e7de25c4105303e5938c40566c2dfb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://rev

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 405105. vtjnash added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/

[clang-tools-extra] 84f137a - Reland "enable plugins for clang-tidy"

Author: Jameson Nash Date: 2022-02-01T17:37:24-05:00 New Revision: 84f137a590e7de25c4105303e5938c40566c2dfb URL: https://github.com/llvm/llvm-project/commit/84f137a590e7de25c4105303e5938c40566c2dfb DIFF: https://github.com/llvm/llvm-project/commit/84f137a590e7de25c4105303e5938c40566c2dfb.diff

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman updated this revision to Diff 405103. arphaman marked 4 inline comments as done. arphaman added a comment. Update to address review feedback, remove `appendToken` which is not needed as we're can just `setTokens` instead (it's a new macro info) CHANGES SINCE LAST ACTION https://revie

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turned out that this change is causing segfaults in some situations. This reverts commit cf730d8ce1341ba593144df2e2bc8411238e04c3

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Thanks, that feedback makes sense. I'll update the patch today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405085. tyb0807 added a comment. Remove prefix from tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/Co

[clang] 676ddba - Add ClangLinkerWrapper to the TOC to appease the Sphinx build bot

Author: Aaron Ballman Date: 2022-02-01T16:37:43-05:00 New Revision: 676ddba12021f513b24fe4af960f9ff21f5b73e6 URL: https://github.com/llvm/llvm-project/commit/676ddba12021f513b24fe4af960f9ff21f5b73e6 DIFF: https://github.com/llvm/llvm-project/commit/676ddba12021f513b24fe4af960f9ff21f5b73e6.diff

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405083. tyb0807 added a comment. Update tests with `clang -Xclang -verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cp

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:229 MacroBuilder &Builder) const { + // FIXME: this does not handle the case where MOPS is disabled using +nomops + Builder.defineMacro("__ARM_FEATURE

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405080. tyb0807 marked an inline comment as done. tyb0807 added a comment. Update tests with `clang_cc1 -verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. In D118313#3288651 , @kda wrote: > This looks like it is breaking the sanitizer buildbot for android: > https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio > > Failed Tests (1): > HWAddressSanitizer

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

kda added a comment. This looks like it is breaking the sanitizer buildbot for android: https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio Failed Tests (1): HWAddressSanitizer-aarch64 :: TestCases/stack-uas.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118734: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes #53355

Febbe created this revision. Herald added a subscriber: carlosgalvezp. Febbe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118734 Files: clang-tools-extra/cla

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions --

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1269 + const TargetFrameLowering &TFI = *MF.getSubtarget().getFrameLowering(); + for (auto RestoreBlock : RestoreBlocks) +TFI.emitZeroCallUsedRegs(RegsToZero, *RestoreBlock); --

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. Hey! Looks like Diff 404763 for an x86 defconfig plus CONFIG_ZERO_CALL_USED_REGS=y starts booting! Looks like it panics though trying to launch `init`(pid 1) though. [0.702163] Run /bin/sh as init process [0.702913] Failed to execute /bin/sh (error -

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. What the fuck. I know of trigraphs, and that we got rid of them, but these... Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0185ffaec3c: [clang] Don't typo-fix an expression in a SFINAE context. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGE

[clang] c0185ff - [clang] Don't typo-fix an expression in a SFINAE context.

Author: Arthur O'Dwyer Date: 2022-02-01T15:17:28-05:00 New Revision: c0185ffaec3cb0aa7677b13a898eaa485ef29421 URL: https://github.com/llvm/llvm-project/commit/c0185ffaec3cb0aa7677b13a898eaa485ef29421 DIFF: https://github.com/llvm/llvm-project/commit/c0185ffaec3cb0aa7677b13a898eaa485ef29421.diff

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ce45670789: [clang] Correctly(?) handle placeholder types in ExprRequirements. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorep

[clang] f6ce456 - [clang] Correctly(?) handle placeholder types in ExprRequirements.

Author: Arthur O'Dwyer Date: 2022-02-01T15:16:17-05:00 New Revision: f6ce456707898f0ae2c70748e896130e1c897960 URL: https://github.com/llvm/llvm-project/commit/f6ce456707898f0ae2c70748e896130e1c897960 DIFF: https://github.com/llvm/llvm-project/commit/f6ce456707898f0ae2c70748e896130e1c897960.diff

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), hans wrote: > ychen wrote:

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 405018. ychen marked 2 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNot

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. Apart from some minor inline comments this revision addresses all my outstanding comments. LGTM. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:17747 + +SDValue

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, I think this approach is worth trying. I agree with you that we're in a bit of new territory here regarding the testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00

[PATCH] D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute

egorzhdan abandoned this revision. egorzhdan added a comment. Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham added a comment. @keith I don't have commit access, would you be able to merge this if you're happy with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://reviews.llvm.org/D117937 _

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118652/new/ https://reviews.llvm.org/D118652 __

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham updated this revision to Diff 404999. bnbarham added a reviewer: nathawes. bnbarham added a comment. Noticed one of the unit tests wasn't actually testing the right thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://r

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 404994. pkasting marked 5 inline comments as done. pkasting retitled this revision from "Add /winsysroot support to lld" to "Make lld-link work in a non-MSVC shell". pkasting edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. I decided it made the most sense to me to go with option 3, so this should be ready to land again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 404993. vtjnash added a comment. - Reland "enable plugins for clang-tidy" - fixup! Reland "enable plugins for clang-tidy": Disable the test if the user has disabled support for building it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118070: Add /winsysroot support to lld

pkasting marked 9 inline comments as done. pkasting added a comment. In D118070#3278123 , @thakis wrote: > Things that can still improve: > > 1. This now does way more than just /winsysroot:. It also makes it so that > lld-link works in a non-msvc shell

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

rsmith added a comment. Thanks, this looks functionally good to me. I'm happy for this to land with the `Sema` member renamed. Comment at: clang/lib/Sema/SemaModule.cpp:727 +ModuleMap &Map = PP.getHeaderSearchInfo().getModuleMap(); +GlobalModuleFragmentCache = Map.crea

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-pointer-as-values.cpp:12 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'p_local0' of type 'double *' can be declared 'const' +

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. In D118199#3287636 , @chill wrote: > I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang > -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of > tagging intrinsics from `arm_acle.h`.

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because e.g. + // the sequence "<::" will be inconditi

[PATCH] D118711: [hack] Build a tree of preprocessing directives

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: ymandel. Herald added subscribers: carlosgalvezp, kbarton, mgorny, nemanjai. LegalizeAdulthood requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This cod

[PATCH] D118708: [OpenMP] Add kernel string attribute to kernel function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118708/new/ https://reviews.llvm.org/D118708 ___

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG245b8e5691ed: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX (authored by stevewan). Repository: rG LLVM Github M

[clang] 245b8e5 - [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

Author: Steven Wan Date: 2022-02-01T11:49:53-05:00 New Revision: 245b8e5691ed9e4483b3e0f807706fe1fb6eaa38 URL: https://github.com/llvm/llvm-project/commit/245b8e5691ed9e4483b3e0f807706fe1fb6eaa38 DIFF: https://github.com/llvm/llvm-project/commit/245b8e5691ed9e4483b3e0f807706fe1fb6eaa38.diff LO

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D11

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404951. stevewan added a comment. Add the flag to all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Analysis/padding_c.c clang/test/Analysis/

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of tagging intrinsics from `arm_acle.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/test/Analysis/padding_c.c:7 // RUN: not %clang_analyze_cc1 -verify %s \ // RUN: -analyzer-checker=core \ Even if it works as-is, might be good to add `-Wno-aix-compat` here too since `-verify`

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:229 MacroBuilder &Builder) const { + // FIXME: this does not handle the case where MOPS is disabled using +nomops + Builder.defineMacro("__ARM_FEATURE_M

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404947. stevewan added a comment. Use "-Wno-aix-compat" so that we don't lose coverage on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Ana

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/31592. This commits enables l

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

pkubaj added a comment. Since I'm not a LLVM committer, can you commit it and merge to 14 branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117972/new/ https://reviews.llvm.org/D117972 ___ cfe-commit

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers marked 7 inline comments as done. vabridgers added a comment. I think the comments have been addressed for now. Please let me know if I missed something, or anything else needs to be done (besides back out the change to SValBuilder.cpp when ready). Thanks for the comments. Best Repo

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. I think @steakhal will have a more comprehensive change to back out the makeNull() calls to makeNullWithWidth() calls. I'll back out the change to SValBuilder.cpp once that change is pushed. For now, this is my update. Thanks Repository: rG LLVM Github Monorepo C

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 404940. vabridgers added a comment. Simplify assertion per comments. Add a "temp" fix in SValBuilder that permits the additional test cases to pass without crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro updated this revision to Diff 404939. ro added a comment. Herald added a subscriber: jrtc27. - Use `CreateGEP` - Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 Files: clang/lib/CodeGen/Ta

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3285825 , @efriedma wrote: > In D91607#3283350 , @ro wrote: > >> In D91607#3280808 , @efriedma wrote: >> >>> Testcase? >> >> I thought the 3 tes

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Tests are passing again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > > > Just early ret

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404935. tbaeder marked an inline comment as done. tbaeder added a comment. Stop hardcoding `v1` or `11` and make the tests work like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib

  1   2   >