[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, iains, urnathan, dblaikie. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This fixes issue51873 . The issu

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC, shchenz. Herald added subscribers: kbarton, krytarowski. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 updated this revision to Diff 407387. tianshilei1992 added a comment. recover test cases removed by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenM

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/test/CodeGen/X86/jmc-instrument.ll:2 +; Check that the flag symbol is not full-qualified. +; RUN: llc < %s -enable-jmc-instrument | FileCheck %s + hans wrote: > ychen wrote: > >

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 407384. ychen marked an inline comment as done. ychen added a comment. - Remove CodeViewDebug.cpp and the associated test. It was needed because the instrumented flag variables were scoped inside the associated method in the CodeView. The current patch puts th

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

junaire created this revision. junaire added reviewers: Quuxplusone, aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang diagnostics should say "floating-point literal" instead of "floating-point constant" accordin

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

MaskRay added a comment. In D119383#3309796 , @tstellar wrote: > I would like to keep this supported upstream as this is how we build clang in > Fedora. If some people find the stand-alone builds burdensome, then I think > it would be best to start a t

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD, Jim wrote: > Is

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to sta

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya created this revision. haonanya added reviewers: Anastasia, svenvh. haonanya added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. haonanya requested review of this revision. Herald added a subscriber: cfe-commits. It is necessary to guard atomic_double type accordin

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc" ---

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c930cef0e4c: [NFC] [Modules] Refactor ODR checking for default template argument in (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] 8c930ce - [NFC] [Modules] Refactor ODR checking for default template argument in

Author: Chuanqi Xu Date: 2022-02-10T10:10:10+08:00 New Revision: 8c930cef0e4c6d76fdb483051187c59d5aea6db7 URL: https://github.com/llvm/llvm-project/commit/8c930cef0e4c6d76fdb483051187c59d5aea6db7 DIFF: https://github.com/llvm/llvm-project/commit/8c930cef0e4c6d76fdb483051187c59d5aea6db7.diff LO

[clang-tools-extra] 4f30a52 - NFC: fix GCC warning -Wcast-qual

Author: Yuanfang Chen Date: 2022-02-09T18:03:25-08:00 New Revision: 4f30a5269696ff03fd600e756e934a44d4c71b46 URL: https://github.com/llvm/llvm-project/commit/4f30a5269696ff03fd600e756e934a44d4c71b46 DIFF: https://github.com/llvm/llvm-project/commit/4f30a5269696ff03fd600e756e934a44d4c71b46.diff

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

tianshilei1992 added inline comments. Comment at: README.md:71 + mlir, openmp, polly, or pstl. ``LLVM_ENABLE_RUNTIMES`` can include any of + libcxx, libcxxabi, libunwind, or compiler-rt. FWIW, OpenMP can be put into either of them. In OpenMP

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This is a follow-up patch of D1193

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

MaskRay accepted this revision. MaskRay added a comment. Thanks for improving the documentation. I occasionally see folks (and two today!) puzzled by LLVM_ENABLE_RUNTIMES and this patch should help them. Personally I use the `-S -B` style (actually `-H`, but now I see that `-S` is documented I

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407336. ychen added a comment. - Handle ARM - Add driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp c

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. In D117809#3306785 , @MaskRay wrote: > Thanks for working on such tools but the patch order is not right. > You should implement the functionality first, and in the last, add the driver > option. > The driver option is user-facing

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

MaskRay added inline comments. Comment at: clang/CMakeLists.txt:16 if(CLANG_BUILT_STANDALONE) set(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ standard to conform to") set(CMAKE_CXX_STANDARD_REQUIRED YES) For the main branch, we can delete this block. Reposit

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, mstorsjo, rjmccall, rsmith. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For me, `cmake -Hclang -B/path/to/build` currently

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim planned changes to this revision. hctim marked 8 inline comments as done. hctim added a comment. Pushed the [1/3] ELF note parsing over to D119381 . Will leave this review for the clang-side changes, and send a new patch for the LLD changes. All of your co

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407314. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp clang/lib/Driver/ToolCha

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309253 , @ychen wrote: > In D119301#3309140 , @lenary wrote: > >> I don't fully understand the reasoning for the patch, and you haven't really >> explained it. I think what you

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407313. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/test-wunalig

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407312. tianshilei1992 added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309140 , @lenary wrote: > I don't fully understand the reasoning for the patch, and you haven't really > explained it. I think what you are saying is that the `IsAux` argument to > `getTargetFeatures` should be conside

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407309. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. use `LLVM_FALLTHROUGH` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407308. ychen added a comment. - add ARM64 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/tes

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407307. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and mark related functions as unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https:/

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. Thanks, if you encounter more issues next week, let me know, and I will continue trying to adjust it to work for all config option combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/new/ https://reviews.llv

[clang] 76cad51 - replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

Author: Jameson Nash Date: 2022-02-09T17:31:34-05:00 New Revision: 76cad51ba700233d6e3492eddcbb466b6adbc2eb URL: https://github.com/llvm/llvm-project/commit/76cad51ba700233d6e3492eddcbb466b6adbc2eb DIFF: https://github.com/llvm/llvm-project/commit/76cad51ba700233d6e3492eddcbb466b6adbc2eb.diff

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG76cad51ba700: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

devjgm updated this revision to Diff 407300. devjgm added a comment. - accepted ymandel's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveC

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 407295. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files: clang/include/clang/AST/ASTFwd.h clang/include/clang/AS

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

devjgm updated this revision to Diff 407288. devjgm added a comment. Accepted ymandel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveCo

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam resigned from this revision. cristian.adam added a comment. This revision is now accepted and ready to land. In D119199#3309117 , @vtjnash wrote: > @cristian.adam Is this good now? You are blocking merging this, but I think > it is ready to

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

lenary added a comment. I don't fully understand the reasoning for the patch, and you haven't really explained it. I think what you are saying is that the `IsAux` argument to `getTargetFeatures` should be considered because it's `true` for offloading to another compiler, but I don't understand

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 407287. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ext

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. @cristian.adam Is this good now? You are blocking merging this, but I think it is ready to land, and I would like to not hold it up for other people if it is fixing their issues (and the issues you discovered too) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron added a comment. The assert that I mentioned in the summary: https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/ExprConstant.cpp#L14969 (Although `assert`s are deleted in release builds, one can check the violation by `llvm::errs() << isValueDependent() << "\n";` in the method)

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 407284. Quuxplusone added a comment. Rebase; clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119184/new/ https://reviews.llvm.org/D119184 Files: clang/include/clang/Sema/Sema.h clang/lib/Se

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:197-198 } } else if (ReceivingExpr) { -if ((*InvocationParmType)->isRValueRefere

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b5e5b413bd: [clang-format] Fix formatting of macro definitions with a leading comment. (authored by curdeius). Repository: rG LLVM Github Monore

[clang] a7b5e5b - [clang-format] Fix formatting of macro definitions with a leading comment.

Author: Marek Kurdej Date: 2022-02-09T22:39:59+01:00 New Revision: a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a URL: https://github.com/llvm/llvm-project/commit/a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a DIFF: https://github.com/llvm/llvm-project/commit/a7b5e5b413bd1654e8e96b9c7842c7c1ab0db58a.diff

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron created this revision. Izaron added reviewers: aaron.ballman, cor3ntin. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Value-dependent ConstantExprs are not meant to be evaluated. There is an assert in Expr::EvaluateAsConstan

[PATCH] D119117: [clang-format] Fix formatting of the array form of delete.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGa77c67f93917: [clang-format] Fix formatting of the array form of delete. (authored by curdeius). Changed

[clang] a77c67f - [clang-format] Fix formatting of the array form of delete.

Author: Marek Kurdej Date: 2022-02-09T22:36:13+01:00 New Revision: a77c67f93917596f9eded9edaced4a9d355a4e1c URL: https://github.com/llvm/llvm-project/commit/a77c67f93917596f9eded9edaced4a9d355a4e1c DIFF: https://github.com/llvm/llvm-project/commit/a77c67f93917596f9eded9edaced4a9d355a4e1c.diff

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

devjgm updated this revision to Diff 407267. devjgm added a comment. Here is also updated the documentation to include the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe329b5866f17: [clang-format] Honour "// clang-format off" when using QualifierOrder. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[clang] e329b58 - [clang-format] Honour "// clang-format off" when using QualifierOrder.

Author: Marek Kurdej Date: 2022-02-09T22:15:20+01:00 New Revision: e329b5866f1732f5c24cf2ae96479971f7101914 URL: https://github.com/llvm/llvm-project/commit/e329b5866f1732f5c24cf2ae96479971f7101914 DIFF: https://github.com/llvm/llvm-project/commit/e329b5866f1732f5c24cf2ae96479971f7101914.diff

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

devjgm created this revision. Herald added a subscriber: carlosgalvezp. devjgm requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option allows callers to disable the warning from https://clang.llvm.org/extra/clang-tidy/checks

[libunwind] dfa5ab7 - [libunwind] Avoid a warning in 32 bit builds. NFC.

Author: Martin Storsjö Date: 2022-02-09T23:00:46+02:00 New Revision: dfa5ab7b2b510e68ca2b11b043898c192633c0f6 URL: https://github.com/llvm/llvm-project/commit/dfa5ab7b2b510e68ca2b11b043898c192633c0f6 DIFF: https://github.com/llvm/llvm-project/commit/dfa5ab7b2b510e68ca2b11b043898c192633c0f6.diff

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer Review please :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D110485: Support [[no_unique_address]] for all targets.

mstorsjo added a comment. In D110485#3308854 , @mstorsjo wrote: > To pick up the thread here again, `[[no_unique_address]]` is done and settled > in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is > accepted, without any warning

[PATCH] D110485: Support [[no_unique_address]] for all targets.

mstorsjo added a comment. To pick up the thread here again, `[[no_unique_address]]` is done and settled in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is accepted, without any warning (in C++20 mode), but it has no effect. (This, not related to LLVM, but because they h

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); pcc wrote: > samitolvanen wrote: > >

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, hiraditya. Herald added a reviewer: aaron.ballman. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-com

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); samitolvanen wrote: > pcc wrote: > >

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This removes clangd's existing workaround in favor of prope

[PATCH] D119364: Refactor nested if else with ternary operator

phyBrackets created this revision. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119364 Files: clang/lib/CodeGen/CGExprScalar.cpp Index: clang/lib/CodeGen/C

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

Quuxplusone added inline comments. Comment at: bolt/docs/OptimizingClang.md:228-236 $ CPATH=${TOPLEV}/stage1/install/bin/ -$ cmake -G Ninja ${TOPLEV}/llvm-project/llvm -DLLVM_TARGETS_TO_BUILD=X86 \ +$ cmake -G Ninja -S ${TOPLEV}/llvm-project/llvm -B ${TOPLEV}/stage2-prof-gen \ +

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this NFC change is reasonable. We do lose a bit of JSON dumping test coverage from it (I don't see any tests for the offset there now), but I am okay with that as I don't

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Add `ObjCProtocolLoc` which behaves like `TypeLoc` but for `ObjCProtocolDecl` references.

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

rafauler added a comment. BOLT modifications LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119351/new/ https://reviews.llvm.org/D119351 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D119296: KCFI sanitizer

samitolvanen planned changes to this revision. samitolvanen added a comment. Thanks for the pointers, Aaron. I'll rework the attribute code and also address the issues Nick pointed out in the next revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D119296: KCFI sanitizer

samitolvanen marked an inline comment as not done. samitolvanen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:696 +def KCFIUnchecked : Attr { + let Spellings = [Clang<"kcfi_unchecked">]; + let Subjects = SubjectList<[Var, TypedefName]>; j

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); pcc wrote: > We considered a

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

beanz added a comment. I realize this is a _big_ silly NFC change, but I figured I'd blast it out there in case anyone objects to the premise. My goal is to eventually get to the point where Windows developers can use autocrlf (see the note here: https://llvm.org/docs/GettingStarted.html#check

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda marked 2 inline comments as done. jchlanda added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} -

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

beanz created this revision. beanz added reviewers: aaron.ballman, jyknight, rnk, dblaikie. beanz requested review of this revision. Herald added a project: clang. None of these tests are really intended to test the file offset as much as to test the structure. Making the regex allows this test to

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc updated this revision to Diff 407227. pcc retitled this revision from "AST: Move __va_list tag to the top level on ARM architectures." to "AST: Move __va_list tag back to std conditionally on AArch64.". pcc edited the summary of this revision. pcc added a comment. Make it conditional Repos

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} jchlanda wrote: > tra wrote: > >

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

mehdi_amini added a comment. In D72404#3307623 , @aykevl wrote: > So, should all passes just look at the `optsize` and `minsize` attributes > instead of the `SizeLevel`? In other words, should > `PassManagerBuilder.SizeLevel` be removed and should passes

[clang] 8073da0 - [NFC] Fix sign-compare warning in GrammarBNF thanks to int promotion

Author: Erich Keane Date: 2022-02-09T11:25:58-08:00 New Revision: 8073da0beed804d0cef1697b72fdc4151457a327 URL: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327 DIFF: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327.diff L

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} tra wrote: > The new 3-argu

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} The new 3-argument constructor a

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe marked an inline comment as done. Febbe added a comment. Thank you for the review. I am done and you can commit the patch :) . I don't have the rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 __

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe updated this revision to Diff 407200. Febbe marked 4 inline comments as done. Febbe added a comment. Last batch of suggested changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 Files: clang-tools-extra/clang-tidy/modernize/UseTrail

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante added a comment. Sorry I missed your message. At the moment I don't intend to continue with this review. Do you want to commandeer this one or do you prefer me to abandon it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71966/new/ https://reviews.llvm.org/D71966

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added a comment. In D118070#3308304 , @pkasting wrote: > MaskRay: Friendly ping. I think I still feel that having this in LLVMSupport is strange, but am happy if the two other folks I added are happy... Repository: rG LLVM Github Monorepo C

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. MaskRay: Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

ldionne created this revision. Herald added subscribers: libcxx-commits, ayermolo, arphaman, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added projects: libunwind, Flang. Herald added a reviewe

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > sameerds wrote: > > jdoerfert wrote: > > > sameerds wrote: > > > > jdoerfert wrote: > > > > > sameerds wrote: > > > > > > jd

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} tianshilei1992 wrote: > ABataev wrote: > > Output? > I did it on

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 407159. tyb0807 added a comment. Turn off warnings for negative tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp c

[clang] a464444 - [OpenCL][Docs] Update OpenCL 3.0 status info

Author: Sven van Haastregt Date: 2022-02-09T15:12:49Z New Revision: a46b2888b9d0fcfb712897f0110cadb84d93 URL: https://github.com/llvm/llvm-project/commit/a46b2888b9d0fcfb712897f0110cadb84d93 DIFF: https://github.com/llvm/llvm-project/commit/a46b2888b9d0fcfb712897f0110cadb84d93.diff

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 407155. tyb0807 added a comment. Fix buildbots failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/Code

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. ok, thanks for considering the suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118437/new/ https://reviews.llvm.org/D118437 _

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). --

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349-352 + // This should be an assert, but asserts shouldn't be used in signal + // handlers + if (!CurContext) +return; ---

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407139. awarzynski added a comment. Remove the change from `fir::CodeGenSpecifics::get` (this was uploaded as a seperate patch: https://reviews.llvm.org/D119332) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as far as the changes go (I can't speak to how appropriate the changes are for the PS4 target). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

aykevl added a comment. After some more testing on a larger amount of code (many small programs, together over 1MB of code), LoopRotate indeed seems to be the culprit. I'm now looking into a patch to LoopRotate to respect the `optsize` function attribute. Repository: rG LLVM Github Monorepo

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-protot

[libunwind] 6f17768 - [runtimes] Remove support for standalone builds

Author: Louis Dionne Date: 2022-02-09T08:55:31-05:00 New Revision: 6f17768e11480063f4c2bcbeea559505fee3ea19 URL: https://github.com/llvm/llvm-project/commit/6f17768e11480063f4c2bcbeea559505fee3ea19 DIFF: https://github.com/llvm/llvm-project/commit/6f17768e11480063f4c2bcbeea559505fee3ea19.diff

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. Ping? I'd really like to get this fixed in 14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added a comment. In D118847#3307497 , @Febbe wrote: > Can I still add a diff, or does this cause a revoke (apply the rest of the > feedback)? > Also, is the commit added automatically to the repo, or do I / another one > have to rebase it. > >

  1   2   >