[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 418142. lkail added reviewers: dim, pkubaj. lkail set the repository for this revision to rG LLVM Github Monorepo. lkail added subscribers: pkubaj, dim. lkail added a comment. @dim @pkubaj We are modifying layout of 16-byte atomic type on Linux to be consisten

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail added a comment. Removed alter of `-ppc-quadword-atomcis` in backend to decouple from frontend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 ___ cfe-co

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418155. kbobyrev added a comment. Fix a bug, add tests for diagnostics. This is ready for a review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clan

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:316 + if (StringRef(D.Dir).startswith(SysRoot) && + D.getVFS().exists(D.Dir + "/../lib/libc++.so")) addPathIfExists(D, D.Dir + "/../lib", Paths); I wonder if this still wou

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418159. kbobyrev added a comment. Add some docs, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418160. kbobyrev added a comment. Use better name for header recorder lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/Inclu

[clang] 6c0e60e - [C++20][Modules][HU 1/5] Introduce header units as a module type.

Author: Iain Sandoe Date: 2022-03-25T09:17:14Z New Revision: 6c0e60e884a20016ccc0d7c7e6f06df089a0de86 URL: https://github.com/llvm/llvm-project/commit/6c0e60e884a20016ccc0d7c7e6f06df089a0de86 DIFF: https://github.com/llvm/llvm-project/commit/6c0e60e884a20016ccc0d7c7e6f06df089a0de86.diff LOG: [

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c0e60e884a2: [C++20][Modules][HU 1/5] Introduce header units as a module type. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121095/new

[clang] 520c8ca - [Clang] Added release note for improved -Wunused-but-set-variable warning

Author: Dávid Bolvanský Date: 2022-03-25T10:45:28+01:00 New Revision: 520c8ca9d2f940dd93618ad98c445573f13aa714 URL: https://github.com/llvm/llvm-project/commit/520c8ca9d2f940dd93618ad98c445573f13aa714 DIFF: https://github.com/llvm/llvm-project/commit/520c8ca9d2f940dd93618ad98c445573f13aa714.dif

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

owenpan added a comment. In D121757#3406814 , @sstwcw wrote: > I tried formatting the files in `clang-formatted-files.txt`. Besides the > files in the list that get changed when formatted with the program built from > `main`, none gets changed when I fo

[clang] 311a00c - [clang-format] Clean up DefinitionBlockSeparatorTest. NFC.

Author: Marek Kurdej Date: 2022-03-25T10:59:46+01:00 New Revision: 311a00c39046ed3f84cd31ffcd513975d3000402 URL: https://github.com/llvm/llvm-project/commit/311a00c39046ed3f84cd31ffcd513975d3000402 DIFF: https://github.com/llvm/llvm-project/commit/311a00c39046ed3f84cd31ffcd513975d3000402.diff

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

owenpan added a comment. In D121757#3407539 , @owenpan wrote: > In D121757#3406814 , @sstwcw wrote: > >> I tried formatting the files in `clang-formatted-files.txt`. Besides the >> files in the list that get chan

[PATCH] D122468: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[clang] ce2b36e - [clang] CheckSizelessVectorOperands - use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-03-25T10:23:30Z New Revision: ce2b36e123e7b5312016b09c1b2971c9d80416e7 URL: https://github.com/llvm/llvm-project/commit/ce2b36e123e7b5312016b09c1b2971c9d80416e7 DIFF: https://github.com/llvm/llvm-project/commit/ce2b36e123e7b5312016b09c1b2971c9d80416e7.diff LOG:

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418171. iains added a comment. Herald added a subscriber: MaskRay. rebased, fix testcase for windows, add command line options to docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.ll

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418172. iains added a comment. fix some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.org/D121589 Files: clang/docs/ClangCommandLineReference.rst clang/include/cl

[PATCH] D122394: [C++20][Modules] Correct an assert for modules-ts.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. Understood. To document the approach: 1. clearly separate -fmodules-ts semantics (which are vague in places, but whatever) 2. implement c++20 modules semantics 3a) switch -fmodules-ts op

[clang] 635dde8 - Fix clang Sphinx build bot

Author: Aaron Ballman Date: 2022-03-25T07:13:26-04:00 New Revision: 635dde811717e736ddb6b675f678b64c54607eba URL: https://github.com/llvm/llvm-project/commit/635dde811717e736ddb6b675f678b64c54607eba DIFF: https://github.com/llvm/llvm-project/commit/635dde811717e736ddb6b675f678b64c54607eba.diff

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418187. iains added a comment. amend filecheck match to avoid quoting windows pathnames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.org/D121589 Files: clang/docs/ClangComman

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418188. iains added a comment. amend second testcase for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.org/D121589 Files: clang/docs/ClangCommandLineReference.rst cla

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3406765 , @njames93 wrote: > In D120185#3405091 , @aaron.ballman > wrote: > >> @thakis -- is it possible your build bot is configured to disable generation >> of crash d

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. > Sorry, for my own sanity, I've stopped reviewing C++ Core Guideline reviews > for their diagnostic behavior until the guideline authors put effort into > specifying realistic enforcement guidance. And how can we continue now? I fear that this is effectively the deat

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added a comment. In D54943#3407789 , @JonasToth wrote: >> Sorry, for my own sanity, I've stopped reviewing C++ Core Guideline reviews >> for their diagnostic behavior until the guideline authors put effort into >> specifying realistic enfor

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418196. iains added a comment. another tweak to the second testcase for windows *sigh* ... I will get the recipe right eventually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.or

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

sammccall added a comment. Thanks, this is much nicer! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:310 findReferencedFiles(const ReferencedLocations &Locs, const SourceManager &SM, -llvm::function_ref HeaderResponsible) { +ll

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9381 + M.getTarget().getTargetOpts().CodeObjectVersion != 500) { +F->addFnAttr("amdgpu-no-hostcall-ptr"); + } sameerds wrote: > The frontend does not need to worry about this att

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for the discussion on this new check, it LGTM! Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; -

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang created this revision. tingwang added reviewers: PowerPC, jsji, nemanjai, shchenz. tingwang added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. tingwang requested review of this revision. Herald added a project: clang. Herald added subscribers:

[clang-tools-extra] 72864d9 - [pseudo] Use box-drawing chars to prettify debug dumps. NFC

Author: Sam McCall Date: 2022-03-25T14:17:38+01:00 New Revision: 72864d9bfec929b2427981d99c2ac67ff5fcfe19 URL: https://github.com/llvm/llvm-project/commit/72864d9bfec929b2427981d99c2ac67ff5fcfe19 DIFF: https://github.com/llvm/llvm-project/commit/72864d9bfec929b2427981d99c2ac67ff5fcfe19.diff LO

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418206. ymandel added a comment. remove stray comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptio

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks really solid now! Comment at: clang/lib/Lex/PPLexerChange.cpp:430 - // Complain about reaching a true EOF within assume_nonnull. + // Complain ab

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

aaron.ballman added reviewers: alexfh, sammccall. aaron.ballman added subscribers: sammccall, alexfh. aaron.ballman added a comment. Thanks for the fix, can you also add a release note for it? I'm a bit worried about using `hasAncestor()` for this; that has a tendency to do surprising things in

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418205. ymandel added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptiona

[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122344/new/ https://reviews.llvm.org/D122344

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 6 inline comments as done and an inline comment as not done. ymandel added a comment. Thanks for the detailed review! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:119 + auto NonEmptyStringOptional = unaryOperator( +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"result

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418210. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Frontend/CompilerInvocati

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418209. ymandel marked an inline comment as done. ymandel added a comment. adjust logical formula Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files: clang/lib/A

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added a comment. Since this is compatibility support, I'm trying to match the result from XLC in scenarios where there is all kinds of QNaN, SNaN, +/-Infinity, +/-ZERO. Currently maxfl and maxfs still give different result compared with XLC in above scenario. This is one thing I'm stil

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

sammccall added a comment. I don't actually know a great deal about matcher performance :-( I wish I did. I think this is pretty much in line with how plenty of check matchers already work though, in particular unless(isInTemplateInstantiation()) is basically the same thing and is used in many p

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D122078#3407981 , @sammccall wrote: > I don't actually know a great deal about matcher performance :-( I wish I did. > I think this is

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

aaron.ballman added reviewers: rsmith, clang-language-wg. aaron.ballman added a comment. Herald added a project: All. I'm adding more reviewers for a wider audience on this topic. Personally, I don't think we should support this extension. EWG voted pretty strongly against it: 0/3/7/6/1 (https:

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

erichkeane added a comment. In D120589#3408015 , @aaron.ballman wrote: > I'm adding more reviewers for a wider audience on this topic. Personally, I > don't think we should support this extension. EWG voted pretty strongly > against it: 0/3/7/6/1 > (h

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 418219. adamcz marked an inline comment as done. adamcz added a comment. added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 Files: clang/lib/Sema/TreeTr

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. Thanks for all the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 418220. iains added a comment. we need the quotes around the components. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.org/D121589 Files: clang/docs/ClangCommandLineReference.r

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

aykevl added a comment. Herald added a subscriber: StephenFan. @MaskRay it was my suggestion to move this from the toolchain specific file to the generic file, because it makes the implementation much simpler. See my comment D117423#3251110 for details.

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Our internal CI flagged an assertion in `llvm::NVPTXTargetLowering::getFunctionParamOptimizedAlign(llvm::Function const*, llvm::Type*, llvm::DataLayout const&)` last night. Given the er

[clang] 7e45912 - [clang] Do not crash on arrow operator on dependent type.

Author: Adam Czachorowski Date: 2022-03-25T15:48:08+01:00 New Revision: 7e459126185f4d5115e6e2166a866aba1369d024 URL: https://github.com/llvm/llvm-project/commit/7e459126185f4d5115e6e2166a866aba1369d024 DIFF: https://github.com/llvm/llvm-project/commit/7e459126185f4d5115e6e2166a866aba1369d024.d

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e459126185f: [clang] Do not crash on arrow operator on dependent type. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D118680: [Intrinsics] Add `nocallback` to the default intrinsic attributes

jdoerfert closed this revision. jdoerfert added a comment. closed by a81fff8afd06fab8818db521cc79bf933c700e24 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118680/new/ https://r

[clang] cf396c5 - [C++20][Modules] Correct an assert for modules-ts.

Author: Iain Sandoe Date: 2022-03-25T14:55:13Z New Revision: cf396c56e7df756d460a456f99ceab1b5d2c2e37 URL: https://github.com/llvm/llvm-project/commit/cf396c56e7df756d460a456f99ceab1b5d2c2e37 DIFF: https://github.com/llvm/llvm-project/commit/cf396c56e7df756d460a456f99ceab1b5d2c2e37.diff LOG: [

[PATCH] D122394: [C++20][Modules] Correct an assert for modules-ts.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf396c56e7df: [C++20][Modules] Correct an assert for modules-ts. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122394/new/ https://revi

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

kamaub added a comment. This option appears to incorrectly warn warning that `unsigned NumEntries = getNumEntries();` is "set but not used" in llvm/include/llvm/ADT/DenseMap.h:129 and so it is breaking the ppc64le-ll

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

kamaub added a comment. I'm sorry I took so long to notify you but I need to bring these bots back to green as soon as possible, they have been broken too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D12

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 418227. jhuber6 added a comment. Splitting this out into a patch for the format. Adding a unit test and changing strings to now be an arbitrary string map. Hopefully the move to LLVM proper won't draw ire for creating another binary format in LLVM. Repositor

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. Godbold seems to not have included this: $ cat test.cpp int main(){return 0;} $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target -march=sm_80 test.cpp ... static bool llvm::isa_impl_cl::doit(const From *) [To = llvm::ConstantAsMetadata, From = const l

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 added a comment. In D122078#3407984 , @aaron.ballman wrote: > Okie dokie, thanks for weighing in! This LGTM (feel free to add the release > note when landing). If @alexfh has some technical concerns with > `hasAncestor()`, we can always revert

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 418235. erichkeane added a comment. Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/include/clang/Sema/T

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

njames93 added a comment. I share @aaron.ballman option that given the flakiness of the guidelines, the check shouldn't mention that it addresses the c++core guidelines. Instead moving the check into another module(misc) would still provide immense value, with the side effect that it is still a

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

kovdan01 added a comment. In D120129#3408088 , @jdoerfert wrote: > Godbold seems to not have included this: > > $ cat test.cpp > int main(){return 0;} > $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target -march=sm_80 > test.cpp > ... sta

[PATCH] D122443: [OpenMP] Replace device kernel linkage with weak_odr

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f67d44ba37: [OpenMP] Replace device kernel linkage with weak_odr (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122443/new/ https://

[clang] b9f67d4 - [OpenMP] Replace device kernel linkage with weak_odr

Author: Joseph Huber Date: 2022-03-25T11:29:15-04:00 New Revision: b9f67d44ba37f3012f892a65550ec941f13626c0 URL: https://github.com/llvm/llvm-project/commit/b9f67d44ba37f3012f892a65550ec941f13626c0 DIFF: https://github.com/llvm/llvm-project/commit/b9f67d44ba37f3012f892a65550ec941f13626c0.diff

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 418238. balazske marked 11 inline comments as done. balazske added a comment. Address review comments. - Removed caching of errno-related values from the checker. - Added note tags. - Added documentation comments. Repository: rG LLVM Github Monorepo CHA

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:545 + Dependencies<[ErrnoModeling]>, + Documentation; + steakhal wrote: > Then we should have documentation, and examp

[clang-tools-extra] 39b80c8 - [clang-tidy] Add modernize-macro-to-enum check

Author: Richard Date: 2022-03-25T09:45:55-06:00 New Revision: 39b80c8380c86539de391600efaa17184b5a52b4 URL: https://github.com/llvm/llvm-project/commit/39b80c8380c86539de391600efaa17184b5a52b4 DIFF: https://github.com/llvm/llvm-project/commit/39b80c8380c86539de391600efaa17184b5a52b4.diff LOG:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

This revision was automatically updated to reflect the committed changes. Closed by commit rG39b80c8380c8: [clang-tidy] Add modernize-macro-to-enum check (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ http

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske added a comment. This errno check will work if a state split is added at every standard function that may set `errno` at failure. (The success and failure branches have different //errno check state//, and probably different return value for the function.) Probably this is too many sta

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. In D120129#3408116 , @kovdan01 wrote: > In D120129#3408088 , @jdoerfert > wrote: > >> Godbold seems to not have included this: >> >> $ cat test.cpp >> int main(){return 0;} >> $ c

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

kovdan01 added a comment. In D120129#3408168 , @jdoerfert wrote: > You don't need to run it. If you use this command line it doesn't crash? Yes, I run the same command (with sm_75 instead of sm_80 because I don't have libomptarget-nvptx-sm_80.bc), and i

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs created this revision. rs added reviewers: tstellar, lenary. Herald added a subscriber: kristof.beyls. Herald added a project: All. rs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the warning more specific as downstream compilers

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar added a comment. The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useful (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 added a comment. In D122271#3408060 , @kamaub wrote: > This option appears to incorrectly warn warning that `unsigned NumEntries = > getNumEntries();` is "set but not used" in > llvm/include/llvm/ADT/DenseMap.h:129 >

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. In D120129#3408174 , @kovdan01 wrote: > In D120129#3408168 , @jdoerfert > wrote: > >> You don't need to run it. If you use this command line it doesn't crash? > > Yes, I run the same co

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. Here are the null pointers that cause the assertion: !nvvm.annotations = !{!8, !9, !8, !10, !10, !10, !10, !11, !11, !10} !8 = !{null, !"align", i32 8} !9 = !{null, !"align", i32 8, !"align", i32 65544, !"align", i32 131080} !10 = !{null, !"align", i32 16}

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

thakis added a comment. That bot sets ENABLE_BACKTRACES=1. It seems to work for clang-cl (foo.cc contains `#pragma clang __debug parser_crash`): >out\gn\bin\clang-cl /c foo.cc PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, prepro

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

RKSimon added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:216 + MacroToEnumCheck *Check; + const LangOptions &LangOptions; + const SourceManager &SM; @LegalizeAdulthood I'm seeing errors in https://lab.llvm.org/bu

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:451 + MaxAtomicPromoteWidth = 128; + MaxAtomicInlineWidth = 128; +} MaxAtomicPromoteWidth should not depend on whether quadword-atomics is present, only the target OS. It de

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:316 + if (StringRef(D.Dir).startswith(SysRoot) && + D.getVFS().exists(D.Dir + "/../lib/libc++.so")) addPathIfExists(D, D.Dir + "/../lib", Paths);

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 418255. jhuber6 added a comment. Changing test, `uniform_int_distribution` doesn't support `char` or `uint8_t` according to the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://revie

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

aaron.ballman added a comment. I think this is a sufficient stopgap measure to keep clang from crashing, and I appreciate the FIXME comment. Should the cxx_status page also be updated, or is P0315R4 still partial (and if it is, can we add information to the status page about what's partial if y

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

erichkeane added a comment. Don't forget about Release notes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3408258 , @thakis wrote: > That bot sets ENABLE_BACKTRACES=1. > > It seems to work for clang-cl (foo.cc contains `#pragma clang __debug > parser_crash`): > > >out\gn\bin\clang-cl /c foo.cc > PLEASE submit a b

[clang] a184a0d - [clang][dataflow] Add support for disabling warnings on smart pointers.

Author: Yitzhak Mandelbaum Date: 2022-03-25T16:44:34Z New Revision: a184a0d8aae6efc1d7f19a900155b8694178d617 URL: https://github.com/llvm/llvm-project/commit/a184a0d8aae6efc1d7f19a900155b8694178d617 DIFF: https://github.com/llvm/llvm-project/commit/a184a0d8aae6efc1d7f19a900155b8694178d617.diff

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked 3 inline comments as done. Closed by commit rGa184a0d8aae6: [clang][dataflow] Add support for disabling warnings on smart pointers. (authored by ymandel)

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. Technically, it looks good to me. However, I'd suggest waiting until Jannik is able to test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] c7f91e2 - [InstrProfiling] No runtime hook for unused funcs

Author: Gulfem Savrun Yeniceri Date: 2022-03-25T17:03:03Z New Revision: c7f91e227a799dfee05962bb108274dbfe809fee URL: https://github.com/llvm/llvm-project/commit/c7f91e227a799dfee05962bb108274dbfe809fee DIFF: https://github.com/llvm/llvm-project/commit/c7f91e227a799dfee05962bb108274dbfe809fee.d

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7f91e227a79: [InstrProfiling] No runtime hook for unused funcs (authored by gulfem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains updated this revision to Diff 418267. iains added a comment. Herald added a subscriber: MaskRay. rebased, addrssed review comment, amend testcase for windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121590/new/ https://reviews.llvm.org/

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains updated this revision to Diff 418268. iains added a comment. another testcase ajustment for windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121590/new/ https://reviews.llvm.org/D121590 Files: clang/lib/Driver/Driver.cpp clang/test

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 418269. cor3ntin added a comment. - Fix a typo (sorry Aaron, I completely missed that) - Add a release note - Clarify why the implementation status is still partial. This is a bit of a drive-by change but I agree it's a good thing to clarify. Repository:

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:569 + if (!containsProfilingIntrinsics(M)) { +if (!CoverageNamesVar || !NeedsRuntimeHook) { + return MadeChange; https://llvm.org/docs/CodingStandards.html

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs added a comment. @tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:569 + if (!containsProfilingIntrinsics(M)) { +if (!CoverageNamesVar || !NeedsRuntimeHook) { + return MadeChange; MaskRay wrote: > https://llvm.org/docs/Codi

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 __

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 418274. iains added a comment. Herald added a subscriber: MaskRay. rebased, adjusted testcases to avoid using clang++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121591/new/ https://reviews.llvm.org/D121591 F

[clang] b97f260 - Reland "[ASTMatchers] Output currently processing match and nodes on crash"

Author: Nathan James Date: 2022-03-25T17:53:58Z New Revision: b97f26083bd04ccbdd63b0c726e047496e5b847a URL: https://github.com/llvm/llvm-project/commit/b97f26083bd04ccbdd63b0c726e047496e5b847a DIFF: https://github.com/llvm/llvm-project/commit/b97f26083bd04ccbdd63b0c726e047496e5b847a.diff LOG:

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D122487#3408425 , @rs wrote: > @tstellar thanks for the review. I can't really think of any other way to > test this. I'll wait till Monday if

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

scott.linder added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9381 + M.getTarget().getTargetOpts().CodeObjectVersion != 500) { +F->addFnAttr("amdgpu-no-hostcall-ptr"); + } arsenm wrote: > sameerds wrote: > > The frontend does not need

[clang] 35b89bc - [clang][driver] Disable non-functional --version option for clang -cc1

Author: Emil Kieri Date: 2022-03-25T19:04:27+01:00 New Revision: 35b89bc24ca58d5b3a87578f69936afb26ef3b69 URL: https://github.com/llvm/llvm-project/commit/35b89bc24ca58d5b3a87578f69936afb26ef3b69 DIFF: https://github.com/llvm/llvm-project/commit/35b89bc24ca58d5b3a87578f69936afb26ef3b69.diff LO

  1   2   >