[PATCH] D123280: [CMake][Fuchsia] Include bolt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff78d25b8e1c: [CMake][Fuchsia] Include bolt (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ff78d25 - [CMake][Fuchsia] Include bolt

Author: Petr Hosek Date: 2022-04-06T22:48:17-07:00 New Revision: ff78d25b8e1c2367a8b06ec40960ce8220c1e2d2 URL: https://github.com/llvm/llvm-project/commit/ff78d25b8e1c2367a8b06ec40960ce8220c1e2d2 DIFF: https://github.com/llvm/llvm-project/commit/ff78d25b8e1c2367a8b06ec40960ce8220c1e2d2.diff

[PATCH] D123280: [CMake][Fuchsia] Include bolt

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We would like to use bolt with Fuchsia toolchain.

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421088. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz created this revision. beanz added reviewers: tschuett, aaron.ballman, jaebaek, antiagainst, kuhar. Herald added a subscriber: arphaman. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This document

[clang] 6c9b363 - [Driver][test] Fix csky-toolchain.c to be CLANG_DEFAULT_PIE_ON_LINUX agnostic

Author: Fangrui Song Date: 2022-04-06T21:14:24-07:00 New Revision: 6c9b363cf67747ea13b12457199ccb151ed1ecea URL: https://github.com/llvm/llvm-project/commit/6c9b363cf67747ea13b12457199ccb151ed1ecea DIFF: https://github.com/llvm/llvm-project/commit/6c9b363cf67747ea13b12457199ccb151ed1ecea.diff

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added inline comments. Comment at: llvm/test/CodeGen/PowerPC/atomics-i128.ll:77 +; AIX64-PWR8-NEXT:sync +; AIX64-PWR8-NEXT:bl .__sync_lock_test_and_set_16[PR] +; AIX64-PWR8-NEXT:nop hubert.reinterpretcast wrote: > What library is this expected

[PATCH] D122734: [HIP] Fix mangling number for local struct

yaxunl added a comment. This patch takes a similar approach as https://reviews.llvm.org/D69322 has done for lambda. When doing host compilation for CUDA/HIP on Windows with MSVC toolchain, mangling number of lambda always uses Itanium mangling number. In this case, mangling number of local

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:440 if (Triple.isOSAIX() || Triple.isOSLinux()) DataLayout += "-S128-v256:256:256-v512:512:512"; resetDataLayout(DataLayout); adalava wrote: > I don't understand what

[clang] e3dcef3 - [Driver][test] Fix csky-toolchain.c to be CLANG_DEFAULT_PIE_ON_LINUX agnostic

Author: Fangrui Song Date: 2022-04-06T20:41:39-07:00 New Revision: e3dcef355febe6e5d0760e4a804861cdea5f2e22 URL: https://github.com/llvm/llvm-project/commit/e3dcef355febe6e5d0760e4a804861cdea5f2e22 DIFF: https://github.com/llvm/llvm-project/commit/e3dcef355febe6e5d0760e4a804861cdea5f2e22.diff

[clang] 2aca33b - Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON""

Author: Fangrui Song Date: 2022-04-06T20:19:07-07:00 New Revision: 2aca33baf15926afe2520a06b1427a9894226fd2 URL: https://github.com/llvm/llvm-project/commit/2aca33baf15926afe2520a06b1427a9894226fd2 DIFF: https://github.com/llvm/llvm-project/commit/2aca33baf15926afe2520a06b1427a9894226fd2.diff

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:14 // PPC: @c = global i8 0, align 1{{$}} _Atomic(char) c; // expected-no-diagnostics I was recently informed that, instead of using

[clang-tools-extra] f2796a5 - Link aganist clangSema to fix broken build.

Author: Jun Zhang Date: 2022-04-07T10:50:50+08:00 New Revision: f2796a5d444998ea73f02f433ed34b7c09e0f7d5 URL: https://github.com/llvm/llvm-project/commit/f2796a5d444998ea73f02f433ed34b7c09e0f7d5 DIFF: https://github.com/llvm/llvm-project/commit/f2796a5d444998ea73f02f433ed34b7c09e0f7d5.diff

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. In D119409#3432281 , @iains wrote: > In D119409#3410893 , @ChuanqiXu > wrote: > >> In D119409#3410868 , @iains wrote: >> >>> In

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. @rsmith @Bigcheese gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @rsmith gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cd43464091c: [clang-format][docs] Fix incorrect clang-format 11 option markers (authored by kuzkry, committed by owenpan). Changed prior to commit:

[clang] 1cd4346 - [clang-format][docs] Fix incorrect 'clang-format 11' option markers

Author: Krystian Kuzniarek Date: 2022-04-06T18:38:30-07:00 New Revision: 1cd43464091c4e177c87b1c03c1db906ecd88d4f URL: https://github.com/llvm/llvm-project/commit/1cd43464091c4e177c87b1c03c1db906ecd88d4f DIFF:

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. Ping @arphaman @sstefan1 @jdoerfert Any comments on this patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3928 break; + case UnaryTransformType::AddConst: +Out << "2ac"; cjdb wrote: > aaron.ballman wrote: > > Are these the suggested manglings from the Itanium mangling

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rjmccall added a comment. In D116203#3434515 , @cjdb wrote: > In D116203#3431612 , @rjmccall > wrote: > >> In D116203#3430332 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3417452 , @dhruvachak wrote: > I added https://github.com/llvm/llvm-project/issues/54654 documenting what I > found when testing this patch on amdgpu. > > @ggeorgakoudis Can you please rebase this patch on top

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall updated this revision to Diff 421028. sammccall added a comment. rebased, come and get me robots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123261/new/ https://reviews.llvm.org/D123261

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added inline comments. Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:994 + enum A { Zero = 0, One = 1 }; + enum B { IntMax = INT_MAX, ULongLongMax = ULLONG_MAX }; + enum class C : unsigned { Two = 2 }; It looks like you need to include `` for

[clang-tools-extra] 5749a26 - [pseudo] Include missing `count` in test deps.

Author: Sam McCall Date: 2022-04-07T00:15:18+02:00 New Revision: 5749a261c584cd16f90e473697fdf640c371eaaa URL: https://github.com/llvm/llvm-project/commit/5749a261c584cd16f90e473697fdf640c371eaaa DIFF: https://github.com/llvm/llvm-project/commit/5749a261c584cd16f90e473697fdf640c371eaaa.diff

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith accepted this revision. dexonsmith added a comment. LGTM; thanks for iterating on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123197/new/ https://reviews.llvm.org/D123197 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. In D116203#3431612 , @rjmccall wrote: > In D116203#3430332 , @aaron.ballman > wrote: > >> In D116203#3425512 , @cjdb wrote: >> >>> I've noticed

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall updated this revision to Diff 421021. sammccall added a comment. Make test a friend of {File,Directory}Entry to avoid the FileManager-as-factory. (A real constructor would be cleaner, but requires tricky FileManager changes). Revert most of the related test changes. Had to rename the

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Objective-C methods selector parts should be considered as identifiers. Depends on D123259

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a bug in `DeclarationFragments::appendSpace` where the space character is added to a

[clang] 69f7210 - Remove unused FileEntry::operator<. NFC

Author: Sam McCall Date: 2022-04-06T23:39:17+02:00 New Revision: 69f7210657a302d0f0a756eb91ec4f54d85fb704 URL: https://github.com/llvm/llvm-project/commit/69f7210657a302d0f0a756eb91ec4f54d85fb704 DIFF: https://github.com/llvm/llvm-project/commit/69f7210657a302d0f0a756eb91ec4f54d85fb704.diff

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman added a comment. In D123167#3434383 , @beanz wrote: > In D123167#3434375 , @aaron.ballman > wrote: > >> I had a meeting with @beanz today because I was also pretty surprised. >> Chris, it might

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. In D123167#3434375 , @aaron.ballman wrote: > I had a meeting with @beanz today because I was also pretty surprised. Chris, > it might make sense to type up a bit of what we talked about as an FAQ and > maybe stick it in Clang's

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

tschuett added a comment. In D123167#3434372 , @beanz wrote: > In D123167#3434364 , @tschuett > wrote: > >> Relying on the parser to find semantic misbehavior sounds strange ... > > I don't disagree. An

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman added a comment. In D123167#3434364 , @tschuett wrote: > Relying on the parser to find semantic misbehavior sounds strange ... I had a meeting with @beanz today because I was also pretty surprised. Chris, it might make sense to type up a

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. In D123167#3434364 , @tschuett wrote: > Relying on the parser to find semantic misbehavior sounds strange ... I don't disagree. An alternative point: HLSL has no _syntax_ for pointers. Repository: rG LLVM Github Monorepo

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

tschuett added a comment. Relying on the parser to find semantic misbehavior sounds strange ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123167/new/ https://reviews.llvm.org/D123167 ___ cfe-commits

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. In D123167#3434350 , @tschuett wrote: > Is the downstream compiler also relying on the parser? Not sure what you mean by downstream compiler. The current official HLSL compiler is a fork of clang-3.7. We don't intend to merge

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

tschuett added a comment. In D123167#3434349 , @beanz wrote: > In D123167#3434346 , @tschuett > wrote: > >> Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp? > > Yes absolutely. I haven't yet added any

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. In D123167#3434346 , @tschuett wrote: > Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp? Yes absolutely. I haven't yet added any Sema-specific validations yet that are complex enough to break out, but we will 100% get

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

tschuett added a comment. Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123167/new/ https://reviews.llvm.org/D123167 ___ cfe-commits mailing list

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman added a comment. In D123167#3434289 , @beanz wrote: > In D123167#3434023 , @aaron.ballman > wrote: > >> I think you're going to need semantic restrictions as well as parsing >> restrictions

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

adalava added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:440 if (Triple.isOSAIX() || Triple.isOSLinux()) DataLayout += "-S128-v256:256:256-v512:512:512"; resetDataLayout(DataLayout); I don't understand what DataLayout does mean,

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. In D123167#3434023 , @aaron.ballman wrote: > I think you're going to need semantic restrictions as well as parsing > restrictions because of type deduction. Even if you don't support templates > (yet), there's still `auto`,

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

dblaikie accepted this revision. dblaikie added a comment. In D122119#3432220 , @iains wrote: > @dblaikie - is the explanation for the change in diagnostics at the same time > OK? (if not, I am happy to split the patch, but either way I'd like to land

[PATCH] D120989: Support debug info for alias variable

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D120989#3411553 , @kavitha-natarajan wrote: >> Thanks for the details - can you ping this thread once the gdb thread has >> progressed/seems

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall added a comment. Storing the UsingShadowDecl directly is much nicer :-) Comment at: clang/include/clang/AST/TemplateName.h:231 + +/// A template name that refers to a template declaration through a specific +/// using shadow declaration.

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

cishida accepted this revision. cishida added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 420977. hokein added a comment. some tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 420976. hokein added a comment. A revised iteration: store UsingShadowDecl directly in TemplateName::Storage, UsingTemplateName class is no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin added a subscriber: aaron.ballman. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:130-131 def ext_delimited_escape_sequence : Extension< - "delimited escape sequences are a Clang extension">, + "%select{delimited|named}0

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman added a comment. I think you're going to need semantic restrictions as well as parsing restrictions because of type deduction. Even if you don't support templates (yet), there's still `auto`, `decltype`, `__typeof__`, and `__auto_type` (I probably missed some, lol) to worry

[clang-tools-extra] c03d625 - [pseudo] Rename DirectiveMap -> DirectiveTree. NFC

Author: Sam McCall Date: 2022-04-06T21:36:57+02:00 New Revision: c03d6257c58ff357b03900fffee6bf75e175f497 URL: https://github.com/llvm/llvm-project/commit/c03d6257c58ff357b03900fffee6bf75e175f497 DIFF: https://github.com/llvm/llvm-project/commit/c03d6257c58ff357b03900fffee6bf75e175f497.diff

[PATCH] D123243: [pseudo] Strip directives from a token stream

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This includes only the taken branch of conditional

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:27 #include "clang/AST/NonTrivialTypeVisitor.h" +#include "clang/AST/Randstruct.h" #include "clang/AST/StmtCXX.h" aaron.ballman wrote: > Is this include necessary? Yes. There's a call to

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420972. void marked 3 inline comments as done. void added a comment. Don't re-randomize a structure. Also some minor style changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420971. cor3ntin added a comment. Recover from valid but loosly matched character names in identifiers more gracefully Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/

[clang] 375d934 - [PS4] Fix a buggy cast

Author: Paul Robinson Date: 2022-04-06T12:28:50-07:00 New Revision: 375d93465b3e6f342e0554cfaee308a45a523969 URL: https://github.com/llvm/llvm-project/commit/375d93465b3e6f342e0554cfaee308a45a523969 DIFF: https://github.com/llvm/llvm-project/commit/375d93465b3e6f342e0554cfaee308a45a523969.diff

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:519-521 +void setLangDefaults(LangOptions , Language Lang, const llvm::Triple , + std::vector , + LangStandard::Kind LangStd); sammccall

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; cameron.mcinally wrote: > Sorry for the late comment,

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. Up for review: https://reviews.llvm.org/D123241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG178aad9b946e: [clang][extract-api] Add Objective-C Category support (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 178aad9 - [clang][extract-api] Add Objective-C Category support

Author: Zixu Wang Date: 2022-04-06T12:00:12-07:00 New Revision: 178aad9b946e3c5abe9df162e5c482fb4acae99c URL: https://github.com/llvm/llvm-project/commit/178aad9b946e3c5abe9df162e5c482fb4acae99c DIFF: https://github.com/llvm/llvm-project/commit/178aad9b946e3c5abe9df162e5c482fb4acae99c.diff

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw updated this revision to Diff 420964. zixuw added a comment. Remove extra commas in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

HazardyKnusperkeks added a comment. In D122064#3430644 , @kuzkry wrote: > Kind reminder, please deliver this revision. I don't have write access. It's not forgotten, at least by me, but I currently have no time to update my LLVM, so I could push

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added a comment. (Seeing the other replies now!) In D123197#3433846 , @sammccall wrote: > I think it's worth making the test a bit uglier to achieve that, and by > contrast adding inheritance to FileManager would make it harder to

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:117 /// gcc5.3. Once that's no longer supported, change this back. -llvm::PointerUnion V; +llvm::PointerUnion V; dexonsmith wrote: > These `const`-ness changes

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 2 inline comments as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1272-1273 + // (x != y). + if ((ConvertedLHS.getMaxValue() < ConvertedRHS.getMinValue()) || + (ConvertedLHS.getMinValue() >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. @steakhal apologies for holding onto this for so long. I managed to fix previously untestable test cases. The issue was that I was building expressions as `(u1 != u2) != 0` and the solver was canonicalizing this to an equivalent `BO_EQ` expression. That's why, it wasn't

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:332-334 + FileEntry(); + FileEntry(const FileEntry &) = delete; + FileEntry =(const FileEntry &) = delete; Aha, now I understand why you needed a factory in the FileEntryTest:

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

benlangmuir added inline comments. Comment at: clang/unittests/Basic/FileEntryTest.cpp:47-52 FileEntryRef addFile(StringRef Name) { -FEs.push_back(std::make_unique()); +const FileEntry *FE = +FM.getVirtualFile(std::to_string(UniqueNameCounter++), 0, 0);

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 420962. manas added a comment. Herald added a project: All. Fix test cases to make them reachable via VisiBinaryOperator and using getConcreteValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

benlangmuir added inline comments. Comment at: clang/unittests/Basic/FileEntryTest.cpp:47-52 FileEntryRef addFile(StringRef Name) { -FEs.push_back(std::make_unique()); +const FileEntry *FE = +FM.getVirtualFile(std::to_string(UniqueNameCounter++), 0, 0);

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index:

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall marked an inline comment as done. sammccall added a comment. In D123197#3433755 , @dexonsmith wrote: >> The ugly part here: >> >> - FileEntryTest was constructing dummy FileEntrys to wrap in FileEntryRef >> - I changed this to use a

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

Trass3r added a comment. That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw updated this revision to Diff 420956. zixuw added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D122734: [HIP] Fix mangling number for local struct

tra added subscribers: rnk, rsmith. tra added a comment. @rnk, @rsmith -- PTAL. Changing mangling for CXXABI on Windows is way out of my comfort zone. > This patch uses Itanium mangling number for structs in HIP host compilation > on Windows to fix this issue. It does not appear to be

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:117 /// gcc5.3. Once that's no longer supported, change this back. -llvm::PointerUnion V; +llvm::PointerUnion V; These `const`-ness changes look independent and

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Randstruct.h:31-35 +using llvm::SmallVectorImpl; + +bool randomizeStructureLayout(const ASTContext , llvm::StringRef Name, + llvm::ArrayRef Fields, +

[clang] 6b30623 - DebugInfo: Make the simplified template names prefix more unique

Author: David Blaikie Date: 2022-04-06T18:25:46Z New Revision: 6b306233f78876a1d197ed6e1f05785505de7c63 URL: https://github.com/llvm/llvm-project/commit/6b306233f78876a1d197ed6e1f05785505de7c63 DIFF: https://github.com/llvm/llvm-project/commit/6b306233f78876a1d197ed6e1f05785505de7c63.diff

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:462 UFE->Dir = >getDirEntry(); - UFE->UID = NextFileUID++; - UFE->IsValid = true; + UFE->UID = NextFileUID++; UFE->File.reset(); sammccall wrote: > kadircet wrote: > >

[PATCH] D123019: [clang][extract-api] Add support for typedefs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc45ca00a19: [clang][extract-api] Add support for typedefs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9fc45ca - [clang][extract-api] Add support for typedefs

Author: Daniel Grumberg Date: 2022-04-06T19:14:05+01:00 New Revision: 9fc45ca00a19336c0724631aa1b1985dd4f4d536 URL: https://github.com/llvm/llvm-project/commit/9fc45ca00a19336c0724631aa1b1985dd4f4d536 DIFF:

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added reviewers: benlangmuir, bnbarham. dexonsmith added a comment. Adding a couple of reviewers that have been looking at FileManager issues with me recently; maybe they have a different perspective. (also, I neglected to say so explicitly before: removing `isValid()` SGTM;

[PATCH] D123141: [clang][DOC] Document module mangler changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG482fad4a3fcb: [clang][DOC] Document module mangler changes (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 482fad4 - [clang][DOC] Document module mangler changes

Author: Nathan Sidwell Date: 2022-04-06T11:13:32-07:00 New Revision: 482fad4a3fcb013aa19e97661e3d66583d026bb8 URL: https://github.com/llvm/llvm-project/commit/482fad4a3fcb013aa19e97661e3d66583d026bb8 DIFF:

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan requested changes to this revision. urnathan added a comment. This revision now requires changes to proceed. Either update this when you're ready, or abandon and create a new one for 1857. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added a comment. > The ugly part here: > > - FileEntryTest was constructing dummy FileEntrys to wrap in FileEntryRef > - I changed this to use a FileManager as a factory It's not clear *why* you changed this to use a FileManager as a factory. It seems unrelated to removing

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420950. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 planned changes to this revision. durin42 added a comment. I'll hold off on this one until the other LLVM patches are done, then mail out the clang work as its own logical unit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg added a comment. Just a note - I was able to test this finally and it works for what I was trying to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420946. cor3ntin added a comment. - Typo fixes for invalid code points Add a method `NearestMatchesForCodepointName` that will return the N closest valid codepoints, by edit distance. This is used to detect typos in named escape sequences in literals. -

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3433691 , @erichkeane wrote: > In D122983#3433685 , @aaron.ballman > wrote: > >> The `-Wimplicit-function-declaration` already exists today, so I believe we >> can

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:318 FileEntryRef ReturnedRef(*NamedFileEnt); - if (UFE.isValid()) { // Already have an entry with this inode, return it. + if (ReusingEntry) { // Already have an entry with this inode, return it.

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

dexonsmith accepted this revision. dexonsmith added a reviewer: benlangmuir. dexonsmith added a subscriber: benlangmuir. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Once we've removed the last use of `DirectoryEntry::getName()`, we should drop

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. In D122983#3433685 , @aaron.ballman wrote: > In D122983#3430706 , @erichkeane > wrote: > >> In D122983#3427518 , @xbolva00 >> wrote: >> >>>

  1   2   >