[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw updated this revision to Diff 423011. zixuw added a comment. Add test case to demonstrate the framework case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 Files:

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:87 +Dir = DirPath; +for (auto NI = path::begin(File), NE = path::end(File), + DI = path::begin(Dir), DE = path::end(Dir); I still need to dig into this

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw created this revision. zixuw added reviewers: ributzka, dang, cishida. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Proof-of-concept patch. Needs more work. Transform input headers to relative

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422996. qiongsiwu1 added a comment. > Also, what's the feedback mechanism for issues with these listings? Say we > add a new Arm header but forget to put it on these lists, who would be the > first to notice? (I admit I'm not very familiar with the

[PATCH] D123825: clang/AMDGPU: Define macro for -munsafe-fp-atomics

arsenm closed this revision. arsenm added a comment. a1303b23c9de6ef6d667aa923ec266ca4a0334e7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123825/new/ https://reviews.llvm.org/D123825

[clang] a1303b2 - clang/AMDGPU: Define macro for -munsafe-fp-atomics

Author: Matt Arsenault Date: 2022-04-14T22:04:59-04:00 New Revision: a1303b23c9de6ef6d667aa923ec266ca4a0334e7 URL: https://github.com/llvm/llvm-project/commit/a1303b23c9de6ef6d667aa923ec266ca4a0334e7 DIFF:

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

peixin accepted this revision. peixin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135 + UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46) + UnorderedRuntimeSimd =

[PATCH] D123300: [Clang] Enable opaque pointers by default

manojgupta added a comment. We noticed a new crash that still repros at head. clang -target armv7a-linux-gnueabihf -march=armv8a -mthumb -c -O2 file.cc llvm-project/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10135: llvm::Value *llvm::VPTransformState::get(llvm::VPValue *, unsigned int):

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay added a comment. Beside the concern raised by platform maintainers: the cc1 default switch part should be made separately from the patch. This makes revert easy and leaves fewer churn to the test suite. If -fno-sized-deallocation is a better cc1 default (but not Driver's), I can make

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

MaskRay accepted this revision. MaskRay added a comment. LGTM if you use `addOptOutFlag` Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:764 CmdArgs.push_back(MArchName.data()); +if (!Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) +

[clang] 8c77a75 - [randstruct] Add test for "-frandomize-layout-seed-file" flag

Author: Bill Wendling Date: 2022-04-14T16:35:41-07:00 New Revision: 8c77a75fb6a82a4cc2182bca89e007e7190a83de URL: https://github.com/llvm/llvm-project/commit/8c77a75fb6a82a4cc2182bca89e007e7190a83de DIFF: https://github.com/llvm/llvm-project/commit/8c77a75fb6a82a4cc2182bca89e007e7190a83de.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rnk added a comment. Generally speaking, this sounds like a good idea to me. One time in 2019 I used -ftime-trace+ClangBuildAnalyzer and it told me that std::unique_ptr was the most expensive template because it is instantiated so

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#3450940 , @bowang wrote: > Any updates on this patch? Would like to see it moving forward. > > I was trying to use Google Breakpad with Clang. Breakpad is a crash handling > library that generates a minidump at crash.

[clang] 27dead3 - Revert "[randstruct] Add test for "-frandomize-layout-seed-file" flag"

Author: Bill Wendling Date: 2022-04-14T16:07:00-07:00 New Revision: 27dead3e3a532625704654a0b66d77f8654d1af2 URL: https://github.com/llvm/llvm-project/commit/27dead3e3a532625704654a0b66d77f8654d1af2 DIFF: https://github.com/llvm/llvm-project/commit/27dead3e3a532625704654a0b66d77f8654d1af2.diff

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

efriedma created this revision. efriedma added a reviewer: erichkeane. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. In D123649 , I got the formula for getFlexibleArrayInitChars slightly wrong: the

[PATCH] D123825: clang/AMDGPU: Define macro for -munsafe-fp-atomics

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123825/new/ https://reviews.llvm.org/D123825 ___ cfe-commits mailing list

[PATCH] D123825: clang/AMDGPU: Define macro for -munsafe-fp-atomics

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The HIP headers want to use this to swap the

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith added a comment. In D122983#3451920 , @erichkeane wrote: > I think Aaron's approach provides a proper 'depreciation' period in our > compiler, as best as we have the ability to do. We've been warning by default for a decade that this code is

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31ea4798ad09: [randstruct] Add test for -frandomize-layout-seed-file flag (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 31ea479 - [randstruct] Add test for "-frandomize-layout-seed-file" flag

Author: Bill Wendling Date: 2022-04-14T15:41:25-07:00 New Revision: 31ea4798ad0990838ccd27f80ca112f177ce91d9 URL: https://github.com/llvm/llvm-project/commit/31ea4798ad0990838ccd27f80ca112f177ce91d9 DIFF: https://github.com/llvm/llvm-project/commit/31ea4798ad0990838ccd27f80ca112f177ce91d9.diff

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

void updated this revision to Diff 422976. void added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123636/new/ https://reviews.llvm.org/D123636 Files: clang/unittests/AST/RandstructTest.cpp Index:

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

aprantl added a comment. > For an example, if thread local variable is present in copyin clause > (testcase attached with the patch), parameter with same name is generated as parameter to artificial function. When user inquires the thread Local variable, its debug info is hidden by the

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1684 + +if (AT->isDeduced() && ThisPtr->getPointeeCXXRecordDecl()->isLambda()) + Elts.push_back(getOrCreateType(AT->getDeducedType(),Unit)); aprantl wrote: > Can you add a

[clang] f20968e - [Driver] Remove unneeded -f[no-]pascal-strings translation. NFC

Author: Fangrui Song Date: 2022-04-14T15:20:58-07:00 New Revision: f20968e00667955f9911864ea922d5a24f548d0d URL: https://github.com/llvm/llvm-project/commit/f20968e00667955f9911864ea922d5a24f548d0d DIFF: https://github.com/llvm/llvm-project/commit/f20968e00667955f9911864ea922d5a24f548d0d.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3452496 , @aaron.ballman wrote: > Do you have ideas on how we can improve the debugging checkpoint behavior (if > at all)? I think we just live with it, like we do for other builtin functions. (There might be things

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

void added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:72 + + return std::tuple(AST.release(), ASTFileSeed.release()); +}; MaskRay wrote: > void wrote: > > MaskRay wrote: > > > aaron.ballman wrote: > > > > void wrote: > > > > >

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

void updated this revision to Diff 422965. void added a comment. Use "unique_ptr" when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123636/new/ https://reviews.llvm.org/D123636 Files: clang/unittests/AST/RandstructTest.cpp Index:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); tra wrote: >

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422959. qiongsiwu1 added a comment. Thanks @DavidSpickett !! The patch is updated. The `arm` headers are now split between `arm` and `aarch64`. > Also, what's the feedback mechanism for issues with these listings? Say we > add a new Arm header but

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

MaskRay added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:72 + + return std::tuple(AST.release(), ASTFileSeed.release()); +}; void wrote: > MaskRay wrote: > > aaron.ballman wrote: > > > void wrote: > > > > aaron.ballman wrote: > > > > >

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

void marked an inline comment as done. void added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:72 + + return std::tuple(AST.release(), ASTFileSeed.release()); +}; MaskRay wrote: > aaron.ballman wrote: > > void wrote: > > > aaron.ballman

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

rjmccall added a comment. The GCC documentation really ought to specify what alignment assumptions these functions make, if any. But they control the specification here, so if they're making alignment assumptions, then I

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); jhuber6 wrote: >

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123808: [clang] Fix the bogus diagnostic introduced by the newly-added UsingTemplate Kind.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11014 // Check that the return type is written as a specialization of // the template specified as the

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added a comment. Apparently the assertions I added are triggering in the LLVM test-suite. Commented them out in 6cf0b1b3da3e8662baf030a2d741e3becaaab2b0 ; I'll come up with a proper fix soon. Repository: rG LLVM

[clang] 6cf0b1b - Comment out assertions about initializer size added in D123649.

Author: Eli Friedman Date: 2022-04-14T13:58:17-07:00 New Revision: 6cf0b1b3da3e8662baf030a2d741e3becaaab2b0 URL: https://github.com/llvm/llvm-project/commit/6cf0b1b3da3e8662baf030a2d741e3becaaab2b0 DIFF: https://github.com/llvm/llvm-project/commit/6cf0b1b3da3e8662baf030a2d741e3becaaab2b0.diff

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); tra wrote: >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); Do you think

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. For reference, this is how I used this driver to offload a CUDA and OpenMP offload kernel that both called an external "hello world" function in `device.cu`. $ clang++ hello.cu device.cu -foffload-new-driver --offload-arch=sm_70 -c $ clang++ openmp.cpp

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather

[clang] 7726ad0 - [PS5] Add basic PS5 driver behavior

Author: Paul Robinson Date: 2022-04-14T12:45:33-07:00 New Revision: 7726ad04e2633a843fb9743e5adfbb404446e657 URL: https://github.com/llvm/llvm-project/commit/7726ad04e2633a843fb9743e5adfbb404446e657 DIFF: https://github.com/llvm/llvm-project/commit/7726ad04e2633a843fb9743e5adfbb404446e657.diff

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

MaskRay added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:40 -static std::unique_ptr makeAST(const std::string ) { +static std::string Seed = "1234567890abcdef"; + `constexpr llvm::StringLiteral Seed = ...` or `constexpr char Seed[]`

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3452572 , @uweigand wrote: > In D123627#3451373 , @aaron.ballman > wrote: > >> Thank you for letting me know -- I've speculatively fixed the issue in >>

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

rnk added a comment. Looks good to me after the fact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

uweigand added a comment. In D123627#3451373 , @aaron.ballman wrote: > Thank you for letting me know -- I've speculatively fixed the issue in > 726901d06aab2f92d684d28507711308368c29d6 >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void added a comment. Updated with those changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void updated this revision to Diff 422936. void marked an inline comment as done. void added a comment. Add some smoke tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763 Files:

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void updated this revision to Diff 422934. void marked an inline comment as done. void added a comment. Accept initialzers of the forms: struct foo f = {}; struct foo g = {0}; Move tests to lit tester. Improve error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5955a0f - Allow flexible array initialization in C++.

Author: Eli Friedman Date: 2022-04-14T11:56:40-07:00 New Revision: 5955a0f9375a8c0b134eeb4a8de5155dcce7c94f URL: https://github.com/llvm/llvm-project/commit/5955a0f9375a8c0b134eeb4a8de5155dcce7c94f DIFF: https://github.com/llvm/llvm-project/commit/5955a0f9375a8c0b134eeb4a8de5155dcce7c94f.diff

[PATCH] D123649: Allow flexible array initialization in C++.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5955a0f9375a: Allow flexible array initialization in C++. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3452491 , @efriedma wrote: >> The reason you get the weird behavior with the note pointing to the same >> line as the declaration is because rintf() is a predefined builtin: >> https://godbolt.org/z/j3W759M7a

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

aaron.ballman added a comment. In D123345#3446495 , @rsmith wrote: > In D123345#3440935 , @aaron.ballman > wrote: > >> Any chance you'd be interested in submitting this patch to >>

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

efriedma added a comment. > The reason you get the weird behavior with the note pointing to the same line > as the declaration is because rintf() is a predefined builtin: > https://godbolt.org/z/j3W759M7a (note the same lovely diagnostic note > behavior). It points at the same location, but

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commits mailing

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

aaron.ballman added a comment. In D97121#3452435 , @njames93 wrote: > In D97121#3448467 , @aaron.ballman > wrote: > >> I'd like to hear from @sammccall as well, but I think the changes here LGTM. >> Can you

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3452424 , @efriedma wrote: > In D123627#3451373 , @aaron.ballman > wrote: > >> Thank you for letting me know -- I've speculatively fixed the issue in >>

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3efad612d234: [HLSL] Pointers are unsupported in HLSL (authored by beanz). Changed prior to commit:

[clang] 3efad61 - [HLSL] Pointers are unsupported in HLSL

Author: Chris Bieneman Date: 2022-04-14T13:32:51-05:00 New Revision: 3efad612d234f938d5012317cfb827e2bf8a1ee7 URL: https://github.com/llvm/llvm-project/commit/3efad612d234f938d5012317cfb827e2bf8a1ee7 DIFF:

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 added a comment. In D97121#3448467 , @aaron.ballman wrote: > I'd like to hear from @sammccall as well, but I think the changes here LGTM. > Can you please add a release note for the fix? Is this a clang-tidy, clangd or both release notes. The

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1397 +for (LateParsedAttribute *Attr : LateParsedAttrs) { + ParseLambdaLexedAttribute(*Attr, Attributes, D); + delete Attr; cor3ntin wrote: >

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

efriedma added a comment. In D123627#3451373 , @aaron.ballman wrote: > Thank you for letting me know -- I've speculatively fixed the issue in > 726901d06aab2f92d684d28507711308368c29d6 >

[clang-tools-extra] b9ca972 - [clang-tidy] Add portability-std-allocator-const check

Author: Fangrui Song Date: 2022-04-14T11:13:41-07:00 New Revision: b9ca972b1ff0548a831fe416cec8d39f7e569c94 URL: https://github.com/llvm/llvm-project/commit/b9ca972b1ff0548a831fe416cec8d39f7e569c94 DIFF: https://github.com/llvm/llvm-project/commit/b9ca972b1ff0548a831fe416cec8d39f7e569c94.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1397 +for (LateParsedAttribute *Attr : LateParsedAttrs) { + ParseLambdaLexedAttribute(*Attr, Attributes, D); + delete Attr; aaron.ballman wrote: > cor3ntin

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 422922. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D123808: [clang] Fix the bogus diagnostic introduced by the newly-added UsingTemplate Kind.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123808 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422920. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address aarons comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files:

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; Isn't the same true for this variable? It seems like: `trivial` == `savedAttrs.empty()`

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao added a subscriber: rsmith. ayzhao added a comment. In D122766#3451775 , @hans wrote: > In D122766#3450298 , @ayzhao wrote: > >> So, the general consensus seems to be that we should use backslashes when

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1486 + if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, + tok::kw___declspec, tok::kw_constexpr, tok::kw_consteval, + tok::kw___private,

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the formatting nit. Comment at: clang/lib/Sema/SemaExpr.cpp:15252-15257 + if (getLangOpts().HLSL) { +if (Opc == UO_AddrOf) + return

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1486 + if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, + tok::kw___declspec, tok::kw_constexpr, tok::kw_consteval, +

Re: [clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

This fixed failure of clang_f_opts.c after bfafa105aab05e2c243e74114739b7d37f8ab0be when the LLVM_DEFAULT_TARGET_TRIPLE looks like arm64-apple-darwin. Sorry that I did not provide enough information in the message. I think the few lines in Darwin.cpp should just be removed since -mpascal-strings

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1397 +for (LateParsedAttribute *Attr : LateParsedAttrs) { + ParseLambdaLexedAttribute(*Attr, Attributes, D); + delete Attr; cor3ntin wrote: >

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1253-1256 + // Due to a parsing error, we either went over the cached tokens or + // there are still cached tokens left, so we skip the leftover tokens. +

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah updated this revision to Diff 422906. tblah added a comment. Added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1234 +void Parser::ParseLambdaLexedAttribute(LateParsedAttribute , + ParsedAttributes , Declarator ) { I think this should likely be named

[clang] 7ef9dd3 - [PS4] Fix a couple of typos

Author: Paul Robinson Date: 2022-04-14T10:14:17-07:00 New Revision: 7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa URL: https://github.com/llvm/llvm-project/commit/7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa DIFF: https://github.com/llvm/llvm-project/commit/7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa.diff

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 422902. MosheBerman added a comment. The tests now pass and actually verify the behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 Files:

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if (loadModuleMapFile(*Dir.getDirRef(), IsSystem,

[PATCH] D123737: [clang-format] Skip preprocessor lines when finding the record lbrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf14ebe91c5dd: [clang-format] Skip preprocessor lines when finding the record lbrace (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] f14ebe9 - [clang-format] Skip preprocessor lines when finding the record lbrace

Author: Arthur Eubanks Date: 2022-04-14T09:31:15-07:00 New Revision: f14ebe91c5dd6be5b64a45e479291cd08676be0c URL: https://github.com/llvm/llvm-project/commit/f14ebe91c5dd6be5b64a45e479291cd08676be0c DIFF:

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks for doing all these Jan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123767/new/ https://reviews.llvm.org/D123767

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added a comment. > Make CTU a two phase analysis At this point maybe it will be a three phase, as we might dump the ASTs/create index in phase 1 :) > During this phase, if we find a foreign function (that could be inlined from > another TU) then we don’t inline that immediately, we

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1466c34669: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL (authored by john.brawn). Repository: rG LLVM Github Monorepo

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1b1466c - [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

Author: John Brawn Date: 2022-04-14T16:51:22+01:00 New Revision: 1b1466c346694c02ff0e30c96a50701b58bc4830 URL: https://github.com/llvm/llvm-project/commit/1b1466c346694c02ff0e30c96a50701b58bc4830 DIFF: https://github.com/llvm/llvm-project/commit/1b1466c346694c02ff0e30c96a50701b58bc4830.diff

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

asavonic added a comment. Herald added a subscriber: gchakrabarti. @MaskRay, should we merge this patch or rework it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121299/new/ https://reviews.llvm.org/D121299

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

hjl.tools added a comment. In D122789#3447413 , @pengfei wrote: > In D122789#3446865 , @MaskRay wrote: > >> To kurly (original Gentoo reporter): >> >> printf '#include \n#include \nuint32_t >>

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fdf952deeb9: [HLSL] Add Semantic syntax, and SV_GroupIndex (authored by beanz). Changed prior to commit:

[clang] 1fdf952 - [HLSL] Add Semantic syntax, and SV_GroupIndex

Author: Chris Bieneman Date: 2022-04-14T10:21:58-05:00 New Revision: 1fdf952deeb9a02aa34794af3c1a7d13a30e068e URL: https://github.com/llvm/llvm-project/commit/1fdf952deeb9a02aa34794af3c1a7d13a30e068e DIFF:

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. FWIW, Aaron and I discussed this at length while he was preparing this patch. I think the current behavior (warn in C99, warn-as-error in C11/C17, hard error in C20) is about as aggressive as I'd want us to be with erroring without causing extensive heartache on

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe471ba3d0122: [Object] Add binary format for bundling offloading metadata (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman added a comment. FYI -- I plan to land this tomorrow unless I hear more feedback from reviewers (but as always, I'll happily take post-commit feedback as well). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123456/new/ https://reviews.llvm.org/D123456

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur updated this revision to Diff 422862. Meinersbur added a comment. - address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123403/new/ https://reviews.llvm.org/D123403 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz updated this revision to Diff 422860. beanz added a comment. Updates to test cases to increase coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123167/new/ https://reviews.llvm.org/D123167 Files:

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur marked 7 inline comments as done. Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135 + UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46) + UnorderedRuntimeSimd = BaseRuntimeSimd | ModifierUnordered,

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. One comment inline. Update coming in a few minutes. Comment at: clang/lib/Sema/SemaExpr.cpp:15252-15257 + if (getLangOpts().HLSL) { +if (Opc == UO_AddrOf) + return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 0); +if (Opc

  1   2   >