[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j created this revision. lamb-j added reviewers: yaxunl, kzhuravl. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j updated this revision to Diff 424110. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124151/new/ https://reviews.llvm.org/D124151 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j updated this revision to Diff 424111. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124151/new/ https://reviews.llvm.org/D124151 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/

[PATCH] D124152: [clang-format] Fix a crash on AllowShortFunctionsOnASingleLine

owenpan created this revision. owenpan added reviewers: aeubanks, curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixe

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// craig.topper wrote: > craig.topper wrote:

[clang] 1234b1c - [AST] Support template declaration found through using-decl for QualifiedTemplateName.

Author: Haojian Wu Date: 2022-04-21T10:53:23+02:00 New Revision: 1234b1c6d8113d50beef5801be607ad1d502b2f7 URL: https://github.com/llvm/llvm-project/commit/1234b1c6d8113d50beef5801be607ad1d502b2f7 DIFF: https://github.com/llvm/llvm-project/commit/1234b1c6d8113d50beef5801be607ad1d502b2f7.diff LO

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1234b1c6d811: [AST] Support template declaration found through using-decl for… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D123775?vs=423843&id=424128#toc Repository: rG L

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1031-1035 + if (it->second.Finalized) { +FormatTok->setFinalizedType(it->second.Type); + } else { +FormatTok->setType(it->second.Type); + }

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

Naghasan added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Any rational for not calling `addTempFile` during the binding rather than the call setup ? I had a brief look there and it seems to me this is the root of the problem. I got bitten by this patch in a down

[PATCH] D124154: [clangd] Fix a declare-constructor tweak crash on incomplete fields.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[clang-tools-extra] 82cddb1 - [clangd] tweak tile should start with a capital letter.

Author: Haojian Wu Date: 2022-04-21T11:24:02+02:00 New Revision: 82cddb173f3781860814fedd86dc83f11ac12e02 URL: https://github.com/llvm/llvm-project/commit/82cddb173f3781860814fedd86dc83f11ac12e02 DIFF: https://github.com/llvm/llvm-project/commit/82cddb173f3781860814fedd86dc83f11ac12e02.diff LO

[PATCH] D123450: [clang-format] Parse Verilog if statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:1572 + bool isBlockBegin(const FormatToken &Tok, const FormatStyle &Style) const { +return Style.isVerilog() ? isVerilogBegin(Tok) : Tok.is(tok::l_brace); + } Shouldn't we

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks added a comment. As this is still on my todo list: Have you considered concept X = Bar<5 < 4, 5 > 8>; concept X = Bar<5 < 4, false>; Or stuff like that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://revi

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. In D123896#3464171 , @HazardyKnusperkeks wrote: > As this is still on my todo list: Have you considered > > concept X = Bar<5 < 4, 5 > 8>; > concept X = Bar<5 < 4, false>; > > Or stuff like that? I think it would not work

[clang] 87a2583 - [OpenCL] Guard read_write images with TypeExtension

Author: Sven van Haastregt Date: 2022-04-21T10:52:41+01:00 New Revision: 87a258366e5d4f3786c6c2b9fe5dbeb736def909 URL: https://github.com/llvm/llvm-project/commit/87a258366e5d4f3786c6c2b9fe5dbeb736def909 DIFF: https://github.com/llvm/llvm-project/commit/87a258366e5d4f3786c6c2b9fe5dbeb736def909.

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 created this revision. skc7 added reviewers: sameerds, cdevadas, ronlieb. Herald added subscribers: mattd, asavonic, ThomasRaoux, jdoerfert, kerbowa, kbarton, jvesely, nemanjai. Herald added a project: All. skc7 requested review of this revision. Herald added a reviewer: jdoerfert. Herald add

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks added a comment. Not yet: https://reviews.llvm.org/D120034 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list cfe-c

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. I see now, would certainly like to help but it sounds like I might not be competent enough for this. I guess this review could be closed unless it's an acceptable half-measure, not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with one minor typo Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. ///

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

kiranchandramohan added a comment. Thanks @Meinersbur for this patch. Apologies for the delay in reviewing many of your patches. The patch looks mostly LGTM. A few nits. The patch probably needs a rebase since there are no dependencies now and a few more construct lowering has landed in MLIR

[PATCH] D124154: [clangd] Fix a declare-constructor tweak crash on incomplete fields.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:182 +if (!C.hasDefinition()) + return Skip; // We can't always tell if

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Sounds good to me. Worth a release note maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124057/new/ https://reviews.llvm.org/D124057

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3463600 , @nemanjai wrote: > In D122983#3463569 , @xbolva00 > wrote: > >> But your link shows failures in compiler-rt/, not in llvm test-suite > > It shows both. But the

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. I'm not able to reproduce the test failure in CI. It looks spurious to me because I have not changed anything related to openmp. The only change in behaviour after my patch should be to avoid a null pointer dereference. In tests which did not hit that null pointer derefer

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a subscriber: fhahn. xbolva00 added a comment. In D122983#3464315 , @aaron.ballman wrote: > In D122983#3463600 , @nemanjai > wrote: > >> In D122983#3463569

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Ok, still looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 __

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3464331 , @xbolva00 wrote: > You probably need to fix Makefiles as well. I believe there were similar > mysterious errors with -ffp-contract changes. Try to look at history of llvm > test-suite. > > cc @fhahn if

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a comment. https://github.com/llvm/llvm-test-suite/commit/79f2b03c5111392d647fa542e120f70c8f39a991 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 __

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#3464124 , @Naghasan wrote: > Any rational for not calling `addTempFile` during the binding rather than the > call setup ? I had a brief look there and it seems to me this is the root of > the problem. > > I got bitten

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3464342 , @xbolva00 wrote: > https://github.com/llvm/llvm-test-suite/commit/79f2b03c5111392d647fa542e120f70c8f39a991 Awesome, parallel build systems to boot. I'll make that change at the same time as setting CFL

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Xcode's clang seems to support this: % clang -target arm64-apple-macos -target-variant arm64-apple-ios13.1-macabi foo.s -c % otool -l foo.o | rg -A2 BUILD

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a comment. In D122983#3464347 , @aaron.ballman wrote: > In D122983#3464342 , @xbolva00 > wrote: > >> https://github.com/llvm/llvm-test-suite/commit/79f2b03c5111392d647fa542e120f70c8f39a991 > > Awe

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3464347 , @aaron.ballman wrote: > In D122983#3464342 , @xbolva00 > wrote: > >> https://github.com/llvm/llvm-test-suite/commit/79f2b03c5111392d647fa542e120f70c8f39a991 >

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

fhahn added a comment. In D122983#3464331 , @xbolva00 wrote: > In D122983#3464315 , @aaron.ballman > wrote: > >> In D122983#3463561 , @MaskRay >> wrote: >> >>> Adding a

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry -

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

sammccall created this revision. sammccall added reviewers: kbobyrev, CJ-Johnson. Herald added subscribers: usaxena95, kadircet, mgrang, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: cla

[clang] 408226f - Fix Sphinx build

Author: Aaron Ballman Date: 2022-04-21T08:52:29-04:00 New Revision: 408226f20ab51508350b2e683c39e1710ea73491 URL: https://github.com/llvm/llvm-project/commit/408226f20ab51508350b2e683c39e1710ea73491 DIFF: https://github.com/llvm/llvm-project/commit/408226f20ab51508350b2e683c39e1710ea73491.diff

[clang-tools-extra] 95d7738 - [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

Author: Fabian Wolff Date: 2022-04-21T15:18:31+02:00 New Revision: 95d77383f2ba8d3136856b52520d3f73f9bc89e7 URL: https://github.com/llvm/llvm-project/commit/95d77383f2ba8d3136856b52520d3f73f9bc89e7 DIFF: https://github.com/llvm/llvm-project/commit/95d77383f2ba8d3136856b52520d3f73f9bc89e7.diff

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

This revision was automatically updated to reflect the committed changes. Closed by commit rG95d77383f2ba: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D113804?vs=400677&id=424172#toc Repos

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424176. kbobyrev added a comment. Remove unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.cpp:111 +// If a self-contained header is included recursively it will get +// different FileIDs each t

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 424183. erichkeane added a comment. This revision is now accepted and ready to land. Added the tests that still fail to 'concepts.cpp', I still need to figure those out. However, I switched our 'skipping of instantiation' over to use `RebuildExprInCurren

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane planned changes to this revision. erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts.cpp:391 + + CausesFriendConstraint CFC; + FriendFunc(CFC, 1); A bunch of the tests below this all fail. CHANGES SINCE LAST ACTION htt

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124151/new/ https://reviews.llvm.org/D124151 __

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424189. kbobyrev added a comment. Use strlen for performance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added a comment. In D123831#3459368 , @ributzka wrote: > In D123831#3458774 , @dang wrote: > >> In D123831#3455048 , @cishida >> wrote: >> we might not always w

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424192. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-too

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby updated this revision to Diff 424193. DavidTruby added a comment. Add additional tests for vector splats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124091/new/ https://reviews.llvm.org/D124091 Files: clang/include/clang/Sema/Sema.h

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.cpp:26 const char IWYUPragmaKeep[] = "// IWYU pragma: keep"; +const char IWYUPragmaExport[] = "// IWYU pragma: export"

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

Jake-Egan added a comment. Hi, we also have a failure on AIX with test-suite `call to undeclared library function '%0' with type %1; ISO C99 and later` https://lab.llvm.org/buildbot/#/builders/214/builds/825/steps/9/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3464724 , @Jake-Egan wrote: > Hi, we also have a failure on AIX with test-suite `call to undeclared library > function '%0' with type %1; ISO C99 and later` > https://lab.llvm.org/buildbot/#/builders/214/builds

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It runs i

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove fiddly union, preambles are heavyweight - Remove fiddly move constructors i

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:373 + } + llvm::StringRef filePath() const { return File->getFilePath(); } + llvm::StringRef memoryContents() co

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424205. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-ex

[clang-tools-extra] 9f05b11 - [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

Author: Kirill Bobyrev Date: 2022-04-21T17:00:06+02:00 New Revision: 9f05b111ee1fc48974ed515c865bdaddb5998d01 URL: https://github.com/llvm/llvm-project/commit/9f05b111ee1fc48974ed515c865bdaddb5998d01 DIFF: https://github.com/llvm/llvm-project/commit/9f05b111ee1fc48974ed515c865bdaddb5998d01.diff

[clang-tools-extra] e1c0d2f - [clangd] Correctly identify self-contained headers included rercursively

Author: Kirill Bobyrev Date: 2022-04-21T16:54:59+02:00 New Revision: e1c0d2fb8272dd7f8e406334ac14077154217031 URL: https://github.com/llvm/llvm-project/commit/e1c0d2fb8272dd7f8e406334ac14077154217031 DIFF: https://github.com/llvm/llvm-project/commit/e1c0d2fb8272dd7f8e406334ac14077154217031.diff

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1c0d2fb8272: [clangd] Correctly identify self-contained headers included rercursively (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f05b111ee1f: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export (authored by kbobyrev). Repository: rG LLVM Github Monore

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3462665 , @klausler wrote: > New comments or not, this step remains premature from my perspective. Let me make `-flang-experimental-exec` a "hidden" option then. This way this flag (and the functionality that it en

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/FeatureModule.h:109 +// Called before the preamble build. Allows modules to modify the +// CompilerInvocation

[clang] f80e369 - [PS4] Driver: use correct --shared option

Author: Paul Robinson Date: 2022-04-21T08:19:42-07:00 New Revision: f80e369f61ebd33dd9377bb42fcab64d17072b18 URL: https://github.com/llvm/llvm-project/commit/f80e369f61ebd33dd9377bb42fcab64d17072b18 DIFF: https://github.com/llvm/llvm-project/commit/f80e369f61ebd33dd9377bb42fcab64d17072b18.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 424209. bc-lee added a comment. Add `REQUIRES: x86-registered-target` on the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added inline comments. Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s -o -

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

adamcz updated this revision to Diff 424215. adamcz marked 5 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124176/new/ https://reviews.llvm.org/D124176 Files: clang-tools

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of unconditionally copying the PCHBuffer into an ostream which can be backed

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad46aaede6e4: [clangd] Add beforeExecute() callback to FeatureModules. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang-tools-extra] ad46aae - [clangd] Add beforeExecute() callback to FeatureModules.

Author: Adam Czachorowski Date: 2022-04-21T18:03:39+02:00 New Revision: ad46aaede6e4d5a6951fc9827da994d3fbe1af44 URL: https://github.com/llvm/llvm-project/commit/ad46aaede6e4d5a6951fc9827da994d3fbe1af44 DIFF: https://github.com/llvm/llvm-project/commit/ad46aaede6e4d5a6951fc9827da994d3fbe1af44.d

[clang] af3fb07 - [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

Author: Sam McCall Date: 2022-04-21T18:10:13+02:00 New Revision: af3fb071545918f2de61142fa12d8782e5a37fa5 URL: https://github.com/llvm/llvm-project/commit/af3fb071545918f2de61142fa12d8782e5a37fa5 DIFF: https://github.com/llvm/llvm-project/commit/af3fb071545918f2de61142fa12d8782e5a37fa5.diff LO

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGaf3fb0715459: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D124177?vs=4

[clang] afcc6ba - [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

Author: Jacob Lambert Date: 2022-04-21T09:24:33-07:00 New Revision: afcc6baac52fcc91d1636f6803f5c230e7018016 URL: https://github.com/llvm/llvm-project/commit/afcc6baac52fcc91d1636f6803f5c230e7018016 DIFF: https://github.com/llvm/llvm-project/commit/afcc6baac52fcc91d1636f6803f5c230e7018016.diff

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafcc6baac52f: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when… (authored by lamb-j). Repository: rG LLVM Github Mon

[PATCH] D123450: [clang-format] Parse Verilog if statements

MyDeveloperDay added a comment. As first passes for adding a new language I think this looks pretty good. ``if (Keywords.isBlockBegin(*FormatTok, Style)) {`` I'm not a massive fan of handling l_brace and begin and end as the same thing, I might be tempted to handle them separately, as then its

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

daltenty added a comment. In D122983#3464759 , @aaron.ballman wrote: > In D122983#3464724 , @Jake-Egan > wrote: > >> Hi, we also have a failure on AIX with test-suite `call to undeclared >> library function '%0

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#3463887 , @pcwang-thead wrote: > In D112921#3462592 , @Mordante > wrote: > >> I didn't look at the code, but I have some hints how we can test libc++. > > Thanks! I ran tests

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3465052 , @daltenty wrote: > In D122983#3464759 , @aaron.ballman > wrote: > >> In D122983#3464724 , @Jake-Egan >> wrote: >> >>>

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

nemanjai added a comment. @daltenty Can you please run this with the same config as the bot on one of our AIX machines but be sure to pass `-i` if it's `make` or `-k 0` if it's `ninja`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ htt

[clang] f296b4c - [AIX] Always pass namedsects option when linking with PGO.

Author: Wael Yehia Date: 2022-04-21T17:01:37Z New Revision: f296b4c444625f84be1db27cfd52a3d16387f456 URL: https://github.com/llvm/llvm-project/commit/f296b4c444625f84be1db27cfd52a3d16387f456 DIFF: https://github.com/llvm/llvm-project/commit/f296b4c444625f84be1db27cfd52a3d16387f456.diff LOG: [A

[PATCH] D124046: [AIX] Always pass namedsects option when linking with PGO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf296b4c44462: [AIX] Always pass namedsects option when linking with PGO. (authored by w2yehia). Herald added a project: clang. Herald added a subscri

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3465099 , @nemanjai wrote: > @daltenty Can you please run this with the same config as the bot on one of > our AIX machines but be sure to pass `-i` if it's `make` or `-k 0` if it's > `ninja`? That would be *aw

[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

craig.topper added a comment. The intrinsic interface doesn't care about 0https://reviews.llvm.org/D124186/new/ https://reviews.llvm.org/D124186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILE

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 424241. erichkeane added a comment. This revision is now accepted and ready to land. Found that the recursive var-decl collection was incorrect, since all the values were already in the parent scopes! So I ended up being able to fix MOST of the problems

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane planned changes to this revision. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2329 + // constraint, so we should just create a copy of the previous one. + // TODO: ERICH: Should this be RebuildExprInCurrentInstantiation he

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3465139 , @rastogishubham wrote: > Hi, this patch causes an issue with the CMake Xcode build configuration, if I > try to use xcode as the generator with CMake, using the build command: > > I used git bisect to fig

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. This patch is a continuation of https://reviews.llvm.org/D123353. Not only kernels in anonymous namespace, but also template kernels

[PATCH] D124154: [clangd] Fix a declare-constructor tweak crash on incomplete fields.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:182 +if (!C.hasDefinition()) + return Skip; // We can't always tell if C is copyable/movable without doing Sema work. sammccall wrote: > Fa

[clang-tools-extra] 84051d8 - [clangd] Fix a declare-constructor tweak crash on incomplete fields.

Author: Haojian Wu Date: 2022-04-21T19:44:43+02:00 New Revision: 84051d8226d517f7728750ec4bde3ba75ca03468 URL: https://github.com/llvm/llvm-project/commit/84051d8226d517f7728750ec4bde3ba75ca03468 DIFF: https://github.com/llvm/llvm-project/commit/84051d8226d517f7728750ec4bde3ba75ca03468.diff LO

[PATCH] D124154: [clangd] Fix a declare-constructor tweak crash on incomplete fields.

This revision was automatically updated to reflect the committed changes. Closed by commit rG84051d8226d5: [clangd] Fix a declare-constructor tweak crash on incomplete fields. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124154

[clang] 6e22dac - [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

Author: Sam McCall Date: 2022-04-21T19:52:59+02:00 New Revision: 6e22dac2e2955db1310c63aec215fc22d8da258e URL: https://github.com/llvm/llvm-project/commit/6e22dac2e2955db1310c63aec215fc22d8da258e DIFF: https://github.com/llvm/llvm-project/commit/6e22dac2e2955db1310c63aec215fc22d8da258e.diff LO

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e22dac2e295: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory (authored by sammccall). Changed prior to commit: htt

[clang] 1283ccb - Support z16 processor name

Author: Ulrich Weigand Date: 2022-04-21T19:58:22+02:00 New Revision: 1283ccb610feef4f2e0edf22f66a705155a0e0c7 URL: https://github.com/llvm/llvm-project/commit/1283ccb610feef4f2e0edf22f66a705155a0e0c7 DIFF: https://github.com/llvm/llvm-project/commit/1283ccb610feef4f2e0edf22f66a705155a0e0c7.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

nemanjai added a comment. In D122983#3465122 , @aaron.ballman wrote: > In D122983#3465099 , @nemanjai > wrote: > >> @daltenty Can you please run this with the same config as the bot on one of >> our AIX machine

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi Thanks for the response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added subscribers: yln, thakis. thakis added a comment. I think this might've broken check-clangd: http://45.33.8.238/linux/74320/step_9.txt The output isn't very useful though, I'm guessing @yln's recent gtest runner change it's not getting printed. Repository: rG LLVM Github Monore

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added a subscriber: ychen. thakis added a comment. Sorry, @ychen, not @yln (D122251 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124180/new/ https://reviews.llvm.org/D124180 _

  1   2   3   >