[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. > I looked at your code quickly and I wonder if using operand bundles would be > better than adding an attribute. Thoughts? Perhaps @pcc can provide a better feedback on the hassle (or joys) behind using operand bundles. My insights on the attribute is that it is ve

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. > I agree that a separate pass wasn't ideal, but InstCombine seems to be full > of code to "fix what other passes messed up". :) I'm not sure if messed up > is the correct term though, these are checks that were necessary before > optimizations, but are no longer

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. Thank you all commit in eaca933c59fd61b3df4697b5fae0eeec67acfaeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaca933c59fd: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name (authored by jonasyhwang ). Reposit

[clang] eaca933 - [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

Author: jonasyhwang Date: 2022-04-29T12:58:53+08:00 New Revision: eaca933c59fd61b3df4697b5fae0eeec67acfaeb URL: https://github.com/llvm/llvm-project/commit/eaca933c59fd61b3df4697b5fae0eeec67acfaeb DIFF: https://github.com/llvm/llvm-project/commit/eaca933c59fd61b3df4697b5fae0eeec67acfaeb.diff L

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3477316 , @erichkeane wrote: > Correct the caching behavior to make the FriendFunc example work. > > I THINK this is ready to review! I'd like to do the lambda examples in a > followup patch as I believe that is a

[PATCH] D124348: [1/2][RISCV]Add Intrinsics for B extension in Clang

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM, but please fix the title to not use "B extension" since the "B extension" was never ratified. Only Zba, Zbb, Zbc, Zbs were ratified and there will never be a B. Repository:

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124509/new/ https://reviews.llvm.org/D124509 ___

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78582194361e: [asan] Enable detect_stack_use_after_return=1 by default on Linux (authored by vitalybuka). Changed prior to commit: https://reviews

[clang] 7858219 - [asan] Enable detect_stack_use_after_return=1 by default on Linux

Author: Vitaly Buka Date: 2022-04-28T21:08:16-07:00 New Revision: 78582194361e4454e95d3af23367b81dd63b7943 URL: https://github.com/llvm/llvm-project/commit/78582194361e4454e95d3af23367b81dd63b7943 DIFF: https://github.com/llvm/llvm-project/commit/78582194361e4454e95d3af23367b81dd63b7943.diff L

[clang] a70cf56 - Reland: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Author: Qiongsi Wu Date: 2022-04-29T00:03:06-04:00 New Revision: a70cf56d20b956fc008d24420e14226127ba9f4a URL: https://github.com/llvm/llvm-project/commit/a70cf56d20b956fc008d24420e14226127ba9f4a DIFF: https://github.com/llvm/llvm-project/commit/a70cf56d20b956fc008d24420e14226127ba9f4a.diff LO

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425953. int3 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/O

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

rjmccall added a comment. My only comment about the design is that maybe it should be `__builtin_kcfi_call_unchecked`, which does not seem like something you need to hold up LKML discussion for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211

[clang] 52ce95a - [NFC] Prevent shadowing a variable declared in `if`

Author: Ken Matsui Date: 2022-04-28T22:22:27-04:00 New Revision: 52ce95a1a55424256f0d56e32392396896ed7f76 URL: https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76 DIFF: https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76.diff LO

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce95a1a554: [NFC] Prevent shadowing a variable declared in `if` (authored by ken-matsui, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 2d13386 - Frontend: Delete output streams before closing CompilerInstance outputs

Author: Duncan P. N. Exon Smith Date: 2022-04-28T19:07:40-07:00 New Revision: 2d133867833fe8eb20c11377ff1221f71afc1db3 URL: https://github.com/llvm/llvm-project/commit/2d133867833fe8eb20c11377ff1221f71afc1db3 DIFF: https://github.com/llvm/llvm-project/commit/2d133867833fe8eb20c11377ff1221f71afc

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d133867833f: Frontend: Delete output streams before closing CompilerInstance outputs (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D124635?vs=425893&id=425946#toc Reposit

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425944. int3 added a comment. add --no-force-dwarf-unwind-info; only omit by default on aarch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/cl

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3481573 , @joaomoreira wrote: > At first I was on the boat of KCFI being implemented in the IR level because > being architecture agnostic is certainly a great plus. The original plan was to just lower the intri

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3480793 , @pcc wrote: >> Yes, I suspect this might be an issue with Clang's existing CFI schemes too, >> and would probably require an additional pass to drop checks before calls >> that were either inlined or op

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 425942. samitolvanen marked an inline comment as done. samitolvanen added a comment. - Moved the KCFI pass to InstCombine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/

[PATCH] D119296: KCFI sanitizer

joaomoreira added a subscriber: craig.topper. joaomoreira added a comment. > This seems like a reasonable approach, and was also the approach taken for > the PAuth ABI. The PAuth ABI attaches an operand bundle to the call > instruction and arranges for the code for the check to be generated toge

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

MaskRay accepted this revision. MaskRay added a comment. Happy if Aaron is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 ___ cfe-commits mailing list c

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

dexonsmith added a comment. In D124635#3481346 , @benlangmuir wrote: > LGTM, although I made a suggestion about the spelling. Thanks for the review! >> This fixes theoretical bugs related to proxy streams, which may have >> cleanups to run in their des

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Some of our users are not very happy with the churn probably caused by this change where the declaration has the "void" argument but the later definition does not have explicit "void". void foo(void); void foo() { } GCC does not warn about this usage: h

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

MaskRay added a comment. Probably no from my view, as I got another internal feedback that "this seems rather crufty". It seems that it is the build system maintainer's responsibility. If you add `-Wno-unknown-warning-option` temporarily, after a new clang is rolled, you may remove `-Wno-unknow

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:400 + /// then the return value is 0 + /// and the note may say "Assuming the character is non-alphabetical". + class SummaryCa

[clang] f68c0a2 - [analyzer] Add path note tags to standard library function summaries.

Author: Artem Dergachev Date: 2022-04-28T17:17:05-07:00 New Revision: f68c0a2f58e484f008883ab290e36a36e851c1bf URL: https://github.com/llvm/llvm-project/commit/f68c0a2f58e484f008883ab290e36a36e851c1bf DIFF: https://github.com/llvm/llvm-project/commit/f68c0a2f58e484f008883ab290e36a36e851c1bf.dif

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf68c0a2f58e4: [analyzer] Add path note tags to standard library fu

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. General question: There is the question of whether or not the replacement should have `()`s around the whole thing because we don't analyze the context to see if the change in precedence between `operator!` and `operator&&` or `operator||` makes any difference

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93. LegalizeAdulthood added projects: clang-tools-extra, All. Herald added subscribers: carlosgalvezp, xazax.hun. LegalizeAdulthood requested review of this revision. Make the following simplifications

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void updated this revision to Diff 425932. void added a comment. Rebase with top-of-tree. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 Files: clang/lib/Sema/SemaDecl.cpp clang/unittests/AST/

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi, Thank you for your work on the patch, it seems to work now! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11d3e31c60bd: [CUDA][HIP] Fix mangling number for local struct (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[clang] 11d3e31 - [CUDA][HIP] Fix mangling number for local struct

Author: Yaxun (Sam) Liu Date: 2022-04-28T19:54:43-04:00 New Revision: 11d3e31c60bdc9e491c51b97a964b6289575edfa URL: https://github.com/llvm/llvm-project/commit/11d3e31c60bdc9e491c51b97a964b6289575edfa DIFF: https://github.com/llvm/llvm-project/commit/11d3e31c60bdc9e491c51b97a964b6289575edfa.dif

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen added a comment. In D124211#3480773 , @nickdesaulniers wrote: > Perhaps it's time to start a discussion on LKML then, before landing this? I don't intend to land these patches until there's a consensus on the correct approach from both pro

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

benlangmuir added a comment. LGTM, although I made a suggestion about the spelling. > This fixes theoretical bugs related to proxy streams, which may have > cleanups to run in their destructor. E.g., buffer_ostream supports > pwrite() by holding all content in a buffer until destruction time. Th

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma created this revision. efriedma added reviewers: asmith, tentzen, rnk, mstorsjo, JosephTremoulet, dpaoliello, rjmccall. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. efriedma requested review of this revision. Herald added a subscriber: jdoerfert. Herald added

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSe

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. Hi, @aaron.ballman Thanks for your kind reviews! I’ve updated the code, but is this what you’d expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 __

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 425916. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

This revision was automatically updated to reflect the committed changes. Closed by commit rG42823beb1d71: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 42823be - [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

Author: Argyrios Kyrtzidis Date: 2022-04-28T15:23:03-07:00 New Revision: 42823beb1d710f8e7273e3025e4ba793253fc0a4 URL: https://github.com/llvm/llvm-project/commit/42823beb1d710f8e7273e3025e4ba793253fc0a4 DIFF: https://github.com/llvm/llvm-project/commit/42823beb1d710f8e7273e3025e4ba793253fc0a4.

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425914. dgoldman marked 6 inline comments as done. dgoldman added a comment. - Extract var type handling to a function - Other fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https:/

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124593/new/ https://reviews.llvm.org/D124593 ___ cfe-co

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 ___ cfe-co

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 ___

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida created this revision. cishida added reviewers: ributzka, zixuw, jansvoboda11. Herald added a project: All. cishida requested review of this revision. Herald added a project: clang. tapi & clang-extractapi both attempt to construct then check against how a header was included to determine

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StoreToImmutableChecker.cpp:43 + + if (!isa(R->getMemorySpace())) +return; This check catches a lot more regions than the ones produced by the other checker. In particular, it'll warn

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: abrachet. Herald added a reviewer: libc++. Herald added projects: libc++abi, libunwind, All. Herald added a reviewer: libc++abi. Herald added a reviewer: li

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:889-890 +REGISTER_MAP_FACTORY_WITH_PROGRAMSTATE(CastMap, uint32_t /*bitwidth*/, RangeSet) +REGISTER_MAP_WITH_PROGRAMSTATE(SymCastMap, SymbolRef, CastMap) + These ma

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

CJ-Johnson accepted this revision. CJ-Johnson added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:18 +class ASTWalker : public RecursiveASTVisitor { + DeclCallback Callback; + Apologies for my ignorance of LLVM style. Should this

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai added a comment. Recollected that `ASTStructuralEquivalence` by default tends to be order-dependent while ODR hash order-independent. Different approaches can be achieved with different mechanisms but some behavior is easier to achieve. Another peculiarity of `ASTStructuralEquivalence`

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. (clearing my queue while there are unaddressed comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/ https://reviews.l

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-

[PATCH] D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap"

t-rasmud abandoned this revision. t-rasmud added a comment. Abandoning this patch because it was a downstream problem and I incorrectly diagnosed it on the one source branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124570/new/ https://review

[PATCH] D124635: Frontend: Delete output streams before closing CompilerInstance outputs

dexonsmith created this revision. dexonsmith added reviewers: akyrtzi, steven_wu, benlangmuir. Herald added a project: All. dexonsmith requested review of this revision. Herald added a project: clang. Delete the output streams coming from CompilerInstance::createOutputFile() and friends once write

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

vsapsai updated this revision to Diff 425891. vsapsai added a comment. Simplify pointer comparison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124285/new/ https://reviews.llvm.org/D124285 Files: clang/include/clang/Parse/Parser.h clang/incl

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17067 +void Sema::ActOnObjCTemporaryExitContainerContext(ObjCContainerDecl *ObjCCtx) { + auto DC = cast(ObjCCtx); assert(DC == CurContext && "Mismatch of container contexts"); jansvoboda11

[PATCH] D121873: [clang][extract-api] Add enum support

dexonsmith added inline comments. Comment at: clang/test/ExtractAPI/enum.c:11 +// RUN: %t/output.json >> %t/output-normalized.json +// RUN: diff %t/reference.output.json %t/output-normalized.json + Diffing against reference output is usually not ideal: - It makes

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

dblaikie added a comment. In D124434#3480519 , @aaron.ballman wrote: > In D124434#3480481 , @dblaikie > wrote: > >> Yeah, I have mixed feelings - I think at least in theory, C++ tries to be >> mostly backwards

[PATCH] D124634: ExtractAPI: Use %clang_cc1 and -verify in enum.c

dexonsmith created this revision. dexonsmith added reviewers: zixuw, dang, ributzka. Herald added a project: All. dexonsmith requested review of this revision. Herald added a project: clang. Fix one test (enum.c) in ExtractAPI to use %clang_cc1 and -verify instead of calling the full driver and Fi

[PATCH] D121873: [clang][extract-api] Add enum support

dexonsmith added inline comments. Comment at: clang/test/ExtractAPI/enum.c:5 +// RUN: %t/reference.output.json +// RUN: %clang -extract-api -target arm64-apple-macosx \ +// RUN: %t/input.h -o %t/output.json | FileCheck -allow-empty %s I just noticed these tests u

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 425879. jhuber6 added a comment. Changin `-f[no-]offload-new-driver` into `--[no-]offload-new-driver` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/i

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. @rsmith -- do you have any lingering concerns about the severity of the diagnostic? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<

[PATCH] D123325: [Clang] Make enabling the new driver more generic

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<["-"

[PATCH] D123958: [randstruct] Randomize all elements of a record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG463790bfc70e: [randstruct] Randomize all elements of a record (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 463790b - [randstruct] Randomize all elements of a record

Author: Bill Wendling Date: 2022-04-28T12:01:11-07:00 New Revision: 463790bfc70e15f9c23b76f1c53e228b644f8bb1 URL: https://github.com/llvm/llvm-project/commit/463790bfc70e15f9c23b76f1c53e228b644f8bb1 DIFF: https://github.com/llvm/llvm-project/commit/463790bfc70e15f9c23b76f1c53e228b644f8bb1.diff

[PATCH] D119296: KCFI sanitizer

pcc added a comment. In D119296#3467905 , @samitolvanen wrote: > In D119296#3466027 , @joaomoreira > wrote: > >> I played a little bit with kcfi and here are some thoughts: >> >> - under -Os I saw functions bein

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. In D124211#3480709 , @samitolvanen wrote: > In D124211#3480652 , > @nickdesaulniers wrote: > >> Can you link to the lore thread on discussions around the builtin? > > There's no

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa marked an inline comment as done. yihanaa added a comment. Thanks for review @erichkeane and @aaron.ballman , I have add a newline back to the end of the test, and waiting for ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 425861. yihanaa added a comment. Add the newline back to the end of the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen added a comment. In D124211#3480652 , @nickdesaulniers wrote: > Can you link to the lore thread on discussions around the builtin? There's no LKML discussion about the built-in, but there were earlier proposals of using an attribute to acc

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + nickdesaulniers wrote: > `auto *Call =` > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall added a comment. Ok, this looks pretty good to me! Just nits Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSett

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. Can you link to the lore thread on discussions around the builtin? Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + `auto *Call =` https://llvm.org/docs/CodingStandards

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123325: [Clang] Make enabling the new driver more generic

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<["-"

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:431 +def ext_pp_gnu_line_directive : Extension< + "this style of line directive is a GNU extension">; + Oops, I missed this last time around, but we need this to be

[PATCH] D124540: [clang][dataflow] Perform structural comparison of indirection values in `join`.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:357-365 +// FIXME: add unit tests that cover this statement. +if (auto *IndVal1 = dyn_cast(Val)) { + auto *IndVal2 = cast(It-

[PATCH] D124540: [clang][dataflow] Perform structural comparison of indirection values in `join`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c81b5723716: [clang][dataflow] Perform structural comparison of indirection values in `join`. (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D124540?vs=425567&id=425849#toc R

[clang] 6c81b57 - [clang][dataflow] Perform structural comparison of indirection values in `join`.

Author: Yitzhak Mandelbaum Date: 2022-04-28T17:55:09Z New Revision: 6c81b57237164319b5429ee33957004aa21db2fa URL: https://github.com/llvm/llvm-project/commit/6c81b57237164319b5429ee33957004aa21db2fa DIFF: https://github.com/llvm/llvm-project/commit/6c81b57237164319b5429ee33957004aa21db2fa.diff

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124558/new/ https://reviews.llvm.org/D124558 ___ cfe-commits mailing l

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. In D124382#3479773 , @jchlanda wrote: > In D124382#3472888 , @Anastasia > wrote: > >> > > > >> Can you provide an example of where it could be useful? Note that I feel that >> such fun

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath added a comment. Herald added a subscriber: StephenFan. Wanted to circle back around to this one, since this feature would still really help improve the workflow for ignoring warnings on build systems without deep compiler examination capabilities. Can we move forward with this? R

[PATCH] D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers

kuzkry added a comment. Here's a list of earliest commits where each option changed in this PR was introduced: AlwaysBreakTemplateDeclarations - 61e6bbf8508a46ad1269c8ea67dc0372b84e9a3b IncludeBlocks - 4c2c9c3620e3bed9cb6fa709ec3b3cc454eb5748 IncludeCategories - introduced in 85c472dccdf536fb185

[PATCH] D121156: [OPENMP]PR53344: Emit code for final update of the inscan reduction vars in worksharing loops.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1462e63f67a9: [OPENMP]PR53344: Emit code for final update of the i

[clang] 1462e63 - [OPENMP]PR53344: Emit code for final update of the inscan reduction vars in worksharing loops.

Author: Alexey Bataev Date: 2022-04-28T10:41:28-07:00 New Revision: 1462e63f67a965defec035c3bc17a5ddeb366964 URL: https://github.com/llvm/llvm-project/commit/1462e63f67a965defec035c3bc17a5ddeb366964 DIFF: https://github.com/llvm/llvm-project/commit/1462e63f67a965defec035c3bc17a5ddeb366964.diff

[PATCH] D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

efriedma added a comment. In D124158#3480384 , @arsenm wrote: > I'm thinking noundef is a bit of red herring here. The real problem seems to > be arising from the assume call which is inserted, which now introduces the > assumption that the lane ID must

[clang] 17f3a92 - [PS5] Default to omit leaf frame pointer

Author: Paul Robinson Date: 2022-04-28T10:35:14-07:00 New Revision: 17f3a92ee5d5490e84cc81481b0947f6a9be3106 URL: https://github.com/llvm/llvm-project/commit/17f3a92ee5d5490e84cc81481b0947f6a9be3106 DIFF: https://github.com/llvm/llvm-project/commit/17f3a92ee5d5490e84cc81481b0947f6a9be3106.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added a comment. I think there are no more untied knots... @pengfei, do you think this is ready to merge? If yes, can you please merge it? tks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118052/new/ https://reviews.llvm.org/D118052 __

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

akyrtzi added a comment. @jansvoboda11 thanks for reviewing! I've changed APIs to use a reference instead of a pointer and removed the unnecessary check and heap allocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124558/new/ https://review

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

akyrtzi updated this revision to Diff 425833. akyrtzi added a comment. Change APIs to accept a reference of `ExcludedPreprocessorDirectiveSkipMapping` instead of a pointer, since it is required now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124

[PATCH] D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap"

steakhal added a comment. In D124570#3480457 , @t-rasmud wrote: > In D124570#3479334 , @steakhal > wrote: > >> I'm not comfortable with reverting this. >> We depend on taint capabilities downstream, thus we would

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:135-145 TEST(ParmVarDecl, KNRLocation) { LocationVerifier Verifier; - Verifier.expectLocation(1, 8); - EXPECT_TRUE(Verifier.match("void f(i) {}", varDecl(), Lang_C99)); + Verifier.e

[PATCH] D124624: [OpenMP] Add variant extension that applies to declarations

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: aaron.ballman. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3480481 , @dblaikie wrote: > Yeah, I have mixed feelings - I think at least in theory, C++ tries to be > mostly backwards compatible and so old tests should run successfully in new > language modes - and I guess

  1   2   3   >