[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

HazardyKnusperkeks added a comment. In D126132#3533033 , @owenpan wrote: > @HazardyKnusperkeks I think you know this better than any of us as you added > the assertion to `setType()`. Does this look ok to you? This looks good. One should define what is

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

MaskRay added a comment. This needs a test. Can Debian's riscv GCC be fixed to use a normalized triple for library and include paths? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126672/new/ https://reviews.llvm.org/D126672

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433029. junaire added a comment. - Support undo N times - Add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Inter

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433030. junaire added a comment. Pass PTU by reference as it can't be NULL, this makes our code safer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433031. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Inte

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld added a comment. In D126672#3546773 , @MaskRay wrote: > This needs a test. There are no tests for any of the other architectures. > Can Debian's riscv GCC be fixed to use a normalized triple for library and > include paths? This is not specif

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

Purva-Chaudhari added a comment. In D123674#3546738 , @v.g.vassilev wrote: > In D123674#3546722 , @uabelho wrote: > >> Hi, >> >> I noticed that the testcase Interpreter/execute.cpp starts failing with this >> pa

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433038. junaire added a comment. - Add prefix for meta commands - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpre

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added a comment. this depends on https://reviews.llvm.org/D126684 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 ___ cfe-commits mailing list cfe-commi

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

herhut accepted this revision. herhut added a comment. This revision is now accepted and ready to land. Separate pass works for me. Comment at: mlir/include/mlir/Dialect/LLVMIR/Transforms/Passes.td:19 +def NVVMOptimize : Pass<"nvvm-optimize"> { + let summary = "Optimize NVVM

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

nikic accepted this revision. nikic added a comment. LGTM Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:5 +// RUN: %clang_cc1 -opaque-pointers -triple x86_64-unknown-linux-gnu -flto=thin -emit-llvm-bc %t/a.c -o %t/a.bc +// RUN: %clang_cc1 -opaque-pointers -triple x86_64

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 433046. balazske added a comment. rebase, fix of failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150 Files: clang/include/clang/StaticAnalyzer/Checkers/C

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 433047. balazske added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

Re: [PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator < revi...@reviews.llvm.org> wrote: > > 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's > decided for `flang-new`. That would already be a huge step forward (and > would reflect accurately what the bash wrapper

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 433049. iains marked 7 inline comments as done. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files: clan

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:645-646 + llvm::raw_svector_ostream Out(FnName); + cast(getCXXABI().getMangleContext()) + .mangleModuleInitializer(M, Out); +} ChuanqiXu wrote: > iains wrote: > > Chua

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 433054. rovka added a comment. Updated test to check for link.exe instead of lld-link.exe. This doesn't look great but it works for both lld-link.exe and the default link.exe. I tried to use --ld-path=various/paths instead, but it seems to be ignored on Window

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: flang/test/Driver/flang-linker-flags-windows.f90:16 +! Linker invocation to generate the executable +! CHECK-LABEL: lld-link.exe +! CHECK-NOT: libcmt Meinersbur wrote: > This is failing for me. Instead of `lld-link.exe`,

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

thakis added a comment. Even after this, you still have to explicitly set `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. Given that the host and target systems are both mac, that's a bit weird. llvm-tblgen doesn't need this, it just works as long as you set `LLVM_USE

[PATCH] D126691: ASTContext: Provide a query for module initializer contents.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When deciding if a global module fragement decl is unused, we have to account for t

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. The basis for removal of GMF decls is that

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126608/new/ https://reviews.llvm.org/D126608 __

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

serge-sans-paille updated this revision to Diff 433063. serge-sans-paille added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Updating test case / sorry for the delay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120484/new/ https://reviews.llvm.org/D120484

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. Thanks for adding this, Diana! :) Overall, makes sense to me. I have a couple of questions/points. In D126291#3547023 , @rovka wrote: > With this patch in place, we still need to add `-Xlinker -subsystem:console' > in order

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few comments that can be addressed when you commit. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:87-89 +

[PATCH] D114834: [clang][PR52088]Fix assertion failure when passing bool as the type of next parameter

Lucas abandoned this revision. Lucas added a comment. Herald added a subscriber: jsji. Herald added a project: All. This issue has already been fixed by https://reviews.llvm.org/D116272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114834/new/ htt

[clang] 858e627 - [Clang] Always set opaque pointers mode

Author: Nikita Popov Date: 2022-05-31T15:43:05+02:00 New Revision: 858e6273d938cc4d08ee053ddff3fe7b19eb302a URL: https://github.com/llvm/llvm-project/commit/858e6273d938cc4d08ee053ddff3fe7b19eb302a DIFF: https://github.com/llvm/llvm-project/commit/858e6273d938cc4d08ee053ddff3fe7b19eb302a.diff

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

erichkeane added a comment. I'm not sure I'm grokking hte difference between the ExtraBitfields and ExtParamInfos here. Also, the 'hasBitfields' seems like the answer should just be 'no' in the case when its 'no'... Comment at: clang/include/clang/AST/Type.h:4103 bool has

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

aaron.ballman added a comment. Thanks for this! I'm still thinking about the design for this, but spotted a few minor things that could be addressed in the meantime. Comment at: clang/include/clang/AST/Type.h:3801-3802 /// FunctionTypeBitfields. Aligned to alignof(void *) t

[PATCH] D119646: [clang] Allow consteval functions in default arguments

erichkeane accepted this revision. erichkeane added a comment. This seems innocuous enough, and seems to better reflect the intent of the standard, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.org/D119646

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 433081. jolanta.jensen added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479 Files: clang/include/clang/Basic/TargetIn

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/test/Sema/attr-mode.c:40 +typedef _Complex float c16a __attribute((mode(HC))); +int c16a_test[sizeof(c16a) == 4 ? 1 : -1]; mgabka wrote: > shouldn't we have here and in the line below : "// expected-no-dia

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

aaron.ballman added a reviewer: tahonermann. aaron.ballman added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:287-288 FloatModeKind ExplicitType) const { + if (getHalfWidth() == BitWidth) +return FloatModeKind::Ha

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis added a comment. In D116638#3545246 , @stasm wrote: > I'm still interested in seeing this fixed. Would it help if I rebased this > change and addressed the outstanding review comments? Go for it! I don't plan to do any further work on this. (I'm

[clang] 35b1cfc - [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp

Author: Daniel McIntosh Date: 2022-05-31T10:33:55-04:00 New Revision: 35b1cfc76f08faabf3f27c0bd054acc7c854a6ca URL: https://github.com/llvm/llvm-project/commit/35b1cfc76f08faabf3f27c0bd054acc7c854a6ca DIFF: https://github.com/llvm/llvm-project/commit/35b1cfc76f08faabf3f27c0bd054acc7c854a6ca.dif

[PATCH] D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b1cfc76f08: [Driver][Modules] Remove dependence on linking support from… (authored by DanielMcIntosh-IBM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:160 +- Made :doc:`cert-oop57-cpp ` more sensitive + by checking for an arbitrary expression in the second argument of `memset`. + Please use double back-ticks for language

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

nikic added a comment. In D126308#3546235 , @mizvekov wrote: > In D126308#3545937 , @Ericson2314 > wrote: > >> There is a lot of cruft behind the signs. I would just use >> `LLVM_TOOLS_INSTALL_DIR` then which is

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall added a comment. In D126397#3547060 , @thakis wrote: > Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's basically > the same situation. Yes, I agree, it should. I'll send a patch. One caveat here: that there are (too) many p

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[clang-tools-extra] ae67984 - [clangd] ExtractVariable support for C and Objective-C

Author: David Goldman Date: 2022-05-31T11:14:51-04:00 New Revision: ae67984ca6d89c7ccdbdca258cd05c151d8b6431 URL: https://github.com/llvm/llvm-project/commit/ae67984ca6d89c7ccdbdca258cd05c151d8b6431 DIFF: https://github.com/llvm/llvm-project/commit/ae67984ca6d89c7ccdbdca258cd05c151d8b6431.diff

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGae67984ca6d8: [clangd] ExtractVariable support for C and Objective-C (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D124486?vs=425914&id=433089#toc Repository: rG LLVM Gith

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3662 + } + ExprResult StringResult = Parser::ParseStringLiteralExpression(); + if (StringResult.isInvalid()) Comment at: clang/lib/Parse/ParsePragma.cpp:3671

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

hans added a reviewer: aaron.ballman. hans added a comment. Looks reasonable to me. It would be good if Richard or Aaron could take a look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126664/new/ https://reviews.llvm.org/D126664 ___

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1207-1213 + FD->addAttr(FramePointerAttr::CreateImplicit(Context, Kind)); +} + +void Sema::AddOptsize(FunctionDecl *FD, SourceLocation Loc) { + FD->dropAttr(); + OptimizeSizeAttr::Kind Kind = Optimize

[PATCH] D126704: [HIP] Pass -Xoffload-linker option to device linker

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Reuse -Xoffload-linker option for HIP toolchain. https://reviews.llvm.org/D126704 Files: clang/lib/Driver/ToolChains/HIPAMD.cp

[clang] 10555a8 - [PS5] Tweak dllexport test

Author: Paul Robinson Date: 2022-05-31T08:22:15-07:00 New Revision: 10555a82df22bf67a9c30165e952b44969b46b6f URL: https://github.com/llvm/llvm-project/commit/10555a82df22bf67a9c30165e952b44969b46b6f DIFF: https://github.com/llvm/llvm-project/commit/10555a82df22bf67a9c30165e952b44969b46b6f.diff

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3547435 , @nikic wrote: > In D126308#3546235 , @mizvekov > wrote: > >> In D126308#3545937 , @Ericson2314 >> wrote: >> >>> There is a

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. I'm fine with removing or renaming the existing flang shell script. My proposal is not to wait for a 100% pass rate. My proposal is to wait until the messages for unimplemented features are converted to TODOs that reference the program's source line and that legal p

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen added a comment. In D126642#3547284 , @erichkeane wrote: > I'm not sure I'm grokking hte difference between the ExtraBitfields and > ExtParamInfos here. The reason I repurposed the bit was because I previously tried adding a bit to `unsigned

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code

martong updated this revision to Diff 433097. martong added a comment. - Add AssumeStack to track recursive assume calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files: clang/include/clang/Static

[clang-tools-extra] c797952 - [clangd] Minor fixes to ExtractVariableTests missed in D124486

Author: David Goldman Date: 2022-05-31T11:34:35-04:00 New Revision: c797952d4f012275b2e23f5ffcab1f39eacd184d URL: https://github.com/llvm/llvm-project/commit/c797952d4f012275b2e23f5ffcab1f39eacd184d DIFF: https://github.com/llvm/llvm-project/commit/c797952d4f012275b2e23f5ffcab1f39eacd184d.diff

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

erichkeane added a comment. In D126642#3547496 , @sdesmalen wrote: > In D126642#3547284 , @erichkeane > wrote: > >> I'm not sure I'm grokking hte difference between the ExtraBitfields and >> ExtParamInfos here.

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[clang] e22b02d - [Clang][Docs] Document the clang-offload-packager better

Author: Joseph Huber Date: 2022-05-31T11:53:27-04:00 New Revision: e22b02d9b4f8bb968628ac7cf2d9a42bf13e2898 URL: https://github.com/llvm/llvm-project/commit/e22b02d9b4f8bb968628ac7cf2d9a42bf13e2898 DIFF: https://github.com/llvm/llvm-project/commit/e22b02d9b4f8bb968628ac7cf2d9a42bf13e2898.diff

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 433104. Herald added a subscriber: jsji. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h c

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3520773 , @rjmccall wrote: > Okay, well, first off, we definitely shouldn't be repeating conditions like > `isX86()` all over the place. What you want to do is to have a general > predicate which answers whether we

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3547060 , @thakis wrote: > Even after this, you still have to explicitly set > `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. > Given that the host and target systems are both mac, that's a

[clang] 259a9df - [Clang][Docs] Fix typo in offload packager reference

Author: Joseph Huber Date: 2022-05-31T12:27:33-04:00 New Revision: 259a9df963ca5f28f325ed6f6bfe5da639c78cbf URL: https://github.com/llvm/llvm-project/commit/259a9df963ca5f28f325ed6f6bfe5da639c78cbf DIFF: https://github.com/llvm/llvm-project/commit/259a9df963ca5f28f325ed6f6bfe5da639c78cbf.diff

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1249 +// Build TargetTriple from target_profile option for clang-dxc. +if (const Arg *A = Args.getLastArg(options::OPT_target_profile)) { + StringRef TargetProfile = A->getValue();

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

steplong added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1207-1213 + FD->addAttr(FramePointerAttr::CreateImplicit(Context, Kind)); +} + +void Sema::AddOptsize(FunctionDecl *FD, SourceLocation Loc) { + FD->dropAttr(); + OptimizeSizeAttr::Kind Kind = OptimizeSizeA

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added a comment. I am sorry, I completely forgot one of my motivations for https://reviews.llvm.org/D117977 was that `LLVM_TOOLS_BINARY_DIR` was completely misnamed and just this sort of foot-gun! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator wrote: > 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's decided > for `flang-new`. That would already be a huge step forward (and > would > reflect accurately what the bash wrappe

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jsji. Thanks again Phoebe for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

abrachet updated this revision to Diff 433120. abrachet marked an inline comment as done. abrachet added a comment. Fix tests on macOS and compile test with `-fsyntax-only` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files: clang/include

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

abrachet updated this revision to Diff 433122. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/test/Driver/crash-report-cr

[clang] 7d76d60 - [Clang] Extend -gen-reproducer flag

Author: Alex Brachet Date: 2022-05-31T17:10:16Z New Revision: 7d76d6095880f34914d85d876b260cc4a4ea640d URL: https://github.com/llvm/llvm-project/commit/7d76d6095880f34914d85d876b260cc4a4ea640d DIFF: https://github.com/llvm/llvm-project/commit/7d76d6095880f34914d85d876b260cc4a4ea640d.diff LOG:

[PATCH] D126681: [HIP] Fix static lib name on windows

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1788 +for (auto Prefix : {"/libdevice/", "/"}) { + if (IsMSVC) { +AOBFileNames.push_back(Twine(LPath + P

[clang] 35a032e - [InstrProf] Stop exporting lprofDirMode

Author: Alex Brachet Date: 2022-05-31T17:13:00Z New Revision: 35a032eaf429abd2b9785b2d989f5a42c89bc6a8 URL: https://github.com/llvm/llvm-project/commit/35a032eaf429abd2b9785b2d989f5a42c89bc6a8 DIFF: https://github.com/llvm/llvm-project/commit/35a032eaf429abd2b9785b2d989f5a42c89bc6a8.diff LOG:

[PATCH] D126548: [InstrProf] Stop exporting lprofDirMode

This revision was automatically updated to reflect the committed changes. Closed by commit rG35a032eaf429: [InstrProf] Stop exporting lprofDirMode (authored by abrachet). Herald added subscribers: Sanitizers, cfe-commits, Enna1. Herald added projects: clang, Sanitizers. Repository: rG LLVM Gith

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

stasm added a comment. In D116638#3547366 , @andmis wrote: > In D116638#3545246 , @stasm wrote: > >> I'm still interested in seeing this fixed. Would it help if I rebased this >> change and addressed the outstand

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

rnk added a comment. I think it's fine to implement this, but I wanted to share some of the motivation for the current state of things. In our experience, the majority of uses of pragma optimize were to work around MSVC compiler bugs. So, instead of honoring them, we felt it was best to ignore

[clang] c4d9698 - [clang][Driver] Fix SIE builders

Author: Alex Brachet Date: 2022-05-31T17:26:18Z New Revision: c4d9698f3c8db47ac7a0bee8bba6b9b8b91f7d58 URL: https://github.com/llvm/llvm-project/commit/c4d9698f3c8db47ac7a0bee8bba6b9b8b91f7d58 DIFF: https://github.com/llvm/llvm-project/commit/c4d9698f3c8db47ac7a0bee8bba6b9b8b91f7d58.diff LOG:

[clang] a0ef52c - Fix windows build

Author: Alex Brachet Date: 2022-05-31T17:31:55Z New Revision: a0ef52cc102504c4282dec7001664ee020396681 URL: https://github.com/llvm/llvm-project/commit/a0ef52cc102504c4282dec7001664ee020396681 DIFF: https://github.com/llvm/llvm-project/commit/a0ef52cc102504c4282dec7001664ee020396681.diff LOG:

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

dyung added a comment. The test you added seems to be failing on the PS4 Windows bot. A quick glance seems to suggest that you aren't properly escaping the path separators somewhere. Can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/bui

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

abrachet added a comment. In D120201#3547834 , @dyung wrote: > The test you added seems to be failing on the PS4 Windows bot. A quick glance > seems to suggest that you aren't properly escaping the path separators > somewhere. Can you take a look and re

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

dyung added a comment. In D120201#3547835 , @abrachet wrote: > In D120201#3547834 , @dyung wrote: > >> The test you added seems to be failing on the PS4 Windows bot. A quick >> glance seems to suggest that you ar

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15746 ExprResult Sema::BuildStmtExpr(SourceLocation LPLoc, Stmt *SubStmt, SourceLocation RPLoc, unsigned TemplateDepth) { assert(SubStmt && isa(SubStmt) && "Invalid action

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433138. sbc100 added a comment. Herald added subscribers: llvm-commits, asb, hiraditya. Herald added a project: LLVM. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D7

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added a comment. Currently waiting on https://github.com/emscripten-core/emscripten/pull/17099 to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 __

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:287-288 FloatModeKind ExplicitType) const { + if (getHalfWidth() == BitWidth) +return FloatModeKind::Half; if (getFloatWidth() == BitWidth) ---

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:60 + Ibm128, + Half }; The existing enumerators were ordered according to precision. Consider moving `Half` to before `Float` if doing so doesn't cause any problems (I would

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

sdesmalen updated this revision to Diff 433140. sdesmalen marked 4 inline comments as done. sdesmalen retitled this revision from "[Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields" to "[Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.". sdesmalen edited the summary

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

sdesmalen added a comment. In D126642#3547526 , @erichkeane wrote: > Right, yeah. One thing to consider: `ExtInfo` was 'first', and so it got to > keep the 'in bitfield bits'. However, much of what is in there is, IMO, not > something that is used oft

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. It looks like MSVC also accepts // foo.c static void foo(); #pragma alloc_text("hello", foo) void foo() {} and // foo.cpp extern "C" { static void foo(); #pragma alloc_text("hello", foo) void foo() {} } Do you know of a way I can check whether a fu

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae updated this revision to Diff 433143. python3kgae added a comment. Add check for no -T option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125585/new/ https://reviews.llvm.org/D125585 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

erichkeane added a comment. In D126642#3547905 , @sdesmalen wrote: > In D126642#3547526 , @erichkeane > wrote: > >> Right, yeah. One thing to consider: `ExtInfo` was 'first', and so it got to >> keep the 'in bi

[clang] 7689c7f - Create specialization of -Wgnu-statement-expression for expressions found in macros.

Author: Michael Wyman Date: 2022-05-31T11:13:08-07:00 New Revision: 7689c7fc9e08cc430daca3714bcffdd00fd538bd URL: https://github.com/llvm/llvm-project/commit/7689c7fc9e08cc430daca3714bcffdd00fd538bd DIFF: https://github.com/llvm/llvm-project/commit/7689c7fc9e08cc430daca3714bcffdd00fd538bd.diff

[PATCH] D126522: Create specialization of `-Wgnu-statement-expression` for expressions found in macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7689c7fc9e08: Create specialization of -Wgnu-statement-expression for expressions found in… (authored by mwyman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think I'm Ok with this as a 1st step for the cleanup. I think we should probably evaluate what amount of work is necessary to extract the ExtInfo out into trailing storage, dependin

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125585/new/ https://reviews.llvm.org/D125585 ___

[PATCH] D126536: [pseudo] Add grammar annotations support.

sammccall added a comment. Nice! This has tests for the parsing-the-attribute bits, but I think we're missing tests for the actual guards added. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:114 +using ReduceGuard = +std::function RHS, +

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

sammccall added a comment. Oh wow, my mental model of these was all wrong. Thank you! Do you want me to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1207-1213 + FD->addAttr(FramePointerAttr::CreateImplicit(Context, Kind)); +} + +void Sema::AddOptsize(FunctionDecl *FD, SourceLocation Loc) { + FD->dropAttr(); + OptimizeSizeAttr::Kind Kind = Optimize

[clang-tools-extra] 9d991da - [pseudo] Respect LLVM_USE_HOST_TOOLS

Author: Sam McCall Date: 2022-05-31T20:47:57+02:00 New Revision: 9d991da60df492a191b34aa3e75484ddd27e8930 URL: https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930 DIFF: https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930.diff LO

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3547494 , @sscalpone wrote: > I'm fine with removing or renaming the existing flang shell script. In D125788#3547656 , @rouson wrote: > On Mon, May 30, 2022 at 2:39 AM An

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a nit. Comment at: clang/include/clang/AST/Type.h:3809-3811 unsigned NumExceptionType; + +FunctionTypeExtraBitfields() : NumExceptionType(0) {} Repository: rG LLV

  1   2   >