[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:362-364 - /// Retrieves and sets the UserMode. This is a high-level option, - /// which is used

[PATCH] D125669: Adding support for target in_reduction

RitanyaB added a comment. Could someone please review the changes? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-com

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. In D127471#3580581 , @akuegel wrote: > It seems this change triggers a warning: > > https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 > > llvm-project/llvm/lib/Transforms/Utils/C

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

akuegel added a comment. It seems this change triggers a warning: https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 llvm-project/llvm/lib/Transforms/Utils/CodeExtractor.cpp:901:15: error: enumeration value 'PresplitCoroutine' not handled in swit

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3577815 , @iains wrote: > In D126694#3576853 , @ChuanqiXu > wrote: > >> In D126694#3576602 , @iains wrote: >> >>> @ChuanqiXu - I cha

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

mstorsjo accepted this revision. mstorsjo added a comment. The changes left in this patch seem fine to me now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 _

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

mstorsjo added a reviewer: mstorsjo. mstorsjo added a comment. LGTM in general, but I'd leave it to the others to formally approve. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1477 if (Args.hasArg(options::OPT_shared_libgcc)) return LibGccType::SharedLibGcc;

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall added a comment. Yeah, I think the appropriate thing is to just treat the entire asm statement like it's a single full-expression. As always, that implies an annoying lifetime for blocks and C compound literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG735e6c40b5e9: [Coroutines] Convert coroutine.presplit to enum attr (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 735e6c4 - [Coroutines] Convert coroutine.presplit to enum attr

Author: Chuanqi Xu Date: 2022-06-14T14:23:46+08:00 New Revision: 735e6c40b5e9a128820f009595de4728e5d6b3d5 URL: https://github.com/llvm/llvm-project/commit/735e6c40b5e9a128820f009595de4728e5d6b3d5 DIFF: https://github.com/llvm/llvm-project/commit/735e6c40b5e9a128820f009595de4728e5d6b3d5.diff LO

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436661. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Aaron's comments - `{}` => `llvm::None` in Lexer.cpp - Fix casing in UnicodeNameToCodepoint.cpp to match the style, and a couple I missed in UnicodeNameMappingGenerator.cpp

[PATCH] D127624: [C++20][Modules] Allow for redeclarations in partitions.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Yeah, it might be painful to compare string all the time. Let's do it when refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder added a comment. That does indeed work, thanks for the suggestion! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D127638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder updated this revision to Diff 436650. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D127638 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/test/SemaCXX/nested-name-spec.cpp Index: clang/test/SemaCXX/nested-name-spec.cpp ===

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e19a592842: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly… (authored by akyrtzi). Repository: rG LLVM Github Mo

[clang] f7e19a5 - [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

Author: Argyrios Kyrtzidis Date: 2022-06-13T21:46:46-07:00 New Revision: f7e19a59284208712314a2d0702b48c445909130 URL: https://github.com/llvm/llvm-project/commit/f7e19a59284208712314a2d0702b48c445909130 DIFF: https://github.com/llvm/llvm-project/commit/f7e19a59284208712314a2d0702b48c445909130.

[clang] 11cf75f - [Driver][test] Make ananas.c and solaris-ld.c robust

Author: Fangrui Song Date: 2022-06-13T19:44:24-07:00 New Revision: 11cf75f602e6717e2a5195b3e8ca161dd9de9945 URL: https://github.com/llvm/llvm-project/commit/11cf75f602e6717e2a5195b3e8ca161dd9de9945 DIFF: https://github.com/llvm/llvm-project/commit/11cf75f602e6717e2a5195b3e8ca161dd9de9945.diff

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. I love the tests (pretty cool examples of what can be handled). Thanks for the thoroughness! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessMo

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

MaskRay added a comment. I pushed 0ba43f4c2b263268f6fbc56bb3f6d43936781957 with an elaborated comment. This patch is not needed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 0ba43f4 - [sanitizer] Add -lresolv only for non-Android non-musl Linux

Author: Fangrui Song Date: 2022-06-13T19:12:13-07:00 New Revision: 0ba43f4c2b263268f6fbc56bb3f6d43936781957 URL: https://github.com/llvm/llvm-project/commit/0ba43f4c2b263268f6fbc56bb3f6d43936781957 DIFF: https://github.com/llvm/llvm-project/commit/0ba43f4c2b263268f6fbc56bb3f6d43936781957.diff

[PATCH] D127707: [Clang] Simplify unifying target features

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, jdoerfert, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch simplifies how we unify target features. Now we simply i

[PATCH] D127706: [Clang] Enable MSVC embedded records for Plan 9

ksaunders created this revision. ksaunders added a reviewer: rsmith. ksaunders added a project: clang. Herald added a project: All. ksaunders requested review of this revision. Herald added a subscriber: cfe-commits. This diff enables MSVC embedded records when Plan 9 extensions are enabled. As w

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 436616. abidmalikwaterloo added a comment. Revised the patcg according to the reviews of the reviewers. clean the code and add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ h

[clang] 3b6e166 - [Driver] Improve linking options for target AVR

Author: Ben Shi Date: 2022-06-14T01:30:49Z New Revision: 3b6e166999bb83197c8b70468c2d371c58cf0c25 URL: https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 DIFF: https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25.diff LOG: [Driv

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Two questions for Clang developers as I work on my next patches: 1. What is the Clang policy for warnings on extension usages? For example, this diff permits redeclaration of typedefs, which is a Plan 9 and Microsoft C extension. Earlier in the file this extension is

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi updated this revision to Diff 436612. akyrtzi added a comment. Add more comments about the use of `SkippingExcludedConditionalBlock` and move the new `Preprocessor` fields towards the top of the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 520d17b - Revert "[Driver] Improve linking options for target AVR"

Author: Ben Shi Date: 2022-06-14T09:12:21+08:00 New Revision: 520d17bfa012e07daf7abda68cf903838b374848 URL: https://github.com/llvm/llvm-project/commit/520d17bfa012e07daf7abda68cf903838b374848 DIFF: https://github.com/llvm/llvm-project/commit/520d17bfa012e07daf7abda68cf903838b374848.diff LOG:

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:661 + +The $map_type_modifier vector specifies the modifier for each map type +operand abidmalikwaterlo

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436611. jhuber6 added a comment. Does this approach work? I'm just using the reverse iterator and only adding the argument if it hasn't been seen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:735 + llvm::StringMap LastOpt; + for (unsigned I = 0, N = Features.size(); I < N; ++I) { +StringRef Name = Features[I]; // Record the index of the last occurence

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436607. jhuber6 added a comment. Adjust how we generate arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/ https://reviews.llvm.org/D127686 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D126192: [Driver] Improve linking options for target AVR

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7599be9e84f: [Driver] Improve linking options for target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://rev

[clang] d7599be - [Driver] Improve linking options for target AVR

Author: Ben Shi Date: 2022-06-13T23:38:59Z New Revision: d7599be9e84fb205b7f50de406dc87858aebc0f4 URL: https://github.com/llvm/llvm-project/commit/d7599be9e84fb205b7f50de406dc87858aebc0f4 DIFF: https://github.com/llvm/llvm-project/commit/d7599be9e84fb205b7f50de406dc87858aebc0f4.diff LOG: [Driv

[PATCH] D126192: [Driver] Improve linking options for target AVR

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. It is fine if you don't add a magic linker script for -fuse-ld=lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 _

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu-new.c:117 + +// CHECK-LTO-FEATURES: clang-offload-packager{{.*}}feature={{.*}}ptx jhuber6 wrote: > tra wrote: > > This should probably be a bit more specific/verbose. E.g. I'd want to mak

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev marked 3 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598 + MergedEnv.makeOr( + MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal1), + Merg

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. a gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

thakis added a comment. Thanks for the successful whack-a-moling :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

steplong updated this revision to Diff 436592. steplong added a comment. - Ignore /Zc:wchar_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/include/clang/Driver/Options.td clang/test/Dr

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev updated this revision to Diff 436590. sgatev added a comment. Rebase main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125931/new/ https://reviews.llvm.org/D125931 Files: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptio

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 added a comment. Thanks for the comments, I'll try to address them. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8320 +TC->getDriver().isUsingLTO(/* IsOffload */ true) +? ",feature=" + llvm::join(FeatureArgs, ",feature=") +: "";

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay updated this revision to Diff 436589. mdfazlay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added erroneous tests, nesting of regions test and analysis tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8320 +TC->getDriver().isUsingLTO(/* IsOffload */ true) +? ",feature=" + llvm::join(FeatureArgs, ",feature=") +: ""; This makes a couple of implicit assump

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. No, I don't think there are any problems. We can probably just pop the cleanups at the end of the asm statement. The original commit message said the asm calls had to be wrapped in `StmtExpr`s because temporaries would get destroyed before the asm calls, but that doesn

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

efriedma added a comment. Why are you messing with test_demangle.pass.cpp? The demangler doesn't care what symbols we actually define in LLVM... it's just a bunch of hardcoded testcases. So it doesn't matter if it continues to refer to GCCBuiltin. Other changes look fine. Repository: rG L

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek added a comment. @mstorsjo let me know if this looks good to you, I tested this locally and it seems to be working fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 ___

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek updated this revision to Diff 436584. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/CMakeLists.txt compiler-rt/cmake/config-ix.cmake

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

efriedma added a comment. A couple notes skimming the changes: 1. If you're going to update URLs, please verify the new URLs are actually valid. 2. Some of the "URLs" you're updating aren't actually URLs. For example, the `xmlns` attribute in SVG files must be the exact string written in the s

[PATCH] D126984: [clang] Add support for optimize function attribute

jdoerfert added a comment. In D126984#3571573 , @aeubanks wrote: > IIRC in the past there was a strong preference to not have the pass manager > support this sort of thing > if you want to support this, there should be an RFC for how the optimization >

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek added inline comments. Comment at: compiler-rt/CMakeLists.txt:512 +# default libunwind (which may be missing still). +append_list_if(CXX_SUPPORTS_UNWINDLIB_NONE_FLAG --unwindlib=none SANITIZER_COMMON_LINK_FLAGS) + mstorsjo wrote: > phosek wrote: >

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek updated this revision to Diff 436575. phosek marked an inline comment as done. Herald added subscribers: cfe-commits, abrachet. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. LGTM: http://45.33.8.238/win/60042/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@

[PATCH] D126984: [clang] Add support for optimize function attribute

xbolva00 added a comment. If you compile file with -Ofast and use optimise(-Os) for F - I would expect no fast math flags for function F but I am worried a bit that only “optsize” is added. Plesse verify and/or add such test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D126984: [clang] Add support for optimize function attribute

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3469 +support the GCC semantics. Optimization levels `-O1` through `-O4` are +ignored. Only "-O0", "-Oz", "-Os", and "-Ofast" are supported. + something about `optimize(-Os)` still

[clang] 2a5d567 - Fix-forward broken ASan test on Windows.

Author: Mitch Phillips Date: 2022-06-13T14:23:23-07:00 New Revision: 2a5d567041565a2c6b8bc8aa7845ad176dbf5d54 URL: https://github.com/llvm/llvm-project/commit/2a5d567041565a2c6b8bc8aa7845ad176dbf5d54 DIFF: https://github.com/llvm/llvm-project/commit/2a5d567041565a2c6b8bc8aa7845ad176dbf5d54.diff

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders updated this revision to Diff 436561. wanders added a subscriber: kimgr. wanders added a comment. Updated diff with: - Release note - Cleaned up command line options in RUN commands - Fixed type mimatch pointed out by @kimgr (out of band) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Couple more minor things, but basically LGTM. Comment at: clang/include/clang/Lex/Preprocessor.h:2601 + /// This is used to guard against calling this function rec

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436557. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/SemaCXX/constant

Re: [clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Please include details of what changed between one commit and a recommit of a patch - helpful for reviewers checking what's changed since the last commit, double-checking that the patch fully addresses the issues, etc. On Sun, Jun 12, 2022 at 2:24 PM Jez Ng via cfe-commits < cfe-commits@lists.llvm

Re: [clang] d941d59 - Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"

Please include details about the reason for a revert in the revert commit message - helpful for folks following along/looking to see if a given revert addresses an issue they're seeing, etc. On Sun, Jun 12, 2022 at 7:47 AM Jez Ng via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Je

Re: [clang] f13019f - [clang] Use any_of and none_of (NFC)

On Sun, Jun 12, 2022 at 10:17 AM Kazu Hirata via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kazu Hirata > Date: 2022-06-12T10:17:12-07:00 > New Revision: f13019f8367a417075e70effb13dcf58024090b2 > > URL: > https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:514 + BeginPtr = PP.CurLexer->getBufferLocation(); + SkipRangePtr = &PP.RecordedSkippedRanges[BeginPtr]; + if (*SkipRangePtr) { akyr

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi updated this revision to Diff 436554. akyrtzi added a comment. Assert that `SkipExcludedConditionalBlock()` is not recursively called. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127379/new/ https://reviews.llvm.org/D127379 Files: clan

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong updated this revision to Diff 436551. steplong added a comment. - Remove -Og, and all non-zero optimization levels - Fix up docs - Modified tests to reflect -Og and non-zero opt level change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:885 bool useObjCFPRetForRealType(FloatModeKind T) const { +assert(T <= FloatModeKind::Last); return RealTypeUsesObjCFPRet & (1 << (int)T); aaron.ballman wrote: > Thi

[PATCH] D127690: [NFC] clang/Parser: remove dead code

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127690 Files: clang/

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

thakis added a comment. Ping – windows bots are still red. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

erichkeane added a comment. In D127593#3579518 , @royjacobson wrote: > I don't think the OpenMP tests are failing because of this PR, they are a bit > flaky sometimes. > > @erichkeane - Since we haven't branched clang15 yet, I think it's Ok not to > ad

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This is a bold direction but I like it a lot. Over to @aaron.ballman for final approval. Comment at: clang/lib/Sema/ParsedAttr.cpp:228 + switch (getParsedKind()) { + case

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. I don't think the OpenMP tests are failing because of this PR, they are a bit flaky sometimes. @erichkeane - Since we haven't branched clang15 yet, I think it's Ok not to add the Ver15 value to the ABI options? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. This is great, thanks for the changes! I added two follow-up inline comments. Another two other small details: Please add documentation about this to LangOptions.h (We try to document there the changes for each ABI version), and please add a release note about this

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM. Added some clang-tidy reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, tra, yaxunl, saiislam. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The target fe

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added 1 blocking reviewer(s): libc++abi. GuillaumeGomez added a comment. I finally took time to fix the failing test. For some reason, I can't seem to push without marking `libcxxabi/test/test_demangle.pass.cpp` as a binary file with `arc diff HEAD~2 --update D127460`. I hope thi

[PATCH] D127685: [clang-format] Never analyze insert/remove braces in the same pass

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turn off `Remo

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 436527. GuillaumeGomez added a comment. Fix libcxxabi mangling test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

philnik added a comment. Could you do this on a per-project basis? More than 1000 files is way to much to sift through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

thakis added a comment. The reland broke fewer tests, but it still broke tests: http://45.33.8.238/win/60026/step_7.txt If you update the patch on here, the presubmit bot should also run windows tests, so you don't have to break main to find out if the patch works. Repository: rG LLVM Githu

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

sunshaoce created this revision. Herald added subscribers: libc-commits, libcxx-commits, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, hsmhsm, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, sdasgup3, asavonic, carlosgalvezp, jeroen.dobbelaere, abrachet, wenzhicui, wrengr, C

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 436525. GuillaumeGomez added a comment. Fix libcxxabi mangling test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 Files: libcxxabi/test/test_demangle.pass.

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added inline comments. Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:49 +std::string s; +s.reserve(64); +auto n = this; cor3ntin wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Any particular reason for 64? > > Sti

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks for the review! Indeed this looks like it implements the defect report dr2171. I didn't realize there was a defect report about this, thanks for bringing it up. I am not sure If this behavior should also change for move constructors, but clang currently cann

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

bnbarham added a comment. The failure here is likely due to the hack in FileManager::getFileRef: // FIXME: This hack ensures that `getDir()` will use the path that was // used to lookup this file, even if we found a file by different path // first. This is required in order to find a module

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added a comment. I really only had one salient question (and a tiny nit), so I think this is almost good to go. Comment at: clang/include/clang/Basic/AttrDocs.td:6501 + +The attribute does not have any effect on the semantics of C++ code, neither +type checking r

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436516. Javier-varez added a comment. - Preseve ABI when clang is invoked with -fclang-abi-compat <= 14. - Add test for defect report in `clang/test/CXX/drs/dr21xx.cpp`. - Refactor ConstArg to remove if condition. Repository: rG LLVM Github Monorepo

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added inline comments. Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:49 +std::string s; +s.reserve(64); +auto n = this; aaron.ballman wrote: > aaron.ballman wrote: > > Any particular reason for 64? > Still wondering why 64 bytes spe

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. Thanks for the heads up. Reverted, and now re-landing. Unfortunately I don't have a Windows machine so I've made my best guesses about fixing (mostly seems to just symbol name mangling / global attributes that change on the windows target). I'll keep an eye on that specif

[clang] 77475ff - Reland "Add sanitizer metadata attributes to clang IR gen."

Author: Mitch Phillips Date: 2022-06-13T12:23:27-07:00 New Revision: 77475ffd22418ca7249f5457dddba15ab7cda0cc URL: https://github.com/llvm/llvm-project/commit/77475ffd22418ca7249f5457dddba15ab7cda0cc DIFF: https://github.com/llvm/llvm-project/commit/77475ffd22418ca7249f5457dddba15ab7cda0cc.diff

[PATCH] D127683: Adds a warning for aligned new in MSVC before C++17

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC requires C++17 to support aligned new and defining the macro __cpp_aligned_new. Clang does not, which could r

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

aaron.ballman added a comment. > Note that the call to isTemplateName() is basically copied from > DiagnoseUnknownTypeName() in SemaDecl.cpp. However, just calling that from > SemaCXXScopeSpec.cpp as well makes the SemaObjCXX/property-dot-error.mm test > fail, because it now outputs > clang/tes

[PATCH] D127485: [analyzer][NFC] Remove unused Analyses enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0539b456b788: [analyzer][NFC] Remove unused Analyses enum (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D127485?vs=435

[clang] 0539b45 - [analyzer][NFC] Remove unused Analyses enum

Author: Balazs Benics Date: 2022-06-13T21:19:55+02:00 New Revision: 0539b456b7889f9958c07a3c85f9e87bb227c355 URL: https://github.com/llvm/llvm-project/commit/0539b456b7889f9958c07a3c85f9e87bb227c355 DIFF: https://github.com/llvm/llvm-project/commit/0539b456b7889f9958c07a3c85f9e87bb227c355.diff

[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:362-364 - /// Retrieves and sets the UserMode. This is a high-level option, - /// which is used to set other low-level options. It is not accessible - /// outside of AnalyzerO

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:978 +assert(!Ty.isNull()); +if (Ty.isConstQualified() && Ty->isArithmeticType()) { // TODO: We could walk the complex types here and see if everything is steak

[clang] 8e1f47b - Revert "Add sanitizer metadata attributes to clang IR gen."

Author: Mitch Phillips Date: 2022-06-13T12:11:13-07:00 New Revision: 8e1f47b596b28fbc88cf32e8f46eb2fecb145fb2 URL: https://github.com/llvm/llvm-project/commit/8e1f47b596b28fbc88cf32e8f46eb2fecb145fb2 DIFF: https://github.com/llvm/llvm-project/commit/8e1f47b596b28fbc88cf32e8f46eb2fecb145fb2.diff

[PATCH] D127614: [clang-format] Handle more cases for RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cb0bc8abf6e: [clang-format] Handle more cases for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7cb0bc8 - [clang-format] Handle more cases for RemoveBracesLLVM

Author: owenca Date: 2022-06-13T12:10:35-07:00 New Revision: 7cb0bc8abf6efd7e25b0091a7306de23c3a0f314 URL: https://github.com/llvm/llvm-project/commit/7cb0bc8abf6efd7e25b0091a7306de23c3a0f314 DIFF: https://github.com/llvm/llvm-project/commit/7cb0bc8abf6efd7e25b0091a7306de23c3a0f314.diff LOG: [

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436506. serge-sans-paille retitled this revision from "Confusable identifiers detection" to "[clang-tidy] Confusable identifiers detection". serge-sans-paille added a comment. Herald added a subscriber: xazax.hun. Address reviews CHANGES SINCE LAS

  1   2   3   >