[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat created this revision. Herald added a subscriber: inglorion. Herald added a project: All. azat requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Right now in case of LTO the section is not emited: $ cat test.c void

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

inclyc added a comment. In D133085#3763198 , @ChuanqiXu wrote: > Do you have commit access? If you have, I remember LLVM encourages to land > such fixes directly without reviewed. (+ @aaron.ballman to make sure) Thanks! I'm just not sure whether these

[clang] 5ee51e8 - [clang] trim trailing space in format tests. NFC

Author: YingChi Long Date: 2022-09-01T13:30:40+08:00 New Revision: 5ee51e8154253088b333c8e82c64d0f00d7d0524 URL: https://github.com/llvm/llvm-project/commit/5ee51e8154253088b333c8e82c64d0f00d7d0524 DIFF: https://github.com/llvm/llvm-project/commit/5ee51e8154253088b333c8e82c64d0f00d7d0524.diff

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ee51e815425: [clang] trim trailing space in format tests. NFC (authored by inclyc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133085/new/

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen added a comment. In D133052#3763041 , @luken-google wrote: > In D133052#3762596 , @ychen wrote: > >> Like mentioned in >>

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

ChuanqiXu added subscribers: aaron.ballman, ChuanqiXu. ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Do you have commit access? If you have, I remember LLVM encourages such fixes landed directly without review. (+ @aaron.ballman to

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457172. Amir added a comment. Successfully invoke the bootstrap/profiling build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { +

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457171. junaire added a comment. Simpify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire created this revision. junaire added a reviewer: aaron.ballman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the declaration of an identifier has block scope, and the identifier has

[PATCH] D133087: [Docs] fix wrong example of warping class definitions

Passw created this revision. Herald added a project: All. Passw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. example of BraceWrapping AfterClass is wrong Repository: rG LLVM Github Monorepo

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

shafik added a comment. Do you have an idea of how common this might be? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133029/new/ https://reviews.llvm.org/D133029 ___ cfe-commits mailing list

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

inclyc created this revision. inclyc added a reviewer: clang-language-wg. Herald added a project: All. inclyc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found in https://reviews.llvm.org/D132568 Repository: rG LLVM Github Monorepo

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

shafik added a comment. I think like @aaron.ballman was saying in another PR you should aim for as complete set of tests as possible even if you have to comment one that can't work yet. For example cases that would involve `MemberExpr` or `UsingShadow` for example as well as the cases you

[PATCH] D133082: WIP: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457159. mizvekov planned changes to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp

[PATCH] D133082: WIP: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov created this revision. Herald added subscribers: libcxx-commits, cfe-commits, arichardson. Herald added projects: clang, libc++, All. Herald added a reviewer: libc++. mizvekov requested review of this revision. Herald added a subscriber: MaskRay. This implements setting the equivalent of

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. In D133052#3762596 , @ychen wrote: > Like mentioned in > https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-implementation-unnecessary-checking-of, > could we not go down the path of

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3bd67eddf65: [clang][Sema] check default argument promotions for printf (authored by inclyc). Changed prior to commit:

[clang] e3bd67e - [clang][Sema] check default argument promotions for printf

Author: YingChi Long Date: 2022-09-01T10:10:10+08:00 New Revision: e3bd67eddf65b20956513e91715b1f997dae2690 URL: https://github.com/llvm/llvm-project/commit/e3bd67eddf65b20956513e91715b1f997dae2690 DIFF: https://github.com/llvm/llvm-project/commit/e3bd67eddf65b20956513e91715b1f997dae2690.diff

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 457153. inclyc added a comment. Update comments according to review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132636: [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation problem

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da0df5e7cac: [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation… (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 2da0df5 - [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation problem

Author: Xiang1 Zhang Date: 2022-09-01T09:37:23+08:00 New Revision: 2da0df5e7cac2d06e0632522a3451e3a2dbd1a37 URL: https://github.com/llvm/llvm-project/commit/2da0df5e7cac2d06e0632522a3451e3a2dbd1a37 DIFF: https://github.com/llvm/llvm-project/commit/2da0df5e7cac2d06e0632522a3451e3a2dbd1a37.diff

[clang] 58a4b4f - [Driver][test] Fix incorrect -arch= -amx-int8

Author: Fangrui Song Date: 2022-08-31T18:13:16-07:00 New Revision: 58a4b4fcebf45eecafab00d006de019d76f828d8 URL: https://github.com/llvm/llvm-project/commit/58a4b4fcebf45eecafab00d006de019d76f828d8 DIFF: https://github.com/llvm/llvm-project/commit/58a4b4fcebf45eecafab00d006de019d76f828d8.diff

[clang] 08d9912 - [Driver] Remove unimplemented Joined -a / --profile-blocks

Author: Fangrui Song Date: 2022-08-31T18:13:16-07:00 New Revision: 08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83 URL: https://github.com/llvm/llvm-project/commit/08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83 DIFF: https://github.com/llvm/llvm-project/commit/08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83.diff

[clang] 23ce683 - [Driver] Remove Joined -Z and err_drv_use_of_Z_option

Author: Fangrui Song Date: 2022-08-31T17:58:04-07:00 New Revision: 23ce683eea358f0cf82ef51692bba6c86ffcf4a8 URL: https://github.com/llvm/llvm-project/commit/23ce683eea358f0cf82ef51692bba6c86ffcf4a8 DIFF: https://github.com/llvm/llvm-project/commit/23ce683eea358f0cf82ef51692bba6c86ffcf4a8.diff

[clang] 98615fd - [Driver] Remove Joined -X

Author: Fangrui Song Date: 2022-08-31T17:30:51-07:00 New Revision: 98615fd376cea15af21e120e0e3ffa5ba68c2b6d URL: https://github.com/llvm/llvm-project/commit/98615fd376cea15af21e120e0e3ffa5ba68c2b6d DIFF: https://github.com/llvm/llvm-project/commit/98615fd376cea15af21e120e0e3ffa5ba68c2b6d.diff

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

alexfh accepted this revision. alexfh added a comment. LGTM. Thanks for driving this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-commits mailing

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D132998#3762578 , @alexander-shaposhnikov wrote: > Regarding the practical side - yeah, I've come across this issue (and others) > while trying

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

aaronpuchert added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + egorzhdan wrote: > gribozavr2 wrote: > > egorzhdan wrote: > > > This test was never properly passing. Because of the bug in string > > >

[PATCH] D133072: WIP: [clang] fix profiling of template arguments of template and declaration kind

mizvekov created this revision. Herald added projects: clang, libc++, All. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. mizvekov requested review of this revision. Template arguments of template and declaration kind were being profiled only by their

[PATCH] D133006: [clang-tidy] Skip copy assignment operators with nonstandard return types

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133006/new/ https://reviews.llvm.org/D133006 ___

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou created this revision. zhouyizhou added reviewers: MikeStump, riccibruno, rsmith. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi I think the comment above the condition expression

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen added a comment. Like mentioned in https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-implementation-unnecessary-checking-of, could we not go down the path of considering conversion candidates? It seems that's blessed by the standard. Repository: rG

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

alexander-shaposhnikov added a comment. Regarding the practical side - yeah, I've come across this issue (and others) while trying to run this check over a few large codebases (including LLVM and Chrome), and this particular issue accounts of a few hundreds of build breakages. Repository:

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

jyknight added a comment. In D129488#3761478 , @ilya-biryukov wrote: > In D129488#3761398 , @jyknight > wrote: > >> I believe this should print `fn=14 fn2=14`. I don't see how we can get that >> by

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457102. Amir added a comment. Succeeded instrumenting Clang with BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert accepted this revision. jdoerfert added a comment. LG, the new remarks need to be addressed in a follow up. Please test for them and make a TODO that they should be optimized away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a reviewer: ilya-biryukov. luken-google added a comment. I'm open to other suggestions if this doesn't seem like the right approach. The problem is the concept evaluation code is fairly separated in the call stack from this Sema code, so it's hard to think of a minimal change

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExternalSemaSourceMembers(ExternalSemaSource *ExtSema)

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 457084. luken-google added a comment. Remove extraneous header inclusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/50891 Repository: rG LLVM Github Monorepo

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { +

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 457081. python3kgae added a comment. Move reuse decl in PCH into BuiltinTypeDeclBuilder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files:

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman updated this revision to Diff 457074. aidengrossman added a comment. Changed error message from "Could not read profile" to "Error in reading profile" to better reflect the fact that profile reading can fail for multiple reasons, not just when the file path cannot be read/does not

[clang] bb9dedc - [Frontend] Restore Preprocessor::getPredefines()

Author: Roy Jacobson Date: 2022-08-31T23:16:49+03:00 New Revision: bb9dedce5d01f5608acd784942481f386c710c0d URL: https://github.com/llvm/llvm-project/commit/bb9dedce5d01f5608acd784942481f386c710c0d DIFF: https://github.com/llvm/llvm-project/commit/bb9dedce5d01f5608acd784942481f386c710c0d.diff

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9dedce5d01: [Frontend] Restore Preprocessor::getPredefines() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

royjacobson updated this revision to Diff 457070. royjacobson edited the summary of this revision. royjacobson added a comment. Add a link to github issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133044/new/ https://reviews.llvm.org/D133044

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG960e7a551326: [msan] Use Debug Info to point to affected fields (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D132909?vs=456541=457069#toc Repository: rG LLVM Github

[clang] 960e7a5 - [msan] Use Debug Info to point to affected fields

Author: Vitaly Buka Date: 2022-08-31T13:12:17-07:00 New Revision: 960e7a5513267b38a07405931300bbf40ddf1902 URL: https://github.com/llvm/llvm-project/commit/960e7a5513267b38a07405931300bbf40ddf1902 DIFF: https://github.com/llvm/llvm-project/commit/960e7a5513267b38a07405931300bbf40ddf1902.diff

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457067. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

thieta accepted this revision. thieta added a comment. LGTM and seems pretty safe so I am not opposed to merge it before 15 final. I would maybe add a link to the GitHub issue in the comment, but that's a nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

brad.king accepted this revision. brad.king added a comment. This revision is now accepted and ready to land. LGTM. After applying this patch locally on top of the release/15.x branch, CastXML builds again. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

royjacobson created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A patch from May removed Preprocessor::getPredefines() from Clang's API,

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

alexfh added a comment. In D132998#3760603 , @alexander-shaposhnikov wrote: > My assumption was that a codebase needs to compile with c++11 in the first > place - otherwise the automatic fixit will break the build (as it happens > right now). > I was

[PATCH] D133043: [clangd] Fix tests for implicit C function declaration

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[clang] 41b1c9f - Re-add the REQUIRES line to fix a failed build on builder llvm-clang-win-x-aarch64.

Author: Ying Yi Date: 2022-08-31T20:22:18+01:00 New Revision: 41b1c9ff70142dc38a381517718cd3f95e8d62b7 URL: https://github.com/llvm/llvm-project/commit/41b1c9ff70142dc38a381517718cd3f95e8d62b7 DIFF: https://github.com/llvm/llvm-project/commit/41b1c9ff70142dc38a381517718cd3f95e8d62b7.diff LOG:

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:297 + } + IdentifierInfo = AST.Idents.get("hlsl", tok::TokenKind::identifier); beanz wrote: > I think the core of what you'e doing here is not far off, but I think this

[clang] cdf3de4 - [CodeGen] fix misnamed "not" operation; NFC

Author: Sanjay Patel Date: 2022-08-31T15:11:48-04:00 New Revision: cdf3de45d282694290011a2949bdcc61cabb47ef URL: https://github.com/llvm/llvm-project/commit/cdf3de45d282694290011a2949bdcc61cabb47ef DIFF: https://github.com/llvm/llvm-project/commit/cdf3de45d282694290011a2949bdcc61cabb47ef.diff

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt updated this revision to Diff 457052. wyt added a comment. Use `u` suffix to declare constants as unsigned in `CFGMatchSwitchTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131616/new/ https://reviews.llvm.org/D131616 Files:

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman added a comment. In D132962#3761463 , @kadircet wrote: > can you also add test cases for the other two (filtering both for speculative > index queries/regular ones, and making sure we don't suggest symbols from > index for category names), so

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457049. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7671 + AllArgs, CallType)) +return true; + yihanaa wrote: > rjmccall wrote: > > You can just pull the argument expressions out of the `CallExpr`; you

[clang] 74c8d9d - Revert "[clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`."

Author: Wei Yi Tee Date: 2022-08-31T18:49:56Z New Revision: 74c8d9d5fc83868977d497c4376296bc27319622 URL: https://github.com/llvm/llvm-project/commit/74c8d9d5fc83868977d497c4376296bc27319622 DIFF: https://github.com/llvm/llvm-project/commit/74c8d9d5fc83868977d497c4376296bc27319622.diff LOG:

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3759731 , @efriedma wrote: > As a practical matter, there isn't any reason to force variably modified > parameters to make a function variably modified. The types of parameters > aren't visible in the caller

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. Thanks for your review John, I'll try to fix these problem later which you point out. Comment at: clang/lib/Sema/SemaChecking.cpp:7659 + << 0 << 2 << TheCall->getNumArgs() << Callee->getSourceRange(); + } + rjmccall wrote:

[clang] 66f3e90 - [Driver][test] Test -dumpmachine

Author: Fangrui Song Date: 2022-08-31T10:31:45-07:00 New Revision: 66f3e90cf8225333273bfaddc1a7f832fe0c263d URL: https://github.com/llvm/llvm-project/commit/66f3e90cf8225333273bfaddc1a7f832fe0c263d DIFF: https://github.com/llvm/llvm-project/commit/66f3e90cf8225333273bfaddc1a7f832fe0c263d.diff

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

xur added a comment. I'm fine with this change. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1301 +unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, +"Could not read profile %0: %1"); +

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

efriedma added inline comments. Comment at: clang/docs/ReleaseNotes.rst:141 +- Implemented `WG14 N2562 `_. + Clang will now consider default argument promotions in printf, and remove unnecessary warnings.

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. Thanks. Just a few small requests to re-use more of the existing logic here. Comment at: clang/lib/Sema/SemaChecking.cpp:7659 + << 0 << 2 << TheCall->getNumArgs() << Callee->getSourceRange(); + } + It looks like this

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9033eeb2e59: [clang][dataflow] Generalise match switch utility to other AST types and add a… (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c9033ee - [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

Author: Wei Yi Tee Date: 2022-08-31T17:02:07Z New Revision: c9033eeb2e59c0157b84adfc6b0fe345f6f03113 URL: https://github.com/llvm/llvm-project/commit/c9033eeb2e59c0157b84adfc6b0fe345f6f03113 DIFF: https://github.com/llvm/llvm-project/commit/c9033eeb2e59c0157b84adfc6b0fe345f6f03113.diff LOG:

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman accepted this revision. aaron.ballman added a comment. Basically LGTM as well, just some nits about comments and a small fix to the c status page. In D132568#3753512 , @inclyc wrote: > Currently this patch has not fully implemented

[clang] 83902c4 - Reapply "[clang][deps] Split translation units into individual -cc1 or other commands"

Author: Ben Langmuir Date: 2022-08-31T09:45:11-07:00 New Revision: 83902c403611af3a52453867cb8848fb3fd6a39c URL: https://github.com/llvm/llvm-project/commit/83902c403611af3a52453867cb8848fb3fd6a39c DIFF: https://github.com/llvm/llvm-project/commit/83902c403611af3a52453867cb8848fb3fd6a39c.diff

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan updated this revision to Diff 456989. egorzhdan added a comment. Rebase to apply fixes to string conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132932/new/ https://reviews.llvm.org/D132932 Files:

[PATCH] D131563: [clang] Fix clang multiarch isssue with musl

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This may not be the right direction. If GCC is not configured with `--enable-multi-arch`, `--print-multiarch` output is an empty line. The `x86_64-linux-gnu` style output is for

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:141 - /// Alignment options. - /// - /// They can also be read as a whole for compatibility. The choices are: + /// Alignment styles of ``AlignConsecutiveStyle`` are: /// - None

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0935238527: [libclang] Fix conversion from `StringRef` to `CXString` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133009/new/

[clang] 8c09352 - [libclang] Fix conversion from `StringRef` to `CXString`

Author: Egor Zhdan Date: 2022-08-31T17:39:45+01:00 New Revision: 8c0935238527622ba0a7e78e8a1ee2d36026961c URL: https://github.com/llvm/llvm-project/commit/8c0935238527622ba0a7e78e8a1ee2d36026961c DIFF: https://github.com/llvm/llvm-project/commit/8c0935238527622ba0a7e78e8a1ee2d36026961c.diff

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. @aaron.ballman should review+accept this before you land it, but I'm satisfied with the result. Thank you @inclyc for working on this! Repository: rG LLVM Github Monorepo

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I am okay with this change, it does give a proper canonical form, which is good. On the other hand, I agree that (on the long term) base regions and offsets would be a better memory model

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

ilya-biryukov added a comment. In D129488#3761398 , @jyknight wrote: > I believe this should print `fn=14 fn2=14`. I don't see how we can get that > by special-casing calls to `std::source_location::current`, and indeed, with > this version of the

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#3640233 , @jdoerfert wrote: > In D129008#3640194 , > @tianshilei1992 wrote: > >> `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. > > Don't

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet added a comment. can you also add test cases for the other two (filtering both for speculative index queries/regular ones, and making sure we don't suggest symbols from index for category names), so that we don't regress in the future? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

wyt updated this revision to Diff 456986. wyt added a comment. Update according to change in preceding patches to replace use of designated initialisers when constructing `AnalysisInputs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132756/new/

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt updated this revision to Diff 456983. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132763/new/ https://reviews.llvm.org/D132763 Files:

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

tahonermann added a comment. > While accepting all these inside of string and character literals in C and > C++20 and older is fine, accepting them inside of identifiers can change > meaning of valid programs. Thank you for reporting this impact, @jakubjelinek! I'll copy you on an email to

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 456982. wyt added a comment. Update according to change in parent patch to replace designated initialisers when constructing `AnalysisInputs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

jyknight added a comment. (please ignore the last comment, I sent it to the wrong review thread) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132944/new/ https://reviews.llvm.org/D132944 ___ cfe-commits mailing list

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

ilya-biryukov added a comment. In D133029#3761400 , @gribozavr2 wrote: > In D133029#3761344 , @ilya-biryukov > wrote: > >> [...] I don't think there is an easy way to write it outside `Sema` and >> `Sema` is

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 456980. wyt added a comment. This is a re-update of a previous update which uploaded the wrong diff. Remove use of designated initializers which are only allowed on C++20. Instead, introduce a constructor that sets required fields, and withFieldName methods

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + gribozavr2 wrote: > egorzhdan wrote: > > This test was never properly passing. Because of the bug in string > > conversion, the printed comments

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

gribozavr2 added a comment. In D133029#3761344 , @ilya-biryukov wrote: > [...] I don't think there is an easy way to write it outside `Sema` and > `Sema` is not readily available for `clang-tidy`. What information is missing, exactly? Repository:

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

jyknight added a comment. #include #include consteval int fn(std::source_location sl = std::source_location::current()) { return sl.line(); } consteval int fn2(int line = fn()) { return line; } int main() { printf("fn=%d fn2=%d\n", fn(), fn2()); } I

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

jyknight added a comment. #include #include consteval int fn(std::source_location sl = std::source_location::current()) { return sl.line(); } consteval int fn2(int line = fn()) { return line; } int main() { printf("fn=%d fn2=%d\n", fn(), fn2()); } I

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

gribozavr2 added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + egorzhdan wrote: > This test was never properly passing. Because of the bug in string > conversion, the printed comments contained the entire

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 456978. wyt added a comment. Herald added subscribers: llvm-commits, mgrang, mgorny. Herald added a project: LLVM. Remove use of designated initializers which are only allowed on C++20. Instead, introduce a constructor that sets required fields, and

[PATCH] D131879: [clang][analyzer] Errno modeling code refactor (NFC).

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131879/new/ https://reviews.llvm.org/D131879 ___

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

ilya-biryukov added a comment. This warning might be a little verbose and pedantic for Clang, but I still wanted to share the code. I would be more comfortable doing this a `clang-tidy` check, but I don't think there is an easy way to write it outside `Sema` and `Sema` is not readily available

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

serge-sans-paille updated this revision to Diff 456971. serge-sans-paille edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132944/new/ https://reviews.llvm.org/D132944 Files: clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGExpr.cpp

  1   2   >