[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

owenpan updated this revision to Diff 469969. owenpan added a comment. This revision is now accepted and ready to land. Fixed assertion failures on the tests in https://github.com/llvm/llvm-project/issues/58161#issuecomment-1287904972. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13643

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

Izaron added a comment. LGTM! I'm sorry that you had to fix CMakeLists.txt. It really "worked on my machine", I was running these commands: cmake --build build --target ClangSupportTests # build and link the binary ./build/tools/clang/unittests/Support/ClangSupportTests # run the binary Re

[clang] e5032d8 - [clang][unittest] Resolve ClangSupportTest link time errors

Author: John McIver Date: 2022-10-23T09:54:39Z New Revision: e5032d89e44a7fa5f2cc06925be28e87e3bdb9f0 URL: https://github.com/llvm/llvm-project/commit/e5032d89e44a7fa5f2cc06925be28e87e3bdb9f0 DIFF: https://github.com/llvm/llvm-project/commit/e5032d89e44a7fa5f2cc06925be28e87e3bdb9f0.diff LOG: [

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5032d89e44a: [clang][unittest] Resolve ClangSupportTest link time errors (authored by jmciver, committed by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder updated this revision to Diff 469971. tbaeder added a comment. Handle integer over- and underflows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h cla

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 created this revision. zero9178 added reviewers: erichkeane, rjmccall, efriedma, asl, aaron.ballman. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A common post condition of the various visit

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

Izaron created this revision. Izaron added reviewers: dyung, aaron.ballman, jloser. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The time profiler in `Expr::isIntegerConstantExpr` used to call `Loc->pr

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 469976. lime added a comment. I updated the patch based on D136468 . I added a change which I think could be a fix to the specialization problem. It is just skipping the addition of the level where the specialization specialize

[PATCH] D136090: Handle errors in expansion of response files

sepavloff updated this revision to Diff 469978. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1029 if (llvm::sys::path::is_relative(CfgFilePath)) { - if (getVFS().makeAbsolute(CfgFilePath)) -return true; - auto Status = getVFS().status(CfgFilePath); - i

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 469982. lime added a comment. Update for the format check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Par

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

pengfei added inline comments. Comment at: clang/test/Driver/x86-target-features.c:313 +// RUN: %clang -target i686-unknown-linux-gnu -mcmpccxadd %s -### -o %t.o 2>&1 | FileCheck -check-prefix=CMPCCXADD %s +// RUN: %clang -target i686-unknown-linux-gnu -mno-cmpccxadd %s -### -

[PATCH] D134137: [clangd] Return earlier when snippet is empty

sammccall added a comment. It's not surprising that we often don't crash here, the "obvious" lowering of `S.front()` is `*S.data()` which is perfectly valid (will be 0 for an empty string). One way to crash on this is to build with libstdc++'s debug iterators, which assert on this. Fedora seem

[PATCH] D134137: [clangd] Return earlier when snippet is empty

tom-anders added a comment. In D134137#3877726 , @sammccall wrote: > It's not surprising that we often don't crash here, the "obvious" lowering of > `S.front()` is `*S.data()` which is perfectly valid (will be 0 for an empty > string). > > One way to cr

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver added a comment. Thanks @Izaron for taking the time to review and commit on my behalf! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136546/new/ https://reviews.llvm.org/D136546 ___ cfe-commits m

[PATCH] D136554: [WIP] Implement CWG2631

cor3ntin created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469987. calebzulawski added a comment. Move SDK detection to its own test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/lib/Driver/ToolChains/

[clang] f92980c - [clang] Fix a warning

Author: Kazu Hirata Date: 2022-10-23T09:34:49-07:00 New Revision: f92980c72660c40a18b72dd3b259dd3c200f109f URL: https://github.com/llvm/llvm-project/commit/f92980c72660c40a18b72dd3b259dd3c200f109f DIFF: https://github.com/llvm/llvm-project/commit/f92980c72660c40a18b72dd3b259dd3c200f109f.diff L

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127462/new/ https://reviews.llvm.org/D127462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ychen added a comment. Looks straightforward to me with one suggestion. Is the CI fail related? Comment at: clang/include/clang/Sema/Sema.h:2569 + enum class TypeAccessKind { Explicit, Implicit, Typename }; + QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

sammccall added a comment. This is a subtle change that needs careful review, and honestly should have a test. I realize there's a breakage that needs to be fixed with some urgency and you believe you're just restoring the old behavior, however in that case the right course of action is to rev

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

sammccall added a comment. > This is a subtle change that needs careful review, and honestly should have a > test. Um, sorry for the grumpy tone. I thought this had already been quickly landed! Apologies... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. LGTM, thanks for picking it up! I wonder how much effect this has on compilation times given that `SubsumptionCache` caches subsumption by the `Decl *` pair... One Q - do you think

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 updated this revision to Diff 470002. zero9178 added a comment. Rebase and boop CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136548/new/ https://reviews.llvm.org/D136548 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/pr53

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3877854 , @ychen wrote: > Looks straightforward to me with one suggestion. > > Is the CI fail related? Yeah, the CI fail is because, while there is a change in libcxx diagnostics and we fix it, the same tests are run

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470004. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov retitled this revision from "[clang] Implement sugar retention for converted template arguments" to "[clang] Changes to produce sugared converted template arguments". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470006. Repository: rG LLVM Githu

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since these are much like template type aliases, where we don't track a specialization for them and just substitute them e

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov retitled this revision from "[clang] Instiantiate early substituted entities with sugared template arguments" to "[clang] Implement sugared substitution changes to infrastructure". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470008. Herald added a

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

philnik added a comment. Would it be possible to just add `#if TEST_CLANG_VER >= 1600` around the new warnings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 ___

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470009. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3877974 , @philnik wrote: > Would it be possible to just add `#if TEST_CLANG_VER >= 1600` around the new > warnings? That works for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes use of the changes introduced in D134604 , in order to instantiate non-type

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470011. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, LLDB, clang-tools-extra. Herald added subscribers: cfe-commits, lldb-commits. This makes use of th

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we don't unique specializations for concepts, we can just instantiate them with the sugared template arguments, at n

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

alexfh added a comment. In D136539#3877872 , @sammccall wrote: > This is a subtle change that needs careful review, and honestly should have a > test. > > I realize there's a breakage that needs to be fixed with some urgency and you > believe you're jus

[clang] e861610 - Revert "[TokenLexer][NFC] Rename the InstLoc to ExpandLoc"

Author: Alexander Kornienko Date: 2022-10-23T23:14:40+02:00 New Revision: e86161076e4a0633d7ab845037fe9443363a5a29 URL: https://github.com/llvm/llvm-project/commit/e86161076e4a0633d7ab845037fe9443363a5a29 DIFF: https://github.com/llvm/llvm-project/commit/e86161076e4a0633d7ab845037fe9443363a5a29

[clang] e7656da - Revert "[Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation."

Author: Alexander Kornienko Date: 2022-10-23T23:14:40+02:00 New Revision: e7656daea8724ba1bed6eb7a4dc96498ce7d06c5 URL: https://github.com/llvm/llvm-project/commit/e7656daea8724ba1bed6eb7a4dc96498ce7d06c5 DIFF: https://github.com/llvm/llvm-project/commit/e7656daea8724ba1bed6eb7a4dc96498ce7d06c5

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

alexfh added a comment. FYI, I've reverted f83347b0bedb22ea676861c8e4e2ed9c31371ade and 74e4f778cf16cbf7163b5c6de6027a43f5e9169f . Repository: rG LLVM G

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Undo LGTM, since we decided to go with a revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D1

[clang] a6f621b - [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

Author: Petr Hosek Date: 2022-10-23T21:36:45Z New Revision: a6f621b8cacca926d809010c135be038fd05652c URL: https://github.com/llvm/llvm-project/commit/a6f621b8cacca926d809010c135be038fd05652c DIFF: https://github.com/llvm/llvm-project/commit/a6f621b8cacca926d809010c135be038fd05652c.diff LOG: [C

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6f621b8cacc: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D135471?vs=469706&id=470014#toc Repository: rG LLVM G

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

phosek added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:265-267 +COMPILER_RT_VISIBILITY +void *__llvm_profile_keep[] = {(void *)&dummy_cnts, (void *)&dummy_data, + (void *)&dummy_name, (void *)&dummy_vnds}; ---

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 470015. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

phosek added a comment. I wasn't included as a reviewer on D124857 and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in `InstrProfilingPlatformLinux.c`. AIX is neither Linux nor ELF-based and big chunks of that

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5196-5206 + std::function FormatBadBranches = + [&](std::string Prefix, unsigned Lines) { +const std::string Directives[] = {"", "#if X\n", "#els

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 470016. sstwcw added a comment. - Merge - use ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Fo

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

jloser accepted this revision. jloser added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix. I did leave an open question or two though, but it is non-blocking. Comment at: clang/lib/AST/ExprConstant.cpp:15908 - llvm::TimeTraceScope Tim

[PATCH] D136567: [clangd] Avoid hanging in Selection when PP corrects the token sequence.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Cla

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

dyung accepted this revision. dyung added a comment. I'm not really familiar with this code, so I'll leave others to review the actual change, but I can confirm that when I built a compiler with this change and ran it against the failing tests they all now pass. So in that regard, LGTM. Reposi

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron created this revision. Izaron added reviewers: jcranmer-intel, aaron.ballman, cor3ntin, efriedma. Herald added a subscriber: hiraditya. Herald added a project: All. Izaron requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron added a comment. This patch is similar to `__bultin_fmax`: https://reviews.llvm.org/D134369 The constexpr version of ilogb matches the libc realization, this is verified with the same tests: https://github.com/llvm/llvm-project/blob/main/libc/test/src/math/ILogbTest.h test_special_numb

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

Izaron marked 2 inline comments as done. Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15908 - llvm::TimeTraceScope TimeScope("isIntegerConstantExpr", [&] { -return Loc->printToString(Ctx.getSourceManager()); - }); + ExprTimeTraceScope TimeScop

[clang] 2bb50a5 - [clang] Fix time profile in "isIntegerConstantExpr"

Author: Evgeny Shulgin Date: 2022-10-23T23:17:56Z New Revision: 2bb50a55b0f5a88bd432ad2691060d82748b5bc0 URL: https://github.com/llvm/llvm-project/commit/2bb50a55b0f5a88bd432ad2691060d82748b5bc0 DIFF: https://github.com/llvm/llvm-project/commit/2bb50a55b0f5a88bd432ad2691060d82748b5bc0.diff LOG

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb50a55b0f5: [clang] Fix time profile in "isIntegerConstantExpr" (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136549/new/ https://re

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

jloser added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15908 - llvm::TimeTraceScope TimeScope("isIntegerConstantExpr", [&] { -return Loc->printToString(Ctx.getSourceManager()); - }); + ExprTimeTraceScope TimeScope(this, Ctx, "isIntegerConstantExpr");

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling updated this revision to Diff 470028. tangyouling added a comment. Modify commit information and add missing `s9`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 Files: clang/lib/Basic/Targ

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3873938 , @xen0n wrote: > Commit message is unclear. You added non-prefixed aliases for all registers, > yet only `$a0` is mentioned. I'd like to see what improvement you could come > up with before amending it my

[PATCH] D136570: [RISCV] Add Svnapot extension

BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D134267#3876071 , @dblaikie wrote: > I'm getting a bit exhausted with all the words involved here & not sure how > to simplify/clarify this. > > If @ben.boeckel has particular use cases, it

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3035 + "cmp${cond}xadd\t{$src3, $dst, $dstsrc1|$dstsrc1, $dst, $src3}", + [(set GR64:$dst, (X86cmpccxadd addr:$dstsrc1, GR64:$dstsrc2, GR64:$src3, timm:$cond))]>, + VEX_4V, VEX

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: clang/lib/Headers/cmpccxaddintrin.h:19-34 + _CMPCCX_O, /* Overflow. */ + _CMPCCX_NO, /* No overflow. */ + _CMPCCX_B, /* Below. */ + _CMPCCX_NB, /* Not below. */ + _CMPCCX_Z, /* Zero. */ + _CMPCCX_NZ, /* Not zero. */ +

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. Suspended due to the dependent patches suspended. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134269/new/ https://reviews.llvm.org/D134269 ___ cfe-commits mailing list c

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/lib/Headers/cmpccxaddintrin.h:19-34 + _CMPCCX_O, /* Overflow. */ + _CMPCCX_NO, /* No overflow. */ + _CMPCCX_B, /* Below. */ + _CMPCCX_NB, /* Not below. */ + _CMPCCX_Z, /* Zero. */ + _CMPCCX_NZ, /* Not zero.

[PATCH] D136571: [RISCV] add svinval extension

BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n

[PATCH] D136570: [RISCV] Add Svnapot extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:394 + "'Svnapot' (NAPOT Translation Contiguity)">; +def HasStdExtSvnapot : Predicate<"Subtarget->hasStdExtSvnapot()">, + AssemblerPredicate<(all_of Fea

[PATCH] D136570: [RISCV] Add Svnapot extension

BeMg updated this revision to Diff 470039. BeMg added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Support/RISCVISA

[PATCH] D136571: [RISCV] add svinval extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:814 def SFENCE_VMA : Priv_rr<"sfence.vma", 0b0001001>, Sched<[]>; +let Predicates = [HasStdExtSvinval] in { def SINVAL_VMA : Priv_rr<"sinval.vma", 0b0001011>, Sched<[]>; C

[PATCH] D136570: [RISCV] Add Svnapot extension

BeMg updated this revision to Diff 470040. BeMg added a comment. Remove Predicate and AssemblerPredicate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570 Files: clang/test/Preprocessor/riscv-target-featu

[PATCH] D136571: [RISCV] add svinval extension

BeMg updated this revision to Diff 470041. BeMg added a comment. Use Requires<[HasStdSvinval]> instead of using let Predicates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preproces

[PATCH] D136570: [RISCV] Add Svnapot extension

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570

[PATCH] D136571: [RISCV] add svinval extension

jrtc27 added a comment. Hm, we only have two uses of Requires currently, both of which aren't really for any good reason as far as I can see. It'd be better to keep things uniform with Predicates IMO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D136571: [RISCV] add svinval extension

BeMg updated this revision to Diff 470046. BeMg added a comment. Reorder the def then use the same let Predicates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-tar

[PATCH] D136574: [clang] Copy cmake_policy() to silence CMake warnings in standalone builds

mgorny created this revision. mgorny added reviewers: nickdesaulniers, kastiglione, compnerd, MaskRay, thesamesam, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. https://reviews.llvm.org/D136574 Files: clang/CMakeLists.tx

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/cmpccxaddintrin.h:19-34 + _CMPCCX_O, /* Overflow. */ + _CMPCCX_NO, /* No overflow. */ + _CMPCCX_B, /* Below. */ + _CMPCCX_NB, /* Not below. */ + _CMPCCX_Z, /* Zero. */ + _CMPCCX_NZ, /* Not zero. */

[clang] 6cee539 - [Clang] Change AnonStructIds in MangleContext to per-function based

Author: Rong Xu Date: 2022-10-23T22:33:52-07:00 New Revision: 6cee5393371fdde798605c88bad0ebceb3626257 URL: https://github.com/llvm/llvm-project/commit/6cee5393371fdde798605c88bad0ebceb3626257 DIFF: https://github.com/llvm/llvm-project/commit/6cee5393371fdde798605c88bad0ebceb3626257.diff LOG:

[PATCH] D136397: [Clang] Change AnonStructIds in MangleContext to per-function based

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xur marked an inline comment as done. Closed by commit rG6cee5393371f: [Clang] Change AnonStructIds in MangleContext to per-function based (authored by xur). Herald add

[PATCH] D136575: [Headers] remove define of _GNU_SOURCE when including Darwin's unwind.h

mhjacobson created this revision. mhjacobson added a reviewer: chandlerc. Herald added a project: All. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Darwin's unwind.h has never surrounded declarations with _GNU_SOURCE guards. T

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

ArcsinX added a comment. It seems for x86_32 case (e.g. with -m32 in command line) there is a difference between clang and GCC: clang: `__FLT_EVAL_METHOD__` == 0 GCC: `__FLT_EVAL_METHOD__` == 2 Example: https://godbolt.org/z/EbY8rPYGn I am not sure, is it a correct behavior from clang? CHANGE

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

skan added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") Move it after AVXVNNI

[PATCH] D136070: [LIT] Add AArch64/Windows to LP64 feature

This revision was automatically updated to reflect the committed changes. Closed by commit rGedb68a453350: [LIT] Add AArch64/Windows to LP64 feature (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136070/new/ https://reviews.ll

[clang] edb68a4 - [LIT] Add AArch64/Windows to LP64 feature

Author: Muhammad Omair Javaid Date: 2022-10-24T11:40:52+05:00 New Revision: edb68a45335013c3857844620caa7104a51fa5f4 URL: https://github.com/llvm/llvm-project/commit/edb68a45335013c3857844620caa7104a51fa5f4 DIFF: https://github.com/llvm/llvm-project/commit/edb68a45335013c3857844620caa7104a51fa5

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal marked 2 inline comments as done. steakhal added a comment. In D136162#3874953 , @martong wrote: > Thanks for the update. Nice Work! Thanks! I'll land this tomorrow. Comment at: clang/test/Analysis/region-store.c:66 + // exp