skan added inline comments.
================ Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") ---------------- Move it after AVXVNNI to keep the dictionary order? ================ Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8127-8131 +multiclass avx_dotprod_rm<bits<8> opc, string OpcodeStr, ValueType OpVT, + RegisterClass RC, PatFrag MemOpFrag, + X86MemOperand x86memop, SDNode OpNode, + X86FoldableSchedWrite sched, + bit IsCommutable> { ---------------- Could you unify the name converntion? e.g Captialize the first character for all parameters for this multiclass. ================ Comment at: llvm/test/CodeGen/X86/stack-folding-int-avxvnniint8.ll:4-5 + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-unknown" + ---------------- Could we remove these two lines? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits