[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Support to query separate file for P1689

ChuanqiXu created this revision. ChuanqiXu added reviewers: Bigcheese, jansvoboda11, dblaikie, iains, ben.boeckel. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This functionality is required by

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

JonChesterfield added a comment. I don't recognize atomicrmw udec_wrap and can't find it in https://llvm.org/docs/LangRef.html#atomicrmw-instruction. I do vaguely recall the semantics of these builtins (well, the instructions they target) being surprising, Do you know where the uinc_wrao etc

[clang] 05a113e - [clang][Interp][NFC] Handle discarded ArraySubscriptExprs

Author: Timm Bäder Date: 2022-11-07T08:37:43+01:00 New Revision: 05a113e18852ab54f22516e9ec1b6aa39adc5b33 URL: https://github.com/llvm/llvm-project/commit/05a113e18852ab54f22516e9ec1b6aa39adc5b33 DIFF: https://github.com/llvm/llvm-project/commit/05a113e18852ab54f22516e9ec1b6aa39adc5b33.diff

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70de684d4413: [clang-format] Handle object instansiation in if-statements (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES

[clang] 70de684 - [clang-format] Handle object instansiation in if-statements

Author: Tobias Hieta Date: 2022-11-07T08:34:57+01:00 New Revision: 70de684d44135b4025d92b2b36ad387cf5ab8b5a URL: https://github.com/llvm/llvm-project/commit/70de684d44135b4025d92b2b36ad387cf5ab8b5a DIFF: https://github.com/llvm/llvm-project/commit/70de684d44135b4025d92b2b36ad387cf5ab8b5a.diff

[clang] 9a3b969 - [clang][Interp][NFC] Make InitField() not pop the pointer

Author: Timm Bäder Date: 2022-11-07T08:30:43+01:00 New Revision: 9a3b969d1faa77d4c629ddb797d317579fbe0555 URL: https://github.com/llvm/llvm-project/commit/9a3b969d1faa77d4c629ddb797d317579fbe0555 DIFF: https://github.com/llvm/llvm-project/commit/9a3b969d1faa77d4c629ddb797d317579fbe0555.diff

[clang] 7c0a2d9 - [clang][Interp][NFC] Use StorePop for assignments with DiscardResult

Author: Timm Bäder Date: 2022-11-07T07:56:25+01:00 New Revision: 7c0a2d9cda996a04c9eb55244a0ebf57545de849 URL: https://github.com/llvm/llvm-project/commit/7c0a2d9cda996a04c9eb55244a0ebf57545de849 DIFF: https://github.com/llvm/llvm-project/commit/7c0a2d9cda996a04c9eb55244a0ebf57545de849.diff

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10483ac743e6: [clang][Interp] Support pointer arithmethic in binary operators (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[clang] 10483ac - [clang][Interp] Support pointer arithmethic in binary operators

Author: Timm Bäder Date: 2022-11-07T07:47:19+01:00 New Revision: 10483ac743e69a6de684593565f586116b506b2e URL: https://github.com/llvm/llvm-project/commit/10483ac743e69a6de684593565f586116b506b2e DIFF: https://github.com/llvm/llvm-project/commit/10483ac743e69a6de684593565f586116b506b2e.diff

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin updated this revision to Diff 473564. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137316/new/ https://reviews.llvm.org/D137316 Files:

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:54 +def int_loongarch_crc_w_d_w : Intrinsic<[llvm_i32_ty], +[llvm_i64_ty, llvm_i32_ty], []>; } // TargetPrefix = "loongarch"

[clang] d4f884c - [clang][Interp] Add a test case for #58754

Author: Timm Bäder Date: 2022-11-07T07:25:37+01:00 New Revision: d4f884c550bec6b195eefb454636adc71449c041 URL: https://github.com/llvm/llvm-project/commit/d4f884c550bec6b195eefb454636adc71449c041 DIFF: https://github.com/llvm/llvm-project/commit/d4f884c550bec6b195eefb454636adc71449c041.diff

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473561. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files:

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:39 + +def int_loongarch_dbar : Intrinsic<[], [llvm_i32_ty], []>; } // TargetPrefix = "loongarch" SixWeining wrote: > Seems this arg is unnecessary because the defalut

[clang] 27f5f33 - [clang][Interp][NFC] Remove an unused include

Author: Timm Bäder Date: 2022-11-07T06:34:22+01:00 New Revision: 27f5f33c81d9e253dd5caa31898baf9738a8b068 URL: https://github.com/llvm/llvm-project/commit/27f5f33c81d9e253dd5caa31898baf9738a8b068 DIFF: https://github.com/llvm/llvm-project/commit/27f5f33c81d9e253dd5caa31898baf9738a8b068.diff

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

arsenm added a comment. I think this is fine, but think the name needs to be bikeshedded. "Target" and "Support" are already overloaded enough as it is. Is there anything else that would really ever go into this library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm created this revision. arsenm added reviewers: yaxunl, AMDGPU. Herald added subscribers: kosarev, Anastasia, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This makes the scope and ordering

[clang] 9418634 - [clang] Use llvm::reverse (NFC)

Author: Kazu Hirata Date: 2022-11-06T21:09:20-08:00 New Revision: 94186347a10b4bd945edaa21cfc025685e9490d7 URL: https://github.com/llvm/llvm-project/commit/94186347a10b4bd945edaa21cfc025685e9490d7 DIFF: https://github.com/llvm/llvm-project/commit/94186347a10b4bd945edaa21cfc025685e9490d7.diff

[clang-tools-extra] a5f368a - [clang-tidy] Use structured bindings (NFC)

Author: Kazu Hirata Date: 2022-11-06T20:48:55-08:00 New Revision: a5f368af6d9e469ad2a7f83ce5957776746fa0ca URL: https://github.com/llvm/llvm-project/commit/a5f368af6d9e469ad2a7f83ce5957776746fa0ca DIFF: https://github.com/llvm/llvm-project/commit/a5f368af6d9e469ad2a7f83ce5957776746fa0ca.diff

[PATCH] D137491: [clang][NFC] Use c++17 style variable type traits

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137491/new/ https://reviews.llvm.org/D137491

[clang] 2a67cc7 - [Sema] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-11-06T20:04:53-08:00 New Revision: 2a67cc77e2c5227e81f758d22a5287af9ffe URL: https://github.com/llvm/llvm-project/commit/2a67cc77e2c5227e81f758d22a5287af9ffe DIFF: https://github.com/llvm/llvm-project/commit/2a67cc77e2c5227e81f758d22a5287af9ffe.diff

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:39 + +def int_loongarch_dbar : Intrinsic<[], [llvm_i32_ty], []>; } // TargetPrefix = "loongarch" Seems this arg is unnecessary because the defalut value is `[]`.

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

SixWeining added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:54 +def int_loongarch_crc_w_d_w : Intrinsic<[llvm_i32_ty], +[llvm_i64_ty, llvm_i32_ty], []>; } // TargetPrefix = "loongarch"

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 473545. fpetrogalli added a comment. I have made the dependency on `RISCVTargetSupportTableGen` explicit in the `RISCVCodeGen` target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I am going to block this since the uses of the macros in `clang/lib/Headers/ppc_wrappers` will likely cause build bot failures. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

nemanjai added a comment. As mentioned by @q66 above, this can't go in until usage of this macro in the Clang/LLVM codebase is fixed. Looks like the uses in `clang/lib/Headers/ppc_wrappers` and some of the uses in `libcxx` and `libunwind` must be fixed while others should probably also be

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining added a comment. Sorry for the late reply. Should we choose not to implement the `-mfpu=` option which is not mandatory? Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:31 + options::OPT_msingle_float, +

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

MaskRay updated this revision to Diff 473543. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: steven.zhang. update releasenote Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137511/new/

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/CMakeLists.txt:18 tablegen(LLVM RISCVGenSubtargetInfo.inc -gen-subtarget) +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def) Should not this only be in the CMakeLists for the

[PATCH] D137521: [AVR][Clang] Implement __AVR_ARCH__ macro

aykevl created this revision. aykevl added reviewers: dylanmckay, benshi001. Herald added a subscriber: Jim. Herald added a project: All. aykevl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This macro is defined in avr-gcc, and is very

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

MaskRay added subscribers: Bdragon28, jhibbits, dim. MaskRay added a comment. In D137511#3911052 , @thesamesam wrote: > This needs to go in Breaking Changes in the release notes, not least so we > can link to it when updating upstreams. > > What do you

[PATCH] D137520: [AVR][Clang] Move family names into MCU list

aykevl created this revision. aykevl added reviewers: dylanmckay, benshi001. Herald added a subscriber: Jim. Herald added a project: All. aykevl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This simplifies the code by avoiding some

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c50bcb44170: [RISCV] Support -mcpu/mtune=native (authored by pcwang-thead). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136930/new/

[clang] 7c50bcb - [RISCV] Support -mcpu/mtune=native

Author: wangpc Date: 2022-11-07T10:43:32+08:00 New Revision: 7c50bcb441707f862cd7fcd07d81fbcdc29e98dc URL: https://github.com/llvm/llvm-project/commit/7c50bcb441707f862cd7fcd07d81fbcdc29e98dc DIFF: https://github.com/llvm/llvm-project/commit/7c50bcb441707f862cd7fcd07d81fbcdc29e98dc.diff LOG:

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

thesamesam added a comment. This needs to go in Breaking Changes in the release notes, not least so we can link to it when updating upstreams. What do you mean by "while the darwin support has been removed from llvm-project."? I don't think that's the case, if you mean that LLVM.org's LLVM

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

pcwang-thead added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136930/new/ https://reviews.llvm.org/D136930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. Thanks! I think it's a great improvement! Comment at: llvm/lib/Target/RISCV/RISCV.td:509 -def : ProcessorModel<"generic-rv32", NoSchedModel, [Feature32Bit]>; -def : ProcessorModel<"generic-rv64", NoSchedModel, [Feature64Bit]>; +class

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. This is helpful. I feel it is OK to add the warning in the clang too. Are you interested in that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. RFC at RFC at https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli added a comment. RFC at https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137516/new/ https://reviews.llvm.org/D137516

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Thanks @MaskRay and @wenlei for the reviewing. New version for using dummy file has been updated. Comment at: clang/test/Driver/pgo-sample-use-profi.c:2 +/// Test if profi flat is enabled in frontend as user-facing feature. +// RUN: %clang -c

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 473533. HaoyuZhang added a comment. Use a dummy file instead of cross-directory test file reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/D136846 Files:

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 473529. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Herald added a subscriber: mstorsjo. In D137381#3907799 , @lebedev.ri wrote: > In D137381#3907104

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

sstwcw added a comment. Here is one problem: clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1, IndentWidth: 4, IndentCaseLabels: true}' actual: #define X \ switch (x) {

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 473532. fpetrogalli added a comment. I updated the text of the header of the file `RISCVTargetDefEmitter.cpp`. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/

[clang] 34f687c - [test] Canonicalize PowerPC detection macros to __powerpc__

Author: Fangrui Song Date: 2022-11-06T17:38:57-08:00 New Revision: 34f687cbe468e8044e8d94c977a2e47cbd3f3799 URL: https://github.com/llvm/llvm-project/commit/34f687cbe468e8044e8d94c977a2e47cbd3f3799 DIFF: https://github.com/llvm/llvm-project/commit/34f687cbe468e8044e8d94c977a2e47cbd3f3799.diff

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 473528. francii added a comment. Including test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli created this revision. Herald added subscribers: kosarev, sunshaoce, VincentWu, foad, vkmr, frasercrmck, evandro, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli created this revision. Herald added subscribers: kosarev, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar,

[PATCH] D137515: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli abandoned this revision. fpetrogalli added a comment. Abandoning because I accidentally squashed the two commits together when using Arcanist. I'll follow up with two new revisions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137515: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli created this revision. Herald added subscribers: kosarev, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar,

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

dotnwat created this revision. Herald added subscribers: carlosgalvezp, ChuanqiXu, kbarton, xazax.hun, nemanjai. Herald added a project: All. dotnwat requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Signed-off-by: Noah Watkins

[PATCH] D137512: [clang] Add Swift support for MIPS

colemancda created this revision. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. colemancda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for compiling Swift targeting the

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

ecatmur added a comment. In D134231#3803380 , @shafik wrote: > Hello Ed, thank you for picking up this work. > > I liked the approach in the first PR, did you consider reaching out to the > author is asking if it was ok to commandeer the work to allow

[clang] 7aa90b2 - [PowerPC] Replace __ppc64__ with __powerpc64__

Author: Fangrui Song Date: 2022-11-06T16:16:50-08:00 New Revision: 7aa90b21b453d1ca52fdfccfd7e01e61d9e5b1f1 URL: https://github.com/llvm/llvm-project/commit/7aa90b21b453d1ca52fdfccfd7e01e61d9e5b1f1 DIFF: https://github.com/llvm/llvm-project/commit/7aa90b21b453d1ca52fdfccfd7e01e61d9e5b1f1.diff

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

q66 added a comment. The `__ppc__` macro should get the same treatment. That said, I believe there are instances of both macros being used across the LLVM codebase, and those cases are valid, so that should also be updated (one instance i know of is the limits header of libcxx, there are

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

MaskRay created this revision. MaskRay added reviewers: q66, thesamesam. Herald added subscribers: StephenFan, shchenz, kbarton, nemanjai. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC only

[PATCH] D137510: [clang] Add SwiftABIInfo support for PPC32

colemancda updated this revision to Diff 473517. colemancda added a comment. Updated clang changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137510/new/ https://reviews.llvm.org/D137510 Files: clang/lib/Basic/Targets/PPC.h

[PATCH] D137510: [clang] Add SwiftABIInfo support for PPC32

colemancda created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. colemancda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang] Add Swift CC support to PPC Repository: rG LLVM

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb84fd822fa7e: Add boundary check for ASTUnresolvedSet::erase (authored by zhouyizhou, committed by MaskRay). Changed prior to commit:

[clang] b84fd82 - Add boundary check for ASTUnresolvedSet::erase

Author: Zhouyi Zhou Date: 2022-11-06T15:07:42-08:00 New Revision: b84fd822fa7eeaec2bb084a26caa9e41f3495923 URL: https://github.com/llvm/llvm-project/commit/b84fd822fa7eeaec2bb084a26caa9e41f3495923 DIFF: https://github.com/llvm/llvm-project/commit/b84fd822fa7eeaec2bb084a26caa9e41f3495923.diff

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 473509. zhouyizhou added a comment. Thank Ray for your guidance! I achieved a lot in the process ;-) Thanks Zhouyi CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3910799 , @owenpan wrote: > IMO we should find a simpler way to indent bodies of macro definitions that > are nested more than one level deep. I prefer we handle that in another patch > and only support the

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. IMO we should find a simpler way to indent bodies of macro definitions that are nested more than one level deep. I prefer we handle that in another patch and only support the examples in the summary for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135658: demangle OptFunction trace names

Trass3r added a comment. @thakis ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/new/ https://reviews.llvm.org/D135658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. So I finally had time to apply your feedback. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:141 + assert(BlockElement.DeclRefBlock); + auto Block = BlockElement.DeclRefBlock->succs(); + // No

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473508. Febbe marked 19 inline comments as done. Febbe added a comment. Applied feedback - replaced some auto types with the actual type - added `IncludeStyle` to the options list in the documentation - Added "Limitations" paragraph, describing known

[PATCH] D137486: [clang-format] Correctly annotate function names before attributes

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:76 +static bool isCppAttribute(bool IsCpp, const FormatToken ) { + if (!IsCpp ||

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

MaskRay accepted this revision. MaskRay added a comment. Thanks! Comment at: clang/include/clang/AST/ASTUnresolvedSet.h:73 + void erase(unsigned I) { +if (I == (Decls.size() - 1)) + Decls.pop_back(); `if (I == Decls.size() - 1)`

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5a2ef80fa47: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry, committed by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] f5a2ef8 - [clangd] Fix the code action `RemoveUsingNamespace`

Author: v1nh1shungry Date: 2022-11-06T18:31:20+01:00 New Revision: f5a2ef80fa47d657877d5be314ce29ff7195d887 URL: https://github.com/llvm/llvm-project/commit/f5a2ef80fa47d657877d5be314ce29ff7195d887 DIFF: https://github.com/llvm/llvm-project/commit/f5a2ef80fa47d657877d5be314ce29ff7195d887.diff

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

Arfrever added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:25 + + file(GLOB cpp_files "${output_dir}/${filename}*.cpp") + thakis wrote: > Can we list them? We try not to use globs in cmakelists.txt files. This

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

Arfrever added a comment. After reading this discussion, I need some clarification. If there were the followining symlinks pointing to `clang`: `i386-pc-linux-gnu-clang`, `i486-pc-linux-gnu-clang`, `i586-pc-linux-gnu-clang`, `i686-pc-linux-gnu-clang`, `x86_64-pc-linux-gnu-clang`. Then do I

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1033 +!isDeclarationStatement(/*DisambiguatingWithExpression=*/true)) + SingleDecl = ParseTopLevelStmtDecl(); + There is a remaining challenge which probably could be

[PATCH] D137329: [flang] Add -f[no-]associative-math and -mreassociate

awarzynski added a comment. In D137329#3910249 , @kiranchandramohan wrote: > In D137329#3909943 , @awarzynski > wrote: > >> In D137329#3909082 , @clementval >> wrote:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473496. v.g.vassilev added a comment. Remove several fixmes. Now we can deal with templates, deduction guides and operators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 473495. zhouyizhou added a comment. add a test case thank you ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files: clang/include/clang/AST/ASTUnresolvedSet.h

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 473494. carlosgalvezp added a comment. Simplify code for printing the type of the declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files:

[PATCH] D137474: [clang-format] Defer formatting of operator< to honor paren spacing

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:15476 + verifyFormat("bool operator< ();", Space); + verifyFormat("bool operator> ();", Space);

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. In D137494#3910598 , @tom-anders wrote: > Thanks for the fix, LGTM! Do you want me to commit this for you? Yes! Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. Thanks for the fix, LGTM! Do you want me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3910566 , @owenpan wrote: > In D137181#3910404 , @goldstein.w.n > wrote: > >> Doesn't that add an arbitrary +1 to the begining of the indentation? >> Shouldn't it be: >>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473489. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); +

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473485. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments. Call `isCurrentClassName` before calling `isConstructorDeclarator`. CHANGES SINCE LAST ACTION

[PATCH] D137486: [clang-format] Correctly annotate function names before attributes

owenpan added a comment. In D137486#3909970 , @rymiel wrote: > Are both isCpp11AttributeSpecifier and isCppAttribute required? Not really, but I've kept `isCpp11AttributeSpecifier` for now as it might become handy if it needs to be called at other

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3910404 , @goldstein.w.n wrote: > Doesn't that add an arbitrary +1 to the begining of the indentation? > Shouldn't it be: > > // IndentPPDirectives: AfterHash > #ifdef foo > # define bar() \\ > if (A) {