[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

XiaodongLoong created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. XiaodongLoong requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The CACOP instruction is mainly used for cache

[clang] 3b186db - [clang][C++20] Add test for crash in NestedRequirement.

Author: Utkarsh Saxena Date: 2022-12-22T06:52:44+01:00 New Revision: 3b186db5a97c8392bdbb0446e84353497870551e URL: https://github.com/llvm/llvm-project/commit/3b186db5a97c8392bdbb0446e84353497870551e DIFF:

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled "

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5370255ff18a: [RISCV] Merge Masked and unMasked RVV manual codegen (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5370255 - [RISCV] Merge Masked and unMasked RVV manual codegen

Author: Piyou Chen Date: 2022-12-21T20:28:12-08:00 New Revision: 5370255ff18ac101a73685b77615148142ee7552 URL: https://github.com/llvm/llvm-project/commit/5370255ff18ac101a73685b77615148142ee7552 DIFF: https://github.com/llvm/llvm-project/commit/5370255ff18ac101a73685b77615148142ee7552.diff

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +

[clang] 8c0aa53 - Fix out-of-bound access in TransformNestedRequirement.

Author: Utkarsh Saxena Date: 2022-12-22T05:20:31+01:00 New Revision: 8c0aa53b07caa604d58a0d83dc571d8fcb004972 URL: https://github.com/llvm/llvm-project/commit/8c0aa53b07caa604d58a0d83dc571d8fcb004972 DIFF:

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added a comment. In D137517#4012298 , @pcwang-thead wrote: > In D137517#4009175 , @fpetrogalli > wrote: > >> @pcwang-thead, I addressed some of your comments. >> >> The value of `EnumFeatures` is

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. In D137517#4009175 , @fpetrogalli wrote: > @pcwang-thead, I addressed some of your comments. > > The value of `EnumFeatures` is now computed dynamicaly from the > `Features` field of the `Processor` class. Thanks! That

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

MaskRay added a comment. In D127812#4011437 , @hctim wrote: > LDFLAGS="$LDFLAGS -Wl,--rpath=/tmp/2/lib" # < use the instrumented libcxx > from step 2 I think -Wl,-rpath and -isystem are somewhat different.

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012276 , @ilinpv wrote: > I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error > locally, thank you @hctim for help! > If I understand it right, it seems **MSan didn't handle correctly >

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

rtrieu added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled "

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error locally, thank you @hctim for help! If I understand it right, it seems **MSan didn't handle correctly SmallVector** - a variable-sized array with some number of elements in-place and heap

[PATCH] D137415: [clang][Interp] Implement switch statements

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:405 + const Expr *Cond = S->getCond(); + PrimType CondT = this->classifyPrim(Cond->getType()); + The condition could be a class type w/ a conversion operator, this does not

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/lib/AST/Interp/Interp.cpp:1 //===--- Interpcpp - Interpreter for the constexpr VM --*- C++ -*-===// // One more time :-) CHANGES SINCE LAST ACTION

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 484727. Amir added a comment. Convert perf profile using perf2bolt (aggregate-only mode) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. @Bigcheese @jansvoboda11 gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/ https://reviews.llvm.org/D140433

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4011437 , @hctim wrote: > 2. Build a sanitizer libcxx. > > $ cd /tmp/2 > $ cmake \ > -DCMAKE_C_COMPILER=/tmp/1/bin/clang \ > -DCMAKE_CXX_COMPILER=/tmp/1/bin/clang++ \ > -GNinja \ >

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 484699. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reference 3a604fdbcd5f in commit message as well Repository: rG LLVM Github

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers created this revision. Herald added a reviewer: NoQ. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that we support outputs from asm goto along indirect edges, we can

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 484694. paulkirth retitled this revision from "[codegen] Display stack layouts in console" to "[codegen] Add a remarks based Stack Layout Analysis pass". paulkirth edited the summary of this revision. paulkirth added a comment. Herald added subscribers:

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. clang would improperly disallow GNU attributes before C++ standard attributes

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

arsenm closed this revision. arsenm added a comment. 437346abe18ec4fc982ae36f6821487dafc1a06e Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x

[clang] 437346a - clang: Add __builtin_elementwise canonicalize and copysign

Author: Matt Arsenault Date: 2022-12-21T18:01:42-05:00 New Revision: 437346abe18ec4fc982ae36f6821487dafc1a06e URL: https://github.com/llvm/llvm-project/commit/437346abe18ec4fc982ae36f6821487dafc1a06e DIFF:

[PATCH] D140506: [clang][dataflow] Simplify handling of nullopt-optionals.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, in the case of an optional

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGb494f67f6796: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing (authored by

[clang-tools-extra] b494f67 - [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

Author: Sam McCall Date: 2022-12-21T23:35:48+01:00 New Revision: b494f67f67968c50289148fb423a108607be83e9 URL: https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9 DIFF: https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9.diff

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is). Generally

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Ready for review: 1. https://reviews.llvm.org/D135997 2. https://reviews.llvm.org/D140166 3. https://reviews.llvm.org/D139861 4. https://reviews.llvm.org/D139872 5. https://reviews.llvm.org/D139883 6. https://reviews.llvm.org/D139970 7.

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:86 +auto Task = [ +// Captured by value +

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:112 + const auto *Var = selectFirst("global", Results); + ASSERT_TRUE(Fun !=

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484678. nickdesaulniers added a comment. - add clang release notes from D138078 and new one for new feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, the analysis modeled global

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 484672. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index:

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484671. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, drop callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484665. zahiraam marked an inline comment as done. Herald added a subscriber: aheejin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto : Map) { +const auto = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) barannikov88 wrote: > fpetrogalli wrote: > >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484664. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Remove all `auto` types in the emitter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. In D137517#4009328 , @jrtc27 wrote: > Hm, this means that llvm/lib/Target/$TARGET/$TARGET.td needs to remain > working (or at least mostly working, things like ISel patterns can fail to > type check) in order for Clang to

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto : Map) { +const auto = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) fpetrogalli wrote: > barannikov88 wrote: > >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484658. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Remove `RISCVTargetParser.def` from the module map. Follow the guidelines on using namespace llvm

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. It seems gcc assumes the argument to nan is nonnull (https://godbolt.org/z/xzb8T6Gon), so we can assume that too. CHANGES SINCE LAST ACTION

[PATCH] D137070: [clang][Interp] Support destructors

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 ___ cfe-commits mailing list

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:918 return false; + if (!Ptr.isRoot()) +Ptr.initialize(); tbaeder wrote: > shafik wrote: > > Can you explain what is going on here? Why do we need to initialize if it > > is not

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484655. fpetrogalli added a comment. Restore the following... -const auto *Record = Def.second; +const auto = Def.second; ... to prevent this error: /<...>/llvm-project/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:38:17: error:

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484654. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. ops - this was wrong: /Users/fpetrogalli/projects/cpu-defs/upstream/llvm-project/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:38:17: error: variable 'Record' with

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto : Map) { +const auto = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC"))

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/TargetParser/CMakeLists.txt:29 +# LLVMTargetParser. See https://stackoverflow.com/a/25681179 +target_include_directories(LLVMTargetParser PUBLIC $)

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:16 +#include +namespace llvm { + fpetrogalli wrote: > barannikov88 wrote: > > This [[ > >

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added a comment. files under clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem not used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4011372 , @ilinpv wrote: > Regular builds works fine for me, pthreads located here > "/lib/x86_64-linux-gnu/libpthread.so" > "/usr/lib/x86_64-linux-gnu/libpthread.so". Enabling > "-DLLVM_USE_SANITIZER=Memory" resulted

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:15 +#include "llvm/TableGen/Record.h" +#include +namespace llvm { barannikov88 wrote: > [[ > https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484649. fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. I submitted some of the cleanup suggested by @barannikov88 - thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

njames93 added a comment. In D138655#4007822 , @carlosgalvezp wrote: > Now that I think a bit better about this I wonder - does it really make sense > that we increase the complexity of the check to cover for cases where code > does not compile? If it

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4010993 , @hctim wrote: > Hmm, not exactly sure what's going on with the `could NOT find Threads` > there. A quick googling seems to point to pthreads.so not being in the right > places, but I don't think the buildbot

[PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is).

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { zahiraam wrote: > efriedma wrote: > > zahiraam wrote: > > > Do you agree this

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484637. jhuber6 added a comment. Print to `stderr` and only return `1` if thre was an actual error. A lack of devices is considered a success and we print nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 484633. bob80905 added a comment. Herald added subscribers: pcwang-thead, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D140489: Add builtin_elementwise_log

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add codegen for llvm log elementwise

[clang] 6c3a290 - Headers: further refine the `stdatomic.h` MSVC inclusion

Author: Saleem Abdulrasool Date: 2022-12-21T19:09:10Z New Revision: 6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80 URL: https://github.com/llvm/llvm-project/commit/6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80 DIFF: https://github.com/llvm/llvm-project/commit/6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80.diff

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc847e22db33e: [AArch64] Guard {vmull_p64, vmull_high_p64} with aes target guard. (authored by mingmingl). Repository: rG LLVM Github Monorepo

[clang] c847e22 - [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

Author: Mingming Liu Date: 2022-12-21T11:02:27-08:00 New Revision: c847e22db33e4625b1ad58b631f57d7d1e1944ca URL: https://github.com/llvm/llvm-project/commit/c847e22db33e4625b1ad58b631f57d7d1e1944ca DIFF: https://github.com/llvm/llvm-project/commit/c847e22db33e4625b1ad58b631f57d7d1e1944ca.diff

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

arsenm added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:37 +return 1; + printf("CUDA error: %s\n", ErrStr); + return 1; stderr? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG475cc44a2cba: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to… (authored by shafik). Herald added a project: clang.

[clang] 475cc44 - [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

Author: Shafik Yaghmour Date: 2022-12-21T10:50:05-08:00 New Revision: 475cc44a2cba45c5449a323c6b331ddc593bd8de URL: https://github.com/llvm/llvm-project/commit/475cc44a2cba45c5449a323c6b331ddc593bd8de DIFF:

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:1688 for (const auto *Field : record->fields()) -assert(Field->isUnnamedBitfield() && "Only unnamed bitfields allowed"); +assert((Field->isUnnamedBitfield() ||

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik updated this revision to Diff 484613. shafik added a comment. - Add Release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139261/new/ https://reviews.llvm.org/D139261 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D139701: [Clang] Emit "min-legal-vector-width" attribute for X86 only

arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:2235-2241 -``"min-legal-vector-width"=""`` -This attribute indicates the minimum legal vector width required by the -calling convension. It is the maximum width of vector arguments and -returnings in the

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl added a comment. In D140432#4010143 , @dmgreen wrote: > Thanks for putting together the patch. It may be worth mentioning in the > commit message that aes currently includes both FEAT_AES and FEAT_PMULL. > Otherwise LGTM. Thanks for reviews!

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl updated this revision to Diff 484608. mingmingl added a comment. update commit message to mention target guard 'aes' includes both FEAT_AES and FEAT_PMULL currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140432/new/

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4010856 , @ilinpv wrote: > It would be great to have more details how to setup up your bot, using > buildbot_fast.sh on x86_64 Ubuntu 22.04 LTS leads to error ( pthreads > installed ): > > CMake Error at >

[PATCH] D137838: [Support] Move TargetParsers to new component

dblaikie added a comment. This has introduced a circular dependency due to the forwarding header (forwarding header depends on new lib, new lib depends on support, where the forwarding header is). Generally this wouldn't be acceptable (& I'd suggest the patch be reverted on that basis) though

[clang] d4959b5 - [Driver] Fix tests not to fail randomly on Windows

Author: Paul Robinson Date: 2022-12-21T09:37:12-08:00 New Revision: d4959b5a4bb888789f99a952a1304ce915dfee2f URL: https://github.com/llvm/llvm-project/commit/d4959b5a4bb888789f99a952a1304ce915dfee2f DIFF: https://github.com/llvm/llvm-project/commit/d4959b5a4bb888789f99a952a1304ce915dfee2f.diff

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal updated this revision to Diff 484600. steakhal added a comment. - Add two test cases demonstrating the false-positives this patch will introduce. These are semantically equivalent to the one mentioned in the comments by @NoQ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal added a comment. Finally, I had some time to come back to this. Thanks for taking the time for such a detailed response, kudos! @NoQ In D139534#3999455 , @NoQ wrote: > Ok screw it, my static example is still broken. There's technically still a

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry abandoned this revision. v1nh1shungry added a comment. Abandon because of the terrible implementation. - The cost seems to be higher than the value. - The place to insert isn't good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 5 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:124 +// CHECK-LABEL: omp_DistributeOp +func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref,

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484594. jhuber6 added a comment. Change header I copied from the AMD implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/ https://reviews.llvm.org/D140433 Files:

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77a91bb7ba7: [clang] Remove overly restrictive aggregate paren init logic (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140327/new/

[clang] c77a91b - [clang] Remove overly restrictive aggregate paren init logic

Author: Alan Zhao Date: 2022-12-21T08:21:05-08:00 New Revision: c77a91bb7ba793ec3a6a5da3743ed55056291658 URL: https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658 DIFF: https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658.diff

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140327/new/ https://reviews.llvm.org/D140327

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4009577 , @hctim wrote: > In D127812#4009447 , @hctim wrote: > >> Hi, this looks like a candidate for breaking the MSan bot: >>

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/lib/TargetParser/CMakeLists.txt:29 +# LLVMTargetParser. See https://stackoverflow.com/a/25681179 +target_include_directories(LLVMTargetParser PUBLIC $) Will it work if RISC-V target is not compiled-in? This

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:63 + +printf("sm_%d%d\n", Major, Minor); + } tianshilei1992 wrote: > Do we want to include device number here? For `amdgpu-arch` and here we just have it implicitly in the

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tianshilei1992 added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:63 + +printf("sm_%d%d\n", Major, Minor); + } Do we want to include device number here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added a comment. @thakis and https://github.com/llvm/llvm-project/issues/59640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits mailing

[PATCH] D140483: Remove empty header file.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140483 Files:

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. In D140467#4010675 , @pengfei wrote: > As I have explained, users are not suggested to use these builtins given we > have provided the more stable, well documented corresponding intrinsics. The > only case user has to use it is

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked 3 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

thakis added a comment. (and https://bugs.chromium.org/p/chromium/issues/detail?id=1402885#c3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits

  1   2   >