[clang] 57c8191 - [Clang] Convert update_cc_test_checks tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T09:07:15+01:00 New Revision: 57c81917d3a596f925f1c072ad04425b66bbd80e URL: https://github.com/llvm/llvm-project/commit/57c81917d3a596f925f1c072ad04425b66bbd80e DIFF: https://github.com/llvm/llvm-project/commit/57c81917d3a596f925f1c072ad04425b66bbd80e.diff

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev added a comment. This seems like a good candidate for a post commit review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139798/new/ https://reviews.llvm.org/D139798 ___ cfe-commits mailing list cfe-commi

[clang] 159073b - [clang-repl] Support compound statement as a top-level statement.

Author: Vassil Vassilev Date: 2023-02-17T09:09:04Z New Revision: 159073bc0a873b9aa2bc559a8ceba970b049cda2 URL: https://github.com/llvm/llvm-project/commit/159073bc0a873b9aa2bc559a8ceba970b049cda2 DIFF: https://github.com/llvm/llvm-project/commit/159073bc0a873b9aa2bc559a8ceba970b049cda2.diff LO

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG159073bc0a87: [clang-repl] Support compound statement as a top-level statement. (authored by v.g.vassilev). Herald added a

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske added a comment. The plan is to bring the checker out of the alpha package, the bug reports should be good enough for that. To modify bug report text generation a new patch would be better, after the current is finished. Maybe all single numbers in all allowed ranges that are 1, 2 (or

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/redundant-string-cstr.cpp:1 -// RUN: %check_clang_tidy %s readability-redundant-string-cstr %t - -typedef unsigned __INT16_TYPE__ char16; -typedef unsigned __INT32_TYPE__ char

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM thanks! Let's give a couple more days for last reviews. It probably needs a rebase since the Release Notes have got a couple more checks. Repository: rG LLVM Github Monor

[clang] afcf70a - [analyzer] Remove unjustified assert from EquivalenceClass::simplify

Author: Balazs Benics Date: 2023-02-17T11:37:02+01:00 New Revision: afcf70aa6de77a0e99f6cb2d3e3824049203d6e2 URL: https://github.com/llvm/llvm-project/commit/afcf70aa6de77a0e99f6cb2d3e3824049203d6e2 DIFF: https://github.com/llvm/llvm-project/commit/afcf70aa6de77a0e99f6cb2d3e3824049203d6e2.diff

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

This revision was automatically updated to reflect the committed changes. Closed by commit rGafcf70aa6de7: [analyzer] Remove unjustified assert from EquivalenceClass::simplify (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D138037?vs=475480&id=498301#toc Repository:

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. I'm backporting this as #60834 to the 16.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138037/new/ https://reviews.llvm.org/D138037 __

[clang] f3fa108 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T11:56:00+01:00 New Revision: f3fa1086c7f83edcc473724a8ac7d675a9df11d7 URL: https://github.com/llvm/llvm-project/commit/f3fa1086c7f83edcc473724a8ac7d675a9df11d7 DIFF: https://github.com/llvm/llvm-project/commit/f3fa1086c7f83edcc473724a8ac7d675a9df11d7.diff

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. In D138037#4129160 , @xazax.hun wrote: > I am ok with committing this to unblock people hitting this assert, but at > the same time I wonder if we want to open a ticket on GitHub that we might > want to rethink how some of this

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 498308. kadircet marked 6 inline comments as done. kadircet added a comment. - Move patch translation logic to a separate class - Perform eager copies and use `bool translateX(X&)` type of APIs instead of returning optionals. - Perform multi line content che

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:625 +// same spelling. +static std::vector patchDiags(llvm::ArrayRef BaselineDiags, +const ScannedPreamble &BaselineScan, sammccall wrote: > I th

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG thanks! Comment at: clang-tools-extra/clangd/Preamble.cpp:496 +auto CurrentStartIt = CurrentContentsToLine.find(OldLines[OldStart]); +if (CurrentStartIt == C

[clang] 4901245 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2023-02-17T07:57:31-05:00 New Revision: 4901245481b6588056638b8fc38598615039314a URL: https://github.com/llvm/llvm-project/commit/4901245481b6588056638b8fc38598615039314a DIFF: https://github.com/llvm/llvm-project/commit/4901245481b6588056638b8fc38598615039314a.diff

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:3 +// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target aarch64 +// RUN: %check_clang_tidy -std=c++17-or-later %s cert-d

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:5-6 + +// On arm and arch64 architectures, va_list is within the std namespace. +// D136886 exposed an issue in the cert-dcl58-cpp checker where +// implicit namespaces wer

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4627 } else { -Type *newType = - new (*this, TypeAlignment) InjectedClassNameType(Decl, TST); +Type *newType = new (*this, TypeAlignment) InjectedClassNameType(Decl, TST); Decl->TypeF

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added a subscriber: vabridgers. whisperity added a comment. @vabridgers Please take a look at this, as per off-list discussion, in relation to D142822 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1405

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers planned changes to this revision. vabridgers added a comment. Changes are planned. Please do not waste any more time on this for now. This will probably be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142822/new/ https://rev

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. I run this check on project that I work for, here my comments: False-positives (for me) std::optional&& obj + std::move(opj.value()); std::pair&& obj+ std::forward>(obj); Type1&& factory + factory.create() [on initialization list] (create is not && method) Type

[clang] 06621ec - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T15:08:50+01:00 New Revision: 06621ecdaf416d87968dcaf57a634c83cf0dc1b8 URL: https://github.com/llvm/llvm-project/commit/06621ecdaf416d87968dcaf57a634c83cf0dc1b8 DIFF: https://github.com/llvm/llvm-project/commit/06621ecdaf416d87968dcaf57a634c83cf0dc1b8.diff

[clang] 4bf6cc6 - GH60642: Fix ICE when checking a lambda defined in a concept definition

Author: Erich Keane Date: 2023-02-17T06:09:52-08:00 New Revision: 4bf6cc63aa77a7fea7e410f7d45899abcde2b58a URL: https://github.com/llvm/llvm-project/commit/4bf6cc63aa77a7fea7e410f7d45899abcde2b58a DIFF: https://github.com/llvm/llvm-project/commit/4bf6cc63aa77a7fea7e410f7d45899abcde2b58a.diff L

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane abandoned this revision. erichkeane added a comment. Looks like I have ot abandon this now? Anyway, fix was committed, but I forgot the differential-revision line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144192/new/ https://reviews.llvm.org/D144192 __

[clang] af6c0b6 - [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

Author: Vladislav Dzhidzhoev Date: 2023-02-17T15:11:42+01:00 New Revision: af6c0b6d8c9dc52485d56e82f79a03de09aa188f URL: https://github.com/llvm/llvm-project/commit/af6c0b6d8c9dc52485d56e82f79a03de09aa188f DIFF: https://github.com/llvm/llvm-project/commit/af6c0b6d8c9dc52485d56e82f79a03de09aa188

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6c0b6d8c9d: [clang][CodeGen] Use base subobject type layout for potentially-overlapping… (authored by dzhidzhoev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134887 , @erichkeane wrote: > Looks like I have ot abandon this now? Anyway, fix was committed, but I > forgot the differential-revision line. You can also Close the revision instead of abandoning it to make it obv

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added a comment. In D144192#4134893 , @philnik wrote: > In D144192#4134887 , @erichkeane > wrote: > >> Looks like I have ot abandon this now? Anyway, fix was committed, but I >> forgot the differenti

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134894 , @erichkeane wrote: > In D144192#4134893 , @philnik wrote: > >> In D144192#4134887 , @erichkeane >> wrote: >> >>> Looks like

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added a comment. In D144192#4134900 , @philnik wrote: > In D144192#4134894 , @erichkeane > wrote: > >> In D144192#4134893 , @philnik >> wrote: >> >>> In D1441

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang. He

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: sscalpone. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez, ellis. krisb added projects: LLVM, debug-info. krisb publishe

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134902 , @erichkeane wrote: > In D144192#4134900 , @philnik wrote: > >> In D144192#4134894 , @erichkeane >> wrote: >> >>> In D144192

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang. He

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 498351. kadircet marked 4 inline comments as done. kadircet added a comment. - Use direct comparison of ArrayRefs - optional for closest - loop over lookup results rather than through iterator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added a comment. thanks for the review! Comment at: clang-tools-extra/clangd/Preamble.cpp:509 + // Check if AlternateLine matches all lines in the range. + if (llvm::any_of( + llvm::zip_equal(RangeContents, sammccall wrote: > why

[clang] 17a90f1 - Tighten up a modules test

Author: Paul Robinson Date: 2023-02-17T06:35:01-08:00 New Revision: 17a90f1196c1a4b48b8d02c055497565ce5c785d URL: https://github.com/llvm/llvm-project/commit/17a90f1196c1a4b48b8d02c055497565ce5c785d DIFF: https://github.com/llvm/llvm-project/commit/17a90f1196c1a4b48b8d02c055497565ce5c785d.diff

[PATCH] D144188: Tighten up a modules test

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a90f1196c1: Tighten up a modules test (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/ ht

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb abandoned this revision. krisb added a comment. Abandon in favor of https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp created this revision. dkrupp added a reviewer: Szelethus. dkrupp added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, JDevlieghere, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a revi

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2836 + Tok = Tok->getNextNonComment(); + } else if (Tok->is(tok::hashhash)) { +// Concatenation. Skip. MyDeveloperDay wrot

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

sstwcw updated this revision to Diff 498376. sstwcw marked 3 inline comments as done. sstwcw added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143825/new/ https://reviews.llvm.org/D143825 Files: clang/lib/Format/FormatTo

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj updated this revision to Diff 498378. pkubaj added a comment. Addres adalava's review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 Files: clang/lib/Basic/Targets/PPC.h llvm/lib/Target/Power

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They have already been handled before, but we can

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. In D144216#4133671 , @Eugene.Zelenko wrote: > May be you could use heard in other test in same patch? I'm not quite sure what you mean by "heard". Searching for "heard" in the LLVM code and Googling "llvm heard" reveal nothin

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for adding the tests, as I don't know Verilog then I can't really comment on the correctness, as you are mostly in your own scoped verilog functions, I'm fine with yo

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b51c8cd2ac6: [clang-tidy] Clarify bugprone-branch-clone diagnostic message (authored by donat.nagy, committed by Donát Nagy ). Repository: rG LLVM Github Monorepo CHANGES SI

[clang-tools-extra] 2b51c8c - [clang-tidy] Clarify bugprone-branch-clone diagnostic message

Author: Donát Nagy Date: 2023-02-17T17:05:19+01:00 New Revision: 2b51c8cd2ac6b9a6a5b713700c8299954980242d URL: https://github.com/llvm/llvm-project/commit/2b51c8cd2ac6b9a6a5b713700c8299954980242d DIFF: https://github.com/llvm/llvm-project/commit/2b51c8cd2ac6b9a6a5b713700c8299954980242d.diff LO

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added a comment. @elmcdonough , let me rephrase this (should've been clearer before, sorry): > One thing that's not clear to me - how come "-Wextra" is not treated as an > error and "-Wblah" is? Where's the logic that makes sure that `-Wextra` (and other flags that you redefine here

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. I have created the new patch D144273 that should fix the same AST import problems as this patch, without change of `Sema`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142822/new/ https

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske updated this revision to Diff 498392. balazske added a comment. removed a not needed line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144273/new/ https://reviews.llvm.org/D144273 Files: clang/lib/AST/ASTImporterLookupTable.cpp clang

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Some of the examples you mentioned are indeed not compliant with guideline F.18. I have a test for at least one of the examples you gave (`moves_deref_optional` matches your first example). The guideline is fairly strict IMO, and I asked about this in https://github.co

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe marked an inline comment as done. mikecrowe added a comment. > If you're suggesting that I could use the new header to replace > declarations of basic_string etc. in other tests then I think that would be > possible with some careful checking to make sure it include the necessary > f

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 498401. VitaNuo marked 14 inline comments as done. VitaNuo added a comment. Herald added a subscriber: ChuanqiXu. Address review comments. Make diagnostics symref-centered and attach them to each reference. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added a comment. I think we aim at having it strict as default (so someone wanting to comply with the rule "as-is" can just enable the check), and then add options to relax it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Fair enough! I think we should merge this patch as is first, so that people can benefit from it already, and work through the technical debt afterwards. Repository: rG LLVM Gi

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the extensive explanations! See the updated version, it should also take the discussions on the document into account. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:512 +include_cleaner::Includes +convertIncludes(const SourceManage

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. In D144216#4135431 , @carlosgalvezp wrote: > Fair enough! I think we should merge this patch as is first, so that people > can benefit from it already, and work through the technical debt afterwards. Great. Thank you. I'm sti

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 498419. VitaNuo added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/cl

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 ___ cfe-commits mail

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 498428. VitaNuo added a comment. Move to source file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extr

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows `static_assert(false)` to not be ill-formed in template definitions. This change is applied as a DR in all C+

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 498448. cor3ntin added a comment. Forgot to run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Se

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16805 +// definition, the declaration has no effect. +bool InTemplateDefinition = getLangOpts().CPlusPlus && getTemplateDepth(getCurScope()) != 0; + Hmm... interesting way to ca

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

Endill added a comment. Thank you for the patch. Any plans to backport this to 16.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 ___ cfe-commits mail

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16805 +// definition, the declaration has no effect. +bool InTemplateDefinition = getLangOpts().CPlusPlus && getTemplateDepth(getCurScope()) != 0; + erichkeane wrote: > Hmm... int

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added a comment. In D144285#4135775 , @Endill wrote: > Thank you for the patch. > Any plans to backport this to 16.x branch? I think that's something we'd need to discuss with more folks but maybe a bit of time to see how this behaves on real c

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

erichkeane added a comment. In D144285#4135775 , @Endill wrote: > Thank you for the patch. > Any plans to backport this to 16.x branch? I would not really want us to do that, the breaking change here is concerning, and I'd like this to spend time in tru

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel updated this revision to Diff 498453. jcranmer-intel marked 5 inline comments as done. jcranmer-intel added a comment. Mostly test fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 Fil

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added inline comments. Comment at: clang/test/CodeGenOpenCL/opencl_types.cl:2 // RUN: %clang_cc1 -no-opaque-pointers -cl-std=CL2.0 %s -triple "spir-unknown-unknown" -emit-llvm -o - -O0 | FileCheck %s --check-prefixes=CHECK-COM,CHECK-SPIR // RUN: %clang_cc1 -no-

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 498455. cor3ntin added a comment. - Simplify how we check we are in a dependent context - Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 Files: clang/do

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16805 +// definition, the declaration has no effect. +bool InTemplateDefinition = getLangOpts().CPlusPlus && getTemplateDepth(getCurScope()) != 0; +

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 ___

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

reames created this revision. reames added reviewers: craig.topper, asb, Joshua-401, kito-cheng, lbenes, jrtc27. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:853 // Note: The table needs to be sorted by name. static constexpr ImpliedExtsEntry ImpliedExts[] = { {{"v"}, {ImpliedExtsV}}, I think zfa should imply F here? Repository:

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806 +bool InTemplateDefinition = +getLangOpts().CPlusPlus && CurContext->isDependentContext(); +

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 498471. PiotrZSL added a comment. Updated documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files: clang-tools-extra/clang-tidy/performance/CMakeLists

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806 +bool InTemplateDefinition = +getLangOpts().CPlusPlus && CurContext->isDependentContext(); + erichkeane wrote: > CplusPlus check is now not really beneficial? I'm not su

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 498472. PiotrZSL added a comment. Typo in doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt clan

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL added a comment. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. PiotrZSL updated this revision to Diff 498450. PiotrZSL publish

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806 +bool InTemplateDefinition = +getLangOpts().CPlusPlus && CurContext->isDependentContext(); + cor3ntin wrote: > erichkeane wrote: > > CplusPlus check is now not really b

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. You right swap case can also be invalid (rvalue not needed, there). Anyway it it has too be script then this can be strict. But message could be better, for example if we don't move all fields of class, then this could warn that its not fully moved, or that some members

[PATCH] D144291: [clang-format-diff] Correctly parse start-of-file diffs

tamird created this revision. tamird added a reviewer: hans. Herald added a project: All. tamird requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Handle the case where the diff is a pure removal of lines. Before this change start_line would

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to fix some implicit castings for emulated intrinsics

[clang] 4eadd19 - [Fuchsia] Enable llvm-driver build

Author: Alex Brachet Date: 2023-02-17T21:02:18Z New Revision: 4eadd19cc423b860f7ce0217000276da769b7809 URL: https://github.com/llvm/llvm-project/commit/4eadd19cc423b860f7ce0217000276da769b7809 DIFF: https://github.com/llvm/llvm-project/commit/4eadd19cc423b860f7ce0217000276da769b7809.diff LOG:

[PATCH] D144287: [Fuchsia] Enable llvm-driver build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4eadd19cc423: [Fuchsia] Enable llvm-driver build (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Chan

[PATCH] D144287: [Fuchsia] Enable llvm-driver build

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:26 set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") +set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "") phosek wrote: > Nit: can

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous versio

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel added a comment. Note: this patch also makes `LevelIndentTracker::skipLine` obsolete. I suppose I could clean that up in a following patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 _

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 498492. tianshilei1992 marked 7 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3910 + // proper method. + if (Kernel->hasLocalLinkage()) { +assert(Kernel->hasOneUse() && "Unexpected use of debug kernel wrapper."); This doesn't work as expected.

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 updated this revision to Diff 498493. ziqingluo-90 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143680/new/ https://reviews.llvm.org/D143680 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-fix

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 updated this revision to Diff 498494. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143680/new/ https://reviews.llvm.org/D143680 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-local-var-span.cpp Index: clang/test/SemaC

[clang] c0f3ac1 - Revert "[Fuchsia] Enable llvm-driver build"

Author: Alex Brachet Date: 2023-02-17T21:29:14Z New Revision: c0f3ac1d0015fd051144a987ff500b888a32be86 URL: https://github.com/llvm/llvm-project/commit/c0f3ac1d0015fd051144a987ff500b888a32be86 DIFF: https://github.com/llvm/llvm-project/commit/c0f3ac1d0015fd051144a987ff500b888a32be86.diff LOG:

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

ziqingluo-90 updated this revision to Diff 498498. ziqingluo-90 added a comment. Now we have different `FixableGadget`s that may match the same `Stmt` (representing a context). So in order to discover all "Fixable"s, we can no longer match `anyOf` `FixableGadget`s' matchers. Instead, we match

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:849 // in one `anyOf` group (for better performance via short-circuiting). - stmt(anyOf( + stmt(eachOf( #define FIXABLE_GADGET(x)

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

shafik added inline comments. Comment at: clang/docs/ReleaseNotes.rst:62 directly rather than instantiating the definition from the standard library. +- Implemented `CWG2518 `_ which allows ``static_assert(false)`` + not to be ill-formed when its c

  1   2   >