[PATCH] D146686: [Driver] Fix rpath for compiler-rt

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:638 + AddPath({getOSLibName(), llvm::Triple::getArchTypeName(getArch())}); + + return Paths; MaskRay wrote: > unneeded blank line will remove when

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510292. zhangyi1357 added a comment. Format code modified using clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D147395 Files:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zhangyi1357 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 510288. junaire added a comment. CHANGELOG: 1. Add constant array tests. 2. Fix misc issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[clang] 1dd31eb - [clang-format][NFC] Refactor unit tests for "LambdaBodyIndentation: OuterScope"

Author: Jon Phillips Date: 2023-04-01T19:35:49-07:00 New Revision: 1dd31ebe5418d9581f152dcb6cbc4aed66ac9472 URL: https://github.com/llvm/llvm-project/commit/1dd31ebe5418d9581f152dcb6cbc4aed66ac9472 DIFF: https://github.com/llvm/llvm-project/commit/1dd31ebe5418d9581f152dcb6cbc4aed66ac9472.diff

[PATCH] D146995: [clang-format][NFC] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dd31ebe5418: [clang-format][NFC] Refactor unit tests for LambdaBodyIndentation: OuterScope (authored by jp4a50, committed by owenpan).

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510286. junaire added a comment. Fix known memory issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 510282. bolshakov-a edited the summary of this revision. bolshakov-a added a comment. Fix mangling of references to subobjects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 Files:

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added a comment. > The following produces a name collision on MSVC Clang reproduces this buggy behavior. Should it produce an explicit error instead? Or, maybe, some temporary correct algorithm should be found? (It is pretty sad if clang cannot provide new language features for

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 510281. bolshakov-a edited the summary of this revision. bolshakov-a added a comment. Mangling of anonymous unions. @eli.friedman, thank you! > I don't know whether the aforementioned code is acceptable according to the > standard, honestly. It is not

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4238596 , @carlosgalvezp wrote: > Would it make sense to add a scoped enum to the test, to ensure it doesn't > warn/fix? It is not possible to visit scoped enum by instance. I think adding an invalid expression

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1149-1191 + if (Style.isVerilog()) { +const FormatToken *Prev = Tok->getPreviousNonComment(); +const FormatToken *PrevPrev; +// Identify the parameter list and port list

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4d21e2e095: [Clang][AST] Fix __has_unique_object_representations computation for unnamed… (authored by royjacobson). Changed prior to commit:

[clang] 1d4d21e - [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

Author: Roy Jacobson Date: 2023-04-02T00:54:45+03:00 New Revision: 1d4d21e2e0950f6c451198e380371ee3142ce2fb URL: https://github.com/llvm/llvm-project/commit/1d4d21e2e0950f6c451198e380371ee3142ce2fb DIFF: https://github.com/llvm/llvm-project/commit/1d4d21e2e0950f6c451198e380371ee3142ce2fb.diff

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked 5 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:496 + const Expr *SpelledExpr = E->IgnoreUnlessSpelledInSource(); + if (dyn_cast(SpelledExpr)) +

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510270. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/avoid-c-arrays.cpp:170-172 + char init4[] = "abcdef"; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not declare C-style arrays, use

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510267. ccotter added a comment. - Add tests for char[] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510262. ccotter added a comment. - Fix double curly brace matching in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG2469bd98a772: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous… (authored by carlosgalvezp). Changed prior to commit:

[clang-tools-extra] 2469bd9 - [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces

Author: Carlos Galvez Date: 2023-04-01T19:19:00Z New Revision: 2469bd98a77242606426f8a5a8a797054c932bf0 URL: https://github.com/llvm/llvm-project/commit/2469bd98a77242606426f8a5a8a797054c932bf0 DIFF: https://github.com/llvm/llvm-project/commit/2469bd98a77242606426f8a5a8a797054c932bf0.diff

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. AMS21 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. I don't have non-cumbersome access to GPU targets at the moment. I have run the following locally with the patch, and it seems to pass: > ninja check-libomptarget [0/1] Running libomptarget tests Testing Time: 9.69s Unsupported: 57

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

carlosgalvezp added a comment. Would it make sense to add a scoped enum to the test, to ensure it doesn't warn/fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/ https://reviews.llvm.org/D147315

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

PiotrZSL added a comment. Well, description update didn't update, you can update it here in UI, just edit revision, if you use "arc", there is a switch to apply description update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/

[PATCH] D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147379/new/ https://reviews.llvm.org/D147379 ___ cfe-commits mailing list

[PATCH] D147329: [clang-format] Handle Verilog struct literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfeb585e7d62c: [clang-format] Handle Verilog struct literals (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147328: [clang-format] Handle enum in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92b2be39656b: [clang-format] Handle enum in Verilog (authored by sstwcw). Changed prior to commit:

[clang] 92b2be3 - [clang-format] Handle enum in Verilog

Author: sstwcw Date: 2023-04-01T17:09:44Z New Revision: 92b2be39656b9d5c6b57b844884f3bcf3e44f6cd URL: https://github.com/llvm/llvm-project/commit/92b2be39656b9d5c6b57b844884f3bcf3e44f6cd DIFF: https://github.com/llvm/llvm-project/commit/92b2be39656b9d5c6b57b844884f3bcf3e44f6cd.diff LOG:

[clang] feb585e - [clang-format] Handle Verilog struct literals

Author: sstwcw Date: 2023-04-01T17:10:31Z New Revision: feb585e7d62ce92fcd8334abde4a84ee0301dcd3 URL: https://github.com/llvm/llvm-project/commit/feb585e7d62ce92fcd8334abde4a84ee0301dcd3 DIFF: https://github.com/llvm/llvm-project/commit/feb585e7d62ce92fcd8334abde4a84ee0301dcd3.diff LOG:

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510244. sstwcw marked 2 inline comments as done. sstwcw added a comment. - Use shorter conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files:

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 updated this revision to Diff 510241. HerrCai0907 added a comment. update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/ https://reviews.llvm.org/D147315 Files:

[PATCH] D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but will be good idea to wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147379/new/

[PATCH] D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Anonymous

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510228. aaron.ballman added a comment. Another round of fixing what post commit CI found. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147349/new/ https://reviews.llvm.org/D147349 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510226. junaire added a comment. I dont know why the premerge tests are failling, let me try to do a update... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. > It's usually tested indirectly by checks... But this code is used I think > only in 1-2 checks. I see. I'm still trying to understand why we haven't seen this before. If the

[PATCH] D147318: [clang-format] Don't format typename template parameters as expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50acd67018a5: [clang-format] Dont format typename template parameters as expression (authored by rymiel). Repository: rG LLVM Github Monorepo

[clang] 50acd67 - [clang-format] Don't format typename template parameters as expression

Author: Emilia Dreamer Date: 2023-04-01T16:52:51+03:00 New Revision: 50acd67018a53239f11a2889c28f77a1c7dc8c6b URL: https://github.com/llvm/llvm-project/commit/50acd67018a53239f11a2889c28f77a1c7dc8c6b DIFF:

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. The heuristic for determining if an arrow

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510213. aaron.ballman added a comment. Fixed some test failures found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147349/new/ https://reviews.llvm.org/D147349 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

AMS21 created this revision. AMS21 added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

aaron.ballman added subscribers: ChuanqiXu, aaron.ballman. aaron.ballman added a reviewer: ChuanqiXu. aaron.ballman added a comment. CC @ChuanqiXu -- this relates to our discussions about diagnostics in modules. Are you okay with the direction this change is going? Repository: rG LLVM Github

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

PiotrZSL added a comment. We don't have unit tests for most of code... It's usually tested indirectly by checks... But this code is used I think only in 1-2 checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146881/new/

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.cpp:84-85 +Lexer::findNextToken(Start, SM, LangOpts); +if (!CurrentToken || !CurrentToken->is(tok::comment)) + return CurrentToken; + carlosgalvezp wrote:

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

carlosgalvezp added a comment. I'm surprised we don't have unit tests that catch this? Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.cpp:84-85 +Lexer::findNextToken(Start, SM, LangOpts); +if (!CurrentToken || !CurrentToken->is(tok::comment)) +

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Extract DisableTypeMismatchSuggestion & that logic into separate check in bugprone category. TODO: Validate more situations with templates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added a comment. In D144522#4236636 , @PiotrZSL wrote: > @carlosgalvezp > Thank you, by any chance would you be able to look into other reviews ? Doing my best to catch up, I have a long list of patches to review! Unfortunately very

[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cc66f3c779b: [Windows SEH] Fix catch+return crash for Windows -EHa (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147165/new/

[clang] 0cc66f3 - [Windows SEH] Fix catch+return crash for Windows -EHa

Author: Phoebe Wang Date: 2023-04-01T14:53:33+08:00 New Revision: 0cc66f3c779b80a199d692fa84f7ed8d29373d1c URL: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c DIFF: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c.diff

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510186. Krishna-13-cyber added a comment. - Updated diff with `git clang-format HEAD~1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 Files:

[PATCH] D147369: [clang][Interp] Support empty initlist initializers for complex types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo