[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 510706. dhruvachak added a comment. Herald added subscribers: jplehr, sunshaoce, kerbowa. Rebased and updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 added a comment. Now I would kindly as for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 ___ cfe-commits mailing li

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 updated this revision to Diff 510698. AMS21 marked an inline comment as done. AMS21 added a comment. Remove unneccesary braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 Files: clang-tools-ex

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

AMS21 added a comment. In D147376#4239421 , @PiotrZSL wrote: > LGTM. I would kindly ask for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147376/new/ https://reviews.l

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 added a comment. In D147411#4241016 , @PiotrZSL wrote: > LGTM, will you commit this or want someone else to commit this ? As I don't have access to the repository. I need someone else to commit it. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c9db34a9b0: PR58819: Correct linkage and mangling of lambdas in inline static member… (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] e9c9db3 - PR58819: Correct linkage and mangling of lambdas in inline static member initializers

Author: David Blaikie Date: 2023-04-04T04:45:32Z New Revision: e9c9db34a9b04706937e9dd764d1d97ca84337b6 URL: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6 DIFF: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6.diff LOG:

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

craig.topper created this revision. craig.topper added reviewers: efriedma, dmgreen, SjoerdMeijer, john.brawn. Herald added a subscriber: kristof.beyls. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Addresses the FIXME and removes the o

[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a subscriber: inglorion. Herald added a project: All. shafik requested review of this revision. There may be cases in which we want to diagnose a type as unavailable but it may not be complete at

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik added a comment. In D146329#4207522 , @royjacobson wrote: > In D146329#4203174 , @shafik wrote: > >> I would have loved to test the case from >> https://github.com/llvm/llvm-project/issues/61335 directly

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 510667. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/Preprocessor/riscv-target-features.c lld/E

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bee9ff5445: [Clang][Sema] Fix comparison of constraint expressions (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CH

[clang] 60bee9f - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-04-04T02:31:13Z New Revision: 60bee9ff544541e83ffbd4be31923d0e8b644690 URL: https://github.com/llvm/llvm-project/commit/60bee9ff544541e83ffbd4be31923d0e8b644690 DIFF: https://github.com/llvm/llvm-project/commit/60bee9ff544541e83ffbd4be31923d0e8b644690.d

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions + if

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then w

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 510664. VincentWu marked an inline comment as done. VincentWu added a comment. Herald added a subscriber: jobnoorman. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510662. alexander-shaposhnikov added a comment. Add test & minor optimization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaOve

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 510661. VincentWu added a comment. rename FeatureExtZcmp -> FeatureStdExtZcmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv

[PATCH] D147420: [X86] Support AMX Complex instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG038b7e6b761c: [X86] Support AMX Complex instructions (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-comm

[clang] 038b7e6 - [X86] Support AMX Complex instructions

Author: Xiang1 Zhang Date: 2023-04-04T09:54:46+08:00 New Revision: 038b7e6b761c2bebb30440cdd39252a0fa74ac3f URL: https://github.com/llvm/llvm-project/commit/038b7e6b761c2bebb30440cdd39252a0fa74ac3f DIFF: https://github.com/llvm/llvm-project/commit/038b7e6b761c2bebb30440cdd39252a0fa74ac3f.diff

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 510658. HerrCai0907 edited the summary of this revision. HerrCai0907 added a comment. add feature update close comment in fixhint update acc. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions +

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 ___ cfe-commits mailing list

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. > Is there some place (bug, discourse thread, etc) where the broader direction > is discussed? I want to checkin on the design decisions/alternatives without > fragmenting this across multiple reviews/losing context/etc? No, I believe that all the relevant discussion ha

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510637. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaTe

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Does my horrible lambda example work now? If so, that seems like a useful testcase. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510634. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cp

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon. Herald added a project: All. myhsu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add the `-m68881` flag - Add floating point feature detection - Macro defini

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510629. benlangmuir added a comment. Upload correct diff this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510628. benlangmuir added a comment. Also test eagerly-loaded pcm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private-

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 added inline comments. Comment at: clang/test/Modules/implicit-private-with-submodule-explicit.m:9 +// RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules -emit-module -fmodule-name=A_Private %t/module.modulemap -o %t/A_Private.pcm +// RUN: %clang_cc1 -x

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510623. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private-with-submodule-explicit.m Index: clang/test/Modules/implic

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While we eventually want to remove the mapping from .Private to

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub added a comment. Can you add a PowerPC codegen test case for `__attribute__((target(`? All of the updated test cases seem to only test `-target-feature`. The only test case we have for `__attribute((target(` is a sema test `./clang/test/Sema/ppc-attr-target-inline.c`. Converting the dele

[clang] d78ceeb - [Clang] Fix failing test on windows and add TODO for gpu headers

Author: Joseph Huber Date: 2023-04-03T16:54:22-05:00 New Revision: d78ceeba986b5ebe83f935175e584c346a52b8a3 URL: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3 DIFF: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3.diff

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

dblaikie added a comment. Is there some place (bug, discourse thread, etc) where the broader direction is discussed? I want to checkin on the design decisions/alternatives without fragmenting this across multiple reviews/losing context/etc? (specifically - this started out with the trampoline a

[clang] 64549f0 - [OpenMP][5.1] Fix parallel masked is ignored #59939

Author: Rafael A. Herrera Guaitero Date: 2023-04-03T20:33:55Z New Revision: 64549f0903e244fbe2e7f0131698334b6e45dc10 URL: https://github.com/llvm/llvm-project/commit/64549f0903e244fbe2e7f0131698334b6e45dc10 DIFF: https://github.com/llvm/llvm-project/commit/64549f0903e244fbe2e7f0131698334b6e45dc

[PATCH] D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939

This revision was automatically updated to reflect the committed changes. Closed by commit rG64549f0903e2: [OpenMP][5.1] Fix parallel masked is ignored #59939 (authored by randreshg, committed by josemonsalve2). Herald added projects: clang, OpenMP. Herald added subscribers: openmp-commits, cfe-co

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu abandoned this revision. myhsu added a comment. Herald added subscribers: wlei, ormris, MaskRay. Herald added a project: All. just realized I haven't updated this patch for years. I'll come up with an up-to-date version when I have time. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

rsmith closed this revision. rsmith added a comment. Refactoring and test landed in rGa07abe27b4d1d39ebb940a7f4e6235302444cbf0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1470

[clang] fa95f20 - Update Clang 16 statuses

Author: Aaron Ballman Date: 2023-04-03T15:31:20-04:00 New Revision: fa95f20f98c8dfd4d35590a724eb0eb7df64146a URL: https://github.com/llvm/llvm-project/commit/fa95f20f98c8dfd4d35590a724eb0eb7df64146a DIFF: https://github.com/llvm/llvm-project/commit/fa95f20f98c8dfd4d35590a724eb0eb7df64146a.diff

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:775-776 +static bool IsInsideImplicitFullTemplateSpecialization(const DeclContext *DC) { + auto *CTSDecl = dyn_cast_or_null( + DC->getOuterLexicalRecordContext()); + return CTSDecl && !isa(CTSDecl) &&

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added a comment. Can you also change www/cxx_status.html to list P2103R0 as supported in the most recent version of Clang rather than in some previous version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.o

cfe-commits@lists.llvm.org

NoQ accepted this revision. NoQ added a comment. Looks great! LGTM except there's some dead code. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:570-573 +if (const auto *ArraySubst = +dyn_cast(Node->getSubExpr())) + if (const auto *DRE = +

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:775-776 +static bool IsInsideImplicitFullTemplateSpecialization(const DeclContext *DC) { + auto *CTSDecl = dyn_cast_or_null( + DC->getOuterLexicalRecordContext()); + return CTSDecl && !isa(CTSDecl) &&

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8aaad4452f: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14… (authored by aaron.ballman). Repository: rG LLVM Github

[clang] 5d8aaad - [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

Author: Aaron Ballman Date: 2023-04-03T15:22:52-04:00 New Revision: 5d8aaad4452f60ba8902e921d9bed606713a8f26 URL: https://github.com/llvm/llvm-project/commit/5d8aaad4452f60ba8902e921d9bed606713a8f26 DIFF: https://github.com/llvm/llvm-project/commit/5d8aaad4452f60ba8902e921d9bed606713a8f26.diff

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:589-591 + if (LocArg == nullptr) { +return; + } ``` if (

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510574. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Update based on review feedback: - Added an assertion to codegen that a VLA with an initializer is an empty initializer - Updated the codegen tests to use better ide

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson added a comment. FTR, I'll be working my way through a bunch of intrinsics over the next month or so, trying not to do too many at once. Mostly AVX2 but also some others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147461/new/ https://reviews.llvm.org/D147461 _

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D147461 Files: clang/lib/Headers/immintrin.h Index: clang/lib/Headers/immintrin.h ===

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the 'libc' project if present. + if (!Args.hasArg(options::OPT_nostdinc) &&

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263bd8f7d4c: [Clang] Implicitly include LLVM libc headers for the GPU (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1

[clang] f263bd8 - [Clang] Implicitly include LLVM libc headers for the GPU

Author: Joseph Huber Date: 2023-04-03T12:57:21-05:00 New Revision: f263bd8f7d4c82af9672803e6d8d57f25c929d00 URL: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00 DIFF: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00.diff

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

erichkeane added inline comments. Comment at: clang/test/C/C2x/n2900_n3011_2.c:51 + // CHECK: define {{.*}} void @test_vla + // CHECK-NEXT: entry: + // CHECK-NEXT: %[[I:.+]] = alloca i32 so 'entry' isn't really a stable name AFAIK. So this might fail in test

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 510553. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. In D147349#4240847 , @erichkeane wrote: > So not necessary to this patch, but I suspect the non-trivially constructible > types could just be solved the same way we do for ze

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147411/new/ https://reviews.llvm.org/D147411 ___

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT added a comment. In D147414#4240343 , @aaron.ballman wrote: > LGTM! Do you need someone to land this on your behalf? If so, please let me > know what name and email address you would like for patch attribution. > > In D147414#4239453

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the 'libc' project if present. + if (!Args.hasArg(options::OPT_nostdinc) &&

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51f46705e28: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move. (authored by gnanabit, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] e51f467 - [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

Author: Logan Gnanapragasam Date: 2023-04-03T17:01:59Z New Revision: e51f46705e2876fbbdb59d4f1ba43fa6ecf78611 URL: https://github.com/llvm/llvm-project/commit/e51f46705e2876fbbdb59d4f1ba43fa6ecf78611 DIFF: https://github.com/llvm/llvm-project/commit/e51f46705e2876fbbdb59d4f1ba43fa6ecf78611.diff

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT updated this revision to Diff 510542. R2RT added a comment. Bring back Python section in release notes and document new `is_in_system_header` property. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147414/new/ https://reviews.llvm.org/D147414 Files: clang/bindings/python/clang/

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 updated this revision to Diff 510537. AMS21 marked 2 inline comments as done. AMS21 added a comment. Implement suggested way of checking for anonymous structs Add a new more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147411/new/ http

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8234 + ParsedAttr &Attr, Sema &S) { + // Target must have SVE. + if (!S.Context.getTargetInfo().hasFeature("zve32x")) { I need to fix this co

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

gnanabit updated this revision to Diff 510532. gnanabit added a comment. Add release notes entry. Thanks for the reviews! Happy to reword the release notes if they are unclear. @courbet or @PiotrZSL, I don't have commit access. Can you land this patch for me? Please use "Logan Gnanapragasam (gna

[PATCH] D147307: [clang] Consider artificial always inline builtin as inline builtins

efriedma added a comment. I'd be fine with just dropping the check for GNUInline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing list c

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's quite interesting for me. Thanks for your time reviewing and your great advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510521. zhangyi1357 marked an inline comment as not done. zhangyi1357 added a comment. Try to fix the build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D14739

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

erichkeane added a comment. So not necessary to this patch, but I suspect the non-trivially constructible types could just be solved the same way we do for zero-init of these types in fixed-size arrays, right? Its a bit more complicated, but the IR is probably just as do-able: https://godbolt.

[PATCH] D147449: [include-cleaner] Only ignore builtins without a header

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Certain standard library functions (e.g. std::move) are also implemented as

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 510514. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files: clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Co

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu marked an inline comment as done. zequanwu added a comment. In D147073#4240017 , @hans wrote: > I'm not familiar with this code. I suppose the question is whether it's > reasonable for this code to expect that the source locations are always val

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 marked 2 inline comments as done. zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's really interesting for me. Thanks for your time reviewing! Comment at: clang-tools-extr

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510508. zhangyi1357 added a comment. Add uint32Value() for uint32_t type parsing in config file. For TypeNameLimit config, support no limit with value 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:91 +const auto d_ShouldNotDiag = [](const int a, const int b) -> task { + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:30: warning: an exception may be thrown in fu

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

PiotrZSL added a comment. Add release notes entry !. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

PiotrZSL accepted this revision. PiotrZSL added a comment. Current change is correct. This check could be improved in future. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Specifically, the option is renamed to `-mxcoff-roptr` and `-mno-xcoff-roptr` to indicate that this option only affects the `XCOFF` binary format, so it is expected to not affect `ELF` or other formats. Thanks! Repository: rG LLVM Github Monorepo

[clang] 82facc2 - [clang][Interp] Add missing static_assert message

Author: Timm Bäder Date: 2023-04-03T17:12:05+02:00 New Revision: 82facc2b2462441a83ca35d2d6ef1ab28244a1b3 URL: https://github.com/llvm/llvm-project/commit/82facc2b2462441a83ca35d2d6ef1ab28244a1b3 DIFF: https://github.com/llvm/llvm-project/commit/82facc2b2462441a83ca35d2d6ef1ab28244a1b3.diff LO

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG192c2c5c8947: [clang][Interp] Ignore StaticAssertDecls (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 192c2c5 - [clang][Interp] Ignore StaticAssertDecls

Author: Timm Bäder Date: 2023-04-03T16:56:58+02:00 New Revision: 192c2c5c89477e28d0129f37a7d262112585b353 URL: https://github.com/llvm/llvm-project/commit/192c2c5c89477e28d0129f37a7d262112585b353 DIFF: https://github.com/llvm/llvm-project/commit/192c2c5c89477e28d0129f37a7d262112585b353.diff LO

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:215 /// Creates an atomic boolean value. - AtomicBoolValue &createAtomicBoolValue() { -return takeOwnership(std::make

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme updated this revision to Diff 510496. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147302/new/ https://reviews.llvm.org/D147302 File

[clang] b15a946 - [clang][Interp][NFC] Refactor VisitDeclRefExpr

Author: Timm Bäder Date: 2023-04-03T16:42:25+02:00 New Revision: b15a946b9f59f91518ae5e2cb6125592d9c1bf3c URL: https://github.com/llvm/llvm-project/commit/b15a946b9f59f91518ae5e2cb6125592d9c1bf3c DIFF: https://github.com/llvm/llvm-project/commit/b15a946b9f59f91518ae5e2cb6125592d9c1bf3c.diff LO

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added reviewers: erichkeane, rjmccall, efriedma. aaron.ballman added a comment. Adding Erich as attributes code owner and John/Eli as ABI code owners. Comment at: clang/lib/Sema/SemaType.cpp:8265 + // The attribute vector size must match -mrvv-vector-bits. + //

[clang] 8c8b4d2 - [Clang] Update test checks (NFC)

Author: Nikita Popov Date: 2023-04-03T16:33:34+02:00 New Revision: 8c8b4d24f019e51900f15e008b52a05cf1e66381 URL: https://github.com/llvm/llvm-project/commit/8c8b4d24f019e51900f15e008b52a05cf1e66381 DIFF: https://github.com/llvm/llvm-project/commit/8c8b4d24f019e51900f15e008b52a05cf1e66381.diff

[clang-tools-extra] f323e7f - [include-cleaner] Treat member operator calls as implicit

Author: Kadir Cetinkaya Date: 2023-04-03T16:27:23+02:00 New Revision: f323e7f3ca760be786d2584c926edade34c3fbde URL: https://github.com/llvm/llvm-project/commit/f323e7f3ca760be786d2584c926edade34c3fbde DIFF: https://github.com/llvm/llvm-project/commit/f323e7f3ca760be786d2584c926edade34c3fbde.dif

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aaron.ballman added a comment. In D146595#4237228 , @aprantl wrote: > I think `debug_trampoline` both captures the semantics and makes it clear > that this is related to debugging. I'd be fine with this, or `transparent_debug_stepping`, etc. Just someth

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. In D144269#4237539 , @dkrupp wrote: > This is a totally rewritten version of the patch which solely relies on the > existing "interestingness" utility to track back the taint propagation. (And > does not introduce a new FlowI

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. Hmmm, is this effectively `std::has_unique_object_representations` (ensuring that all bits of the object representation contribute to the value)? Comment at: clang/lib/AST/Type.cpp:2610 + + if (const auto *RecordDecl = CanonicalType->getAsCXXRec

[PATCH] D145860: [clang][Interp] Fix initializing fields after base class members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG056042d21b72: [clang][Interp] Fix initializing fields after base class members (authored by tbaeder). Changed prior to commit: https://reviews.llv

[clang] 056042d - [clang][Interp] Fix initializing fields after base class members

Author: Timm Bäder Date: 2023-04-03T15:55:11+02:00 New Revision: 056042d21b72a86653f88719c0b54b07e35d2144 URL: https://github.com/llvm/llvm-project/commit/056042d21b72a86653f88719c0b54b07e35d2144 DIFF: https://github.com/llvm/llvm-project/commit/056042d21b72a86653f88719c0b54b07e35d2144.diff LO

[clang-tools-extra] 26ff268 - [include-cleaner] Report references to operator calls as implicit

Author: Kadir Cetinkaya Date: 2023-04-03T15:49:28+02:00 New Revision: 26ff268b80c589fd9f71c1c214af77cd972642ca URL: https://github.com/llvm/llvm-project/commit/26ff268b80c589fd9f71c1c214af77cd972642ca DIFF: https://github.com/llvm/llvm-project/commit/26ff268b80c589fd9f71c1c214af77cd972642ca.dif

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146973/new/ https://reviews.llvm.org/D146973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

This revision was automatically updated to reflect the committed changes. Closed by commit rG26ff268b80c5: [include-cleaner] Report references to operator calls as implicit (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147144/

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

ymandel accepted this revision. ymandel added a comment. Thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:215 /// Creates an atomic boolean value. - AtomicBoolValue &createAtomicBoolValue() { -return takeOwnership(std::make_uniqu

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG58cf70b2cdc1: [clang][Interp] Fix diagnostics for calling non-constexpr constructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D145841?vs=504406&id=510485#toc Repository:

  1   2   >