[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525420. junaire marked 15 inline comments as done. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/c

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2131 +} + Extra blank line Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c:16 // -vint8mf8_t test_

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:434 + +llvm::Expected Interpreter::CompileDecl(Decl *D) { + assert(D && "The Decl being compiled can't be null"); aaron.ballman wrote: > Any way to make this take a `const Decl *` i

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 525421. daiyousei-qz added a comment. - Address review comment and remove a unnecessary flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files: clang-tools

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Sorry for the inactivity. I have replace the parameter with const ref. By the way, I also removed the existing `IncludeInactiveRegionTokens` flag and uses this filter instead. Please help review the change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D151402: Address some review feedback

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Delete unnecessary includes, revert SymbolGraphSerializer

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525425. junaire added a comment. Remove `Interpereter::getParser` + More clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpr

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:578 +constexpr unsigned HintMinLineLimit = 2; +constexpr unsigned HintMaxLengthLimit = 50; + daiyousei-qz wrote: > sammccall wrote: > > We actually already have a configurab

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1365 defm vaaddu : RISCVSaturatingBinaryAAX; - defm vaadd : RISCVSaturatingBinaryAAX; - defm vaadd_rm : RISCVSaturatingBinaryAAXRoundingMode; + defm vaadd : RISCVSaturatingBinaryAAXRound

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

efriedma added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4698 +if (CodeGenOpts.UnwindTables) + fn->setUWTableKind(llvm::UWTableKind(CodeGenOpts.UnwindTables)); + We probably want to call SetLLVMFunctionAttributesForDefinition() her

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added a comment. I generally support the idea of a CXXLifetimeExtendedObj region, definitely cleaner than a CXXTempObjectRegion with static lifetime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai updated this revision to Diff 525429. smeenai added a comment. Call SetLLVMFunctionAttributesForDefinition instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 Files: clang/lib/CodeGen/Itaniu

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 525431. evelez7 marked 8 inline comments as done. evelez7 added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151293/new/ https://reviews.llvm.org/D151293 Files: clang

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:361 +(Style.BreakBeforeInlineASMColon == FormatStyle::BBIAS_OnlyMultiline && + Style.ColumnLimit != 0 { return true; FWIW

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. In D145739#4370674 , @barannikov88 wrote: > Hi, just a heads-up, some bots seem to be unhappy with the test: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21765 > > error: 'note' diagnostics expected but not seen: >

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:578 +constexpr unsigned HintMinLineLimit = 2; +constexpr unsigned HintMaxLengthLimit = 50; + nridge wrote: > daiyousei-qz wrote: > > sammccall wrote: > > > We actually

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 525448. daiyousei-qz added a comment. - Fix reversed logic of including inactive region token Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files: clang-tool

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525452. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInst

<    1   2   3