[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; craig.topper wrote: > Now we're not checking the index register if there is no

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

dblaikie added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( craig.topper wrote: > This sets BaseReg to 0 if its

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; Now we're not checking the index register if there is no base register?

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( This sets BaseReg to 0 if its already 0? Repository:

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527725. akshaykhadse added a comment. Update AsmParser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1425 + const SmallVectorImpl , + const FormatToken , + const FormatStyle ) { I will

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 : RVVConvBuiltin<"w", "wv", "x", "vfwcvt_f">

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

philnik created this revision. philnik added reviewers: erichkeane, aaron.ballman. Herald added subscribers: luke, steakhal, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Ok, sorry I missed the mangle update, seeing how I missed the MLIR mention as well: I need more sleep!! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik updated this revision to Diff 527704. philnik marked 2 inline comments as done. philnik added a comment. Herald added a subscriber: jdoerfert. - Address comments - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek added a comment. In D151923#4389405 , @mehdi_amini wrote: > I think this LG, but David had to update clang/lib/AST/MicrosoftMangle.cpp > when some other float format was added, you don't need this here? I did update that file - it is part of

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > shchenz wrote: > > MaskRay wrote: > > >

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemDisp()->getKind() == llvm::MCExpr::SymbolRef) + return true; Wouldn't this allow "symbol + %eax" to pick the 64-bit

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

XinWang10 added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. Please let me know if these tests and changes look okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___ cfe-commits mailing

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match In

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. If the first token of an annotated line is finalized, reuse its

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

mehdi_amini added a comment. > Also do you have plans for MLIR? (nothing required for this patch, just > curious). Actually it's the last sentence of the patch description (/facepalm) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151923/new/

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

mehdi_amini added a comment. I think this LG, but David had to update clang/lib/AST/MicrosoftMangle.cpp when some other float format was added, you don't need this here? Also do you have plans for MLIR? (nothing required for this patch, just curious). Repository: rG LLVM Github Monorepo

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb updated this revision to Diff 527681. cjdb added a comment. fixes some code I wrote when debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151952/new/ https://reviews.llvm.org/D151952 Files: clang/docs/LanguageExtensions.rst

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added subscribers: arphaman, martong. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similarly to

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao accepted this revision. ayzhao added a comment. This revision is now accepted and ready to land. In D150122#4388978 , @ayzhao wrote: > In D150122#4388972 , @cor3ntin > wrote: > >> I guess we should land

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a project: clang-modules. jansvoboda11 added a comment. Thanks, Ben. Maybe someone subscribed to `clang-modules` could take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277

[PATCH] D144911: adding bf16 support to NVPTX

manishucsd added a comment. I tried this patch to resolve lowering `nvvm.mma.sync` on bf16 operands for the PR 13858 nvvm.mma.sync A[%293, %295, %297, %299] B[%392, %394] C[%484, %485, %487, %488] {layoutA = #nvvm.mma_layout, layoutB =

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concern with nullptr dereference issue

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses

[PATCH] D151944: [Driver] Move -nostdinc like options into IncludePath_Group

theuni accepted this revision. theuni added a comment. This revision is now accepted and ready to land. Looks good to me. I can confirm that this fixes my test-case from D151926 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151944: [Driver] Move -nostdinc like options into IncludePath_Group

MaskRay updated this revision to Diff 527645. MaskRay added a comment. Include -nobuiltininc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151944/new/ https://reviews.llvm.org/D151944 Files: clang/include/clang/Driver/Options.td

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sunfish added a comment. In D150803#4389040 , @dschuff wrote: > Hm, this is interesting because in the long term we plan to have stack > switching in wasm, which could allow for similar async behavior that JSPI > has, and could be useful in non-web

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D151944: [Driver] Move -nostdinc like options into IncludePath_Group

MaskRay created this revision. MaskRay added reviewers: jansvoboda11, theuni. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With only a link action, we claim all CompileOnly_Group options (including

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

dschuff added a comment. In D150803#4350554 , @sbc100 wrote: > This change looks really nice. I like the new relocation type, I think we > would have had to add that sooner or later anyway. > > My only major concern is making this attribute available

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, but I would prefer at least one more person who understands the identifier handling code review this. It's been years since I thought about this code. Repository: rG LLVM

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

benlangmuir added inline comments. Comment at: clang/test/Modules/crash-vfs-umbrella-frameworks.m:13 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ -// RUN: not %clang -nostdinc -fsyntax-only %s \ +// RUN: not --crash %clang -nostdinc -fsyntax-only %s \

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:892 if (const auto *Attr = FD->getAttr()) { -llvm::Function *Fn = cast(GV); +auto *Fn = cast(GV); llvm::AttrBuilder B(GV->getContext()); Whoops, I

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a comment. In D150122#4388972 , @cor3ntin wrote: > I guess we should land that now @erichkeane ? Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin added a comment. I guess we should land that now @erichkeane ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122 ___ cfe-commits mailing list

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 updated this revision to Diff 527634. jansvoboda11 added a comment. Rebase and switch back to `IdentifierTable::getOwn()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 Files:

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added a comment. ping @arsenm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151876: [NVPTX] Signed char and (unsigned)long overloads of ldg and ldu

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I'd change the patch title: - `[NVPTX]` -> `[cuda, NVPTX]` as these are clang changes, not NVPTX back-end. - `overloads ` -> `builtins` Comment at:

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D151931: [clang] Remove `DirectoryEntry::getName()`

jansvoboda11 added a comment. Yes, I'd like to get the deprecation (and fixes in other LLVM sub-projects) into `main` ASAP and then land this patch after the branch for the 17 release is cut. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151931: [clang] Remove `DirectoryEntry::getName()`

benlangmuir added a comment. Given this was a commonly used function before and there's a decent chance it's used out of tree somewhere, should we wait until the next llvm release branch has been cut before landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151931: [clang] Remove `DirectoryEntry::getName()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch finally

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in ConvertQualTypeToKind(clang::​ASTContext

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527591. fahadnayyar added a comment. Edits in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D151927: [clang] Deprecate `DirectoryEntry::getName()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This finally oficially

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek created this revision. Herald added subscribers: bzcheeseman, rriddle, hiraditya. Herald added a project: All. jfurtek requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, stephenneuendorffer. Herald added projects: clang, LLVM. This diff adds APFloat

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527583. VitaNuo added a comment. Undo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:105 // RUN: -nostdinc \ // RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \ // RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \

[PATCH] D151922: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added subscribers: ributzka, kadircet, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber:

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ shchenz wrote: > MaskRay wrote: > > aix-as.c will be more

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

This revision was automatically updated to reflect the committed changes. Closed by commit rG39ecf9d8a153: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/

[clang] 39ecf9d - [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

Author: Tom Eccles Date: 2023-06-01T19:29:16Z New Revision: 39ecf9d8a1533a434bb9544a1bc275c4d02e2efb URL: https://github.com/llvm/llvm-project/commit/39ecf9d8a1533a434bb9544a1bc275c4d02e2efb DIFF: https://github.com/llvm/llvm-project/commit/39ecf9d8a1533a434bb9544a1bc275c4d02e2efb.diff LOG:

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1553-1554 return TPResult::Error; - if (Tok.isNot(tok::identifier)) + if (NextToken().isNot(tok::identifier)) break; }

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

HazardyKnusperkeks added a comment. In D151761#4385571 , @galenelias wrote: > In D151761#4385163 , > @HazardyKnusperkeks wrote: > >> When I read the title I thought "Yay, some one is doing what I want and >>

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527554. VitaNuo added a comment. Experiment with paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added a comment. In D149867#4387189 , @glaubitz wrote: > In D149867#4386271 , @jrtc27 wrote: > >> I disagree. Being experimental doesn't mean you should do the wrong thing. >> Reusing stdcall in the

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527545. VitaNuo added a comment. Undo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Parse/ParseTentative.cpp:1553-1554 return TPResult::Error; - if (Tok.isNot(tok::identifier)) +

[clang] 0a21fb3 - [Fuchsia] Reland: Add llvm-debuginfod to toolchain

Author: Daniel Thornburgh Date: 2023-06-01T11:48:22-07:00 New Revision: 0a21fb3441dcffa2ccd8215f423100fbe4182f12 URL: https://github.com/llvm/llvm-project/commit/0a21fb3441dcffa2ccd8215f423100fbe4182f12 DIFF:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527543. VitaNuo added a comment. Fix last test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM w/ comments applied. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:95 // Make sure that using -nostdinc, -nostdinc++ or -nostdlib will drop both the toolchain // C++ include path and the sysroot one. Comment at:

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc13957cb17: [clang][docs] document __attribute__((cleanup())) GNU C extension (authored by nickdesaulniers). Repository: rG LLVM Github

[clang] 8dc1395 - [clang][docs] document __attribute__((cleanup())) GNU C extension

Author: Nick Desaulniers Date: 2023-06-01T11:24:53-07:00 New Revision: 8dc13957cb1752b6a90e299d016e09bb98b0df54 URL: https://github.com/llvm/llvm-project/commit/8dc13957cb1752b6a90e299d016e09bb98b0df54 DIFF:

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

nickdesaulniers updated this revision to Diff 527536. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151732/new/ https://reviews.llvm.org/D151732 Files: clang/include/clang/Basic/Attr.td

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

nickdesaulniers updated this revision to Diff 527535. nickdesaulniers added a comment. - add note about reverse declaration order for variables declared in the same scope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151732/new/

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

nickdesaulniers updated this revision to Diff 527528. nickdesaulniers added a comment. - add note about function signature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151732/new/ https://reviews.llvm.org/D151732 Files:

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar marked 2 inline comments as done. fahadnayyar added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119 // RUN: -nostdinc++ \ -// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \ +// RUN: | FileCheck

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527512. fahadnayyar added a comment. Simplifying the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 : RVVConvBuiltin<"w", "wv", "x", "vfwcvt_f"> {

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. I noticed the `Modules/crash-vfs-umbrella-frameworks.m` test fails. I'll need to look into this some more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151855/new/ https://reviews.llvm.org/D151855

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527509. VitaNuo added a comment. Try ignoring verbatim spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files:

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 updated this revision to Diff 527508. jansvoboda11 added a comment. Rebase, reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151855/new/ https://reviews.llvm.org/D151855 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 : RVVConvBuiltin<"w", "wv", "x", "vfwcvt_f">

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2185-2187 + auto TestV = llvm::ConstantInt::get(CGF->Int32Ty, Test); + Function *F = CGF->CGM.getIntrinsic(Intrinsic::is_fpclass, V->getType()); + return CGF->Builder.CreateCall(F, {V, TestV});

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

tra added inline comments. Comment at: clang/unittests/Interpreter/InteractiveCudaTest.cpp:92 + std::unique_ptr Interp = createInterpreter(); + auto Err = Interp->LoadDynamicLibrary("libcudart.so"); + if (Err) { // CUDA runtime is not installed/usable, cannot continue testing

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - rsmith wrote: > Fznamznon wrote: > > cor3ntin wrote:

[PATCH] D151869: [RISCV] Support more builtin for zvfhmin.

eopXD added a comment. I think the topic of this patch is not accurate. The compiler already support these intrinsics with `zvfh` specified. Implementing `zvfhmin` is relaxing the implementation and let come the intrinsics available when only `zvfhmin` and not `zvfm` is specified. So I think

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

eopXD added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2050 Diag(Loc, diag::err_riscv_type_requires_extension, FD) - << Ty << "zvfh"; + << Ty << "zvfh or zvfhmin"; if (Ty->isRVVType(/* Bitwidth */ 32, /* IsFloat */ true) &&

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb092f417db21: [clang] Use `FileEntryRef` in modular header search (part 1/2) (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. In D112932#4005339 , @sepavloff wrote: > Remove __builtin_isfpclass I am interested in adding a __builtin_isfpclass, just in a separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b092f41 - [clang] Use `FileEntryRef` in modular header search (part 1/2)

Author: Jan Svoboda Date: 2023-06-01T10:38:07-07:00 New Revision: b092f417db211b5316bc29bc651eaaa86ce1 URL: https://github.com/llvm/llvm-project/commit/b092f417db211b5316bc29bc651eaaa86ce1 DIFF: https://github.com/llvm/llvm-project/commit/b092f417db211b5316bc29bc651eaaa86ce1.diff

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

eopXD added a comment. Thank you for the patch. Few comments here. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 :

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

argentite added inline comments. Comment at: clang/unittests/Interpreter/InteractiveCudaTest.cpp:92 + std::unique_ptr Interp = createInterpreter(); + auto Err = Interp->LoadDynamicLibrary("libcudart.so"); + if (Err) { // CUDA runtime is not installed/usable, cannot continue

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

tra added inline comments. Comment at: clang/unittests/Interpreter/InteractiveCudaTest.cpp:92 + std::unique_ptr Interp = createInterpreter(); + auto Err = Interp->LoadDynamicLibrary("libcudart.so"); + if (Err) { // CUDA runtime is not installed/usable, cannot continue testing

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. In D112932#4043545 , @arsenm wrote: > This change itself LGTM but I think it should wait until after we get more > optimizations in to go back to fcmp, and after the release branch I think these optimizations are mostly in a

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

jansvoboda11 updated this revision to Diff 527490. jansvoboda11 added a comment. Remove optionality from one argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151854/new/ https://reviews.llvm.org/D151854 Files:

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:763 /// find this file due to requirements from \p RequestingModule. - bool findUsableModuleForHeader(const FileEntry *File, + bool findUsableModuleForHeader(OptionalFileEntryRef

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:763 /// find this file due to requirements from \p RequestingModule. - bool findUsableModuleForHeader(const FileEntry *File, + bool findUsableModuleForHeader(OptionalFileEntryRef

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:790 + +**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ ` + Style of aligning consecutive short case labels.

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

craig.topper added a comment. Doesn't this make codegen worse on when those extensions aren't supported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151867/new/ https://reviews.llvm.org/D151867 ___

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

argentite created this revision. argentite added a reviewer: v.g.vassilev. Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. argentite requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This tests

[clang] 82b5a93 - Revert "[Fuchsia] Add llvm-debuginfod to toolchain"

Author: Haowei Wu Date: 2023-06-01T10:20:17-07:00 New Revision: 82b5a934b8e535d531b204af13775a820010c9be URL: https://github.com/llvm/llvm-project/commit/82b5a934b8e535d531b204af13775a820010c9be DIFF: https://github.com/llvm/llvm-project/commit/82b5a934b8e535d531b204af13775a820010c9be.diff

  1   2   3   >