[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4361594 , @tstellar wrote: > In D141907#4355229 , @paperchalice > wrote: > >> In D141907#4355228 , @tstellar >> wrote: >> >>> @p

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:290 + number of code lines it prints has been increased from 1 to 16. This + can be controlled using ``-fcaret-diagnostics-max-lines=``. dyung wrote: > Is this correct? I notice that all o

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

dyung added inline comments. Comment at: clang/docs/ReleaseNotes.rst:290 + number of code lines it prints has been increased from 1 to 16. This + can be controlled using ``-fcaret-diagnostics-max-lines=``. Is this correct? I notice that all of the tests you u

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > charmitro wrote: > > > tbaede

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 528072. galenelias marked 3 inline comments as done. galenelias retitled this revision from "clang-format: Add AlignConsecutiveShortCaseLabels" to "clang-format: Add AlignConsecutiveShortCaseStatements". galenelias edited the summary of this revision. CHA

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I was not sure what to do with inline functions and also functions that were implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY macro to most of those functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, wenlei, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, n

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 528064. Prabhuk added a comment. Simplifying the patch to include just the scaffolding for X86_64 platform. Removing the predefines to be added as a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

rsmith added a comment. Taking a step back for a moment: what is the intended use case for this? My concern is that most of the time you're going to want to make O(N) such queries into a pack of N elements, resulting in O(N^2) compile time, much like we regrettably get from uses of `__type_pack

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

rsmith added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1553-1554 return TPResult::Error; - if (Tok.isNot(tok::identifier)) + if (NextToken().isNot(tok::identifier)) break; } ---

[PATCH] D132275: [clang] Create alloca to pass into static lambda

leonardchan added subscribers: jdoerfert, leonardchan. leonardchan added a comment. Hi. For an embedded device, prior to this patch, we used to be able to see a significant savings of 28kB when we enabled the attributor. But with this patch, we don't see these savings anymore when enabling the a

[clang] 14c44df - clang: Update tests after InstSimplify change

Author: Matt Arsenault Date: 2023-06-02T18:47:58-04:00 New Revision: 14c44dfbcf1d6f81c1cdaa90ed243b3d53147903 URL: https://github.com/llvm/llvm-project/commit/14c44dfbcf1d6f81c1cdaa90ed243b3d53147903 DIFF: https://github.com/llvm/llvm-project/commit/14c44dfbcf1d6f81c1cdaa90ed243b3d53147903.diff

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

kiranchandramohan added inline comments. Comment at: flang/lib/Lower/Bridge.cpp:271 +bridge{bridge}, foldingContext{bridge.createFoldingContext()}, +ompRequiresFlags{mlir::omp::ClauseRequires::none} {} virtual ~FirConverter() = default; Is this

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

shafik added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:2200 Diag(Tok, diag::err_expected_semi_for); - else -// Skip until semicolon or rparen, don't consume it. Can you explain why you removed this? Commen

[PATCH] D151834: Include math-errno with fast-math

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/FPOptions.def:30 OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) +OPTION(MathErrno, bool, 1, BFloat16ExcessPrecision) #undef OPTION Does this mean M

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a comment. `clang/test/ClangScanDeps/modules-full.cpp ` passes locally for me and I don't see why my change would effect this test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___ c

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620 + if (Kind == clang::TT_TypePackIndex) +return EvaluateIntegralTypeTrait(*this, Kind, KWLoc, Args, RParenLoc, cjdb wrote: > erichkeane wrote: > > I realize this is the 1st, b

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 527978. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - remove unnecessary Visit*CastExpr overrides Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https:/

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620 + if (Kind == clang::TT_TypePackIndex) +return EvaluateIntegralTypeTrait(*this, Kind, KWLoc, Args, RParenLoc, erichkeane wrote: > I realize this is the 1st, but this seems like it

[PATCH] D152034: [clang][NFC] refactors value type traits so we can have more than bools

cjdb created this revision. cjdb added reviewers: erichkeane, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since all the type traits up until now have had Boolean vaules, we've always been able

[PATCH] D152027: [CUDA] Update Kepler(sm_3*) support info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f49116e261c: [CUDA] Update Kepler(sm_3*) support info. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 0f49116 - [CUDA] Update Kepler(sm_3*) support info.

Author: Artem Belevich Date: 2023-06-02T14:16:13-07:00 New Revision: 0f49116e261cf5a156221b006acb677e3565fd1a URL: https://github.com/llvm/llvm-project/commit/0f49116e261cf5a156221b006acb677e3565fd1a DIFF: https://github.com/llvm/llvm-project/commit/0f49116e261cf5a156221b006acb677e3565fd1a.diff

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:190 +// greater throughput than single precision (32-bit) formats. +S_FloatTF32, majnemer wrote: > Hmm, this says improved precision than half but the semantics you gave say >

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStringFrom

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek updated this revision to Diff 527968. jfurtek added a comment. - Fix comment and clang-formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151923/new/ https://reviews.llvm.org/D151923 Files: clang/lib/AST/MicrosoftMangle.cpp llvm/

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

This revision was automatically updated to reflect the committed changes. Closed by commit rG82659941ccb8: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 8265994 - [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Author: Manna, Soumi Date: 2023-06-02T13:40:45-07:00 New Revision: 82659941ccb88605ae4288f7506ef11e5fe3fc17 URL: https://github.com/llvm/llvm-project/commit/82659941ccb88605ae4288f7506ef11e5fe3fc17 DIFF: https://github.com/llvm/llvm-project/commit/82659941ccb88605ae4288f7506ef11e5fe3fc17.diff

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

rnk added a comment. This is pretty cool, even if it's just for data gathering. It's interesting that 29% of .debug_info and .debug_str is for describing class methods, that's pretty significant, even if it's only a 13% reduction across all debug info sections. Repository: rG LLVM Github Mo

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 527950. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCal

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added reviewers: efriedma, rsmith. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValu

[PATCH] D152027: [CUDA] Update Kepler(sm_3*) support info.

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: jlebar. tra added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Kepler is gone! L

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

This revision was automatically updated to reflect the committed changes. Closed by commit rG02ce49afb9a0: [NFC][CLANG] Fix bug with dereference null return value in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/ htt

[clang] 02ce49a - [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

Author: Manna, Soumi Date: 2023-06-02T13:28:06-07:00 New Revision: 02ce49afb9a078932c74f4d9b43189a5567e54e9 URL: https://github.com/llvm/llvm-project/commit/02ce49afb9a078932c74f4d9b43189a5567e54e9 DIFF: https://github.com/llvm/llvm-project/commit/02ce49afb9a078932c74f4d9b43189a5567e54e9.diff

[PATCH] D152023: [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of the target.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18ccca4da8de: [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of… (authored by craig.topper). Repository: rG LLVM Git

[clang] 18ccca4 - [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of the target.

Author: Craig Topper Date: 2023-06-02T13:01:05-07:00 New Revision: 18ccca4da8dec5fbfd1072a1c1544ce25f528627 URL: https://github.com/llvm/llvm-project/commit/18ccca4da8dec5fbfd1072a1c1544ce25f528627 DIFF: https://github.com/llvm/llvm-project/commit/18ccca4da8dec5fbfd1072a1c1544ce25f528627.diff

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ shchenz wrote: > MaskRay wrote: > > shchenz wrote: > > > MaskRay

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I'm traveling but will look at this on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 ___ cfe-commits mailing list cfe-commi

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1209 +return VisitCastExpr(I, T); + } + llvm::Constant *VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr *C, QualType T) { ConstExprEmitter should inherit an identical impleme

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1553-1554 return TPResult::Error; - if (Tok.isNot(tok::identifier)) + if (NextToken().isNot(tok::identifier))

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStringFrom

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik updated this revision to Diff 527937. shafik added a comment. - Update check to use tok::annot_cxxscope CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseTentative.cpp clang/te

[PATCH] D152023: [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of the target.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152023/new/ https://reviews.llvm.org/D152023 ___ c

[PATCH] D152023: [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of the target.

craig.topper created this revision. craig.topper added reviewers: efriedma, nikic, vsk. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Previously we checked isCLZForZeroUndef and only added UBSan ch

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 527931. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, w2yehia. qiongsiwu1 added a project: clang. Herald added subscribers: kbarton, inglorion, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis accepted this revision. TIFitis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 _

[clang] 583e028 - [test] Add -Wno-msvc-not-found to fix linker-opts.c on *-windows-msvc

Author: Fangrui Song Date: 2023-06-02T11:59:23-07:00 New Revision: 583e02831c6d081f43f2d5c5b9be5d773b7ae8b8 URL: https://github.com/llvm/llvm-project/commit/583e02831c6d081f43f2d5c5b9be5d773b7ae8b8 DIFF: https://github.com/llvm/llvm-project/commit/583e02831c6d081f43f2d5c5b9be5d773b7ae8b8.diff

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 527925. nickdesaulniers added a comment. - remove commented out code, still WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files: clang/lib/CodeGen/CGE

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 527924. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - just failing clang/test/CodeGenCXX/atomicinit.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/

[PATCH] D151601: [NVPTX] Coalesce register classes for {i16,f16,bf16}, {i32,v2f16,v2bf16}

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I cannot say that I 100% looked over every line, but in principle this seems fine, and if it's passing TF tests then that's pretty strong evidence this is working. Repository: rG LLVM Gith

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

majnemer added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:190 +// greater throughput than single precision (32-bit) formats. +S_FloatTF32, Hmm, this says improved precision than half but the semantics you gave say 11 digits? Does NVI

[PATCH] D151601: [NVPTX] Coalesce register classes for {i16,f16,bf16}, {i32,v2f16,v2bf16}

tra added a comment. I've tested the change on a bunch of tensorflow tests and the patch didn't cause any apparent issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151601/new/ https://reviews.llvm.org/D151601

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie updated this revision to Diff 527920. dblaikie added a comment. Updating commit message with extra details Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 Files: clang/include/clang/Basic/CodeG

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152016/new/ https://reviews.llvm.org/D152016 _

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie created this revision. dblaikie added a reviewer: probinson. Herald added a project: All. dblaikie requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Complete C++ type information can be quite expensive - and there's limited v

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

zibi created this revision. zibi added reviewers: Kai, fanbo-meng, abhina.sreeskantharajan. Herald added a reviewer: aaron.ballman. Herald added a project: All. zibi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [SystemZ} This revision fi

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStr

[clang-tools-extra] 860e439 - [Clang] Fix missing libraries for the include cleaner check

Author: Joseph Huber Date: 2023-06-02T12:43:55-05:00 New Revision: 860e439fb27f86b97bfd9acce5e27f4337c471c7 URL: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7 DIFF: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7.diff

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > shafik wrote: > > This

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin updated this revision to Diff 527902. cor3ntin added a comment. revert ws changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152009/new/ https://reviews.llvm.org/D152009 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseExprC

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. In D144911#4389187 , @manishucsd wrote: > I fail to compile this patch. Please find the compilation error below: > > [build] ./llvm-project/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:1117:40: > error: Variable not defined: 'hasPTX70'

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. with multiple declarations followed by a colon. Fixes #63010 Repository: rG LLVM Github Monorepo https://reviews.llv

cfe-commits@lists.llvm.org

ilya-biryukov added a comment. @massberg did we figure out if there is anything else left from P2002R1? Are there blockers to landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 ___

[PATCH] D151634: [clang] Add test for CWG253

shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > This is [issue 1380](ht

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits would

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

erichkeane added a comment. In D149573#4391083 , @codemzs wrote: > In D149573#4391013 , @erichkeane > wrote: > >> In D149573#4390895 , @codemzs >> wrote: >> >>> In D1495

[PATCH] D151944: [Driver] Move -nostdinc like options into IncludePath_Group

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b77e752dcd0: [Driver] Move -nostdinc like options into IncludePath_Group (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D151944?vs=527645&id=527884#toc Repository: rG LLVM

[clang] 5b77e75 - [Driver] Move -nostdinc like options into IncludePath_Group

Author: Fangrui Song Date: 2023-06-02T09:33:08-07:00 New Revision: 5b77e752dcd073846b89559d6c0e1a7699e58615 URL: https://github.com/llvm/llvm-project/commit/5b77e752dcd073846b89559d6c0e1a7699e58615 DIFF: https://github.com/llvm/llvm-project/commit/5b77e752dcd073846b89559d6c0e1a7699e58615.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a subscriber: aaron.ballman. codemzs added a comment. In D149573#4391013 , @erichkeane wrote: > In D149573#4390895 , @codemzs wrote: > >> In D149573#4390863

[clang] 8b5dbc3 - [CodeGen] Use llvm::LLVMContext::MD_invariant_load (NFC)

Author: Kazu Hirata Date: 2023-06-02T09:25:00-07:00 New Revision: 8b5dbc37a899faf0d2cb842bcb1ebc66a319c394 URL: https://github.com/llvm/llvm-project/commit/8b5dbc37a899faf0d2cb842bcb1ebc66a319c394 DIFF: https://github.com/llvm/llvm-project/commit/8b5dbc37a899faf0d2cb842bcb1ebc66a319c394.diff L

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151350/new/ https://reviews.llvm.org/D151350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

jdenny added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151356/new/ https://reviews.llvm.org/D151356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19841e4dcaab: [OpenMP] Fix transformed loop's var privacy (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 19841e4 - [OpenMP] Fix transformed loop's var privacy

Author: Joel E. Denny Date: 2023-06-02T12:18:13-04:00 New Revision: 19841e4dcaabe573d35eb88a130fc34d32ecd708 URL: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708 DIFF: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

erichkeane added a comment. In D149573#4390895 , @codemzs wrote: > In D149573#4390863 , @stuij wrote: > >> This is going to be a very unhelpful comment. After looking through the >> changes, I don't have any comm

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); Fznamznon wrote: > erichkean

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); erichkeane wrote: > I am not

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5562 + if (IsDependent) +goto Return; + erichkeane wrote: > Oh, please don't do this. perhaps another way to do this if you want to avoid repeating the return expression would be a s

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); I am not really sure this is

[clang-tools-extra] 5c2072e - [clang-tidy] Fix docs.

Author: Viktoriia Bakalova Date: 2023-06-02T15:31:55Z New Revision: 5c2072e74b42d55e8bf7a9c8fee8800bad591f12 URL: https://github.com/llvm/llvm-project/commit/5c2072e74b42d55e8bf7a9c8fee8800bad591f12 DIFF: https://github.com/llvm/llvm-project/commit/5c2072e74b42d55e8bf7a9c8fee8800bad591f12.diff

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc28506ba4b69: [clang-tidy] Implement an include-cleaner check. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://revi

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] c28506b - [clang-tidy] Implement an include-cleaner check.

Author: Viktoriia Bakalova Date: 2023-06-02T15:21:20Z New Revision: c28506ba4b6961950849f8fdecd0cf7e503a14f9 URL: https://github.com/llvm/llvm-project/commit/c28506ba4b6961950849f8fdecd0cf7e503a14f9 DIFF: https://github.com/llvm/llvm-project/commit/c28506ba4b6961950849f8fdecd0cf7e503a14f9.diff

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per P1975R0 an expression like `static_cast(...)` defines the type of the expression as U[1]. Fixes https://github.com/

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527872. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-too

[PATCH] D152002: [clang][wip] Better handling of dependent lambda. This is an attempt to fix GH62916. However, it breaks GH57960 I seem unable to find something that works for both issues.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152002 Files: clang/lib/Sema/SemaTemplateInstantiate.c

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGcecd8471e499: [Clang][Parser] Accept GNU attributes preceding C++ attributes on templates (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D151837

[clang] cecd847 - [Clang][Parser] Accept GNU attributes preceding C++ attributes on templates

Author: Elizabeth Andrews Date: 2023-06-02T08:11:18-07:00 New Revision: cecd8471e4991b4bea5d2b38a3758cafdb1cbe29 URL: https://github.com/llvm/llvm-project/commit/cecd8471e4991b4bea5d2b38a3758cafdb1cbe29 DIFF: https://github.com/llvm/llvm-project/commit/cecd8471e4991b4bea5d2b38a3758cafdb1cbe29.d

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > This c

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a comment. In D149573#4390863 , @stuij wrote: > This is going to be a very unhelpful comment. After looking through the > changes, I don't have any comments to make, but I also don't feel comfortable > to accept this revision as I don't fe

[PATCH] D151632: [clang-format] Parse the Verilog language option in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG24231df9b8ef: [clang-format] Parse the Verilog language option in configuration (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151632/ne

[clang] 24231df - [clang-format] Parse the Verilog language option in configuration

Author: sstwcw Date: 2023-06-02T14:59:27Z New Revision: 24231df9b8ef560cc6d3c713d5dba1de703e2cb9 URL: https://github.com/llvm/llvm-project/commit/24231df9b8ef560cc6d3c713d5dba1de703e2cb9 DIFF: https://github.com/llvm/llvm-project/commit/24231df9b8ef560cc6d3c713d5dba1de703e2cb9.diff LOG: [clang

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > This checks the same thing in

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

stuij added a comment. This is going to be a very unhelpful comment. After looking through the changes, I don't have any comments to make, but I also don't feel comfortable to accept this revision as I don't feel to know enough about the front-end. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

Fznamznon added a comment. Nothing more from me, but I would wait for someone else's approval. Comment at: clang/lib/Sema/SemaExpr.cpp:18204 +const NamedDecl *ND = cast(DR->getDecl()); +if (const auto *MD = llvm::dyn_cast(ND); MD && (MD->isLambdaStaticInvoker()

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 527854. skatrak added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Update and remove OpenMP dialect dependency from the generic LLVM IR translation. Followed @kiranchandramohan's suggestion in the comments for D

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:956 // Determine whether the type argument is substitutable for the bound. if (typeArgObjC->isObjCIdType()) { // When the type argument is 'id', the only acceptable type e

  1   2   >