[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

MyDeveloperDay added a comment. What would happen in a \r\n example Comment at: clang/lib/Format/BreakableToken.cpp:207 + case 't': + case 'v': +AfterSpace = SplitPoint + 2; Are you testing \r \v \f Repository: rG LLVM Github Monorepo

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster abandoned this revision. ADKaster added a comment. In D154397#4470094 , @jrtc27 wrote: > This is pretty dodgy, I don't think it belongs upstream Fair enough, the original patch had "probably don't upstream this" in the commit description.

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. Now I think the feature may be important for the performance of modules. And I feel we should work on the ASTWriter side instead of ASTReader side. Since the size of BMIs is a problem now also it shows that it is not free to load the large BMIs. So while it is

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:3 + +// REQUIRES: riscv-registered-target + MaskRay wrote: > If you remove `all` and `RISCV` from `LLVM_TARGETS_TO_BUILD`, you can

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=riscv64 --print-supported-extensions 2>&1 | \ +// RUN: FileCheck %s --check-prefix=CHECK-RISCV + MaskRay wrote: > MaskRay wrote: > > Use

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 536947. 4vtomat marked 27 inline comments as done. 4vtomat added a comment. Herald added a subscriber: wangpc. Sorry for late update. Resolved MaskRay's comments, thanks for detailed review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

jrtc27 added a comment. This is pretty dodgy, I don't think it belongs upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154397/new/ https://reviews.llvm.org/D154397 ___ cfe-commits mailing list

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comment. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:732-735 UseSeparateSections))

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added a comment. Updated patch limited to changing the feature test macro value would match Varna meeting outcome (changes to allow macro to be `0` accepted as DR). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143670/new/

[PATCH] D153600: Implement -frecord-command-line for XCOFF

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2338 // Emit bytes for llvm.commandline metadata. - emitModuleCommandLines(M); + // The command line metadata waas emitted earlier on XCOFF. + if

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){}

[PATCH] D154401: [tools] Support building shared libLLVM and libClang for SerenityOS

ADKaster created this revision. Herald added subscribers: mstorsjo, fedor.sergeev. Herald added a project: All. ADKaster requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch tells CMake that the --whole-archive

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Force Clang use the initial-exec TLS model instead of the default local-exec when building code for Serenity.

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds support for the `$arch-pc-serenity` target to the Clang front end. This makes the compiler look for

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536920. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Thanks for the review @stephenpeckham, I updated the patch with the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/

[clang] 3f3620e - [clang-format] Correctly annotate */&/&& in operator function calls

Author: Owen Pan Date: 2023-07-03T17:49:10-07:00 New Revision: 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 URL: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 DIFF: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37.diff

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3620e5c9ee: [clang-format] Correctly annotate *// in operator function calls (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcff99b76ac4f: Add a flag to disable duplicate definition of category warnings (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] cff99b7 - Add a flag to disable "duplicate definition of category" warnings

Author: Akira Hatanaka Date: 2023-07-03T16:25:22-07:00 New Revision: cff99b76ac4f502ceba897a62db658667f1237f3 URL: https://github.com/llvm/llvm-project/commit/cff99b76ac4f502ceba897a62db658667f1237f3 DIFF:

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL added a comment. In D144347#4469770 , @ccotter wrote: > @PiotrZSL - checking back, do you plan to revisit this change soon (I think > there are some pending feedback and you planned some changes)? I'd like to > see this in change merged in.

[PATCH] D153600: Implement -frecord-command-line for XCOFF

stephenpeckham added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2338 // Emit bytes for llvm.commandline metadata. - emitModuleCommandLines(M); + if (!TM.getTargetTriple().isOSBinFormatXCOFF()) +emitModuleCommandLines(M); I

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35041a435def: [OPENMP52] Codegen support for doacross clause. (authored by jyu2). Changed prior to commit:

[clang] 35041a4 - [OPENMP52] Codegen support for doacross clause.

Author: Jennifer Yu Date: 2023-07-03T15:24:05-07:00 New Revision: 35041a435def860e2b1b99133b934632a9d634ac URL: https://github.com/llvm/llvm-project/commit/35041a435def860e2b1b99133b934632a9d634ac DIFF: https://github.com/llvm/llvm-project/commit/35041a435def860e2b1b99133b934632a9d634ac.diff

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. @PiotrZSL - checking back, do you plan to revisit this change soon (I think there are some pending feedback and you planned some changes)? I'd like to see this in change merged in. Let me know if I can help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. this LGTM, assuming D154329 is landed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536890. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added a comment. In D154180#4469417 , @ABataev wrote: > LG with a nit Thank you so much! Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536887. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index:

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + lamb-j wrote: > arsenm wrote: > > "on amdgpu target" doesn't sound grammatical > "for

[PATCH] D154388: Don't pass -ibuiltininc, which is used only by the driver, to CC1

ahatanak created this revision. ahatanak added reviewers: arphaman, fahad, MaskRay. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a fallout from 5b77e752dcd073846b89559d6c0e1a7699e58615

[clang] 4eef528 - [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

Author: Yaxun (Sam) Liu Date: 2023-07-03T16:19:25-04:00 New Revision: 4eef528853418fd72bffbb139d953520bb7b4c73 URL: https://github.com/llvm/llvm-project/commit/4eef528853418fd72bffbb139d953520bb7b4c73 DIFF:

[PATCH] D154385: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4eef52885341: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1 (authored by yaxunl). Herald added a project: clang. Repository:

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

shafik added a comment. Thank you or the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154334/new/ https://reviews.llvm.org/D154334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

garymm added a comment. Herald added subscribers: carlosgalvezp, mgehre. Herald added a project: All. @aaron.ballman what's remaining for this to be mergeable? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:2285-2297 +return (C->getDependencyKind() == OMPC_DEPEND_sink); + } + bool isSource(const

[PATCH] D154385: [HIP] Pass -fno-hip-fp32-correctly-rounded-divide-sqrt to clang -cc1

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, arsenm. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. `-fno-hip-fp32-correctly-rounded-divide-sqrt` affects clang codegen and should be passed to clang -cc1 by clang

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

benlangmuir added a comment. In D135849#4469347 , @jansvoboda11 wrote: > It'd be really nice to have DirectoryEntry::getDir() API, so that we can walk > up the directory hierarchy while preserving the virtual/real distinction > between directories in

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 added a comment. Okay, I'll try to figure out how expensive this would be. I'd like Clang to be stricter in situations like these, but if that's not feasible, I'll probably implement the first workaround. For the second workaround, I don't think that moves us in better direction -

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf created this revision. capfredf added a reviewer: v.g.vassilev. Herald added a project: All. capfredf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enabled users to use code completion in a REPL session. The solution

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. > It seems to me that maybe anything with OS none (although that doesn’t seem > to be distinguished from unknown) I considered splitting `none` from `unknown` in Triple, but never had the time to do it. I think this would be good for baremetal toolchains in light of

[PATCH] D154378: [LinkerWrapper] Set the GPU LTO job to be freestanding

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tianshilei1992. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11410 } else { -assert(C->getDependencyKind() == OMPC_DEPEND_sink); +assert(ODK.isSink(C)); RTLFn = OMPBuilder.getOrCreateRuntimeFunction(CGM.getModule(), ABataev

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536838. jyu2 added a comment. Thanks Alexey for the review!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A lambda call operator can be a templated entity - and therefore have constraints while not being a function template

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch adds additional printing of template argument list when the described function is

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11410 } else { -assert(C->getDependencyKind() == OMPC_DEPEND_sink); +assert(ODK.isSink(C)); RTLFn = OMPBuilder.getOrCreateRuntimeFunction(CGM.getModule(), Add a

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

benlangmuir added a comment. > You mean diagnosing whenever the spelling in the VFS definition differs from > its realpath? Right, this would be ideal, but may be too expensive in practice. > How could we make that work with symlinks in place? Ah right, we are intentionally allowing symlinks

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

This revision was automatically updated to reflect the committed changes. Closed by commit rGce2d44b0ab6d: [clang-tidy] Accessing checks not done for aliases of `std::array` (authored by sousajo, committed by PiotrZSL). Changed prior to commit:

[clang-tools-extra] ce2d44b - [clang-tidy] Accessing checks not done for aliases of `std::array`

Author: Jorge Pinto Sousa Date: 2023-07-03T16:43:08Z New Revision: ce2d44b0ab6da147931e9711e01d44a672ec3854 URL: https://github.com/llvm/llvm-project/commit/ce2d44b0ab6da147931e9711e01d44a672ec3854 DIFF: https://github.com/llvm/llvm-project/commit/ce2d44b0ab6da147931e9711e01d44a672ec3854.diff

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG2806cf4b5430: [clang-tidy] Fix width/precision argument order in modernize-use-std-print (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2806cf4 - [clang-tidy] Fix width/precision argument order in modernize-use-std-print

Author: Mike Crowe Date: 2023-07-03T16:39:04Z New Revision: 2806cf4b5430ad6d4d5aa2d501aea1de67272876 URL: https://github.com/llvm/llvm-project/commit/2806cf4b5430ad6d4d5aa2d501aea1de67272876 DIFF: https://github.com/llvm/llvm-project/commit/2806cf4b5430ad6d4d5aa2d501aea1de67272876.diff LOG:

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector> ArgRotates; + mikecrowe wrote: > PiotrZSL wrote: > > mikecrowe wrote: > > > PiotrZSL wrote: > > >

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 536802. yronglin added a comment. Address comment. - Change `EvaluateDependentExpr`. - Add more test for do/while/for/return/ctor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:986 + + // If there's no metadata, the length is 0. + if (MetadataSize == 0) { Handled the 0 length case here. CHANGES SINCE LAST ACTION

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked 6 inline comments as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1022 + if (PaddingSize) { +assert(PaddedSize - Index == WordSize); +std::array LastWord = {0}; I changed the assert that you requested

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11405-11406 + llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder(); + const OMPDependClause *DepC = dyn_cast(C); + const OMPDoacrossClause *DoC = dyn_cast(C); + if ((DoC &&

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536798. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536795. Jake-Egan added a comment. Thanks for the review @scott.linder. I applied the changes you requested with some differences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files:

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. In D153296#4468373 , @aaron.ballman wrote: > In D153296#4459769 , @yronglin > wrote: > >> Please help me, I have no better idea on this issue, do you have any better >> ideas?

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added a comment. this LGTM. thanks! Please, wait for approve from Jonas. I think someone from lldb needs to check whether new error reporting is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:378 + { {"core_3rd_gen_avx"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, 'S', true }, + { {"core-avx-i"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, '\0', false }, // Haswell

[PATCH] D154359: [clang] Reset FP options before template instantiation

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. AST nodes that may depend on FP options keep them as a difference relative to the options

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther created this revision. cwalther added reviewers: MaskRay, jroelofs. cwalther added projects: clang, PowerPC. Herald added subscribers: luismarques, steven.zhang, s.egerton, shchenz, abidh, PkmX, simoncook, asb, kristof.beyls, arichardson, nemanjai. Herald added a project: All. cwalther

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:67 /// Determine which headers should be inserted or removed from the main file. /// This exposes conclusions but not reasons: use lower-level walkUsed for

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added a comment. In D153881#4467127 , @aaron.ballman wrote: > I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but > separate `constexpr` out into its own warning flag, but I'm also not opposed. Would moving both const and

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9841daf27076: [clang][tooling] Fix early termination when there are nested expansions (authored by kadircet). Repository: rG LLVM Github Monorepo

[clang] 9841daf - [clang][tooling] Fix early termination when there are nested expansions

Author: Kadir Cetinkaya Date: 2023-07-03T16:58:04+02:00 New Revision: 9841daf27076886c6ab8e155eb812bda76f77532 URL: https://github.com/llvm/llvm-project/commit/9841daf27076886c6ab8e155eb812bda76f77532 DIFF:

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet updated this revision to Diff 536771. hazohelet edited the summary of this revision. hazohelet added a comment. - Removed the `base class inherited here` redundant note - Provided source range and added test for it The provided source range is NOT directly calling

[PATCH] D154349: [include-cleaner] Add a signal to down-rank exporting headers

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently exporter can have same relevance signals as the origin header

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-format.rst:6 + +Converts calls to ``absl::StrFormat`` to equivalent calls to C++20's +``std::format`` function, modifying the format string appropriately. The

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

ldionne added a comment. Herald added a subscriber: ekilmer. What is the status of this? We now require CMake 3.20, can this be rebased and landed in some form? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:116 - -// Now: how do we adjust the previous/next bounds? Three cases: -// A) If they are also part of the

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d4f2890823f: [clang] Add `__has_extension ()` for C++11 features (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 2d4f289 - [clang] Add `__has_extension ()` for C++11 features

Author: Mariya Podchishchaeva Date: 2023-07-03T10:15:40-04:00 New Revision: 2d4f2890823fa3edc6ae563edec4dacad1989564 URL: https://github.com/llvm/llvm-project/commit/2d4f2890823fa3edc6ae563edec4dacad1989564 DIFF:

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

aaron.ballman added a comment. In D154334#4468404 , @Fznamznon wrote: > In D154334#4468158 , @aaron.ballman > wrote: > >> Thank you for this! LGTM. but can you also be sure to update this table: >>

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon added a comment. In D154334#4468158 , @aaron.ballman wrote: > Thank you for this! LGTM. but can you also be sure to update this table: > https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429 Hmm, I

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo added a comment. while landing it, if someone feels that the release work can be reworded please feel free to do so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 ___ cfe-commits mailing

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D153296#4459769 , @yronglin wrote: > Please help me, I have no better idea on this issue, do you have any better > ideas?

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet updated this revision to Diff 536743. hazohelet edited the summary of this revision. hazohelet added a comment. Edited release note so that it only mentions the clang 16 -> 17 changes, and not development internal ones CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping. If no objections, I'll merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme marked 3 inline comments as done. mboehme added a comment. https://reviews.llvm.org/D154339 has changes in response to post-commit comments. Comment at: clang/include/clang/Analysis/FlowSensitive/RecordOps.h:26 +/// fields of record type. It also copies properties

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out this didn't need to be a template

[clang] d963420 - [Headers][X86] Ensure all AVX broadcast scalar load intrinsics are unaligned

Author: Simon Pilgrim Date: 2023-07-03T14:04:50+01:00 New Revision: d9634205d999439807a9f6c5a18be58ac1a55ced URL: https://github.com/llvm/llvm-project/commit/d9634205d999439807a9f6c5a18be58ac1a55ced DIFF: https://github.com/llvm/llvm-project/commit/d9634205d999439807a9f6c5a18be58ac1a55ced.diff

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; avl wrote: > probably, it would be better to add

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein updated this revision to Diff 536735. hokein marked an inline comment as done. hokein added a comment. address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 Files:

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; probably, it would be better to add error text here?

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1606 + CGOpenMPRuntimeGPU = + *(static_cast(())); + if (RT.isDelayedVariableLengthDecl(*this, )) { 1. use `static_cast(CGM.getOpenMPRuntime())` 2. It will crash if your

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11405-11406 + llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder(); + const OMPDependClause *DepC = dyn_cast(C); + const OMPDoacrossClause *DoC = dyn_cast(C); + if ((DoC &&

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for this! LGTM. but can you also be sure to update this table: https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e9145e43142: [clang][ExtractAPI] Add --emit-symbol-graph option (authored by Arsenic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8e9145e - [clang][ExtractAPI] Add --emit-symbol-graph option

Author: Ankur Date: 2023-07-03T17:32:30+05:30 New Revision: 8e9145e4314202b960dd883e6a7b21707ed5c176 URL: https://github.com/llvm/llvm-project/commit/8e9145e4314202b960dd883e6a7b21707ed5c176 DIFF: https://github.com/llvm/llvm-project/commit/8e9145e4314202b960dd883e6a7b21707ed5c176.diff LOG:

[PATCH] D154335: [clang][tooling] Fix early termination when there are nested expansions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This also does some

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon updated this revision to Diff 536715. Fznamznon added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154334/new/ https://reviews.llvm.org/D154334 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `__has_extension (cxx_defaulted_functions)` and `__has_extension (cxx_defaulted_functions)` since they are accepted

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG899c86779440: [clang-format] Fixed bad performance with enabled qualifier fixer. (authored by Sedeniono, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 899c867 - [clang-format] Fixed bad performance with enabled qualifier fixer.

Author: Sedenion Date: 2023-07-03T11:54:33+01:00 New Revision: 899c86779440dca84085fb53a1fbba6c5aa5a3b6 URL: https://github.com/llvm/llvm-project/commit/899c86779440dca84085fb53a1fbba6c5aa5a3b6 DIFF: https://github.com/llvm/llvm-project/commit/899c86779440dca84085fb53a1fbba6c5aa5a3b6.diff

  1   2   >