[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616 _

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One existing problem is that we can't do much with the

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this due to circular deps. `clangAnalysis` should not depend on `clangSema`. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.

[clang] ba7273b - Reformat

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: ba7273b02577236fbbca53554bafc6c22d7dd4c9 URL: https://github.com/llvm/llvm-project/commit/ba7273b02577236fbbca53554bafc6c22d7dd4c9 DIFF: https://github.com/llvm/llvm-project/commit/ba7273b02577236fbbca53554bafc6c22d7dd4c9.dif

[clang] c915908 - Revert D150338, "[-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute"

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: c915908f6d6946151b17eae00c7f093e6f37c677 URL: https://github.com/llvm/llvm-project/commit/c915908f6d6946151b17eae00c7f093e6f37c677 DIFF: https://github.com/llvm/llvm-project/commit/c915908f6d6946151b17eae00c7f093e6f37c677.dif

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 updated this revision to Diff 540627. strimo378 added a comment. Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 Files: clang/lib/AST/DeclPrinter.cpp clang/test/AST/ast-pri

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

SuperSodaSea updated this revision to Diff 540621. SuperSodaSea retitled this revision from "Fix some typos in comments: evalute -> evaluate" to "Fix some typos in comments: evalute -> evaluate (NFC)". SuperSodaSea added a comment. Update patch CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 143e2c2 - [RISCV] Split clmul/clmulh/clmulr builtins into _32 and _64 versions.

Author: Craig Topper Date: 2023-07-14T19:09:15-07:00 New Revision: 143e2c2ac03cbcce290a9f14b0d667bf0f793280 URL: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280 DIFF: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280.diff

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

[PATCH] D155337: [CMake] Include riscv32-unknown-elf target in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. It would be a better summary to say "include ... runtimes ...". Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:10 set(_FUCHSIA_ENABLE_PROJECTS "bolt;clang;clang-too

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K == tok:

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 540600. RIscRIpt marked 17 inline comments as done. RIscRIpt added a comment. Addressed review comments, rebased onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D1

[clang] 232ce90 - [OpenMP][FIX] Adjust "known" attributes for runtime functions

Author: Johannes Doerfert Date: 2023-07-14T17:01:48-07:00 New Revision: 232ce90541fe1bd1aa96319b36d8fe5b5344a52b URL: https://github.com/llvm/llvm-project/commit/232ce90541fe1bd1aa96319b36d8fe5b5344a52b DIFF: https://github.com/llvm/llvm-project/commit/232ce90541fe1bd1aa96319b36d8fe5b5344a52b.d

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:136-139 +- Implemented `P2169R4: A nice placeholder with no name `_. This allows using `_` + as a variable name multiple times in the same scope and is supported in

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:56 def BPFNoALU32 : Predicate<"!Subtarget->getHasAlu32()">; +def BPFHasCPUv4_ldsx : Predicate<"Subtarget->getCPUv4_ldsx()">; +def BPFHasCPUv4_movsx : Predicate<"Subtarget->getCPUv4_movsx()">; --

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:794 + // [-Wc++20-extensions] + LabelDecl *TL = TargetLabel; + // Is TargetLabel one of the targets of the JumpStmt? If not, then skip Just wonder why not just use TargetLab

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 accepted this revision. jyu2 added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9ef33e1d8a8: [Clang] Fix crash when emitting diagnostic for out of order designated… (authored by shafik). Herald added a project: clang. Repositor

[clang] c9ef33e - [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

Author: Shafik Yaghmour Date: 2023-07-14T15:57:51-07:00 New Revision: c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257 URL: https://github.com/llvm/llvm-project/commit/c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257 DIFF: https://github.com/llvm/llvm-project/commit/c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257.dif

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik updated this revision to Diff 540587. shafik marked 2 inline comments as done. shafik added a comment. - Add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.c

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm closed this revision. arsenm added a comment. bac2a075408377a8aa41f6626b17bb3e471221f3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 __

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540586. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reword commit msg one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.

[clang] bac2a07 - clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

Author: Matt Arsenault Date: 2023-07-14T18:46:18-04:00 New Revision: bac2a075408377a8aa41f6626b17bb3e471221f3 URL: https://github.com/llvm/llvm-project/commit/bac2a075408377a8aa41f6626b17bb3e471221f3 DIFF: https://github.com/llvm/llvm-project/commit/bac2a075408377a8aa41f6626b17bb3e471221f3.diff

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540585. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reword description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540584. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 Files: clang/lib/Sema/JumpDiagnostics.cpp clang/test/Sem

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9115f18de906: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17 (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[clang] 9115f18 - [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

Author: Nick Desaulniers Date: 2023-07-14T15:20:08-07:00 New Revision: 9115f18de90611d42147838e53bd8e37f206b744 URL: https://github.com/llvm/llvm-project/commit/9115f18de90611d42147838e53bd8e37f206b744 DIFF: https://github.com/llvm/llvm-project/commit/9115f18de90611d42147838e53bd8e37f206b744.di

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540574. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - add link to CBL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise we observe false positive warnings claiming that an asm goto cannot jump to another label in a dif

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

cjdb added a comment. Sorry, forgot to come back and LGTM, but it did indeed LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153623/new/ https://reviews.llvm.org/D153623 ___ cfe-commits mailing list

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

benlangmuir added a comment. > I took a look at the code and it looks to me like it would be safe to change > ModuleMap::canonicalizeModuleMapPath() to use a drive preserving > canonicalization This sounds reasonable to me (the person who added canonicalizeModuleMapPath), though I am not at al

[PATCH] D155339: Enable zba and zbs for riscv android

hiraditya created this revision. hiraditya added reviewers: enh, pirama, srhines. Herald added subscribers: luke, VincentWu, danielkiss, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b012bf5ab5f: [-Wunsafe-buffer-usage] Improving insertion of the [[clang… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5b012bf - [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

Author: ziqingluo-90 Date: 2023-07-14T14:47:07-07:00 New Revision: 5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3 URL: https://github.com/llvm/llvm-project/commit/5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3 DIFF: https://github.com/llvm/llvm-project/commit/5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3.diff

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. >> In D154130#4486898 , @tahonermann >> wrote: >> >>> 95% of the %>t are around clang modulemap files, because that code resolves >>> real paths in C++ by design, so I can't avoid it. >> >> Can you link to evidence that this

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.h:231 /// Used e.g. to break like: + /// \code /// functionCall(Parameter, otherCall( Unrelated. Comment at: clang/lib/Format/ContinuationIndenter.h:234

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. Hi Joe, it's nice to see multilib.yaml getting some adoption :) > For the RISCVMultilibFlags, the mabi flag is used in combination with all the > march extension features (e.g +m). Notably, this doesn't align with the > current arm/aarch64 multilib flags, which

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + keryell wrote: > I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not > understand

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers updated this revision to Diff 540561. nickdesaulniers added a comment. This revision is now accepted and ready to land. - better identifiers, use llvm::DenseMap::contains Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155336/new/ htt

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:740-741 unsigned IGScope = LabelAndGotoScopes[IG]; Stmt *&Entry = JumpScopesMap[IGScope]; if (!Entry) Entry = IG; } --

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not understand "portable applicat

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540559. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Revise tests + update summary - Add driver tests for -S - Add codegen tests for -S - Test Unified LTO codegen - Use -fdriver-only t

[clang] b9f1df7 - Revert "[UTC] Add fallback support for specific metadata, and check their defs"

Author: Johannes Doerfert Date: 2023-07-14T13:53:37-07:00 New Revision: b9f1df7a04d7a3169623e437597aa4b32d99d8b3 URL: https://github.com/llvm/llvm-project/commit/b9f1df7a04d7a3169623e437597aa4b32d99d8b3 DIFF: https://github.com/llvm/llvm-project/commit/b9f1df7a04d7a3169623e437597aa4b32d99d8b3.d

[clang] 5b8b9b3 - Revert "[UTC] Adapt version matcher to glob CLANG_VENDOR"

Author: Johannes Doerfert Date: 2023-07-14T13:53:36-07:00 New Revision: 5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72 URL: https://github.com/llvm/llvm-project/commit/5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72 DIFF: https://github.com/llvm/llvm-project/commit/5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72.d

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay added a comment. In D154923#4491673 , @MaskRay wrote: > In D154923#4491411 , @efriedma > wrote: > >> If I follow correctly, this is basically undoing the splitting that was done >> by the command that pr

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155336/new/ https://reviews.llvm.org/D155336

[PATCH] D155337: [CMake] Include riscv32-unknown-elf target in Fuchsia toolchain

phosek created this revision. Herald added subscribers: ekilmer, VincentWu, abrachet, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. phosek requested review of this revision. Herald added subsc

[PATCH] D155335: Revert 245d10b7a2c12ec25e7b5860a38c61991543a739

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9543f7de697: Revert "[clang][Interp][NFC] Trim Source.h includes"

[clang] b9543f7 - Revert "[clang][Interp][NFC] Trim Source.h includes"

Author: Sterling Augustine Date: 2023-07-14T13:34:26-07:00 New Revision: b9543f7de69770a97e983452c5158acc3b4783c7 URL: https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7 DIFF: https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7.

[PATCH] D155335: Replace forward-declarations with proper headers for Decl and Stmt

saugustine updated this revision to Diff 540552. saugustine added a comment. Switch to pure revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155335/new/ https://reviews.llvm.org/D155335 Files: clang/lib/AST/Interp/Source.h Index: clang/li

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. I would appreciate help with moving this code review forwards. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the code to more modern C++ style. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D155335: This fixes an issue with 245d10b7a2c12ec25e7b5860a38c61991543a739, where on slightly older versions of clang, we get the below error and several others similar.

saugustine created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. saugustine requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In file included from .../clang/lib/AST/Interp/Source.h:17: In file included fro

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 updated this revision to Diff 540548. ziqingluo-90 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150338/new/ https://reviews.llvm.org/D150338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferUsage.c

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. In D154130#4502036 , @MrTrillian wrote: > In D154130#4487292 , @jdenny wrote: > >> 3. Extend lit's own test suite to cover it. > > I submitted an update with your suggestions #1 and #2 but

[PATCH] D155326: [Clang][lld][RISCV] Passing 'mattr' to lld/llvmgold

craig.topper added a comment. In D155326#4502097 , @dtcxzyw wrote: > In D155326#4501997 , @jrtc27 wrote: > >> Why do you believe this is better than encoding it in the module's IR like >> the ABI? > > > > - There

[PATCH] D155326: [Clang][lld][RISCV] Passing 'mattr' to lld/llvmgold

craig.topper added a comment. -mattr is a different syntax than -march that users are used to. Why would we want to expose that? There was previously a proposal for doing this automatically https://reviews.llvm.org/D132843 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D155326: [Clang][lld][RISCV] Passing 'mattr' to lld/llvmgold

dtcxzyw added a comment. In D155326#4501997 , @jrtc27 wrote: > Why do you believe this is better than encoding it in the module's IR like > the ABI? - There is no module-level metadata for target CPU and sub-target features. So I just think that this

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. In D154357#4500241 , @cwalther wrote: > Thank you! > > So I guess next time I submit a patch here (nothing planned at the moment), I > should put the proposed commit message into the summary field and the > backstory and start o

[clang] 7a59e2c - [clang][NFC] Remove trailing whitespace from riscv_vector.td

Author: Nikolas Klauser Date: 2023-07-14T12:38:29-07:00 New Revision: 7a59e2c59187fc76e39b0e4d5bfd13a0a5144c44 URL: https://github.com/llvm/llvm-project/commit/7a59e2c59187fc76e39b0e4d5bfd13a0a5144c44 DIFF: https://github.com/llvm/llvm-project/commit/7a59e2c59187fc76e39b0e4d5bfd13a0a5144c44.dif

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. In D154130#4487292 , @jdenny wrote: > 3. Extend lit's own test suite to cover it. I submitted an update with your suggestions #1 and #2 but this #3 is much more difficult because of the nature of `%{t:real}`. I'm not sure I c

[PATCH] D155326: [Clang][lld][RISCV] Passing 'mattr' to lld/llvmgold

jrtc27 added a comment. Why do you believe this is better than encoding it in the module's IR like the ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155326/new/ https://reviews.llvm.org/D155326 ___

[PATCH] D155326: [Clang][lld][RISCV] Passing 'mattr' to lld/llvmgold

dtcxzyw created this revision. dtcxzyw added reviewers: MaskRay, jrtc27, kito-cheng, craig.topper. dtcxzyw added projects: lld, clang. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, simoncook, arichards

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:118-120 +def ext_concat_predef_ms : ExtWarn< + "concatenation of predefined identifier '

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

davidxl added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:795 - /* When PNS >= OldPNS, the last one wins. */ - if (!FilenamePat || parseFilenamePattern(FilenamePat, CopyFilenamePat)) resetFilenameToDefault(); what is this chan

[PATCH] D155321: [clang][Analysis] ExprMutationAnalyzer: break infinite recursion on recursive function call

danix800 created this revision. danix800 added a reviewer: shuaiwang. danix800 added projects: clang, clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added

[clang] df71216 - [RISCV] Make __builtin_riscv_clz/ctz return an unsigned int instead of signed int.

Author: Craig Topper Date: 2023-07-14T11:13:47-07:00 New Revision: df71216d0301780de9dfc467745dd10843de4400 URL: https://github.com/llvm/llvm-project/commit/df71216d0301780de9dfc467745dd10843de4400 DIFF: https://github.com/llvm/llvm-project/commit/df71216d0301780de9dfc467745dd10843de4400.diff

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, arsenm wrote: >

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 540492. jaredgrubb added a comment. Rebased (no other updates) to re-run build and hopefully get some eyes on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 Files: clang/docs/ClangFormatStyleOp

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, scchan wrote: > arsenm wrote: > > Can we avoid adding ye

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +ConditionVar->s

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

scchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, arsenm wrote: > Can we avoid adding yet another language

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 __

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. This looks reasonable to me now. I'll wait next week before approving it so other get a chance to look at it :) Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // tha

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet updated this revision to Diff 540486. hazohelet added a comment. Uses `FunctionDecl::getNameForDiagnostic` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp clang/

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

jaredgrubb updated this revision to Diff 540488. jaredgrubb marked an inline comment as done. jaredgrubb added a comment. Address review comment and rebase to re-run tests. Intend to merge if everything is green! (If there are further comments, I will commit to address them!) CHANGES SINCE LAS

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

jaredgrubb marked 2 inline comments as done. jaredgrubb added inline comments. Herald added a subscriber: wangpc. Herald added a reviewer: rymiel. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1779-1782 nextToken(); +// Return types: pointers are ok too. +

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 540485. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/H

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + arsenm wrote: > Aren't you supposed to use clang++? Also, could show that .hip is recog

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, Can we avoid adding yet another language flag for someth

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 540481. scchan added a comment. added extra checks for not host, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp clang/t

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +ConditionVar->s

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + Aren't you supposed to use clang++? Also, could show that .hip is recognized? CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added a comment. I found further issues with aggregates, I think not supporting aggregates for now would be fine, the high bit is to fix the regressions I did add some more info there https://github.com/cplusplus/CWG/issues/354#issuecomment-1636129255 Repository: rG LLVM Github Mon

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 540479. hazohelet marked 6 inline comments as done. hazohelet added a comment. Address comments from Aaron and Corentin - Call `ConditionVar->setReferenced(false)` without any checks - Added some more tests CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 540477. jaredgrubb added a comment. Rebased and added a line to Release Notes, no other changes. Have requested this to be merged if all builds are green (since this patch has been approved). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/n

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

craig.topper added a comment. > @craig.topper Just to make sure, are you okay with me 'commandeering' this > change and updating it? Yes. Thanks for taking it on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://reviews.llvm.org/D86310

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/test/CodeGen/embed-fat-lto-objects.c:3 +// RUN: %clang -cc1 -triple x86_64-unknown-linux-gnu -flto=full -ffat-lto-objects -emit-llvm < %s | FileCheck %s --check-prefixes=FULL,SPLIT + +// RUN: %clang -cc1 -triple x86_64-unknown-li

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4733 + types::ID Output; + if (Args.hasArg(options::OPT_S)) +Output = types::TY_LTO_IR; MaskRay wrote: > This part is not tested. oh, feel free to disregard my Q about `-S

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG563a23c824db: [clang][Sema] Add fixit for scoped enum format error (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D153622: [clang][Sema] Suggest static_cast in C++ code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c0a136ce4b7: [clang][Sema] Suggest static_cast in C++ code (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] 563a23c - [clang][Sema] Add fixit for scoped enum format error

Author: Alex Brachet Date: 2023-07-14T16:23:22Z New Revision: 563a23c824db22da3ea378e8179fcc7072e897ec URL: https://github.com/llvm/llvm-project/commit/563a23c824db22da3ea378e8179fcc7072e897ec DIFF: https://github.com/llvm/llvm-project/commit/563a23c824db22da3ea378e8179fcc7072e897ec.diff LOG:

[clang] 3c0a136 - [clang][Sema] Suggest static_cast in C++ code

Author: Alex Brachet Date: 2023-07-14T16:22:06Z New Revision: 3c0a136ce4b724221a7f75b656b9f7af3de6b64c URL: https://github.com/llvm/llvm-project/commit/3c0a136ce4b724221a7f75b656b9f7af3de6b64c DIFF: https://github.com/llvm/llvm-project/commit/3c0a136ce4b724221a7f75b656b9f7af3de6b64c.diff LOG:

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4499608 , @MaskRay wrote: > Thanks for the update. Can you add a comment for the `-funified-lto` > combination? It's unclear what it does... ugh, I had put comments above each compiler invocation, but forgot that

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:16 +// Sized deallocation was added in macOS 10.12 and aligned OSes. +// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. In D86310#4501240 , @rnk wrote: > In D86310#4501170 , @hvdijk wrote: > >> For example, it would generally be better if long double were >> 8-byte-aligned, but the x86 32-bit ABI specifies th

  1   2   >