arsenm added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf<hip.KeyPath>; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, ---------------- scchan wrote: > arsenm wrote: > > Can we avoid adding yet another language flag for something that's reusable > > for everything? Is there an --offload-<something> ? > Don't we need a different default value for some languages like OpenCL? Yes, but opencl already has a spec'd flag for this. If we're making up a new one, it could be something generic that aliases the opencl one in that case. Plus the +/- value of a new flag should work (the CL one only goes in one direction) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155213/new/ https://reviews.llvm.org/D155213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
