[PATCH] D156027: [clang][Interp] Rework how initializers work

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 543255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Context.cpp Index: clang/lib/AST/Int

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:764-768 +#if defined(USE_CONSTEVAL) && !defined(NEW_INTERP) static_assert(test_init_capture() == __LINE__ - 4); #else static_assert(test_init_capture() == __LINE__ ); #endif The

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As requested. This depends on a few other patches tho

[PATCH] D154903: clangd: Provide the resource dir via environment variable

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. D156044 attempts to have clangd always exclude the builtin headers when querying the driver. Would be great to know if this fixes your problem. (But if you're not in a position to try a patch like that, filtering the path out in your

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 543253. sammccall added a comment. remove (broken) support for -nobuiltininc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 Files: clang-tools-extra/clangd/Syste

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, madscientist. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. @cor3ntin Ok, I need... - https://reviews.llvm.org/D155707 - https://reviews.llvm.org/D156027 - https://reviews.llvm.org/D156042 to enable the existing tests with at least one of the RUN lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 543249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. This patch is missing the `Ret` part in `InterpBuiltin()` in the same file. That needs to change to the correct type as well. I can do that in a follow-up commit. @aaron.ballman Can you come up with a value I can pass to `-triple` so I can actually test that this works?

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Farid Zakaria via Phabricator via cfe-commits
fzakaria added a comment. Changed to the if condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155857/new/ https://reviews.llvm.org/D155857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Farid Zakaria via Phabricator via cfe-commits
fzakaria updated this revision to Diff 543244. fzakaria added a comment. The previous CMake variable wasn't working. Changed it to the pattern I see in the codebase. Confirmed it via `ninja` command and grepping. ❯ rg --color=always no-nonnull build.ninja | head -n 1 FLAGS = -fPIC -fno-sem

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

2023-07-22 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. Wanted to point out that there is a clang-tidy check in review doing the similar thing - https://reviews.llvm.org/D144429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142800/new/ https://reviews.llvm.org/D142800 ___

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Farid Zakaria via Phabricator via cfe-commits
fzakaria added a comment. Ugh you are right. So weird -- This works: if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") append("-Wno-nonnull" CMAKE_CXX_FLAGS) endif() I read the CMake documentation and it looked like the variable I used should have worked. https://cmake.org/cmake/help/latest/va

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D155857#4525421 , @fzakaria wrote: > Address feedback from maskray@ > > - imperative comment > - switch to CMAKE_GNU_COMPILER_ID for variable Does `append_if(CMAKE_GNU_COMPILER_ID "-Wno-nonnull" CMAKE_CXX_FLAGS)` work? `build

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Farid Zakaria via Phabricator via cfe-commits
fzakaria marked an inline comment as done. fzakaria added a comment. @MaskRay thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155857/new/ https://reviews.llvm.org/D155857 ___ cfe-com

[PATCH] D155857: [clang] fix nonnull warnings during build

2023-07-22 Thread Farid Zakaria via Phabricator via cfe-commits
fzakaria updated this revision to Diff 543238. fzakaria added a comment. Address feedback from maskray@ - imperative comment - switch to CMAKE_GNU_COMPILER_ID for variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155857/new/ https://reviews.l

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

2023-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. @lukasza I think you forgot to upload an updated version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 ___ cfe-commi

[PATCH] D138499: [clangd] Extract Function: add hoisting support

2023-07-22 Thread Julian Schmidt via Phabricator via cfe-commits
5chmidti requested review of this revision. 5chmidti added a comment. Never mind, the problem is unrelated to this patch. Filed clangd issue #1710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/n

[PATCH] D154903: clangd: Provide the resource dir via environment variable

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. TL;DR: can you try just excluding GCC's resource dir, rather than replacing it with clang's? I think that might solve your problem, and is probably something we should be doing automatically. In D154903#4525329 , @madscientist

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

2023-07-22 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. In D154696#4525254 , @cor3ntin wrote: > Can you let me know what the linux folks think? Thanks a lot! Sure thing, you should be able to follow along on the web as well: https://lore.kernel.org/2023070637.GA138486@dev-ar

[clang] e6a9b06 - [CodeGen] Stabilize C2/D2 to C1/D1 replacement order

2023-07-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-07-22T15:29:38-07:00 New Revision: e6a9b06dc0b974eb16186a71099b88a631afdf52 URL: https://github.com/llvm/llvm-project/commit/e6a9b06dc0b974eb16186a71099b88a631afdf52 DIFF: https://github.com/llvm/llvm-project/commit/e6a9b06dc0b974eb16186a71099b88a631afdf52.diff

[PATCH] D154903: clangd: Provide the resource dir via environment variable

2023-07-22 Thread Paul Smith via Phabricator via cfe-commits
madscientist added a comment. Sorry for the delay in replying. I'll try to respond to the various points you made: - I don't quite understand the first bullet, "more ways to initialize the resource dir". As far as I can see there's only one place it's set. If my change is using a "non-offic

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

2023-07-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D154696#4525100 , @nathanchance wrote: > The error added by this patch triggers on some recently added code to the > Linux kernel's -next tree, which I failed to test above due to its generally > unstable nature: > > driv

[PATCH] D138499: [clangd] Extract Function: add hoisting support

2023-07-22 Thread Julian Schmidt via Phabricator via cfe-commits
5chmidti planned changes to this revision. 5chmidti added a comment. I found a new issue. I'll probably fix it by next weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e325081192b: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload` (authored by Izaron, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] 0e32508 - [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

2023-07-22 Thread Piotr Zegar via cfe-commits
Author: Evgeny Shulgin Date: 2023-07-22T19:46:31Z New Revision: 0e325081192be951a9d54bb246ef030c37bffd21 URL: https://github.com/llvm/llvm-project/commit/0e325081192be951a9d54bb246ef030c37bffd21 DIFF: https://github.com/llvm/llvm-project/commit/0e325081192be951a9d54bb246ef030c37bffd21.diff LOG

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9644368f974a: [clang-tidy] Fix checks filter with warnings-as-errors (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D146520?vs=543185&id=543222#toc Repository: rG LLVM Gith

[clang-tools-extra] 9644368 - [clang-tidy] Fix checks filter with warnings-as-errors

2023-07-22 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-22T19:31:51Z New Revision: 9644368f974a095472832bbf9cd475ef5c2c307f URL: https://github.com/llvm/llvm-project/commit/9644368f974a095472832bbf9cd475ef5c2c307f DIFF: https://github.com/llvm/llvm-project/commit/9644368f974a095472832bbf9cd475ef5c2c307f.diff LOG: [

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

2023-07-22 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok created this revision. Herald added a project: All. MitalAshok updated this revision to Diff 543217. MitalAshok added a comment. MitalAshok edited the summary of this revision. MitalAshok added a reviewer: rsmith. MitalAshok published this revision for review. Herald added a project: cla

[PATCH] D156031: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5b75bfd4d4: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1560

[clang-tools-extra] 5b5b75b - [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

2023-07-22 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-22T19:24:54Z New Revision: 5b5b75bfd4d469d56db7980c578214c26288faa9 URL: https://github.com/llvm/llvm-project/commit/5b5b75bfd4d469d56db7980c578214c26288faa9 DIFF: https://github.com/llvm/llvm-project/commit/5b5b75bfd4d469d56db7980c578214c26288faa9.diff LOG: [

[clang-tools-extra] 0f1f1d4 - [clang-tidy][NFC] Fix links in cppcoreguidelines module

2023-07-22 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-22T19:23:06Z New Revision: 0f1f1d45c9f77bf5d8e5dce32551b7c78772b8a6 URL: https://github.com/llvm/llvm-project/commit/0f1f1d45c9f77bf5d8e5dce32551b7c78772b8a6 DIFF: https://github.com/llvm/llvm-project/commit/0f1f1d45c9f77bf5d8e5dce32551b7c78772b8a6.diff LOG: [

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

2023-07-22 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. I have opened a refactoring ticket here: https://github.com/llvm/llvm-project/issues/64037 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 _

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 543212. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D156031: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

2023-07-22 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156031/new/ https://reviews.llvm.org/D156031

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

2023-07-22 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. The error added by this patch triggers on some recently added code to the Linux kernel's -next tree, which I failed to test above due to its generally unstable nature: drivers/gpu/drm/tests/drm_exec_test.c:41:3: error: cannot jump from this indirect goto stateme

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL updated this revision to Diff 543206. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. rebase, add release notes, move tests to separate file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://reviews.

[PATCH] D156031: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commi

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

2023-07-22 Thread Nikolas Klauser via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG874217f99b99: [clang] Enable C++11-style attributes in all language modes (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 874217f - [clang] Enable C++11-style attributes in all language modes

2023-07-22 Thread Nikolas Klauser via cfe-commits
Author: Nikolas Klauser Date: 2023-07-22T09:34:15-07:00 New Revision: 874217f99b99ab3c9026dc3b7bd84cd2beebde6e URL: https://github.com/llvm/llvm-project/commit/874217f99b99ab3c9026dc3b7bd84cd2beebde6e DIFF: https://github.com/llvm/llvm-project/commit/874217f99b99ab3c9026dc3b7bd84cd2beebde6e.dif

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

2023-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 543200. MaskRay added a comment. Herald added a subscriber: wenlei. bump version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/ https://reviews.llvm.org/D155992 Files: clang-tools-extra/clangd/Sou

[PATCH] D156024: [clang-tidy] Add --disable-modular-headers-expansion option

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL updated this revision to Diff 543199. PiotrZSL added a comment. Code formating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156024/new/ https://reviews.llvm.org/D156024 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-ex

[clang-tools-extra] 1d0759e - [clang-tidy][NFC] Fix list.rst generation when adding check

2023-07-22 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-22T15:55:22Z New Revision: 1d0759e6c3c2eaa8cbacfd76d409ed80ffd9fe9d URL: https://github.com/llvm/llvm-project/commit/1d0759e6c3c2eaa8cbacfd76d409ed80ffd9fe9d DIFF: https://github.com/llvm/llvm-project/commit/1d0759e6c3c2eaa8cbacfd76d409ed80ffd9fe9d.diff LOG: [

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL updated this revision to Diff 543196. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase + Update diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-07-22 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet updated this revision to Diff 543189. hazohelet marked 3 inline comments as done. hazohelet edited the summary of this revision. hazohelet added a comment. Address comments from Corentin - NFC stylistic changes - Bring back narrowing warning on constexpr variables to avoid regression -

[clang] 910450a - [NFC][clang] Fixes whitespace.

2023-07-22 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2023-07-22T16:50:58+02:00 New Revision: 910450a28ba9ce5ad67ff62d5cbb4fa81d567aac URL: https://github.com/llvm/llvm-project/commit/910450a28ba9ce5ad67ff62d5cbb4fa81d567aac DIFF: https://github.com/llvm/llvm-project/commit/910450a28ba9ce5ad67ff62d5cbb4fa81d567aac.diff

[PATCH] D156027: [clang][Interp] Rework how initializers work

2023-07-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, we had `visitRecordInitializer()` a

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-22 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D144135#4524902 , @PiotrZSL wrote: > @Eugene.Zelenko I cannot review/accept my own patch :(. I'm sorry for noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL marked an inline comment as done. PiotrZSL added a comment. @Eugene.Zelenko I cannot review/accept my own patch :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-22 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. This LGTM, but can't officially accept the patch so please wait for another reviewer to accept it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL updated this revision to Diff 543185. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Add test & release notes. Cleanup commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.l

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. These hashes are used in the filenames of index shards, and in the metadata describing dependencies between shards. So this is an incompatible change to indexing format, you also need to increment `constexpr static uint32_t Version` in Serialization.cpp:460. (I think

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

2023-07-22 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok marked an inline comment as done. MitalAshok added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13323 // If this is an init-capture pack, consider expanding the pack now. if (OldVD->isParameterPack()) { shafik wrote: > Based

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

2023-07-22 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok updated this revision to Diff 543183. MitalAshok edited the summary of this revision. MitalAshok added a comment. Added entry to changelog and the test from the bug report Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https:/

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

2023-07-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512, FeatureAMXCOMPLEX];

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

2023-07-22 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 9b2dfff57a382b757c358b43ee1df7591cb480ee CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155982/new/ https://reviews.llvm.org/D155982 __

[clang] 9b2dfff - Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

2023-07-22 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-07-22T08:07:50-04:00 New Revision: 9b2dfff57a382b757c358b43ee1df7591cb480ee URL: https://github.com/llvm/llvm-project/commit/9b2dfff57a382b757c358b43ee1df7591cb480ee DIFF: https://github.com/llvm/llvm-project/commit/9b2dfff57a382b757c358b43ee1df7591cb480ee.diff

[PATCH] D156024: [clang-tidy] Add --disable-modular-headers-expansion option

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Experimental option: Di

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

2023-07-22 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a subscriber: alexfh. v.g.vassilev added a comment. @alexfh, could you test that patch on your internal infrastructure and check if it actually decreases the memory footprint and/or compile times? I believe this was the only blocker to land it as it is. CHANGES SINCE LAST AC

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

2023-07-22 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. In D154324#4524368 , @rsmith wrote: > In D154324#4524235 , @v.g.vassilev > wrote: > >> @rsmith, thanks for the suggestions! Could you go over >> `ODRHash::AddTemplateName` suggest h

[PATCH] D154931: [LoongArch] Support InlineAsm for LSX and LASX

2023-07-22 Thread 陈荔 via Phabricator via cfe-commits
leecheechen updated this revision to Diff 543155. leecheechen added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154931/new/ https://reviews.llvm.org/D154931 Files: clang/lib/Basic/Targets/LoongArch.cp

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-07-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D155064#4523024 , @hazohelet wrote: > In D155064#4514893 , @cor3ntin > wrote: > >> This looks good to me modulo nitpicks. >> When you land that, please make an issue on github for th

[PATCH] D155321: [clang][Analysis] ExprMutationAnalyzer: break infinite recursion on recursive function call

2023-07-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ExprMutationAnalyzer.h:31 +if (nullptr == DeclAnalyzed) { + OwningDeclAnalyzed = std::make_unique(); + this->DeclAnalyzed = OwningDeclAnalyzed.get(); NOTE: This memory

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

2023-07-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. FWIW, I think we can use a shorter name `AlignConsecutiveCaseStatements` instead of `AlignConsecutiveShortCaseStatements`. Comment at: clang/lib/Format/WhitespaceManager.cpp:854 + return C.Tok->is(TT_CaseLabelColon); +} else { + // Ignore