MaskRay added a comment.

In D155857#4525421 <https://reviews.llvm.org/D155857#4525421>, @fzakaria wrote:

> Address feedback from maskray@
>
> - imperative comment
> - switch to CMAKE_GNU_COMPILER_ID for variable

Does `append_if(CMAKE_GNU_COMPILER_ID "-Wno-nonnull" CMAKE_CXX_FLAGS)` work? 
`build.ninja` with a GCC doesn't have `-Wno-nonnull`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155857/new/

https://reviews.llvm.org/D155857

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to