[PATCH] D156178: [HLSL] add pow library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5137e984a6: [HLSL] add pow library function (authored by bob80905). Changed prior to commit:

[clang] df5137e - [HLSL] add pow library function

Author: Joshua Batista Date: 2023-08-08T13:07:36-07:00 New Revision: df5137e984a607248cd31ed67aa3822e8ac2a083 URL: https://github.com/llvm/llvm-project/commit/df5137e984a607248cd31ed67aa3822e8ac2a083 DIFF:

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small formatting nit. Comment at: clang/lib/Analysis/BodyFarm.cpp:809 Prop = MD->findPropertyDecl(); -IVar = findBackingIvar(Prop); +

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4570513 , @vitalybuka wrote: > This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 > Not sure what is wrong there, probably the test need to be updated. Can you > please take a look?

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Not sure what is wrong there, probably the test need to be updated. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569967 , @vitalybuka wrote: > In D157119#4569725 , @jroelofs > wrote: > >> Flaky test? Here's a later build where it succeeds, but the change has >> nothing to do with

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo added a comment. In D157332#4570290 , @crtrott wrote: > Question: does this bug potentially affect code generation for > AMD/NVIDIA/Intel GPUs? I believe the easiest way to test that is to try compiling `struct S {}; S ret() { return S(); }`

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL added a comment. Missing release notes, except that looks fine. What about switchStmt ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 ___

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews requested review of this

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff created this revision. fwolff added reviewers: PiotrZSL, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

RKSimon added reviewers: erichkeane, aaron.ballman. RKSimon added a comment. Please can you add them to the constexpr lists in LanguageExtensions.rst ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157420/new/ https://reviews.llvm.org/D157420

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

jyknight added a comment. In D155387#4557834 , @hctim wrote: > I found an issue with building Android using this patch. I've reduced it down > to the following problem where the evaluation of the `std::visit` is believed > to be non-exhaustive, but it

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1494-1505 +Decl *Sema::getCurLocalScopeDecl() { + if (const BlockScopeInfo *BSI = getCurBlock()) +return BSI->TheDecl; + else if (const LambdaScopeInfo *LSI = getCurLambda()) +return

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma added a comment. The overall approach here seems reasonable. I mean, technically the undefined behavior is happening in the library, but detecting it early seems like a good idea. This approach does have a significant limitation, though: CGBuiltin won't detect cases that involve

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added a comment. Aside from some changes to the test coverage, I think @hokein and I are in agreement on moving forward with the patch as-is (feel free to correct me if I'm wrong though!). Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc =

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155850#4570336 , @efriedma wrote: > LGTM (but please don't merge until we reach consensus on the overall feature) Of course, and thank you for the review. Please, do stick around if you don't mind, because this'll still get

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ilya-biryukov added a comment. In D153114#4569591 , @ChuanqiXu wrote: > BTW, I have a question about supporting header modules (including clang > header modules and C++20 header units) in static analysing tools (including > clangd), "why can't we

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (but please don't merge until we reach consensus on the overall feature) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

crtrott added a comment. To answer my own question: I was able to reproduce the bug when compiling for NVIDIA GPUs, I was not able to reproduce it for AMD GPUs yet, and I didn't try for Intel GPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7280 + "a %select{function|lambda}0 with an explicit object parameter cannot " + "%select{be const|be mutable|have reference qualifiers|be volatile}1">; +def

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 548296. bob80905 added a comment. - clang format pow.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } aaron.ballman wrote: > hokein wrote: >

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl added a comment. @efriedma I've updated the patch to fix the decl-use-decl example and added a test for it. Anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

crtrott added a comment. Question: does this bug potentially affect code generation for AMD/NVIDIA/Intel GPUs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. In D156178#4530161 , @bogner wrote: > Looking at > https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, > it seems a bit underspecified, but do we need to worry about differences > between that

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

alexguirre created this revision. alexguirre added a reviewer: RKSimon. Herald added a project: All. alexguirre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables us to use __lzcnt / __popcnt intrinsics inside constexpr code.

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added a comment. In D153914#4570109 , @RIscRIpt wrote: > Rebased onto main, run local lit clang/tests. (bump for @cor3ntin) > As far as I understand this shall be merged into main by maintainers. > Please let me know if something else is

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 548274. RIscRIpt added a comment. Rebased onto main, run local lit clang/tests. (bump for @cor3ntin) As far as I understand this shall be merged into main by maintainers. Please let me know if something else is expected from me. Repository: rG LLVM

[clang] 5f8d332 - Revert "[Clang][OpenMP] Support for Code Generation of loop bind clause."

Author: Nico Weber Date: 2023-08-08T13:12:25-04:00 New Revision: 5f8d332027c8a9ea657752a3b33696ddc9a7e257 URL: https://github.com/llvm/llvm-project/commit/5f8d332027c8a9ea657752a3b33696ddc9a7e257 DIFF: https://github.com/llvm/llvm-project/commit/5f8d332027c8a9ea657752a3b33696ddc9a7e257.diff

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added subscribers: jcranmer-intel, zahiraam. aaron.ballman added inline comments. Comment at: clang/lib/AST/FormatString.cpp:484-487 + if (const auto *PT = argTy->getAs()) { +if (PT->getPointeeType()->isCharType()) + return Match; + }

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157410: [Flang] Enable Rpass flag

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. LGTM, thanks for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410

[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548263. SAtacker added a comment. Fix call to lazyTemplateSpecialization in Function Template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/ https://reviews.llvm.org/D144831 Files:

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; aaron.ballman wrote: > tbaeder wrote: > > probinson

[clang] 4e8cae4 - Fix build break on pickier MSVC configurations [NFC]

Author: Paul Robinson Date: 2023-08-08T12:44:47-04:00 New Revision: 4e8cae4aec6590ca13ec65ed38d6da55c6031755 URL: https://github.com/llvm/llvm-project/commit/4e8cae4aec6590ca13ec65ed38d6da55c6031755 DIFF: https://github.com/llvm/llvm-project/commit/4e8cae4aec6590ca13ec65ed38d6da55c6031755.diff

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569725 , @jroelofs wrote: > Flaky test? Here's a later build where it succeeds, but the change has > nothing to do with clangd: > https://lab.llvm.org/buildbot/#/builders/168/builds/14997 No, I manually

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

aaron.ballman added a comment. This is looking to make similar changes to the ones proposed in https://reviews.llvm.org/D141714 -- can you coordinate with the other author so there's only one review that covers both needs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157410: [Flang] Enable Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. This patch allows

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex :

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

steven_wu accepted this revision. steven_wu added a comment. In D155824#4568904 , @xen0n wrote: > This still LGTM, @steven_wu would you please take another look so this can > get re-landed if confirmed working? The driver part LGTM. Repository: rG

[clang] 925ec54 - Revert "[clang][ExprConst] Add RHS source range to div by zero diags"

Author: Timm Bäder Date: 2023-08-08T18:16:35+02:00 New Revision: 925ec544cf541444bd6615fcf51d2a4b6af4acc5 URL: https://github.com/llvm/llvm-project/commit/925ec544cf541444bd6615fcf51d2a4b6af4acc5 DIFF: https://github.com/llvm/llvm-project/commit/925ec544cf541444bd6615fcf51d2a4b6af4acc5.diff

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

tahonermann requested changes to this revision. tahonermann added a comment. I agree with the analysis done by @steakhal. The static analyzer being used (which I'm not allowed to name) is being too noisy in these cases; it complains about every case where an object of class type is copied

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but please give a day or two for @hazohelet to weigh in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. I think this change is good as is, but I added some additional thoughts to Aaron's earlier comment. Comment at: clang/lib/AST/StmtPrinter.cpp:178 void StmtPrinter::PrintRawCompoundStmt(CompoundStmt *Node) { +

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. Thanks for working on this! I think it would make a lot of sense to unify this build and the Debian build, since currently we are building Clang twice without a good reason. Repository:

[PATCH] D157384: [clang] Added Attr::getVariety function

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:87-99 + enum class Variety { +None, +GNU, // __attribute__((...)) +Declspec, // __declspec(...) +Microsoft,// [...] +CXX11,// [[...]] +C2x,

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74c141a467ca: [clang][ExprConst] Add RHS source range to div by zero diags (authored by tbaeder). Changed prior to commit:

[clang] 74c141a - [clang][ExprConst] Add RHS source range to div by zero diags

Author: Timm Bäder Date: 2023-08-08T17:59:13+02:00 New Revision: 74c141a467caf9ebb4835458bc4ffbedb172a63a URL: https://github.com/llvm/llvm-project/commit/74c141a467caf9ebb4835458bc4ffbedb172a63a DIFF: https://github.com/llvm/llvm-project/commit/74c141a467caf9ebb4835458bc4ffbedb172a63a.diff

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:474 + Inputs.ExtraFiles["bar.h"] = + guard(R"cpp(#include "foo.h" // IWYU pragma:

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

v.g.vassilev added a comment. This LGTM but I'd like to wait for @rjmccall for a week or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157379/new/ https://reviews.llvm.org/D157379 ___ cfe-commits

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. > @tahonermann are all your comments addressed at this point? Apologies for the late response; I was on vacation last week. No. I'm still skeptical that there is ever a desire to expand substitute drives. Comment at:

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/

[clang] 58eba70 - [OpenMP] supporting additional case of declare target initializer expression list

Author: Ritanya B Bharadwaj Date: 2023-08-08T10:14:59-05:00 New Revision: 58eba709a330e4c83de0a98b50fc0acf26cb4344 URL: https://github.com/llvm/llvm-project/commit/58eba709a330e4c83de0a98b50fc0acf26cb4344 DIFF:

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Private headers should be the last resort, even if they match the name of

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + donat.nagy

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. BTW, I have a question about supporting header modules (including clang header modules and C++20 header units) in static analysing tools (including clangd), "why can't we fallback to include the corresponding headers simply?". So I still feel it is not a problem to

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked 4 inline comments as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } hokein wrote: > aaron.ballman

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548217. VitaNuo added a comment. Remove the preferred header hint for exporters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files:

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7280 + "a %select{function|lambda}0 with an explicit object parameter cannot " + "%select{be const|be mutable|have reference qualifiers|be volatile}1">; +def

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11308 + + // There should be a CWG issue for that + if (Name.getNameKind() == DeclarationName::CXXConstructorName || aaron.ballman wrote: > Do

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4283 + if (HasExplicitObjectParameter) { +const VarDecl *D = cast(CurCodeDecl)->getParamDecl(0); +auto It = LocalDeclMap.find(D);

[clang] 8e7f032 - [Clang][OpenMP] Support for Code Generation of loop bind clause.

Author: Sunil Kuravinakop Date: 2023-08-08T09:23:00-05:00 New Revision: 8e7f0320ad7fb760fff598aba4b2c86528c58c2d URL: https://github.com/llvm/llvm-project/commit/8e7f0320ad7fb760fff598aba4b2c86528c58c2d DIFF:

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a subscriber: efriedma. aaron.ballman added a comment. Round two of comments; I picked up from where I left off earlier and haven't checked your changes or responses yet. Precommit CI seems to have found a relevant failure from the patch. Comment at:

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet marked 2 inline comments as done. kadircet added a comment. hi @PiotrZSL, addressed those in 724b40a1379f7c116473a02a3cec4d341c475b46 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 724b40a - [clang-tidy][Docs] Update docs per post-commit review

Author: Kadir Cetinkaya Date: 2023-08-08T16:16:51+02:00 New Revision: 724b40a1379f7c116473a02a3cec4d341c475b46 URL: https://github.com/llvm/llvm-project/commit/724b40a1379f7c116473a02a3cec4d341c475b46 DIFF:

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:195 +- Misc-include-cleaner check has option `DeduplicateFindings` to output one + finding per occurence of a symbol. invalid release note should be something like: ```

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. I have checked the results on some projects (memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,xerces,bitcoin). These results are more interesting, some look correct, some probably not:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548204. VitaNuo added a comment. Remove accidental comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89d0a76be68b: [clang-tidy][include-cleaner] Add option to control deduplication of findings… (authored by kadircet). Repository: rG LLVM Github

[clang-tools-extra] 89d0a76 - [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

Author: Kadir Cetinkaya Date: 2023-08-08T16:01:33+02:00 New Revision: 89d0a76be68b866779ac41e56bc7f7b4fc452f47 URL: https://github.com/llvm/llvm-project/commit/89d0a76be68b866779ac41e56bc7f7b4fc452f47 DIFF:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157395

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 548197. hazohelet added a comment. - Tentatively disable the warning on macros so as not to make a fuss in libc++ tests. - Fixed incorrect output in arguments. - Fixed incorrect output in declaration of init-statement of constexpr-if condition. - Added

[PATCH] D157394: [clang][DeclPrinter] Improved AST print of function attributes

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet updated this revision to Diff 548199. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157390/new/ https://reviews.llvm.org/D157390 Files: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575 + // If we are here with a 'target teams loop' then we are emitting the + // 'parallel' region of the 'target teams distribute parallel for' + // emitted in place of the 'target teams

[PATCH] D156795: [CUDA][HIP] Fix overloading resolution of delete operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG247cc265e74e: [CUDA][HIP] Fix overloading resolution of delete operator (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 247cc26 - [CUDA][HIP] Fix overloading resolution of delete operator

Author: Yaxun (Sam) Liu Date: 2023-08-08T09:50:24-04:00 New Revision: 247cc265e74e25164ee7ce85e6c9c53b3d177740 URL: https://github.com/llvm/llvm-project/commit/247cc265e74e25164ee7ce85e6c9c53b3d177740 DIFF:

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added a comment. Please, use the script to generate the checks for the newly added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ cfe-commits mailing list

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet updated this revision to Diff 548190. kadircet marked 2 inline comments as done. kadircet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157390/new/ https://reviews.llvm.org/D157390 Files:

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.h:48 + // Whether emit only one finding per usage of a symbol. + const bool EmitOnce;

[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548183. SAtacker added a comment. Herald added a subscriber: cfe-commits. [Clang][Modules] Optimized template arguments ODR hash search for modules/PCH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4559248 , @kiranchandramohan wrote: >> rpass flag now prints remarks when requested but does not display >> the passName used, i.e [-Rpass=inline] > > I think the location information is also not printed. Please

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

jcsxky added a comment. In D156693#4568941 , @balazske wrote: > This fix can cause problems because the depth comparison is omitted all > times. It would be better to omit depth check if the imported template is a > friend, and has a

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548175. victorkingi added a comment. changed enum to enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

jcsxky updated this revision to Diff 548166. jcsxky edited the summary of this revision. jcsxky added a comment. update diff: add more conditions on when to ignore comparing depth of two template classes to minimize influence to others and fix name of test case to make easy understanding

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs-without-target-feature.cpp:13-17 +__attribute__((target("sme"))) void streaming_compatible_def_sme_attr() __arm_streaming_compatible {} // OK +__attribute__((target("sme"))) void

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 548168. sdesmalen marked 10 inline comments as done. sdesmalen added a comment. Address further review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157269/new/ https://reviews.llvm.org/D157269

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc,

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc,

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This might be a little light on the testing side. Repository: rG

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/Sema/SemaChecking.cpp:6773 + bool CallerHasZAState = false; + if (auto *CallerFD = dyn_cast(CurContext))

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

aaron.ballman added reviewers: efriedma, rjmccall, rsmith. aaron.ballman added a comment. Adding codegen and ubsan code owners for opinions. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1791 + // Try to eliminate overflow check. + if (auto *VCI = dyn_cast(ArgValue)) { +if

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit extends ClangAttrEmitter of tablegen to generate

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

paulwalker-arm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6762 +Context.getFunctionFeatureMap(CallerFeatureMap, CallerFD); +if (!CallerFeatureMap.count("sme")) + Diag(Loc, diag::err_sme_call_in_non_sme_target);

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

aaron.ballman added a comment. I'm not qualified to give a review of the functional changes, but the intent for the changes SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324

[PATCH] D157011: [Clang][Tooling] Accept preprocessed input files

This revision was automatically updated to reflect the committed changes. Closed by commit rG241cceb9af84: [Clang][Tooling] Accept preprocessed input files (authored by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157011/new/

[clang] 241cceb - [Clang][Tooling] Accept preprocessed input files

Author: J. Ryan Stinnett Date: 2023-08-08T12:44:48+01:00 New Revision: 241cceb9af844ef7d7a87124407a04b0a64991fe URL: https://github.com/llvm/llvm-project/commit/241cceb9af844ef7d7a87124407a04b0a64991fe DIFF:

<    1   2   3   >